{"id":2226614,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2226614/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260422161407.118748-25-kwilczynski@kernel.org/","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/1.1/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260422161407.118748-25-kwilczynski@kernel.org>","date":"2026-04-22T16:14:07","name":"[v6,24/24] PCI/sysfs: Limit BAR resize attribute scope to platforms with PCI mmap","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"a44876b4a377f9b8dc8fa6db66c1d780ef1ca073","submitter":{"id":86709,"url":"http://patchwork.ozlabs.org/api/1.1/people/86709/?format=json","name":"Krzysztof Wilczyński","email":"kwilczynski@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260422161407.118748-25-kwilczynski@kernel.org/mbox/","series":[{"id":501041,"url":"http://patchwork.ozlabs.org/api/1.1/series/501041/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/list/?series=501041","date":"2026-04-22T16:13:46","name":"PCI: Convert all dynamic sysfs attributes to static","version":6,"mbox":"http://patchwork.ozlabs.org/series/501041/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2226614/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2226614/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=m8QdmUHE;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=linux-pci+bounces-53010-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"m8QdmUHE\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g14MS2MWnz1yD5\n\tfor ; Thu, 23 Apr 2026 02:25:24 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id A5F703061DD4\n\tfor ; Wed, 22 Apr 2026 16:16:15 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id D597237DEA5;\n\tWed, 22 Apr 2026 16:15:36 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id B199A37FF7A;\n\tWed, 22 Apr 2026 16:15:36 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 7B917C19425;\n\tWed, 22 Apr 2026 16:15:33 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776874536; cv=none;\n b=Z7WZcqyHVoUK6AEdsOr0yUmAwzyhnPBEV7O7CFSUnDfN8H5AOyQ9P4J7vzZfqoRNJFZ13MPu0fNWmRkNsS6HKrJPYkIdWcAvVDnUbDMna7LWJz5P+gP6WG9UbMzlOZCizai/j2+OVDdt4y3SqjcuiaG4ScuJ2h9oL1bLLyzJP/U=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776874536; c=relaxed/simple;\n\tbh=dFCDzhXA2zUSnlj0+jJsCYTv9upJPkAyBg063oGGGK4=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=F7+yYJZVDeyHdQ46eQ+KKujmejptxUefBOM0al5Qzpbp+PZlWH1HX9hc64kyLpuNiOGKRagOM0fqDhCtLkAOIwkvVAvQyOYGhq3w+v2iFhdaprektVJYjYZz04uAYjESGsE0Wu44cgU1E2ZF/W416XOFlmRa6W4YzqKJ12mpHv8=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=m8QdmUHE; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776874536;\n\tbh=dFCDzhXA2zUSnlj0+jJsCYTv9upJPkAyBg063oGGGK4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=m8QdmUHE22S/biCkSxFIOC14JtXTSxgA4FYN2o0neiedaWK8dLMHPunLd4X2UIExa\n\t fbzI4bOnwaWE+ngvwJt6ZeJzCYXsZ4kO6kjIWY0MAg3MFhCWc5CzEN0nOs9p93y47Y\n\t zdwWd97wxcDcfUK95xpLmLs/yrQiEK5HAcFdj6zOR1/cUGAmz+OT8pWQEyqwEm6gYs\n\t sBAMXyqoPbDKR5h4lD0HI4LpjIEnV7b1fkvWyMLYXG3zJvzNLMVek/O0P9fSknydP0\n\t /TI104uBsJeLPyuRiCg9eg9mkSmplBo9QzuAoD80kRIv1cbfgTbffByeVS7VwniOQ/\n\t NF2QAwy85F9Dw==","From":"=?utf-8?q?Krzysztof_Wilczy=C5=84ski?= ","To":"Bjorn Helgaas ","Cc":"Bjorn Helgaas ,\n Manivannan Sadhasivam ,\n Lorenzo Pieralisi ,\n Magnus Lindholm , Matt Turner ,\n Richard Henderson ,\n Christophe Leroy ,\n Madhavan Srinivasan ,\n Michael Ellerman , Nicholas Piggin ,\n Dexuan Cui ,\n =?utf-8?q?Krzysztof_Ha=C5=82asa?= ,\n Lukas Wunner , \"Oliver O'Halloran\" ,\n Saurabh Singh Sengar ,\n Shuan He , Srivatsa Bhat ,\n\t=?utf-8?q?Ilpo_J=C3=A4rvinen?= ,\n linux-pci@vger.kernel.org, linux-alpha@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org","Subject":"[PATCH v6 24/24] PCI/sysfs: Limit BAR resize attribute scope to\n platforms with PCI mmap","Date":"Wed, 22 Apr 2026 16:14:07 +0000","Message-ID":"<20260422161407.118748-25-kwilczynski@kernel.org>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260422161407.118748-1-kwilczynski@kernel.org>","References":"<20260422161407.118748-1-kwilczynski@kernel.org>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit"},"content":"The resourceN_resize sysfs attributes allow users to resize\nResizable BARs (ReBAR). After a successful resize, the resource\nattribute groups are removed and recreated so that the updated\nBAR sizes are reflected in the sysfs files.\n\nResizable BARs are a PCI Express extended capability\n(PCI_EXT_CAP_ID_REBAR), which requires PCIe extended config\nspace.\n\nEvery PCIe-capable architecture defines either HAVE_PCI_MMAP or\nARCH_GENERIC_PCI_MMAP_RESOURCE (via the relevant arch headers\nor the generic asm-generic/pci.h fallback). On platforms that\ndefine neither, the resource files are not created and the sysfs\ngroup remove and create calls in __resource_resize_store() are\nno-ops.\n\nThus, move the resize show and store helpers, the per-BAR attribute\ndefinitions, and the attribute group behind the existing #ifdef\nHAVE_PCI_MMAP || ARCH_GENERIC_PCI_MMAP_RESOURCE guard, and fold\nthe group reference in pci_dev_groups[] into the existing #if block.\n\nSigned-off-by: Krzysztof Wilczyński \n---\n drivers/pci/pci-sysfs.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c\nindex b167e32d55ac..37c1990124d0 100644\n--- a/drivers/pci/pci-sysfs.c\n+++ b/drivers/pci/pci-sysfs.c\n@@ -1690,6 +1690,7 @@ static const struct attribute_group pci_dev_reset_method_attr_group = {\n \t.is_visible = pci_dev_reset_attr_is_visible,\n };\n \n+#if defined(HAVE_PCI_MMAP) || defined(ARCH_GENERIC_PCI_MMAP_RESOURCE)\n static ssize_t __resource_resize_show(struct device *dev, int n, char *buf)\n {\n \tstruct pci_dev *pdev = to_pci_dev(dev);\n@@ -1804,6 +1805,7 @@ static const struct attribute_group pci_dev_resource_resize_attr_group = {\n \t.attrs = resource_resize_attrs,\n \t.is_visible = resource_resize_attr_is_visible,\n };\n+#endif\n \n static struct attribute *pci_dev_dev_attrs[] = {\n \t&dev_attr_boot_vga.attr,\n@@ -1878,8 +1880,8 @@ const struct attribute_group *pci_dev_groups[] = {\n \t&pci_dev_resource_io_attr_group,\n \t&pci_dev_resource_uc_attr_group,\n \t&pci_dev_resource_wc_attr_group,\n-#endif\n \t&pci_dev_resource_resize_attr_group,\n+#endif\n \t&pci_dev_config_attr_group,\n \t&pci_dev_rom_attr_group,\n \t&pci_dev_reset_attr_group,\n","prefixes":["v6","24/24"]}