{"id":2226609,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2226609/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260422161407.118748-14-kwilczynski@kernel.org/","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/1.1/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260422161407.118748-14-kwilczynski@kernel.org>","date":"2026-04-22T16:13:56","name":"[v6,13/24] alpha/PCI: Use PCI resource accessor macros","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"7cc0706417dacc6b2532ec94eb1f6973a6a971b4","submitter":{"id":86709,"url":"http://patchwork.ozlabs.org/api/1.1/people/86709/?format=json","name":"Krzysztof Wilczyński","email":"kwilczynski@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260422161407.118748-14-kwilczynski@kernel.org/mbox/","series":[{"id":501041,"url":"http://patchwork.ozlabs.org/api/1.1/series/501041/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/list/?series=501041","date":"2026-04-22T16:13:46","name":"PCI: Convert all dynamic sysfs attributes to static","version":6,"mbox":"http://patchwork.ozlabs.org/series/501041/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2226609/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2226609/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=Shun704J;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-52999-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"Shun704J\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g14J70cXQz1yCv\n\tfor ; Thu, 23 Apr 2026 02:22:31 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id DF5E930DAF3E\n\tfor ; Wed, 22 Apr 2026 16:14:57 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 6D71A35AC1A;\n\tWed, 22 Apr 2026 16:14:57 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 49ABE34EEF9;\n\tWed, 22 Apr 2026 16:14:57 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 08687C2BCAF;\n\tWed, 22 Apr 2026 16:14:53 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776874497; cv=none;\n b=T66y/tPnFU6of/2Gq+I1idFh4JwGseiIhjZQKp9hT/S1V3IeFB25NSb9Iojt3oXdiGS1UACC4ghwpXrWS3aUum3HW1zZCNRpsWymyd7m/gy/E2HzPZXVPepR4kHrBFTmSq7JPvpCr7pL2kOrpnfknwUJcIzWQFLhT3EiTWjh6H4=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776874497; c=relaxed/simple;\n\tbh=IMcdakq99wbD1qVW6H0LK/hocegXH8/apKioYrKdwvE=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=Fopo6jVoYxR9AtZ1Ed6fE9nd/rYmrMYrg1rLr2dvEBMfacneXSrJYQgALeUifsDIjppu47H6kl/ci3wJ3d9LCu1e+sizCTMQhAeYRTqVdIzFck0ATBlUrk+WQxoUbT+DhR5d8icCcfBOcI93WU778OdRosNw9NFW7S/nYqhux10=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=Shun704J; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776874497;\n\tbh=IMcdakq99wbD1qVW6H0LK/hocegXH8/apKioYrKdwvE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Shun704JkGUg6uA5ladCW4/NmkGjytnYYQ2SaGF6nupdSJ28rbcXO9fHocNUnWxzt\n\t SjDSwsD07qoZIwr8NKSFrY9b0XZoMLhUFIu4LoT4Y1nwYopUdSJUpupO+jXoImTtKV\n\t xtf1sFRuATsmPcNX4OTaX6yPr9SzSLx2MV9jgoNUND1ms3nOX72CKexebh3gFMmYKY\n\t 41Iaqd0hz+7E/TdMv3DFdVErvkyjCTiAx9fE5q0/Kzs1oQ+CbgKRK/8qyYSmrPO1yo\n\t VIapYPvcW3GqaIumZ+2vimnKL4HIoI95L3Dx0/xx0jAtXq9sLgyKPJPuqL3ASrgA2T\n\t Hw7E7Leu3FJTA==","From":"=?utf-8?q?Krzysztof_Wilczy=C5=84ski?= ","To":"Bjorn Helgaas ","Cc":"Bjorn Helgaas ,\n Manivannan Sadhasivam ,\n Lorenzo Pieralisi ,\n Magnus Lindholm , Matt Turner ,\n Richard Henderson ,\n Christophe Leroy ,\n Madhavan Srinivasan ,\n Michael Ellerman , Nicholas Piggin ,\n Dexuan Cui ,\n =?utf-8?q?Krzysztof_Ha=C5=82asa?= ,\n Lukas Wunner , \"Oliver O'Halloran\" ,\n Saurabh Singh Sengar ,\n Shuan He , Srivatsa Bhat ,\n\t=?utf-8?q?Ilpo_J=C3=A4rvinen?= ,\n linux-pci@vger.kernel.org, linux-alpha@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org","Subject":"[PATCH v6 13/24] alpha/PCI: Use PCI resource accessor macros","Date":"Wed, 22 Apr 2026 16:13:56 +0000","Message-ID":"<20260422161407.118748-14-kwilczynski@kernel.org>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260422161407.118748-1-kwilczynski@kernel.org>","References":"<20260422161407.118748-1-kwilczynski@kernel.org>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit"},"content":"Replace direct pdev->resource[] accesses with pci_resource_n(),\nand open-coded res->flags type checks with pci_resource_is_mem()\nand pci_resource_start() helpers.\n\nWhile at it, move the pci_resource_n() call directly into\npcibios_resource_to_bus() and drop the local struct\nresource pointer.\n\nNo functional changes intended.\n\nTested-by: Magnus Lindholm \nReviewed-by: Ilpo Järvinen \nAcked-by: Magnus Lindholm \nSigned-off-by: Krzysztof Wilczyński \n---\n arch/alpha/kernel/pci-sysfs.c | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)","diff":"diff --git a/arch/alpha/kernel/pci-sysfs.c b/arch/alpha/kernel/pci-sysfs.c\nindex 2330ab84d59c..5c29f1d2821c 100644\n--- a/arch/alpha/kernel/pci-sysfs.c\n+++ b/arch/alpha/kernel/pci-sysfs.c\n@@ -70,7 +70,6 @@ static int pci_mmap_resource(struct kobject *kobj,\n {\n \tstruct pci_dev *pdev = to_pci_dev(kobj_to_dev(kobj));\n \tint barno = (unsigned long)attr->private;\n-\tstruct resource *res = pci_resource_n(pdev, barno);\n \tenum pci_mmap_state mmap_type;\n \tstruct pci_bus_region bar;\n \tint ret;\n@@ -79,15 +78,16 @@ static int pci_mmap_resource(struct kobject *kobj,\n \tif (ret)\n \t\treturn ret;\n \n-\tif (res->flags & IORESOURCE_MEM && iomem_is_exclusive(res->start))\n+\tif (pci_resource_is_mem(pdev, barno) &&\n+\t iomem_is_exclusive(pci_resource_start(pdev, barno)))\n \t\treturn -EINVAL;\n \n \tif (!__pci_mmap_fits(pdev, barno, vma, sparse))\n \t\treturn -EINVAL;\n \n-\tpcibios_resource_to_bus(pdev->bus, &bar, res);\n+\tpcibios_resource_to_bus(pdev->bus, &bar, pci_resource_n(pdev, barno));\n \tvma->vm_pgoff += bar.start >> (PAGE_SHIFT - (sparse ? 5 : 0));\n-\tmmap_type = res->flags & IORESOURCE_MEM ? pci_mmap_mem : pci_mmap_io;\n+\tmmap_type = pci_resource_is_mem(pdev, barno) ? pci_mmap_mem : pci_mmap_io;\n \n \treturn hose_mmap_page_range(pdev->sysdata, vma, mmap_type, sparse);\n }\n@@ -141,7 +141,7 @@ static int sparse_mem_mmap_fits(struct pci_dev *pdev, int num)\n \tlong dense_offset;\n \tunsigned long sparse_size;\n \n-\tpcibios_resource_to_bus(pdev->bus, &bar, &pdev->resource[num]);\n+\tpcibios_resource_to_bus(pdev->bus, &bar, pci_resource_n(pdev, num));\n \n \t/* All core logic chips have 4G sparse address space, except\n \t CIA which has 16G (see xxx_SPARSE_MEM and xxx_DENSE_MEM\n@@ -181,7 +181,7 @@ static int pci_create_attr(struct pci_dev *pdev, int num)\n \tsuffix = \"\";\t/* Assume bwx machine, normal resourceN files. */\n \tnlen1 = 10;\n \n-\tif (pdev->resource[num].flags & IORESOURCE_MEM) {\n+\tif (pci_resource_is_mem(pdev, num)) {\n \t\tsparse_base = hose->sparse_mem_base;\n \t\tdense_base = hose->dense_mem_base;\n \t\tif (sparse_base && !sparse_mem_mmap_fits(pdev, num)) {\n","prefixes":["v6","13/24"]}