{"id":2226599,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2226599/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260422155701.7420-3-khai.wen.tan@linux.intel.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/1.1/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260422155701.7420-3-khai.wen.tan@linux.intel.com>","date":"2026-04-22T15:57:00","name":"[iwl-next,v3,2/3] igc: move autoneg-enabled settings into igc_handle_autoneg_enabled()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"10a503c5d095eb43e663dc3639dcf4fbb3843682","submitter":{"id":93102,"url":"http://patchwork.ozlabs.org/api/1.1/people/93102/?format=json","name":"KhaiWenTan","email":"khai.wen.tan@linux.intel.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260422155701.7420-3-khai.wen.tan@linux.intel.com/mbox/","series":[{"id":501042,"url":"http://patchwork.ozlabs.org/api/1.1/series/501042/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=501042","date":"2026-04-22T15:56:58","name":"igc: add support for forcing link speed without autonegotiation","version":3,"mbox":"http://patchwork.ozlabs.org/series/501042/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2226599/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2226599/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=xW4BxTh/;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g14Fj66Xqz1yCv\n\tfor ; Thu, 23 Apr 2026 02:20:25 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 65EC261B89;\n\tWed, 22 Apr 2026 16:20:24 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id YiopVNYQAR3a; Wed, 22 Apr 2026 16:20:22 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id C3DE760D94;\n\tWed, 22 Apr 2026 16:20:22 +0000 (UTC)","from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n by lists1.osuosl.org (Postfix) with ESMTP id EA06E257\n for ; Wed, 22 Apr 2026 16:20:20 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id DC1A860C22\n for ; Wed, 22 Apr 2026 16:20:20 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id pNpSh005Z1vA for ;\n Wed, 22 Apr 2026 16:20:20 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [198.175.65.11])\n by smtp3.osuosl.org (Postfix) with ESMTPS id DB22E60DBF\n for ; Wed, 22 Apr 2026 16:20:19 +0000 (UTC)","from fmviesa010.fm.intel.com ([10.60.135.150])\n by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 22 Apr 2026 09:20:19 -0700","from unknown (HELO localhost.png.intel.com) ([10.107.255.61])\n by fmviesa010.fm.intel.com with ESMTP; 22 Apr 2026 09:20:15 -0700"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp3.osuosl.org C3DE760D94","OpenDKIM Filter v2.11.0 smtp3.osuosl.org DB22E60DBF"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776874822;\n\tbh=734I3G72OJbK4gdSy/3+p1wA+3ENKQbVirs04y2d5Vc=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=xW4BxTh/z8QsqUSfHsC5FOQ3QMQi2aGeXgODMaBZu+IiGy9heXh7Gjt489U0kIbbk\n\t rDKuYANvr0sVV5CJcDSGMyGSDojebiKKL3HpQIJOuKgEkBrLnpQJ/8ATvfcLRi8KR4\n\t P5tHgwSdQ+tC4J+SFmpmSAhpLyDJNsKjcdg4nXgcE41/v/19ceZsKz3a1DBU2lEdoc\n\t AQtYLQWj1rLQ+x8le2zNyBr7oQRVtKB9l10DylmMiWTRG4uXVfQ9LFfVbItPH0EID8\n\t 68uWCwRsMkCZ6tudM4ktthKQ9yEMWxsW5RGrKWQ7MpKvA6jD0B9nHM1iq/fxhtBff9\n\t qonM9Ml0JIGJQ==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.11;\n helo=mgamail.intel.com; envelope-from=khai.wen.tan@linux.intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp3.osuosl.org DB22E60DBF","X-CSE-ConnectionGUID":["v8IQqt7mSsi8oXoIwi95tg==","yMP4YfLNTJSVIIjF5wcA8Q=="],"X-CSE-MsgGUID":["lHqp/UuJSduZy+fMxBO5ng==","9rYquxjxS0KxfOb29LoFtw=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11764\"; a=\"88134492\"","E=Sophos;i=\"6.23,193,1770624000\"; d=\"scan'208\";a=\"88134492\"","E=Sophos;i=\"6.23,193,1770624000\"; d=\"scan'208\";a=\"228052453\""],"X-ExtLoop1":"1","From":"KhaiWenTan ","To":"anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com,\n andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,\n kuba@kernel.org, pabeni@redhat.com","Cc":"intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,\n linux-kernel@vger.kernel.org, faizal.abdul.rahim@intel.com,\n hong.aun.looi@intel.com, khai.wen.tan@intel.com,\n Faizal Rahim , Looi,\n Aleksandr Loktionov ,\n KhaiWenTan ","Date":"Wed, 22 Apr 2026 23:57:00 +0800","Message-ID":"<20260422155701.7420-3-khai.wen.tan@linux.intel.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260422155701.7420-1-khai.wen.tan@linux.intel.com>","References":"<20260422155701.7420-1-khai.wen.tan@linux.intel.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1776874820; x=1808410820;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=dLjvwNQGbgsihw8eMls+gO1zacDih/y1JKuhzvrV16g=;\n b=AAjw2YdUmUpcXV791tPdNSZzuKfqBDNEEuDsJx+BJcv7JRPrpNFGMmVw\n mrqqfSTIalcBG8t/6FqX6RdLZbJTAQpZvCW87CAYOepakGeyfvTVb7NpR\n JZlKR34TltJ0sVIbZmVl4k+wIb9+SWrk+bG6RK3WtlUWoU59HQelq0b6d\n CxjwTeJSPSZkg4AlrpCMD6jDIm+LjhwmSsTh6xlLVxePGX/v5ATIzX/M6\n q5kAia0J2gk2fmfV5kGsyMAMEJkNUyhlbc9TutTnloSgbBPL8b+O43npk\n /5RbmBCxNx4syn/4spL6W7ucSJv707KzUWxDMHQ+/G6PajA1zPh/IIXB9\n A==;","X-Mailman-Original-Authentication-Results":["smtp3.osuosl.org;\n dmarc=none (p=none dis=none)\n header.from=linux.intel.com","smtp3.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=AAjw2YdU"],"Subject":"[Intel-wired-lan] [PATCH iwl-next v3 2/3] igc: move autoneg-enabled\n settings into igc_handle_autoneg_enabled()","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"From: Faizal Rahim \n\nMove the advertised link modes and flow control configuration from\nigc_ethtool_set_link_ksettings() into igc_handle_autoneg_enabled().\n\nNo functional change.\n\nReviewed-by: Looi, Hong Aun \nReviewed-by: Aleksandr Loktionov \nSigned-off-by: Faizal Rahim \nSigned-off-by: KhaiWenTan \n---\n drivers/net/ethernet/intel/igc/igc_ethtool.c | 72 ++++++++++++--------\n 1 file changed, 44 insertions(+), 28 deletions(-)\n\n--\n2.43.0","diff":"diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c\nindex 0122009bedd0..cfcbf2fdad6e 100644\n--- a/drivers/net/ethernet/intel/igc/igc_ethtool.c\n+++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c\n@@ -2000,6 +2000,49 @@ static int igc_ethtool_get_link_ksettings(struct net_device *netdev,\n \treturn 0;\n }\n\n+/**\n+ * igc_handle_autoneg_enabled - Configure autonegotiation advertisement\n+ * @adapter: private driver structure\n+ * @cmd: ethtool link ksettings from user\n+ *\n+ * Records advertised speeds and flow control settings when autoneg\n+ * is enabled.\n+ */\n+static void igc_handle_autoneg_enabled(struct igc_adapter *adapter,\n+\t\t\t\t const struct ethtool_link_ksettings *cmd)\n+{\n+\tstruct igc_hw *hw = &adapter->hw;\n+\tu16 advertised = 0;\n+\n+\tif (ethtool_link_ksettings_test_link_mode(cmd, advertising,\n+\t\t\t\t\t\t 2500baseT_Full))\n+\t\tadvertised |= ADVERTISE_2500_FULL;\n+\n+\tif (ethtool_link_ksettings_test_link_mode(cmd, advertising,\n+\t\t\t\t\t\t 1000baseT_Full))\n+\t\tadvertised |= ADVERTISE_1000_FULL;\n+\n+\tif (ethtool_link_ksettings_test_link_mode(cmd, advertising,\n+\t\t\t\t\t\t 100baseT_Full))\n+\t\tadvertised |= ADVERTISE_100_FULL;\n+\n+\tif (ethtool_link_ksettings_test_link_mode(cmd, advertising,\n+\t\t\t\t\t\t 100baseT_Half))\n+\t\tadvertised |= ADVERTISE_100_HALF;\n+\n+\tif (ethtool_link_ksettings_test_link_mode(cmd, advertising,\n+\t\t\t\t\t\t 10baseT_Full))\n+\t\tadvertised |= ADVERTISE_10_FULL;\n+\n+\tif (ethtool_link_ksettings_test_link_mode(cmd, advertising,\n+\t\t\t\t\t\t 10baseT_Half))\n+\t\tadvertised |= ADVERTISE_10_HALF;\n+\n+\thw->phy.autoneg_advertised = advertised;\n+\tif (adapter->fc_autoneg)\n+\t\thw->fc.requested_mode = igc_fc_default;\n+}\n+\n static int\n igc_ethtool_set_link_ksettings(struct net_device *netdev,\n \t\t\t const struct ethtool_link_ksettings *cmd)\n@@ -2007,7 +2050,6 @@ igc_ethtool_set_link_ksettings(struct net_device *netdev,\n \tstruct igc_adapter *adapter = netdev_priv(netdev);\n \tstruct net_device *dev = adapter->netdev;\n \tstruct igc_hw *hw = &adapter->hw;\n-\tu16 advertised = 0;\n\n \t/* When adapter in resetting mode, autoneg/speed/duplex\n \t * cannot be changed\n@@ -2032,34 +2074,8 @@ igc_ethtool_set_link_ksettings(struct net_device *netdev,\n \twhile (test_and_set_bit(__IGC_RESETTING, &adapter->state))\n \t\tusleep_range(1000, 2000);\n\n-\tif (ethtool_link_ksettings_test_link_mode(cmd, advertising,\n-\t\t\t\t\t\t 2500baseT_Full))\n-\t\tadvertised |= ADVERTISE_2500_FULL;\n-\n-\tif (ethtool_link_ksettings_test_link_mode(cmd, advertising,\n-\t\t\t\t\t\t 1000baseT_Full))\n-\t\tadvertised |= ADVERTISE_1000_FULL;\n-\n-\tif (ethtool_link_ksettings_test_link_mode(cmd, advertising,\n-\t\t\t\t\t\t 100baseT_Full))\n-\t\tadvertised |= ADVERTISE_100_FULL;\n-\n-\tif (ethtool_link_ksettings_test_link_mode(cmd, advertising,\n-\t\t\t\t\t\t 100baseT_Half))\n-\t\tadvertised |= ADVERTISE_100_HALF;\n-\n-\tif (ethtool_link_ksettings_test_link_mode(cmd, advertising,\n-\t\t\t\t\t\t 10baseT_Full))\n-\t\tadvertised |= ADVERTISE_10_FULL;\n-\n-\tif (ethtool_link_ksettings_test_link_mode(cmd, advertising,\n-\t\t\t\t\t\t 10baseT_Half))\n-\t\tadvertised |= ADVERTISE_10_HALF;\n-\n \tif (cmd->base.autoneg == AUTONEG_ENABLE) {\n-\t\thw->phy.autoneg_advertised = advertised;\n-\t\tif (adapter->fc_autoneg)\n-\t\t\thw->fc.requested_mode = igc_fc_default;\n+\t\tigc_handle_autoneg_enabled(adapter, cmd);\n \t} else {\n \t\tnetdev_info(dev, \"Force mode currently not supported\\n\");\n \t}\n","prefixes":["iwl-next","v3","2/3"]}