{"id":2226597,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2226597/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260422155701.7420-2-khai.wen.tan@linux.intel.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/1.1/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260422155701.7420-2-khai.wen.tan@linux.intel.com>","date":"2026-04-22T15:56:59","name":"[iwl-next,v3,1/3] igc: remove unused autoneg_failed field","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"9d0f1d8fede1bbe6f2ca1ff00a29c80d05db5796","submitter":{"id":93102,"url":"http://patchwork.ozlabs.org/api/1.1/people/93102/?format=json","name":"KhaiWenTan","email":"khai.wen.tan@linux.intel.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260422155701.7420-2-khai.wen.tan@linux.intel.com/mbox/","series":[{"id":501042,"url":"http://patchwork.ozlabs.org/api/1.1/series/501042/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=501042","date":"2026-04-22T15:56:58","name":"igc: add support for forcing link speed without autonegotiation","version":3,"mbox":"http://patchwork.ozlabs.org/series/501042/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2226597/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2226597/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=yKKZFurC;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g14Fc4bBBz1yCv\n\tfor ; Thu, 23 Apr 2026 02:20:20 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id D1EE34052A;\n\tWed, 22 Apr 2026 16:20:18 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id HKLxXt7rNhgG; Wed, 22 Apr 2026 16:20:17 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 432374047B;\n\tWed, 22 Apr 2026 16:20:17 +0000 (UTC)","from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n by lists1.osuosl.org (Postfix) with ESMTP id 3E24B257\n for ; Wed, 22 Apr 2026 16:20:16 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id 2FCA760E27\n for ; Wed, 22 Apr 2026 16:20:16 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id ErScL7i57ADh for ;\n Wed, 22 Apr 2026 16:20:15 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [198.175.65.11])\n by smtp3.osuosl.org (Postfix) with ESMTPS id 1F1E560DBF\n for ; Wed, 22 Apr 2026 16:20:14 +0000 (UTC)","from fmviesa010.fm.intel.com ([10.60.135.150])\n by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 22 Apr 2026 09:20:14 -0700","from unknown (HELO localhost.png.intel.com) ([10.107.255.61])\n by fmviesa010.fm.intel.com with ESMTP; 22 Apr 2026 09:20:10 -0700"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org 432374047B","OpenDKIM Filter v2.11.0 smtp3.osuosl.org 1F1E560DBF"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776874817;\n\tbh=EVoEvpinx7UrEYecHHIFKB8fKx60mrGwXkn35wH4hQA=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=yKKZFurCcriIAVL/zRdSFraYdVynoXvLcYtMQ06jGOYAOP3CJsRhcSYSvi7iu8C++\n\t 5Ug2VN9U5dht20Ytu0/TL54FUMCjpQw1nJH0YSb13WrMKE9glAOqROX8dEHoAw2u2C\n\t e0DQIILb7lJKsHq6vA2OFSjTwXVAid7JlO4bkqDcX5SyYJShgxqpekIrVRCImrfLXJ\n\t 6D4WxkDn51A/ziBQ6K4Jwep0fLJE6P9huuDUCrlk6S/HzhAVKS5lNDCezp2I2R14NA\n\t RnurL5YnULJfmuD/jtIjUW2nWWXDTv9LtORhKqx+rVdM/OQG4661ENwl4pHD9BaBUm\n\t 4lBVUj2bmtawA==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.11;\n helo=mgamail.intel.com; envelope-from=khai.wen.tan@linux.intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp3.osuosl.org 1F1E560DBF","X-CSE-ConnectionGUID":["I2PN88N6Q9Ko9qbJCKP7jA==","IDh7d9TfQ/O9w1f1XGKR/Q=="],"X-CSE-MsgGUID":["5q7Vkd+5TmWNgMwMe49xzQ==","Xg1hl9e7TBusYlz7eQlmxw=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11764\"; a=\"88134468\"","E=Sophos;i=\"6.23,193,1770624000\"; d=\"scan'208\";a=\"88134468\"","E=Sophos;i=\"6.23,193,1770624000\"; d=\"scan'208\";a=\"228052438\""],"X-ExtLoop1":"1","From":"KhaiWenTan ","To":"anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com,\n andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,\n kuba@kernel.org, pabeni@redhat.com","Cc":"intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,\n linux-kernel@vger.kernel.org, faizal.abdul.rahim@intel.com,\n hong.aun.looi@intel.com, khai.wen.tan@intel.com,\n Faizal Rahim , Looi,\n Aleksandr Loktionov ,\n KhaiWenTan ","Date":"Wed, 22 Apr 2026 23:56:59 +0800","Message-ID":"<20260422155701.7420-2-khai.wen.tan@linux.intel.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260422155701.7420-1-khai.wen.tan@linux.intel.com>","References":"<20260422155701.7420-1-khai.wen.tan@linux.intel.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1776874815; x=1808410815;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=EfOOrxhNAc002gBQ2b94VR1M0iDD4MM8+CD2KGS9Miw=;\n b=B7V3RDjRKV2edYDTsf6XW0f0Sptd7jKvr3xzcEsCFFZ1PWT6/1OnJdL6\n T+P4uh0QfsVFLL07CTCUvkRlujAGsD/1SNpvC3Y9JJI+X6oMtj0tX+C8v\n lqrQShjUD01Ub/WEmS9tCfLJyrq0f6p5TZ1Ex0f3hi/58AcmqDdXNJk7Q\n wj3N5iXiLKDpIyGMCdZgmIabh+Hi0Lvi5KjlW4FqhKCiPRCYUIv1XQID2\n W24425Qm2g+R3tELV6W+C4rI59yraN9enLu6RJF1LJCV44uz8W1ZJyzws\n PJ/uwoeiexul+qq5WqdBFZDAbPBZQYDH4cH0lJRrlBbvaAZVueADotXh+\n g==;","X-Mailman-Original-Authentication-Results":["smtp3.osuosl.org;\n dmarc=none (p=none dis=none)\n header.from=linux.intel.com","smtp3.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=B7V3RDjR"],"Subject":"[Intel-wired-lan] [PATCH iwl-next v3 1/3] igc: remove unused\n autoneg_failed field","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"From: Faizal Rahim \n\nautoneg_failed in struct igc_mac_info is never set in the igc driver.\nRemove the field and the dead code checking it in\nigc_config_fc_after_link_up().\n\nReviewed-by: Looi, Hong Aun \nReviewed-by: Aleksandr Loktionov \nSigned-off-by: Faizal Rahim \nSigned-off-by: KhaiWenTan \n---\n drivers/net/ethernet/intel/igc/igc_hw.h | 1 -\n drivers/net/ethernet/intel/igc/igc_mac.c | 16 +---------------\n 2 files changed, 1 insertion(+), 16 deletions(-)\n\n--\n2.43.0","diff":"diff --git a/drivers/net/ethernet/intel/igc/igc_hw.h b/drivers/net/ethernet/intel/igc/igc_hw.h\nindex be8a49a86d09..86ab8f566f44 100644\n--- a/drivers/net/ethernet/intel/igc/igc_hw.h\n+++ b/drivers/net/ethernet/intel/igc/igc_hw.h\n@@ -92,7 +92,6 @@ struct igc_mac_info {\n \tbool asf_firmware_present;\n \tbool arc_subsystem_valid;\n\n-\tbool autoneg_failed;\n \tbool get_link_status;\n };\n\ndiff --git a/drivers/net/ethernet/intel/igc/igc_mac.c b/drivers/net/ethernet/intel/igc/igc_mac.c\nindex 7ac6637f8db7..142beb9ae557 100644\n--- a/drivers/net/ethernet/intel/igc/igc_mac.c\n+++ b/drivers/net/ethernet/intel/igc/igc_mac.c\n@@ -438,28 +438,14 @@ void igc_config_collision_dist(struct igc_hw *hw)\n * Checks the status of auto-negotiation after link up to ensure that the\n * speed and duplex were not forced. If the link needed to be forced, then\n * flow control needs to be forced also. If auto-negotiation is enabled\n- * and did not fail, then we configure flow control based on our link\n- * partner.\n+ * then we configure flow control based on our link partner.\n */\n s32 igc_config_fc_after_link_up(struct igc_hw *hw)\n {\n \tu16 mii_status_reg, mii_nway_adv_reg, mii_nway_lp_ability_reg;\n-\tstruct igc_mac_info *mac = &hw->mac;\n \tu16 speed, duplex;\n \ts32 ret_val = 0;\n\n-\t/* Check for the case where we have fiber media and auto-neg failed\n-\t * so we had to force link. In this case, we need to force the\n-\t * configuration of the MAC to match the \"fc\" parameter.\n-\t */\n-\tif (mac->autoneg_failed)\n-\t\tret_val = igc_force_mac_fc(hw);\n-\n-\tif (ret_val) {\n-\t\thw_dbg(\"Error forcing flow control settings\\n\");\n-\t\tgoto out;\n-\t}\n-\n \t/* In auto-neg, we need to check and see if Auto-Neg has completed,\n \t * and if so, how the PHY and link partner has flow control\n \t * configured.\n","prefixes":["iwl-next","v3","1/3"]}