{"id":2226574,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2226574/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260422161407.118748-16-kwilczynski@kernel.org/","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/1.1/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260422161407.118748-16-kwilczynski@kernel.org>","date":"2026-04-22T16:13:58","name":"[v6,15/24] alpha/PCI: Remove WARN from __pci_mmap_fits()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"6955ab90c594ec0037a2a98a3aa2647bac325064","submitter":{"id":86709,"url":"http://patchwork.ozlabs.org/api/1.1/people/86709/?format=json","name":"Krzysztof Wilczyński","email":"kwilczynski@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260422161407.118748-16-kwilczynski@kernel.org/mbox/","series":[{"id":501041,"url":"http://patchwork.ozlabs.org/api/1.1/series/501041/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/list/?series=501041","date":"2026-04-22T16:13:46","name":"PCI: Convert all dynamic sysfs attributes to static","version":6,"mbox":"http://patchwork.ozlabs.org/series/501041/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2226574/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2226574/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=Kjky3Qp8;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-pci+bounces-53001-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"Kjky3Qp8\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g147r5bYGz1y2d\n\tfor ; Thu, 23 Apr 2026 02:15:20 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 18AD630071FD\n\tfor ; Wed, 22 Apr 2026 16:15:13 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id AF11D325495;\n\tWed, 22 Apr 2026 16:15:04 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B77B37D12E;\n\tWed, 22 Apr 2026 16:15:04 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id F1AA7C2BCB7;\n\tWed, 22 Apr 2026 16:15:00 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776874504; cv=none;\n b=p3gZNB8OnylWevGYL+yL1RWYeyZmj0cUNlWFlOU/xCWaBzGR8gjOtBd/g4qRBKxcncxizrAV0VnDAPoMJUIA6D7kg1EhUAIePxbcAhr5cdxUqk+Ywp41MgD3QR2RhFeOmI89k2WkZssHV4pP+PLAKWYWJr+ulAj5ANyjgapp+iM=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776874504; c=relaxed/simple;\n\tbh=ltS0CwScmU/7W/k23zstFp4KU0BXOTAMQrPkEPzvQfw=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=g/tldm7x2eSN/hYMl+mbp9syVpeBUcG98N/CLjWNK12Rpuw37JqKcvQHjhdi0YvEXBNoHAYu8bhmqiYczEVZbWSYeNQTQuF8BhpI20QO0kuIuNmrrBzRxDndHTcqRuv6nZ9ZYG4v741tauhKANu/4PRnV/hI+P0SaItIpLkd+xA=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=Kjky3Qp8; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776874504;\n\tbh=ltS0CwScmU/7W/k23zstFp4KU0BXOTAMQrPkEPzvQfw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Kjky3Qp8t/knDHFwKUrhkLsr0qZD1jVYl/+BCV7F+W+jC/KDfwIwNzz29ILZHaA/C\n\t HZ5KEAOYmSea9bjuLxdcD6qsHryQtfiMSRnZW4RGtftLFRVvSXoTxjmWCpIqM00eXN\n\t prkYb78V/oaGACAGNylcOckDGDBsVR8VBuRQ3yPD2nqO++JbVa9lR0XtwV//dlwZap\n\t HwEm989HL8MTZdSEG0sOgYUO4VgUrf3T+emm9Efr8j2hn9lGoPYEm1PP2ykvChmDKo\n\t 04nJU4mKd3V6C8Zgg05BljN42NfWYNuvT2p4E0YZiPa8BeMN47WCr696udq7NFuadi\n\t gDZw9G9IBljag==","From":"=?utf-8?q?Krzysztof_Wilczy=C5=84ski?= ","To":"Bjorn Helgaas ","Cc":"Bjorn Helgaas ,\n Manivannan Sadhasivam ,\n Lorenzo Pieralisi ,\n Magnus Lindholm , Matt Turner ,\n Richard Henderson ,\n Christophe Leroy ,\n Madhavan Srinivasan ,\n Michael Ellerman , Nicholas Piggin ,\n Dexuan Cui ,\n =?utf-8?q?Krzysztof_Ha=C5=82asa?= ,\n Lukas Wunner , \"Oliver O'Halloran\" ,\n Saurabh Singh Sengar ,\n Shuan He , Srivatsa Bhat ,\n\t=?utf-8?q?Ilpo_J=C3=A4rvinen?= ,\n linux-pci@vger.kernel.org, linux-alpha@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org","Subject":"[PATCH v6 15/24] alpha/PCI: Remove WARN from __pci_mmap_fits()","Date":"Wed, 22 Apr 2026 16:13:58 +0000","Message-ID":"<20260422161407.118748-16-kwilczynski@kernel.org>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260422161407.118748-1-kwilczynski@kernel.org>","References":"<20260422161407.118748-1-kwilczynski@kernel.org>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit"},"content":"Remove the WARN() that fires when userspace attempts to mmap beyond\nthe BAR bounds. The check still returns 0 to reject the mapping,\nbut the warning is excessive for normal operation.\n\nA similar warning was removed from the PCI core in the commit\n3b519e4ea618 (\"PCI: fix size checks for mmap() on /proc/bus/pci files\").\n\nTested-by: Magnus Lindholm \nReviewed-by: Ilpo Järvinen \nAcked-by: Magnus Lindholm \nSigned-off-by: Krzysztof Wilczyński \n---\n arch/alpha/kernel/pci-sysfs.c | 8 +-------\n 1 file changed, 1 insertion(+), 7 deletions(-)","diff":"diff --git a/arch/alpha/kernel/pci-sysfs.c b/arch/alpha/kernel/pci-sysfs.c\nindex 8802f955256e..f2ee737c588c 100644\n--- a/arch/alpha/kernel/pci-sysfs.c\n+++ b/arch/alpha/kernel/pci-sysfs.c\n@@ -48,13 +48,7 @@ static int __pci_mmap_fits(struct pci_dev *pdev, int num,\n \tstart = vma->vm_pgoff;\n \tsize = ((len - 1) >> (PAGE_SHIFT - shift)) + 1;\n \n-\tif (start < size && size - start >= nr)\n-\t\treturn 1;\n-\tWARN(1, \"process \\\"%s\\\" tried to map%s 0x%08lx-0x%08lx on %s BAR %d \"\n-\t\t\"(size 0x%08lx)\\n\",\n-\t\tcurrent->comm, sparse ? \" sparse\" : \"\", start, start + nr,\n-\t\tpci_name(pdev), num, size);\n-\treturn 0;\n+\treturn start < size && size - start >= nr;\n }\n \n /**\n","prefixes":["v6","15/24"]}