{"id":2226543,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2226543/?format=json","web_url":"http://patchwork.ozlabs.org/project/rtc-linux/patch/1961102.tdWV9SEqCh@rafael.j.wysocki/","project":{"id":9,"url":"http://patchwork.ozlabs.org/api/1.1/projects/9/?format=json","name":"Linux RTC development","link_name":"rtc-linux","list_id":"linux-rtc.vger.kernel.org","list_email":"linux-rtc@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<1961102.tdWV9SEqCh@rafael.j.wysocki>","date":"2026-04-22T15:24:08","name":"[v1,1/4] ACPI: TAD: Use __ATTRIBUTE_GROUPS() macro","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"fb7cb6765580813a877f8e36ffd3cd2b12c0cf93","submitter":{"id":64267,"url":"http://patchwork.ozlabs.org/api/1.1/people/64267/?format=json","name":"Rafael J. Wysocki","email":"rafael@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/rtc-linux/patch/1961102.tdWV9SEqCh@rafael.j.wysocki/mbox/","series":[{"id":501033,"url":"http://patchwork.ozlabs.org/api/1.1/series/501033/?format=json","web_url":"http://patchwork.ozlabs.org/project/rtc-linux/list/?series=501033","date":"2026-04-22T15:25:46","name":"ACPI: TAD: Fixes and cleanups on top of recent changes","version":1,"mbox":"http://patchwork.ozlabs.org/series/501033/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2226543/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2226543/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-rtc@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=mJLGbKx4;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-rtc+bounces-6394-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"mJLGbKx4\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g138L75NSz1y2d\n\tfor ; Thu, 23 Apr 2026 01:30:42 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id D5E56303659C\n\tfor ; Wed, 22 Apr 2026 15:28:16 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 363C634FF5A;\n\tWed, 22 Apr 2026 15:28:05 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 11C273148CF;\n\tWed, 22 Apr 2026 15:28:04 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 935C5C19425;\n\tWed, 22 Apr 2026 15:28:03 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776871685; cv=none;\n b=goq1aBfTH/RX62ABveS8ly/84AZIafgHo0p2tHKUI+IEBtIo+zPKEfS2/nMSHnvCak4CobBfcwEOqlsIX9NHLz7l6GiYVcF9Tu43Aj4y7cW4v0bxKbc83ZvWYvN8BeE2FEzuyFcQFn5J0YJfYVNim97i+9TGc2OXwuJAbwn9JRY=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776871685; c=relaxed/simple;\n\tbh=j5mjbuZHUs3T+VE1ywP1N0KVLJLB/Ivpt2PboPyDndM=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=HVjshrCS/eZvLfiRFf+gnFMxbGQ4qBfclhxbKcSANOVG7Bij/kaVa7byUSNEKaOOpQ5U+lGmUUaXWUD34uTjjg+c7Cu+/FY879MBs9aCKyy1UdiYJ94+IGN7IDbcAB4rM0aL5W3xDgkD5XSGztrwS0zvFRYpNCYHW5rJYkCoOM8=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=mJLGbKx4; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776871684;\n\tbh=j5mjbuZHUs3T+VE1ywP1N0KVLJLB/Ivpt2PboPyDndM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=mJLGbKx4Jc+VLWQ6Pu7MePSSCeZXqF/ELF0qsweJm4MjNqYe9ZtizITlvXKoQAvX9\n\t azgHgBAQ/v5GqAeyA9sJhMVXwWtfgxurCB9SOpPi/7MQtKi7G7O5PyA6qkMZrcAFKP\n\t UltWtsQEZQDrtoEPPJH5oszyACitKU4rsqNTOfdF6bSy85SrduMAP8KxmlQZYGDs5T\n\t 2yVKCTKMkznOI+xc1KcLue5L7bfXVaAKG8aICwusFC+9wRHlVIBpvFyqlZd57iWAz8\n\t xHI7qaheLwZh2sAv7u9EriqVDLqkgjC0aeSA+J2sclNXRuaEVj9u0nHf3RMmNtNQnu\n\t VTIe4qD+nwBMg==","From":"\"Rafael J. Wysocki\" ","To":"Linux ACPI ","Cc":"linux-rtc@vger.kernel.org, LKML ,\n Alexandre Belloni ","Subject":"[PATCH v1 1/4] ACPI: TAD: Use __ATTRIBUTE_GROUPS() macro","Date":"Wed, 22 Apr 2026 17:24:08 +0200","Message-ID":"<1961102.tdWV9SEqCh@rafael.j.wysocki>","Organization":"Linux Kernel Development","In-Reply-To":"<2415066.ElGaqSPkdT@rafael.j.wysocki>","References":"<2415066.ElGaqSPkdT@rafael.j.wysocki>","Precedence":"bulk","X-Mailing-List":"linux-rtc@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"7Bit","Content-Type":"text/plain; charset=\"UTF-8\""},"content":"From: Rafael J. Wysocki \n\nRecent commit 93afe8ba9b01 (\"ACPI: TAD: Use dev_groups in struct\ndevice_driver\") switched over the ACPI TAD driver to using device\nattruibute groups instead of creating and removing the device sysfs\nattributes directly, but it might go one step farther and use the\n__ATTRIBUTE_GROUPS() macro which would reduce the code size slightly.\n\nDo it now.\n\nSigned-off-by: Rafael J. Wysocki \n---\n drivers/acpi/acpi_tad.c | 9 +++------\n 1 file changed, 3 insertions(+), 6 deletions(-)","diff":"--- a/drivers/acpi/acpi_tad.c\n+++ b/drivers/acpi/acpi_tad.c\n@@ -605,15 +605,12 @@ static umode_t acpi_tad_attr_is_visible(\n \treturn 0;\n }\n \n-static const struct attribute_group acpi_tad_attr_group = {\n+static const struct attribute_group acpi_tad_group = {\n \t.attrs\t= acpi_tad_attrs,\n \t.is_visible = acpi_tad_attr_is_visible,\n };\n \n-static const struct attribute_group *acpi_tad_attr_groups[] = {\n-\t&acpi_tad_attr_group,\n-\tNULL,\n-};\n+__ATTRIBUTE_GROUPS(acpi_tad);\n \n #ifdef CONFIG_RTC_CLASS\n /* RTC class device interface */\n@@ -885,7 +882,7 @@ static struct platform_driver acpi_tad_d\n \t.driver = {\n \t\t.name = \"acpi-tad\",\n \t\t.acpi_match_table = acpi_tad_ids,\n-\t\t.dev_groups = acpi_tad_attr_groups,\n+\t\t.dev_groups = acpi_tad_groups,\n \t},\n \t.probe = acpi_tad_probe,\n \t.remove = acpi_tad_remove,\n","prefixes":["v1","1/4"]}