{"id":2226479,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2226479/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422125250.1303100-19-alex.bennee@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260422125250.1303100-19-alex.bennee@linaro.org>","date":"2026-04-22T12:52:35","name":"[v3,18/32] target/arm: make whpx use syndrome helpers for decode","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"e732c0ac43d899c52ebb375ef7859a3b658173ca","submitter":{"id":39532,"url":"http://patchwork.ozlabs.org/api/1.1/people/39532/?format=json","name":"Alex Bennée","email":"alex.bennee@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422125250.1303100-19-alex.bennee@linaro.org/mbox/","series":[{"id":501008,"url":"http://patchwork.ozlabs.org/api/1.1/series/501008/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501008","date":"2026-04-22T12:52:20","name":"target/arm: fully model WFxT instructions for A-profile","version":3,"mbox":"http://patchwork.ozlabs.org/series/501008/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2226479/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2226479/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=qcP5sWV/;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0zvY0JZvz1y2d\n\tfor ; Wed, 22 Apr 2026 23:04:24 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFXE6-0001Kx-Ny; Wed, 22 Apr 2026 09:02:46 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wFXDz-0001A4-3y\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 09:02:39 -0400","from mail-wm1-x335.google.com ([2a00:1450:4864:20::335])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wFXDx-00019n-II\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 09:02:38 -0400","by mail-wm1-x335.google.com with SMTP id\n 5b1f17b1804b1-488af96f6b2so69656705e9.0\n for ; Wed, 22 Apr 2026 06:02:37 -0700 (PDT)","from draig.lan ([185.124.0.195]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488fc10019bsm458543425e9.4.2026.04.22.06.02.28\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 22 Apr 2026 06:02:30 -0700 (PDT)","from draig.lan (localhost [IPv6:::1])\n by draig.lan (Postfix) with ESMTP id 64AB0611AD;\n Wed, 22 Apr 2026 13:52:52 +0100 (BST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776862956; x=1777467756; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=1esNeOF5ufpO0cAxHdsE5rjzSjC5Q+4Ajm02teJ1954=;\n b=qcP5sWV/+P3orJmIQh/4Tp7bsRiuMlRuXSX7xgtks0572Deid/z+fGF2GkRSVc5Rgo\n oWrl5fTq0r9bAxFAw5UwwIjNVjvWfOCn0xaaR8xBVJg1kgbr4sYefl+OBbRL9PBjqnTb\n B6OJChE5d8f+ce6AF89M6HWKOSlc7sX2ZZsI+oZNCD/CMDrQu1aT3k/P9CgC2SaqHW2d\n kM9NNejeMHDk2fxpZcr+x3bfdPtdK2T/lMIVn+ZqCkQEoNovTpnIy++qnBWgbOquGpmV\n 9/J88qdYX7Van07ey3td7e+tdOEpXRMUHljtStFOVlrZYmKIm/UELyjhRF4ISy2ONC5X\n CySg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776862956; x=1777467756;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=1esNeOF5ufpO0cAxHdsE5rjzSjC5Q+4Ajm02teJ1954=;\n b=lW4P8jciT9H16cKb3xixKYH7U5No2nFoX710qlFgyRqVmdWckSuOuYb/IzhR7OgTg6\n y6exK70U/Rs08Tk3npxsBZWnWPoHDmVp77lCPvsun2GoI9bCFL5Din8ZeC53Y/JZszcl\n 7OnJt8SONCZeRcEKI9uttNnyxJsDe51wPfrxYbEE/xgP3qxcMh1S9qUDLypENsea/T8/\n DMYfghBFetIF10wPijPGp58Ls8xFSfcbigmQPgWTk70rgliCPydnxT+zs94mAYYIMdTD\n K0+oBxMAWwxEjnIgrcGeDw8GTxj9Qwgt+aicIz1qkJ0ctS3vqMomUupSCZdhxghT1nnZ\n exkQ==","X-Gm-Message-State":"AOJu0YzfGt/EPVRXsAChf4+obfCQ/Ko5PFLFMpKxp5sZfg5X6PNUpNIi\n rc3F5nxz6GHanfh3VBdvC6mJ8R9O6SFFZs5wzm+ROIhveGBArTZ0eQDuErEqcS/OcGM=","X-Gm-Gg":"AeBDiesVpmqwAw/1P5n3kzlA9EP2X7T4QG4VEz/XEkUgylRpQT5IAA7gK+O+jFgyc4E\n 0IzzEwmWmXHMuB9hqLpk1c6hQq/PM+GV7WZmAus3QqeUivqmsCBL7FQB/nBAjqgWEJYoO+vEOh7\n AtLQVQKxmoML2Ha7/ORUOehkQEu+NX0iomKdSheBADS/5LLh3jtFijIrT/od5dItTal6ZgeJhlX\n EbpEokhVoEb0AmMcyEP5nwnQgNyS5Fjv9E9itIBVIDliPZzSbJ53DtMGDSfRjon2RyU+TbWHSu5\n mTzwuE19RLAAJs7nMulwK/13BoIUNNsTDyMiHNxut1m6VFnkOQOK9W/9CpTHN9i028HkfQuYe4h\n hXY8sYu34ZjF5WTen2rM+oAIXxyARJkrjJWlKl0qIqySzwtz2uDNALFONjgsIpZp88pD9dnzjUR\n R9TfzR7qe72lIUOvesDRF9cp3GMZh9WXU5sA==","X-Received":"by 2002:a05:600c:a108:b0:488:a82f:bbb4 with SMTP id\n 5b1f17b1804b1-488fb78a0famr276133055e9.26.1776862952883;\n Wed, 22 Apr 2026 06:02:32 -0700 (PDT)","From":"=?utf-8?q?Alex_Benn=C3=A9e?= ","To":"qemu-devel@nongnu.org","Cc":"Pedro Barbuda , Alexander Graf ,\n Peter Maydell ,\n Paolo Bonzini ,\n Mohamed Mediouni , kvm@vger.kernel.org,\n qemu-arm@nongnu.org, =?utf-8?q?Alex_Benn=C3=A9e?= ,\n Richard Henderson ","Subject":"[PATCH v3 18/32] target/arm: make whpx use syndrome helpers for\n decode","Date":"Wed, 22 Apr 2026 13:52:35 +0100","Message-ID":"<20260422125250.1303100-19-alex.bennee@linaro.org>","X-Mailer":"git-send-email 2.47.3","In-Reply-To":"<20260422125250.1303100-1-alex.bennee@linaro.org>","References":"<20260422125250.1303100-1-alex.bennee@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::335;\n envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x335.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Rather than open coding a bunch of shifts and masks we can use the\nsyndrome definitions. While we are at it assert it really is a\nEC_DATAABORT.\n\nReviewed-by: Richard Henderson \nSigned-off-by: Alex Bennée \n---\n target/arm/whpx/whpx-all.c | 13 +++++++------\n 1 file changed, 7 insertions(+), 6 deletions(-)","diff":"diff --git a/target/arm/whpx/whpx-all.c b/target/arm/whpx/whpx-all.c\nindex bbf0f6be961..4cfc7f99698 100644\n--- a/target/arm/whpx/whpx-all.c\n+++ b/target/arm/whpx/whpx-all.c\n@@ -356,15 +356,16 @@ static int whpx_handle_mmio(CPUState *cpu, WHV_MEMORY_ACCESS_CONTEXT *ctx)\n {\n uint64_t syndrome = ctx->Syndrome;\n \n- bool isv = syndrome & ARM_EL_ISV;\n- bool iswrite = (syndrome >> 6) & 1;\n- bool sse = (syndrome >> 21) & 1;\n- uint32_t sas = (syndrome >> 22) & 3;\n+ bool isv = FIELD_EX32(syndrome, DABORT_ISS, ISV);\n+ bool iswrite = FIELD_EX32(syndrome, DABORT_ISS, WNR);\n+ bool sse = FIELD_EX32(syndrome, DABORT_ISS, SSE);\n+ uint32_t sas = FIELD_EX32(syndrome, DABORT_ISS, SAS);\n uint32_t len = 1 << sas;\n- uint32_t srt = (syndrome >> 16) & 0x1f;\n- uint32_t cm = (syndrome >> 8) & 0x1;\n+ uint32_t srt = FIELD_EX32(syndrome, DABORT_ISS, SRT);\n+ uint32_t cm = FIELD_EX32(syndrome, DABORT_ISS, CM);\n uint64_t val = 0;\n \n+ assert(syn_get_ec(syndrome) == EC_DATAABORT);\n assert(!cm);\n assert(isv);\n \n","prefixes":["v3","18/32"]}