{"id":2226474,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2226474/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422125250.1303100-20-alex.bennee@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260422125250.1303100-20-alex.bennee@linaro.org>","date":"2026-04-22T12:52:36","name":"[v3,19/32] target/arm: make hvf use syndrome helpers for decode","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"6627f3a40497ac5f2f90cdc02508ce7005b89222","submitter":{"id":39532,"url":"http://patchwork.ozlabs.org/api/1.1/people/39532/?format=json","name":"Alex Bennée","email":"alex.bennee@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422125250.1303100-20-alex.bennee@linaro.org/mbox/","series":[{"id":501008,"url":"http://patchwork.ozlabs.org/api/1.1/series/501008/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501008","date":"2026-04-22T12:52:20","name":"target/arm: fully model WFxT instructions for A-profile","version":3,"mbox":"http://patchwork.ozlabs.org/series/501008/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2226474/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2226474/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=zLSSKlPL;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0ztm0v1lz1y2d\n\tfor ; Wed, 22 Apr 2026 23:03:44 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFXE3-0001FO-CK; Wed, 22 Apr 2026 09:02:43 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wFXDx-00017U-AZ\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 09:02:37 -0400","from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wFXDv-000190-Kh\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 09:02:36 -0400","by mail-wm1-x32b.google.com with SMTP id\n 5b1f17b1804b1-488ff90d6c7so43413155e9.2\n for ; Wed, 22 Apr 2026 06:02:35 -0700 (PDT)","from draig.lan ([185.124.0.195]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488ffc5e3f4sm230894695e9.2.2026.04.22.06.02.27\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 22 Apr 2026 06:02:30 -0700 (PDT)","from draig.lan (localhost [IPv6:::1])\n by draig.lan (Postfix) with ESMTP id 78333611CD;\n Wed, 22 Apr 2026 13:52:52 +0100 (BST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776862954; x=1777467754; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=yq/bGIVh38nrtfwG2BReGAMOSU3dNrWCtccK7bpObt0=;\n b=zLSSKlPLbkPXphKKvIJG9JEobL0FT4X7JeITCTnKZ254Uq+EaHtQlkb5iCxy/flBv3\n UEQe7JUYFIPrTTOgsqcBHPT370TIvEdd8TQTFJ4YW0B0pt0FjfdrvQUh0H3BvtPrhSJ/\n JSTya62e/gNJx8EfbZQED4cBi40/Np0K1Fm83HVpkY67mBh8Ry/jxGY5AfeSN1r4SQYy\n JowkDZqRdp1eBsqdXrWVxFy15ru+zrR+hPXjPvGJD2XeZv+CXr5O34vHoZvT1h9k2Yyf\n A9iR3YPzjIJyBTZ485VcyUxBb/Enu8KF3eadTX2RC0dZln1ZiMGnmycRSS2MoWgLX5vB\n Q2ww==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776862954; x=1777467754;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=yq/bGIVh38nrtfwG2BReGAMOSU3dNrWCtccK7bpObt0=;\n b=kmzq0CvUtQuwg6kEO+C1LPsD7S5IKlw/TjcS6QYpWIk5K8QTIRh5mHc3skrbHpQbir\n 5UoNGZtl1Xoakv/eSNZ2n7wiAuHEUYWRvqQgw19MH36TRcZ2XZZckJUl3UVrKhkwxwzK\n Q2Jxf5cATJmrY+EemP+uYsBEThb0q2z5+sZMUWSb72kpTLAavD4zp7g8RAXCRkss4mLf\n oJo+8CsrevXQ00FCbPGCzK6EMPIIk9PU7gveQHxfFiqkmvuW/DhFN8pN9jlAsfNC6ee+\n buZ2S+LjOOiUOSSSnFQSnq5nsFqxbZ3QQ/Zo+sVXHhafj0TSvf197s0WcBhDNBHzbHeJ\n 6wqg==","X-Gm-Message-State":"AOJu0Yx2SRvgnE9t5rkCxQlXgn6pKXMHZ4FfHLzkQPLjbd/15qD/ACEy\n jGx3acksWHp4kiYxUe46IOktp9czhxFkX1qNYpliW4Q7uIbBof2JREHrbGYUcIs+gsg=","X-Gm-Gg":"AeBDieuwwK2Ass4S5hyWRxwfzTRv/PypXkx/feAjkhQuKIzWI8Ah5r6+lUCC6znoiHB\n kUOVLiJ8MR5X8v9qpCWuKkszz/i6fgzLMFBpi0sJusVfpiYgLcS4ykKmCb7Sr+xqMp2siFZ4Ms8\n 5PodMUgxYGkn/zuCSev1lRpeQ2xhFO9KkdykovnRdIcd8mHyUd8R9n+KldVL7FaJboDe3D5gunX\n kZdKqSzFJLpquqOQ65SOe+k5rB7B0j1BtwVXtEx1G3fun9Xf09hEUdLPUrz2qnIsRK46eGWTvXF\n iO938UlgAgjK0rhmALk4sUrgc8KtUA1gvgWAZ7TUixK2hO7Kxe0o7w7YyXI34UnY1XMa1lgoRnQ\n ATAdwszaQbwonlmVmJfYcSq+bbtjaHlTahEnvV/LV2zys+MQJI78Y3tzpCMqxrKwJFrUzTpH+4c\n CGr9V/VhQbTltlB7FxvMMSHl5A9eduGQQm75DxXWtPs5SM","X-Received":"by 2002:a05:600c:1da1:b0:488:d376:42cd with SMTP id\n 5b1f17b1804b1-488fb785901mr358408635e9.22.1776862952412;\n Wed, 22 Apr 2026 06:02:32 -0700 (PDT)","From":"=?utf-8?q?Alex_Benn=C3=A9e?= ","To":"qemu-devel@nongnu.org","Cc":"Pedro Barbuda , Alexander Graf ,\n Peter Maydell ,\n Paolo Bonzini ,\n Mohamed Mediouni , kvm@vger.kernel.org,\n qemu-arm@nongnu.org, =?utf-8?q?Alex_Benn=C3=A9e?= ,\n Richard Henderson ","Subject":"[PATCH v3 19/32] target/arm: make hvf use syndrome helpers for decode","Date":"Wed, 22 Apr 2026 13:52:36 +0100","Message-ID":"<20260422125250.1303100-20-alex.bennee@linaro.org>","X-Mailer":"git-send-email 2.47.3","In-Reply-To":"<20260422125250.1303100-1-alex.bennee@linaro.org>","References":"<20260422125250.1303100-1-alex.bennee@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32b;\n envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x32b.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Rather than open coding a bunch of shifts and masks we can use the\nsyndrome definitions.\n\nReviewed-by: Richard Henderson \nSigned-off-by: Alex Bennée \n---\n target/arm/hvf/hvf.c | 14 +++++++-------\n 1 file changed, 7 insertions(+), 7 deletions(-)","diff":"diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c\nindex 5fc8f6bbbd9..1c1c31f0b15 100644\n--- a/target/arm/hvf/hvf.c\n+++ b/target/arm/hvf/hvf.c\n@@ -2123,14 +2123,14 @@ static int hvf_handle_exception(CPUState *cpu, hv_vcpu_exit_exception_t *excp)\n break;\n }\n case EC_DATAABORT: {\n- bool isv = syndrome & ARM_EL_ISV;\n- bool iswrite = (syndrome >> 6) & 1;\n- bool s1ptw = (syndrome >> 7) & 1;\n- bool sse = (syndrome >> 21) & 1;\n- uint32_t sas = (syndrome >> 22) & 3;\n+ bool isv = FIELD_EX32(syndrome, DABORT_ISS, ISV);\n+ bool iswrite = FIELD_EX32(syndrome, DABORT_ISS, WNR);\n+ bool s1ptw = FIELD_EX32(syndrome, DABORT_ISS, S1PTW);\n+ bool sse = FIELD_EX32(syndrome, DABORT_ISS, SSE);\n+ uint32_t sas = FIELD_EX32(syndrome, DABORT_ISS, SAS);\n uint32_t len = 1 << sas;\n- uint32_t srt = (syndrome >> 16) & 0x1f;\n- uint32_t cm = (syndrome >> 8) & 0x1;\n+ uint32_t srt = FIELD_EX32(syndrome, DABORT_ISS, SRT);\n+ uint32_t cm = FIELD_EX32(syndrome, DABORT_ISS, CM);\n uint64_t val = 0;\n uint64_t ipa = excp->physical_address;\n AddressSpace *as = cpu_get_address_space(cpu, ARMASIdx_NS);\n","prefixes":["v3","19/32"]}