{"id":2226459,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2226459/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422125250.1303100-16-alex.bennee@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260422125250.1303100-16-alex.bennee@linaro.org>","date":"2026-04-22T12:52:32","name":"[v3,15/32] target/arm: migrate check_hcr_el2_trap to use syndrome helper","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"f447c5afc1b31b900a0c903061195b9411eaa158","submitter":{"id":39532,"url":"http://patchwork.ozlabs.org/api/1.1/people/39532/?format=json","name":"Alex Bennée","email":"alex.bennee@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422125250.1303100-16-alex.bennee@linaro.org/mbox/","series":[{"id":501008,"url":"http://patchwork.ozlabs.org/api/1.1/series/501008/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501008","date":"2026-04-22T12:52:20","name":"target/arm: fully model WFxT instructions for A-profile","version":3,"mbox":"http://patchwork.ozlabs.org/series/501008/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2226459/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2226459/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=KnnUARRm;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0zhK5Kmgz1yD5\n\tfor ; Wed, 22 Apr 2026 22:54:41 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFX5c-0006UO-KK; Wed, 22 Apr 2026 08:54:00 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wFX4m-000627-VT\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 08:53:09 -0400","from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wFX4k-0005Vz-Uy\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 08:53:08 -0400","by mail-wr1-x42c.google.com with SMTP id\n ffacd0b85a97d-43d70c30767so3719713f8f.0\n for ; Wed, 22 Apr 2026 05:53:05 -0700 (PDT)","from draig.lan ([185.124.0.195]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43fe4e59f97sm50548635f8f.37.2026.04.22.05.52.57\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 22 Apr 2026 05:53:02 -0700 (PDT)","from draig.lan (localhost [IPv6:::1])\n by draig.lan (Postfix) with ESMTP id 2A69F61063;\n Wed, 22 Apr 2026 13:52:52 +0100 (BST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776862385; x=1777467185; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=pBHHqWCNozXOcmQTxKAtN3Av+2DGbBLMiAYtHB54URk=;\n b=KnnUARRmenZIfyPVLSLTd79FttMFA9R0BZPOkmxNFBj0tNfpzxmjrll41YwIk4nDyM\n buuOHmvK9qpaXH4fsvmqKFb8McWGqeYkXusXg6Si2L3MyiV5yncWpTSyNEIuIfWlw8I7\n PwWx+t/pm7fYjcIKPLqhFzFPs6H/GQ0cx8y4ALjUqMLnlXSS8SYluI6KYYZU2TxI8T0S\n pH28QqRsPS2PZh5802tyhKCoO35BqdJ4mfmTWdPlHkuUop9DTrVJf4eukisGl1STVc+M\n oPl8kHS1Z9BbMdLMOWMWPK7DADwZxbvIbOHXH+xUC12YwRpHYSZaYo79BJdUuK+Skut0\n mSjQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776862385; x=1777467185;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=pBHHqWCNozXOcmQTxKAtN3Av+2DGbBLMiAYtHB54URk=;\n b=WlENCdLS5Y1UH6u9YBAgDyCQwwZbu8BSvNpU7CAjH5bSYwBaFqe3ojQg5f7UTMQ5SL\n kCXmAjVN0ldldz6ywtFxd/EiThhRqsaBkgV5I8aQeWELNRY4RdEjheI/zNxvFNJIldc5\n R5POhqbZ6ZxgoT0wkr/aR8xNfnQlLos2BMEBxI3oWYjFKY66zokkBnwAE9qchhwfVYPc\n lOEnyAls9AI6LkcHsSaFqEWoi1DDqq8OTwd8gK12r0vDJiRp+vCAKOPDZZoF+ZViXdRh\n EK5GGUP6mQUfgvdnPIWWgDpc6IQvdWlyL0lLMbxdHVvhNN6IyqxKYb7zk7K/YGj/dwkT\n 3euA==","X-Gm-Message-State":"AOJu0YyjcONPk/uLUJsFta8ypO7gfU4jbUxFP8vzwfqb3DlJ2YT+DUfK\n x3+slqlD5r/XagJ2AjMa1fgzSRLxXo4hw3tCeP/qRtTBFxL5vRPaDMOYhI97LwYHdn0=","X-Gm-Gg":"AeBDievdK1qCpNJBjZBLx4ZfKhkJKiKEv6UsKDARdy7kZm10a4SUVovzbEZrIhnOaKH\n 8Id+LDVT/dCwwNlEDXWKceQtLmq6W0CMtvk5JC1NK79JyIe6l5gHNDwGUZTZ5T10W0qJ0Bkamtj\n iXv2UrV4JpkUOEIluFOjmlQJnVk+eBtLLrZOOaVzGXiHXIEcCu7UKPhBcGjZWYdvfpaTn6lDPs6\n HaTi5qigsBnIXcH1xbKhTnDGKGkazZOX+VBnZ7It3fXdufm11Rk9Q6CaKkdMoA9iIDApu4GxBtH\n HZU+0KVwEpWZ1MHHTz9CHL/Rt/AKaokOUggc3SMMjcDcMeft8d9axVwfMsvfuiK/VemK5Hf+2dw\n 4TSlnJDpFMUxoF8+a5ard/EoovfOP7v2JRgYgBVCSszmOF9MbW0Xcx1mf5JXw5ZPJxkfpQK9UYs\n bhY4bI7BAp1v9fjs7jd34vm19x3ln8DBS6tA==","X-Received":"by 2002:a5d:64c9:0:b0:43d:2d34:8963 with SMTP id\n ffacd0b85a97d-43fe407ae53mr37079461f8f.17.1776862384713;\n Wed, 22 Apr 2026 05:53:04 -0700 (PDT)","From":"=?utf-8?q?Alex_Benn=C3=A9e?= ","To":"qemu-devel@nongnu.org","Cc":"Pedro Barbuda , Alexander Graf ,\n Peter Maydell ,\n Paolo Bonzini ,\n Mohamed Mediouni , kvm@vger.kernel.org,\n qemu-arm@nongnu.org, =?utf-8?q?Alex_Benn=C3=A9e?= ,\n Richard Henderson ","Subject":"[PATCH v3 15/32] target/arm: migrate check_hcr_el2_trap to use\n syndrome helper","Date":"Wed, 22 Apr 2026 13:52:32 +0100","Message-ID":"<20260422125250.1303100-16-alex.bennee@linaro.org>","X-Mailer":"git-send-email 2.47.3","In-Reply-To":"<20260422125250.1303100-1-alex.bennee@linaro.org>","References":"<20260422125250.1303100-1-alex.bennee@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::42c;\n envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42c.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"It shares the same COPROC_ISS encoding as the other CP traps although\nnot all the fields are used.\n\nReviewed-by: Richard Henderson \nSigned-off-by: Alex Bennée \n---\n target/arm/syndrome.h | 16 ++++++++++++++++\n target/arm/tcg/vfp_helper.c | 5 +----\n 2 files changed, 17 insertions(+), 4 deletions(-)","diff":"diff --git a/target/arm/syndrome.h b/target/arm/syndrome.h\nindex 841fd3292b8..53137394e28 100644\n--- a/target/arm/syndrome.h\n+++ b/target/arm/syndrome.h\n@@ -251,6 +251,22 @@ FIELD(COPROC_ISS, OP2, 17, 3)\n FIELD(COPROC_ISS, COND, 20, 4)\n FIELD(COPROC_ISS, CV, 24, 1)\n \n+static inline uint32_t syn_cp10_rt_trap(int cv, int cond, int opc1,\n+ int crn, int rt, int isread)\n+{\n+ uint32_t res = syn_set_ec(0, EC_FPIDTRAP);\n+ res = FIELD_DP32(res, SYNDROME, IL, 1);\n+\n+ res = FIELD_DP32(res, COPROC_ISS, CV, cv);\n+ res = FIELD_DP32(res, COPROC_ISS, COND, cond);\n+ res = FIELD_DP32(res, COPROC_ISS, OP1, opc1);\n+ res = FIELD_DP32(res, COPROC_ISS, CRN, crn);\n+ res = FIELD_DP32(res, COPROC_ISS, RT, rt);\n+ res = FIELD_DP32(res, COPROC_ISS, ISREAD, isread);\n+\n+ return res;\n+}\n+\n static inline uint32_t syn_cp14_rt_trap(int cv, int cond, int opc1, int opc2,\n int crn, int crm, int rt, int isread,\n bool is_16bit)\ndiff --git a/target/arm/tcg/vfp_helper.c b/target/arm/tcg/vfp_helper.c\nindex 45f2eb0930f..e692bc568bd 100644\n--- a/target/arm/tcg/vfp_helper.c\n+++ b/target/arm/tcg/vfp_helper.c\n@@ -1359,10 +1359,7 @@ void HELPER(check_hcr_el2_trap)(CPUARMState *env, uint32_t rt, uint32_t reg)\n g_assert_not_reached();\n }\n \n- syndrome = ((EC_FPIDTRAP << ARM_EL_EC_SHIFT)\n- | ARM_EL_IL\n- | (1 << 24) | (0xe << 20) | (7 << 14)\n- | (reg << 10) | (rt << 5) | 1);\n+ syndrome = syn_cp10_rt_trap(1, 0xe, 7, reg, rt, 1);\n \n raise_exception(env, EXCP_HYP_TRAP, syndrome, 2);\n }\n","prefixes":["v3","15/32"]}