{"id":2226049,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2226049/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260422044230.1127071-1-rajasimandalos@gmail.com/","project":{"id":12,"url":"http://patchwork.ozlabs.org/api/1.1/projects/12/?format=json","name":"Linux CIFS Client","link_name":"linux-cifs-client","list_id":"linux-cifs.vger.kernel.org","list_email":"linux-cifs@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260422044230.1127071-1-rajasimandalos@gmail.com>","date":"2026-04-22T04:42:30","name":"[v2] smb: client: sync echo_interval on remount","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"edc4c9e591bd4ad35e17e92bc57af0bdac283635","submitter":{"id":91740,"url":"http://patchwork.ozlabs.org/api/1.1/people/91740/?format=json","name":"RAJASI MANDAL","email":"rajasimandalos@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260422044230.1127071-1-rajasimandalos@gmail.com/mbox/","series":[{"id":500921,"url":"http://patchwork.ozlabs.org/api/1.1/series/500921/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=500921","date":"2026-04-22T04:42:30","name":"[v2] smb: client: sync echo_interval on remount","version":2,"mbox":"http://patchwork.ozlabs.org/series/500921/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2226049/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2226049/checks/","tags":{},"headers":{"Return-Path":"\n <linux-cifs+bounces-10998-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=VOZXoQbg;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-cifs+bounces-10998-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"VOZXoQbg\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.216.52","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0mmn751pz1yGs\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Apr 2026 14:42:49 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id E4505301C5AA\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Apr 2026 04:42:47 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 356D814AD0D;\n\tWed, 22 Apr 2026 04:42:47 +0000 (UTC)","from mail-pj1-f52.google.com (mail-pj1-f52.google.com\n [209.85.216.52])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id E674328DC4\n\tfor <linux-cifs@vger.kernel.org>; Wed, 22 Apr 2026 04:42:45 +0000 (UTC)","by mail-pj1-f52.google.com with SMTP id\n 98e67ed59e1d1-354a18c48b5so4604725a91.1\n        for <linux-cifs@vger.kernel.org>;\n Tue, 21 Apr 2026 21:42:45 -0700 (PDT)","from dev-vm-rm.hzz4ddxqtfeetjrh00qlbgyytb.rx.internal.cloudapp.net\n ([20.197.52.255])\n        by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-362b9b6f5b5sm2012643a91.1.2026.04.21.21.42.43\n        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n        Tue, 21 Apr 2026 21:42:44 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776832967; cv=none;\n b=qbRyJcitV/aCun2o4fhT72/21ZKKWNAF5ThGIIjD9ArVhTOUGLFPVEOJEeswuVAtrj2Be/SrT7IyI8woTO4F5UqKPdqBrknIBsNP3k01TfF9Ae2jit0Yaw9L2ujCvPptUT0UzlEAFnJtHaNCqJGjg+XTu/GYNOLpfw7kRvJECJQ=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776832967; c=relaxed/simple;\n\tbh=+Sn8u0DLRQ7gia1mCmaJ+HRQsiMMm+xdqzgaYSxQtoY=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=eOtU0n36t1ciGJCVr9exQUuK3O32Bs3+hDSZnpUrBjUOu97ZZMrIkM8+xhbb7U1qC44WGRgnLXSm+6GCVeGksmx5Qmg4O9Oqu/zhke9j6ruFCvBkdvdjcI12ThqYixNFgJnzFGFPxh4QwATWcA1V/JttyimxE8ZFiAd5wIC+Kvg=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=VOZXoQbg; arc=none smtp.client-ip=209.85.216.52","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=gmail.com; s=20251104; t=1776832965; x=1777437765;\n darn=vger.kernel.org;\n        h=content-transfer-encoding:mime-version:references:in-reply-to\n         :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n         :message-id:reply-to;\n        bh=ZdBnyRsrmiV1KN7ybACpvzeRlAkDgk61lXOxjaTu8lg=;\n        b=VOZXoQbg7P1yE+HBum6unD07eO/nvU9inRh9BB3ET68bkhFZLtDqxQQOq/pIHG2IWd\n         TN9QGxsUvliiURk4AGwJeKjpX9+FAjqf+ZvpI4htXAiRX2VRYXwMslsjRXyZQrV1E046\n         PR1gxF3t59Lj6BralSe6OQ8ToXhwDydToyaDwMbUrx6riLyPfgwz+oHUUPMylXw4sKm1\n         vcaqA8j7IdkftIjuUiWQ5uxITVsAKl3voAC/vg4dK0LhlKqcqo9qEPWzoFu6HbsBB/OR\n         8xBNErgbpqEeN//nNYC6RF7+Z3EFFjdJOEvPMDUIg38x0JRIXoirUnYaAzXiKznDRP6g\n         7Z5Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=1e100.net; s=20251104; t=1776832965; x=1777437765;\n        h=content-transfer-encoding:mime-version:references:in-reply-to\n         :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n         :to:cc:subject:date:message-id:reply-to;\n        bh=ZdBnyRsrmiV1KN7ybACpvzeRlAkDgk61lXOxjaTu8lg=;\n        b=e/Y4cAFYsWWBNt5viUC+O6PIltkbHb0y/DH1O08b0Jrv037PVumWbnnWULIPFxIyad\n         QzIgVsE1XgGOTHNv9qDxEu2VT2IhqlCNjK7Id+zBsBudVKlS0nHkis2Q4whHOCAC3Nwn\n         UL3w4QEz5SY7qmHgeSszBtJFBQS8MkrteNnGOlBWoYEz184HCyw2EkblnH7Zrc7QS4x1\n         PL9oU+n0ESOXJpuXFdTzJd+q4Hsx0BKu1DNFIlnwAT6zbw0oboA11dgI4WdnG1+W4Csr\n         oHYARRWY4P8NsppnyqG7Juan8HsB1TV21wwsYg7joV5mmWVfw2BKBe4NZBDPFdj+ObfR\n         AXlg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+5TjtJ1zvW1iPNkko9QBIiDa1ZBWgHT86JOc+rGRw1i+DS+ro2iiWUwNmnnl1gEyUpikqr9H3dJwaY@vger.kernel.org","X-Gm-Message-State":"AOJu0Yy+bK9HWFVsDGTldFq6JIjcv9e0zeyJlWLxjZ1V6EoxG3qloxiu\n\t7D674uPRPdMfHS20fyuUJo+z3qSSOB9rv3nw27XBLQwzjr5ZtTfa7tka","X-Gm-Gg":"AeBDievv9n1PvAsWUOhZR0XL9zS7xkuzdxfwXYm+WTuapNGZWAayPAeerxP/GyCy2zz\n\tVqmABRzAIV5xjSGDaglIWYtbVSt3jTpuLk6S//EauFthiVue7THY376xCUOzder6wru7qBgO8sJ\n\tMwmEd812jfFhyW/9AB2X0N+ufjCInBwV9nA9kLNjFdcXpC9qIch0UzFB/MeYwqM9CHVUs0YuJUb\n\tV8DOhIAZAw5OUGF9bL0ItDjzpkMNRPE1NnzCJTVN/gpZ2m/V/jHKqKN0RJXAf/u3TsXCuUZEIWV\n\t8+/jDIMWeFBwpCAO64EDgp3yseByN1eldf1N6rn9Cym6lRXGEQgKt90i3ZrjvC/mw1rXaqMUEUR\n\tUDt6jsbjBDIIgSPX4gEvYpYctskiba+md3tykrSuorc9jMgPDKNoL6+v8jDqWLqZw0BaIFuFupr\n\tnUV5SqJ9IcRuR00faFQ7HadscYmq2HOxWIVmGynZ552VKRmDoJ4YlZbS6RbWqTCPmnfrBrSIp1Z\n\t+maUtcvqtQg/DllPuVBq25Yr/lGYoLVFQ==","X-Received":"by 2002:a17:90b:1804:b0:35d:9da0:4947 with SMTP id\n 98e67ed59e1d1-361403f15abmr22007260a91.11.1776832965189;\n        Tue, 21 Apr 2026 21:42:45 -0700 (PDT)","From":"rajasimandalos@gmail.com","To":"sfrench@samba.org,\n\tlinux-cifs@vger.kernel.org","Cc":"rajasimandalos@gmail.com,\n\tRajasi Mandal <rajasimandal@microsoft.com>","Subject":"[PATCH v2] smb: client: sync echo_interval on remount","Date":"Wed, 22 Apr 2026 04:42:30 +0000","Message-ID":"<20260422044230.1127071-1-rajasimandalos@gmail.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260409095926.905020-5-rajasimandalos@gmail.com>","References":"<20260409095926.905020-5-rajasimandalos@gmail.com>","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"<linux-cifs.vger.kernel.org>","List-Subscribe":"<mailto:linux-cifs+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-cifs+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"From: Rajasi Mandal <rajasimandal@microsoft.com>\n\necho_interval is accepted during remount parsing but\nserver->echo_interval is only set in cifs_get_tcp_session() at\nconnection setup. A remount with a new echo_interval value silently\nhas no effect on the echo keepalive timer.\n\nAdd echo_interval to smb3_sync_server_opts() under srv_lock so the\nnew interval is pushed to the live server struct. Reschedule the echo\ndelayed work via mod_delayed_work() so the new interval takes effect\nimmediately rather than after the current timer fires.\n\nSigned-off-by: Rajasi Mandal <rajasimandal@microsoft.com>\n---\n fs/smb/client/fs_context.c | 12 +++++++++---\n 1 file changed, 9 insertions(+), 3 deletions(-)","diff":"diff --git a/fs/smb/client/fs_context.c b/fs/smb/client/fs_context.c\nindex fd1060483bf2..45173f287f00 100644\n--- a/fs/smb/client/fs_context.c\n+++ b/fs/smb/client/fs_context.c\n@@ -1329,9 +1329,9 @@ static void smb3_sync_tcon_opts(struct cifs_sb_info *cifs_sb,\n \n /*\n  * Synchronize server-level options that are stored on TCP_Server_Info\n- * at mount time.  These fields are consulted at runtime (retry logic)\n- * so remount needs to update the live server struct in addition to\n- * cifs_sb->ctx.\n+ * at mount time.  These fields are consulted at runtime (echo work,\n+ * retry logic) so remount needs to update the live server struct in\n+ * addition to cifs_sb->ctx.\n  */\n static void smb3_sync_server_opts(struct cifs_sb_info *cifs_sb)\n {\n@@ -1341,7 +1341,13 @@ static void smb3_sync_server_opts(struct cifs_sb_info *cifs_sb)\n \tspin_lock(&server->srv_lock);\n \tif (ctx->retrans)\n \t\tserver->retrans = ctx->retrans;\n+\tif (ctx->echo_interval)\n+\t\tserver->echo_interval = ctx->echo_interval * HZ;\n \tspin_unlock(&server->srv_lock);\n+\n+\tif (ctx->echo_interval)\n+\t\tmod_delayed_work(cifsiod_wq, &server->echo,\n+\t\t\t\t server->echo_interval);\n }\n \n static int smb3_reconfigure(struct fs_context *fc)\n","prefixes":["v2"]}