{"id":2225849,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2225849/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260421163438.3447280-4-clg@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260421163438.3447280-4-clg@redhat.com>","date":"2026-04-21T16:34:27","name":"[PULL,03/14] hw/vfio/pci-quirks.c: remove CONFIG_VFIO_IGD","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"66a1a1309fe7b45f4ccfef6d72064da5d32ece88","submitter":{"id":85406,"url":"http://patchwork.ozlabs.org/api/1.1/people/85406/?format=json","name":"Cédric Le Goater","email":"clg@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260421163438.3447280-4-clg@redhat.com/mbox/","series":[{"id":500853,"url":"http://patchwork.ozlabs.org/api/1.1/series/500853/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500853","date":"2026-04-21T16:34:24","name":"[PULL,01/14] hw/vfio/listener.c: remove CONFIG_KVM","version":1,"mbox":"http://patchwork.ozlabs.org/series/500853/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2225849/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2225849/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Iwxo+whJ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0ShC4ycKz1yGs\n\tfor ; Wed, 22 Apr 2026 02:37:47 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFE55-0004xd-Oa; Tue, 21 Apr 2026 12:36:11 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wFE47-0004gr-FS\n for qemu-devel@nongnu.org; Tue, 21 Apr 2026 12:35:15 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wFE3t-0007NK-Mx\n for qemu-devel@nongnu.org; Tue, 21 Apr 2026 12:35:06 -0400","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-656-PIrh7glOMqiQvKw1fUIX0A-1; Tue,\n 21 Apr 2026 12:34:51 -0400","from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 0354C1800451; Tue, 21 Apr 2026 16:34:49 +0000 (UTC)","from corto.redhat.com (unknown [10.44.32.70])\n by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 2A52119560AB; Tue, 21 Apr 2026 16:34:46 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776789296;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=8xxmDsZWnKddXny8XJXbH9vxYlCbZpDY9wqE6WUzTjA=;\n b=Iwxo+whJWCRsQemcZW+fLtJBqn0fO7wpNHt9B2AkQ0tMsc8+YwllmtZ2bTLRlTfnBvPHcg\n VAuQ3Zp4w/3QsHWAspiV1W/Up+65hhTVNEFfahGkT2dPKlt7IknZDs/t55VhAE+jgYcvSt\n hfHx86hIPVn3PyWD7i4K4tS4eKPeXRQ=","X-MC-Unique":"PIrh7glOMqiQvKw1fUIX0A-1","X-Mimecast-MFC-AGG-ID":"PIrh7glOMqiQvKw1fUIX0A_1776789289","From":"=?utf-8?q?C=C3=A9dric_Le_Goater?= ","To":"qemu-devel@nongnu.org","Cc":"Alex Williamson ,\n Pierrick Bouvier , =?utf-8?q?C=C3=A9dric_Le_Go?=\n\t=?utf-8?q?ater?= ,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Subject":"[PULL 03/14] hw/vfio/pci-quirks.c: remove CONFIG_VFIO_IGD","Date":"Tue, 21 Apr 2026 18:34:27 +0200","Message-ID":"<20260421163438.3447280-4-clg@redhat.com>","In-Reply-To":"<20260421163438.3447280-1-clg@redhat.com>","References":"<20260421163438.3447280-1-clg@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.17","Received-SPF":"pass client-ip=170.10.133.124; envelope-from=clg@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Pierrick Bouvier \n\nAdd stubs for needed functions.\n\nvfio_pci_hot_reset_info must be forwarded declared on non linux platforms:\nIn file included from ../hw/vfio/igd-stubs.c:9:\n../hw/vfio/pci.h:265:44: error: 'struct vfio_pci_hot_reset_info' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]\n 265 | struct vfio_pci_hot_reset_info **info_p);\n |\n\nReviewed-by: Cédric Le Goater \nReviewed-by: Philippe Mathieu-Daudé \nSigned-off-by: Pierrick Bouvier \nTested-by: Cédric Le Goater \nTested-by: Philippe Mathieu-Daudé \nLink: https://lore.kernel.org/qemu-devel/20260318174733.1717643-4-pierrick.bouvier@linaro.org\nSigned-off-by: Cédric Le Goater \n---\n hw/vfio/pci.h | 2 ++\n hw/vfio/igd-stubs.c | 20 ++++++++++++++++++++\n hw/vfio/pci-quirks.c | 5 -----\n hw/vfio/meson.build | 1 +\n 4 files changed, 23 insertions(+), 5 deletions(-)\n create mode 100644 hw/vfio/igd-stubs.c","diff":"diff --git a/hw/vfio/pci.h b/hw/vfio/pci.h\nindex d6495d7f297513605db363dcdb3dd9b8dfb29a8d..c3a1f53d35004c914854c97d6e3608e4a20b121a 100644\n--- a/hw/vfio/pci.h\n+++ b/hw/vfio/pci.h\n@@ -258,6 +258,8 @@ bool vfio_probe_igd_config_quirk(VFIOPCIDevice *vdev, Error **errp);\n \n extern const PropertyInfo qdev_prop_nv_gpudirect_clique;\n \n+struct vfio_pci_hot_reset_info;\n+\n void vfio_pci_pre_reset(VFIOPCIDevice *vdev);\n void vfio_pci_post_reset(VFIOPCIDevice *vdev);\n bool vfio_pci_host_match(PCIHostDeviceAddress *addr, const char *name);\ndiff --git a/hw/vfio/igd-stubs.c b/hw/vfio/igd-stubs.c\nnew file mode 100644\nindex 0000000000000000000000000000000000000000..f7687d909125c2233e76f7e6d03aa90f38c3b89f\n--- /dev/null\n+++ b/hw/vfio/igd-stubs.c\n@@ -0,0 +1,20 @@\n+/*\n+ * IGD device quirks stubs\n+ *\n+ * SPDX-License-Identifier: GPL-2.0-or-later\n+ */\n+\n+#include \"qemu/osdep.h\"\n+#include \"qapi/qmp/qerror.h\"\n+#include \"pci.h\"\n+#include \"pci-quirks.h\"\n+\n+void vfio_probe_igd_bar0_quirk(VFIOPCIDevice *vdev, int nr)\n+{\n+ return;\n+}\n+\n+bool vfio_probe_igd_config_quirk(VFIOPCIDevice *vdev, Error **errp)\n+{\n+ return true;\n+}\ndiff --git a/hw/vfio/pci-quirks.c b/hw/vfio/pci-quirks.c\nindex 66e02b15a481aa810cca6fac465e64639673e970..bccf31751fd47387fd89110e27b695e5c822d5c4 100644\n--- a/hw/vfio/pci-quirks.c\n+++ b/hw/vfio/pci-quirks.c\n@@ -11,7 +11,6 @@\n */\n \n #include \"qemu/osdep.h\"\n-#include CONFIG_DEVICES\n #include \"exec/memop.h\"\n #include \"qemu/units.h\"\n #include \"qemu/log.h\"\n@@ -1128,11 +1127,9 @@ static void vfio_probe_rtl8168_bar2_quirk(VFIOPCIDevice *vdev, int nr)\n */\n bool vfio_config_quirk_setup(VFIOPCIDevice *vdev, Error **errp)\n {\n-#ifdef CONFIG_VFIO_IGD\n if (!vfio_probe_igd_config_quirk(vdev, errp)) {\n return false;\n }\n-#endif\n return true;\n }\n \n@@ -1179,9 +1176,7 @@ void vfio_bar_quirk_setup(VFIOPCIDevice *vdev, int nr)\n vfio_probe_nvidia_bar5_quirk(vdev, nr);\n vfio_probe_nvidia_bar0_quirk(vdev, nr);\n vfio_probe_rtl8168_bar2_quirk(vdev, nr);\n-#ifdef CONFIG_VFIO_IGD\n vfio_probe_igd_bar0_quirk(vdev, nr);\n-#endif\n }\n \n void vfio_bar_quirk_exit(VFIOPCIDevice *vdev, int nr)\ndiff --git a/hw/vfio/meson.build b/hw/vfio/meson.build\nindex f2a7728d3d00f70b6a6f6e3ea24749e6246b5c43..6c00a7f51bbe79d8e45d828a11d4deecf21512be 100644\n--- a/hw/vfio/meson.build\n+++ b/hw/vfio/meson.build\n@@ -17,6 +17,7 @@ vfio_ss.add(when: 'CONFIG_VFIO_PCI', if_true: files(\n vfio_ss.add(when: 'CONFIG_VFIO_CCW', if_true: files('ccw.c'))\n vfio_ss.add(when: 'CONFIG_VFIO_AP', if_true: files('ap.c'))\n vfio_ss.add(when: 'CONFIG_VFIO_IGD', if_true: files('igd.c'))\n+stub_ss.add(files('igd-stubs.c'))\n \n specific_ss.add_all(when: 'CONFIG_VFIO', if_true: vfio_ss)\n \n","prefixes":["PULL","03/14"]}