{"id":2225381,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2225381/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260420220215.111510-5-pablo@netfilter.org/","project":{"id":26,"url":"http://patchwork.ozlabs.org/api/1.1/projects/26/?format=json","name":"Netfilter Development","link_name":"netfilter-devel","list_id":"netfilter-devel.vger.kernel.org","list_email":"netfilter-devel@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260420220215.111510-5-pablo@netfilter.org>","date":"2026-04-20T22:02:11","name":"[net,4/8] netfilter: xtables: restrict several matches to inet family","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"4c40ae8f6e7e380e2d900c29646dc302962a00c8","submitter":{"id":1315,"url":"http://patchwork.ozlabs.org/api/1.1/people/1315/?format=json","name":"Pablo Neira Ayuso","email":"pablo@netfilter.org"},"delegate":{"id":11902,"url":"http://patchwork.ozlabs.org/api/1.1/users/11902/?format=json","username":"strlen","first_name":"Florian","last_name":"Westphal","email":"fw@strlen.de"},"mbox":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260420220215.111510-5-pablo@netfilter.org/mbox/","series":[{"id":500691,"url":"http://patchwork.ozlabs.org/api/1.1/series/500691/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=500691","date":"2026-04-20T22:02:07","name":"[net,1/8] netfilter: nft_osf: restrict it to ipv4","version":1,"mbox":"http://patchwork.ozlabs.org/series/500691/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2225381/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2225381/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=netfilter.org header.i=@netfilter.org\n header.a=rsa-sha256 header.s=2025 header.b=E7JJA15K;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-12098-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=netfilter.org header.i=@netfilter.org\n header.b=\"E7JJA15K\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=217.70.190.124","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=netfilter.org","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=netfilter.org"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzzzc3T4Rz1yD8\n\tfor ; Tue, 21 Apr 2026 08:04:28 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id DF84D3031AE1\n\tfor ; Mon, 20 Apr 2026 22:02:40 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 307523BE64B;\n\tMon, 20 Apr 2026 22:02:28 +0000 (UTC)","from mail.netfilter.org (mail.netfilter.org [217.70.190.124])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F0B03CFF7E;\n\tMon, 20 Apr 2026 22:02:26 +0000 (UTC)","from localhost.localdomain (mail-agni [217.70.190.124])\n\tby mail.netfilter.org (Postfix) with ESMTPSA id 431C260264;\n\tTue, 21 Apr 2026 00:02:24 +0200 (CEST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776722547; cv=none;\n b=f0pBw1OPZHMKv0jfSzAq/wnMPL12u+jWR+T+NM78WQp1UntZ4S9H0+UIWNF+ObgIiZA6s5msrtpmkmJYFG3JvAMhu0ZahCshzqX6Rwmke0D5tZUz/6c4/+inKZVDd7O/mtqqwcvrNgn3ux6CCpK9hL2fUH7aD/qMgyeYjqj9fMk=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776722547; c=relaxed/simple;\n\tbh=VA8UTo8Z83ZB4Myct45px9fMJ2rLv7syvIBNMVevznI=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=QiKEj4AaAjuGHtI8RQHRvrjUJp7SFujIt/C35xc5IBJ8K/98TiPMTkuCAtdDahjRME/xOFRFOHjCkPjj66mv0GCwe0KrIJPao0dAxfX7GaDJGOCsWqNvaGKORZO4eXY/GrUj54AI8S27hYgQZ6TYxjIrJRxKTqhuvxBIcsX7SVQ=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=netfilter.org;\n spf=pass smtp.mailfrom=netfilter.org;\n dkim=pass (2048-bit key) header.d=netfilter.org header.i=@netfilter.org\n header.b=E7JJA15K; arc=none smtp.client-ip=217.70.190.124","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=netfilter.org;\n\ts=2025; t=1776722544;\n\tbh=OiAU0N3unB6eDO1ijbrsbW503Mylsms6h7vYxlJm0G0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=E7JJA15K5xGkxVMI2ZR05ZqfVPeynGWN4rVexCi82JrSWH1SQXds2n3Gi0zJ2adlJ\n\t 3dI6AFwxaTrXmja1di2UfY1oQYWLWgfWYL9kn3FpjLwHkrFDMav/0wi/tMzZMRAMN6\n\t YWc0FaCf1OZdooj7kS3QQeouWOAv/s6LjJOJOSfRZ34r1IVfhw5fVhcmB4k0xrpdTK\n\t SzfwJ3tRZLTs3UYzpwvwDAebzRZ67uQDEbjmISwmlzaG0Tn8m/u34OFQxFgmCNkfA0\n\t cX+7rLGFJ7AaKS7+9TQkjtcQ932Vy9KpNqxNM7qPZkZEdVOpbeHO8sIm6EK2BdKXrm\n\t rgF02IK6zLqYw==","From":"Pablo Neira Ayuso ","To":"netfilter-devel@vger.kernel.org","Cc":"davem@davemloft.net,\n\tnetdev@vger.kernel.org,\n\tkuba@kernel.org,\n\tpabeni@redhat.com,\n\tedumazet@google.com,\n\tfw@strlen.de,\n\thorms@kernel.org","Subject":"[PATCH net 4/8] netfilter: xtables: restrict several matches to inet\n family","Date":"Tue, 21 Apr 2026 00:02:11 +0200","Message-ID":"<20260420220215.111510-5-pablo@netfilter.org>","X-Mailer":"git-send-email 2.47.3","In-Reply-To":"<20260420220215.111510-1-pablo@netfilter.org>","References":"<20260420220215.111510-1-pablo@netfilter.org>","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"This is a partial revert of:\n\n commit ab4f21e6fb1c (\"netfilter: xtables: use NFPROTO_UNSPEC in more extensions\")\n\nto allow ipv4 and ipv6 only.\n\n- xt_mac\n- xt_owner\n- xt_physdev\n\nThese extensions are not used by ebtables in userspace.\n\nMoreover, xt_realm is only for ipv4, since dst->tclassid is ipv4\nspecific.\n\nFixes: ab4f21e6fb1c (\"netfilter: xtables: use NFPROTO_UNSPEC in more extensions\")\nReported-by: \"Kito Xu (veritas501)\" \nSigned-off-by: Pablo Neira Ayuso \n---\n net/netfilter/xt_mac.c | 34 +++++++++++++++++++++++-----------\n net/netfilter/xt_owner.c | 37 +++++++++++++++++++++++++------------\n net/netfilter/xt_physdev.c | 29 +++++++++++++++++++----------\n net/netfilter/xt_realm.c | 2 +-\n 4 files changed, 68 insertions(+), 34 deletions(-)","diff":"diff --git a/net/netfilter/xt_mac.c b/net/netfilter/xt_mac.c\nindex 4798cd2ca26e..7fc5156825e4 100644\n--- a/net/netfilter/xt_mac.c\n+++ b/net/netfilter/xt_mac.c\n@@ -36,25 +36,37 @@ static bool mac_mt(const struct sk_buff *skb, struct xt_action_param *par)\n \treturn ret;\n }\n \n-static struct xt_match mac_mt_reg __read_mostly = {\n-\t.name = \"mac\",\n-\t.revision = 0,\n-\t.family = NFPROTO_UNSPEC,\n-\t.match = mac_mt,\n-\t.matchsize = sizeof(struct xt_mac_info),\n-\t.hooks = (1 << NF_INET_PRE_ROUTING) | (1 << NF_INET_LOCAL_IN) |\n-\t (1 << NF_INET_FORWARD),\n-\t.me = THIS_MODULE,\n+static struct xt_match mac_mt_reg[] __read_mostly = {\n+\t{\n+\t\t.name\t\t= \"mac\",\n+\t\t.family\t\t= NFPROTO_IPV4,\n+\t\t.match\t\t= mac_mt,\n+\t\t.matchsize\t= sizeof(struct xt_mac_info),\n+\t\t.hooks\t\t= (1 << NF_INET_PRE_ROUTING) |\n+\t\t\t\t (1 << NF_INET_LOCAL_IN) |\n+\t\t\t\t (1 << NF_INET_FORWARD),\n+\t\t.me\t\t= THIS_MODULE,\n+\t},\n+\t{\n+\t\t.name\t\t= \"mac\",\n+\t\t.family\t\t= NFPROTO_IPV6,\n+\t\t.match\t\t= mac_mt,\n+\t\t.matchsize\t= sizeof(struct xt_mac_info),\n+\t\t.hooks\t\t= (1 << NF_INET_PRE_ROUTING) |\n+\t\t\t\t (1 << NF_INET_LOCAL_IN) |\n+\t\t\t\t (1 << NF_INET_FORWARD),\n+\t\t.me\t\t= THIS_MODULE,\n+\t},\n };\n \n static int __init mac_mt_init(void)\n {\n-\treturn xt_register_match(&mac_mt_reg);\n+\treturn xt_register_matches(mac_mt_reg, ARRAY_SIZE(mac_mt_reg));\n }\n \n static void __exit mac_mt_exit(void)\n {\n-\txt_unregister_match(&mac_mt_reg);\n+\txt_unregister_matches(mac_mt_reg, ARRAY_SIZE(mac_mt_reg));\n }\n \n module_init(mac_mt_init);\ndiff --git a/net/netfilter/xt_owner.c b/net/netfilter/xt_owner.c\nindex 5bfb4843df66..8f2e57b2a586 100644\n--- a/net/netfilter/xt_owner.c\n+++ b/net/netfilter/xt_owner.c\n@@ -127,26 +127,39 @@ owner_mt(const struct sk_buff *skb, struct xt_action_param *par)\n \treturn true;\n }\n \n-static struct xt_match owner_mt_reg __read_mostly = {\n-\t.name = \"owner\",\n-\t.revision = 1,\n-\t.family = NFPROTO_UNSPEC,\n-\t.checkentry = owner_check,\n-\t.match = owner_mt,\n-\t.matchsize = sizeof(struct xt_owner_match_info),\n-\t.hooks = (1 << NF_INET_LOCAL_OUT) |\n-\t (1 << NF_INET_POST_ROUTING),\n-\t.me = THIS_MODULE,\n+static struct xt_match owner_mt_reg[] __read_mostly = {\n+\t{\n+\t\t.name = \"owner\",\n+\t\t.revision = 1,\n+\t\t.family = NFPROTO_IPV4,\n+\t\t.checkentry = owner_check,\n+\t\t.match = owner_mt,\n+\t\t.matchsize = sizeof(struct xt_owner_match_info),\n+\t\t.hooks = (1 << NF_INET_LOCAL_OUT) |\n+\t\t\t (1 << NF_INET_POST_ROUTING),\n+\t\t.me = THIS_MODULE,\n+\t},\n+\t{\n+\t\t.name = \"owner\",\n+\t\t.revision = 1,\n+\t\t.family = NFPROTO_IPV6,\n+\t\t.checkentry = owner_check,\n+\t\t.match = owner_mt,\n+\t\t.matchsize = sizeof(struct xt_owner_match_info),\n+\t\t.hooks = (1 << NF_INET_LOCAL_OUT) |\n+\t\t\t (1 << NF_INET_POST_ROUTING),\n+\t\t.me = THIS_MODULE,\n+\t}\n };\n \n static int __init owner_mt_init(void)\n {\n-\treturn xt_register_match(&owner_mt_reg);\n+\treturn xt_register_matches(owner_mt_reg, ARRAY_SIZE(owner_mt_reg));\n }\n \n static void __exit owner_mt_exit(void)\n {\n-\txt_unregister_match(&owner_mt_reg);\n+\txt_unregister_matches(owner_mt_reg, ARRAY_SIZE(owner_mt_reg));\n }\n \n module_init(owner_mt_init);\ndiff --git a/net/netfilter/xt_physdev.c b/net/netfilter/xt_physdev.c\nindex 53997771013f..d2b0b52434fa 100644\n--- a/net/netfilter/xt_physdev.c\n+++ b/net/netfilter/xt_physdev.c\n@@ -137,24 +137,33 @@ static int physdev_mt_check(const struct xt_mtchk_param *par)\n \treturn 0;\n }\n \n-static struct xt_match physdev_mt_reg __read_mostly = {\n-\t.name = \"physdev\",\n-\t.revision = 0,\n-\t.family = NFPROTO_UNSPEC,\n-\t.checkentry = physdev_mt_check,\n-\t.match = physdev_mt,\n-\t.matchsize = sizeof(struct xt_physdev_info),\n-\t.me = THIS_MODULE,\n+static struct xt_match physdev_mt_reg[] __read_mostly = {\n+\t{\n+\t\t.name\t\t= \"physdev\",\n+\t\t.family\t\t= NFPROTO_IPV4,\n+\t\t.checkentry\t= physdev_mt_check,\n+\t\t.match\t\t= physdev_mt,\n+\t\t.matchsize\t= sizeof(struct xt_physdev_info),\n+\t\t.me\t\t= THIS_MODULE,\n+\t},\n+\t{\n+\t\t.name\t\t= \"physdev\",\n+\t\t.family\t\t= NFPROTO_IPV6,\n+\t\t.checkentry\t= physdev_mt_check,\n+\t\t.match\t\t= physdev_mt,\n+\t\t.matchsize\t= sizeof(struct xt_physdev_info),\n+\t\t.me\t\t= THIS_MODULE,\n+\t},\n };\n \n static int __init physdev_mt_init(void)\n {\n-\treturn xt_register_match(&physdev_mt_reg);\n+\treturn xt_register_matches(physdev_mt_reg, ARRAY_SIZE(physdev_mt_reg));\n }\n \n static void __exit physdev_mt_exit(void)\n {\n-\txt_unregister_match(&physdev_mt_reg);\n+\txt_unregister_matches(physdev_mt_reg, ARRAY_SIZE(physdev_mt_reg));\n }\n \n module_init(physdev_mt_init);\ndiff --git a/net/netfilter/xt_realm.c b/net/netfilter/xt_realm.c\nindex 6df485f4403d..61b2f1e58d15 100644\n--- a/net/netfilter/xt_realm.c\n+++ b/net/netfilter/xt_realm.c\n@@ -33,7 +33,7 @@ static struct xt_match realm_mt_reg __read_mostly = {\n \t.matchsize\t= sizeof(struct xt_realm_info),\n \t.hooks\t\t= (1 << NF_INET_POST_ROUTING) | (1 << NF_INET_FORWARD) |\n \t\t\t (1 << NF_INET_LOCAL_OUT) | (1 << NF_INET_LOCAL_IN),\n-\t.family\t\t= NFPROTO_UNSPEC,\n+\t.family\t\t= NFPROTO_IPV4,\n \t.me\t\t= THIS_MODULE\n };\n \n","prefixes":["net","4/8"]}