{"id":2225380,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2225380/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260420220215.111510-7-pablo@netfilter.org/","project":{"id":26,"url":"http://patchwork.ozlabs.org/api/1.1/projects/26/?format=json","name":"Netfilter Development","link_name":"netfilter-devel","list_id":"netfilter-devel.vger.kernel.org","list_email":"netfilter-devel@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260420220215.111510-7-pablo@netfilter.org>","date":"2026-04-20T22:02:13","name":"[net,6/8] ipvs: fix MTU check for GSO packets in tunnel mode","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"c82809ed53d9933502506ec6d601874ebab2232b","submitter":{"id":1315,"url":"http://patchwork.ozlabs.org/api/1.1/people/1315/?format=json","name":"Pablo Neira Ayuso","email":"pablo@netfilter.org"},"delegate":{"id":11902,"url":"http://patchwork.ozlabs.org/api/1.1/users/11902/?format=json","username":"strlen","first_name":"Florian","last_name":"Westphal","email":"fw@strlen.de"},"mbox":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260420220215.111510-7-pablo@netfilter.org/mbox/","series":[{"id":500691,"url":"http://patchwork.ozlabs.org/api/1.1/series/500691/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=500691","date":"2026-04-20T22:02:07","name":"[net,1/8] netfilter: nft_osf: restrict it to ipv4","version":1,"mbox":"http://patchwork.ozlabs.org/series/500691/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2225380/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2225380/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=netfilter.org header.i=@netfilter.org\n header.a=rsa-sha256 header.s=2025 header.b=N4kMW9p7;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=104.64.211.4; helo=sin.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-12100-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=netfilter.org header.i=@netfilter.org\n header.b=\"N4kMW9p7\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=217.70.190.124","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=netfilter.org","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=netfilter.org"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org [104.64.211.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzzzN2pm4z1yD8\n\tfor ; Tue, 21 Apr 2026 08:04:16 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 924EE300FEE8\n\tfor ; Mon, 20 Apr 2026 22:02:51 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 693F83CEBB0;\n\tMon, 20 Apr 2026 22:02:31 +0000 (UTC)","from mail.netfilter.org (mail.netfilter.org [217.70.190.124])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 263263CFF7E;\n\tMon, 20 Apr 2026 22:02:28 +0000 (UTC)","from localhost.localdomain (mail-agni [217.70.190.124])\n\tby mail.netfilter.org (Postfix) with ESMTPSA id CCE1160254;\n\tTue, 21 Apr 2026 00:02:26 +0200 (CEST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776722551; cv=none;\n b=RGRFmyqW2KnkGNsAhhzdpIWRKiQfjW+TPN5IoUkl7l/0fgvL+hM02tnd4LOBLrjfL8AyPeS0WLVL+A2kvZPMB6HEjc0jJOw7ruNQb1aRgiPH3kb2XW9nI9IbcaAPfKSWDunB9T+ivssgozSlSq1HBmyT9b0REidhJsqJxYqZlmg=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776722551; c=relaxed/simple;\n\tbh=bRd1OG7/KX+gV/NdXpPmMl5SEd/vnaV1ZXVy2vHHi6c=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=M/L36OsghZ5i/W1hNiK5XtGOODjnbmA0WJE8AfH6IZJ8S8F9TSPZ4e4zAmEgeDIQmpV6OWOQ4eTm/JxqsQiyUp5BZ+36aG7t0viNzX8Mpn4rghqWyR7jPwPryHXnqFfWvaQnFO3rl7mSGYB5lh8sbs7ne3tGtmiee7Rp0a5za14=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=netfilter.org;\n spf=pass smtp.mailfrom=netfilter.org;\n dkim=pass (2048-bit key) header.d=netfilter.org header.i=@netfilter.org\n header.b=N4kMW9p7; arc=none smtp.client-ip=217.70.190.124","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=netfilter.org;\n\ts=2025; t=1776722547;\n\tbh=BJX/SLww+rCdphfr96qXMjyaF+QihHqxlvaAKWHk998=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=N4kMW9p78wUnQ+/zOdxLCFRRFf3T3zpXYyEpdYNT6vw6TSVo1+z3MYp4/uGNeZ6Me\n\t yHQTftr9ppss+73M8VbSbavOijr9n2zZzLiGoiEnQOHGecCvU7CujmTbFp74A2p0DN\n\t v2t63eYeyYJzMGWB2TB7Mrkd7dUzb78px1/DlMhIcIPieT1xW2PcllTf+OG0BcA4/2\n\t JkOi46wFDKIPx8s//Xq1GdnrvyYtY5uDieFBISDRMJD2CUF8t1W4SulmzWHt67CoCx\n\t WNoqFszjPo2jwIZyiKZq2HGGp1N7aClY98RfZzIXSsXKDGOMNlgaYcMl6z6NWr9SR+\n\t 3jrtMjkcnKgEA==","From":"Pablo Neira Ayuso ","To":"netfilter-devel@vger.kernel.org","Cc":"davem@davemloft.net,\n\tnetdev@vger.kernel.org,\n\tkuba@kernel.org,\n\tpabeni@redhat.com,\n\tedumazet@google.com,\n\tfw@strlen.de,\n\thorms@kernel.org","Subject":"[PATCH net 6/8] ipvs: fix MTU check for GSO packets in tunnel mode","Date":"Tue, 21 Apr 2026 00:02:13 +0200","Message-ID":"<20260420220215.111510-7-pablo@netfilter.org>","X-Mailer":"git-send-email 2.47.3","In-Reply-To":"<20260420220215.111510-1-pablo@netfilter.org>","References":"<20260420220215.111510-1-pablo@netfilter.org>","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"From: Yingnan Zhang <342144303@qq.com>\n\nCurrently, IPVS skips MTU checks for GSO packets by excluding them with\nthe !skb_is_gso(skb) condition. This creates problems when IPVS tunnel\nmode encapsulates GSO packets with IPIP headers.\n\nThe issue manifests in two ways:\n\n1. MTU violation after encapsulation:\n When a GSO packet passes through IPVS tunnel mode, the original MTU\n check is bypassed. After adding the IPIP tunnel header, the packet\n size may exceed the outgoing interface MTU, leading to unexpected\n fragmentation at the IP layer.\n\n2. Fragmentation with problematic IP IDs:\n When net.ipv4.vs.pmtu_disc=1 and a GSO packet with multiple segments\n is fragmented after encapsulation, each segment gets a sequentially\n incremented IP ID (0, 1, 2, ...). This happens because:\n\n a) The GSO packet bypasses MTU check and gets encapsulated\n b) At __ip_finish_output, the oversized GSO packet is split into\n separate SKBs (one per segment), with IP IDs incrementing\n c) Each SKB is then fragmented again based on the actual MTU\n\n This sequential IP ID allocation differs from the expected behavior\n and can cause issues with fragment reassembly and packet tracking.\n\nFix this by properly validating GSO packets using\nskb_gso_validate_network_len(). This function correctly validates\nwhether the GSO segments will fit within the MTU after segmentation. If\nvalidation fails, send an ICMP Fragmentation Needed message to enable\nproper PMTU discovery.\n\nFixes: 4cdd34084d53 (\"netfilter: nf_conntrack_ipv6: improve fragmentation handling\")\nSigned-off-by: Yingnan Zhang <342144303@qq.com>\nAcked-by: Julian Anastasov \nSigned-off-by: Pablo Neira Ayuso \n---\n net/netfilter/ipvs/ip_vs_xmit.c | 19 +++++++++++++++----\n 1 file changed, 15 insertions(+), 4 deletions(-)","diff":"diff --git a/net/netfilter/ipvs/ip_vs_xmit.c b/net/netfilter/ipvs/ip_vs_xmit.c\nindex 0fb5162992e5..ce542ed4b013 100644\n--- a/net/netfilter/ipvs/ip_vs_xmit.c\n+++ b/net/netfilter/ipvs/ip_vs_xmit.c\n@@ -102,6 +102,18 @@ __ip_vs_dst_check(struct ip_vs_dest *dest)\n \treturn dest_dst;\n }\n \n+/* Based on ip_exceeds_mtu(). */\n+static bool ip_vs_exceeds_mtu(const struct sk_buff *skb, unsigned int mtu)\n+{\n+\tif (skb->len <= mtu)\n+\t\treturn false;\n+\n+\tif (skb_is_gso(skb) && skb_gso_validate_network_len(skb, mtu))\n+\t\treturn false;\n+\n+\treturn true;\n+}\n+\n static inline bool\n __mtu_check_toobig_v6(const struct sk_buff *skb, u32 mtu)\n {\n@@ -111,10 +123,9 @@ __mtu_check_toobig_v6(const struct sk_buff *skb, u32 mtu)\n \t\t */\n \t\tif (IP6CB(skb)->frag_max_size > mtu)\n \t\t\treturn true; /* largest fragment violate MTU */\n-\t}\n-\telse if (skb->len > mtu && !skb_is_gso(skb)) {\n+\t} else if (ip_vs_exceeds_mtu(skb, mtu))\n \t\treturn true; /* Packet size violate MTU size */\n-\t}\n+\n \treturn false;\n }\n \n@@ -232,7 +243,7 @@ static inline bool ensure_mtu_is_adequate(struct netns_ipvs *ipvs, int skb_af,\n \t\t\treturn true;\n \n \t\tif (unlikely(ip_hdr(skb)->frag_off & htons(IP_DF) &&\n-\t\t\t skb->len > mtu && !skb_is_gso(skb) &&\n+\t\t\t ip_vs_exceeds_mtu(skb, mtu) &&\n \t\t\t !ip_vs_iph_icmp(ipvsh))) {\n \t\t\ticmp_send(skb, ICMP_DEST_UNREACH, ICMP_FRAG_NEEDED,\n \t\t\t\t htonl(mtu));\n","prefixes":["net","6/8"]}