{"id":2225333,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2225333/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20260420163551.515651-1-sigmaepsilon92@gmail.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.1/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260420163551.515651-1-sigmaepsilon92@gmail.com>","date":"2026-04-20T16:35:31","name":"fs/squashfs: Set ret to 0 on successful read","commit_ref":"30885b01aaa4bcdfa3fee9ca3066d3af563e6688","pull_url":null,"state":"accepted","archived":false,"hash":"5af1266fc31629a33fc147da295c898975695711","submitter":{"id":69179,"url":"http://patchwork.ozlabs.org/api/1.1/people/69179/?format=json","name":"Michael Zimmermann","email":"sigmaepsilon92@gmail.com"},"delegate":{"id":3651,"url":"http://patchwork.ozlabs.org/api/1.1/users/3651/?format=json","username":"trini","first_name":"Tom","last_name":"Rini","email":"trini@ti.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20260420163551.515651-1-sigmaepsilon92@gmail.com/mbox/","series":[{"id":500679,"url":"http://patchwork.ozlabs.org/api/1.1/series/500679/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=500679","date":"2026-04-20T16:35:31","name":"fs/squashfs: Set ret to 0 on successful read","version":1,"mbox":"http://patchwork.ozlabs.org/series/500679/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2225333/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2225333/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=qdiUERWY;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.b=\"qdiUERWY\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=sigmaepsilon92@gmail.com"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzxzs6Hvsz1yD4\n\tfor ; Tue, 21 Apr 2026 06:34:33 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id E83C18446D;\n\tMon, 20 Apr 2026 22:33:55 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 1525584308; Mon, 20 Apr 2026 18:36:14 +0200 (CEST)","from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com\n [IPv6:2a00:1450:4864:20::32f])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id B080D84315\n for ; Mon, 20 Apr 2026 18:36:11 +0200 (CEST)","by mail-wm1-x32f.google.com with SMTP id\n 5b1f17b1804b1-488d2079582so38465105e9.2\n for ; Mon, 20 Apr 2026 09:36:11 -0700 (PDT)","from toolbox ([2a00:1e:8743:eb00:edd1:4809:dfe2:efaf])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488fc140c82sm273834445e9.12.2026.04.20.09.36.09\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 20 Apr 2026 09:36:10 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_GMAIL_RCVD,\n FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776702971; x=1777307771; darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=rg76lOxP+GG8Fy5/znfBXqhxRJJ32H4CX3GdFulytlA=;\n b=qdiUERWY+DpKVJ7ViJj7j+DS+bytfTrfCp7U0b5C6/r0nkfaL/FVpqEEU6NUgpTfuj\n eGfx51+5YDFYmaZXt3m/O665JU9TBhngDVxSlGvwql4v4iTKivaeW8mziERcMwYDhH5z\n TbotlZRX8+SKQqutswGai/5+TxH6ZwiioR6Fmr7B3m26fj/oXhU6SUu3rNu0F+zm+/hH\n Uh7+oyCcBvQ8WG0UVByqbUCYxGauetyjpBpjTMGxEENXozSFGhAMvIJWSY5IiGKmHc0D\n NGNX7+GljQUC4fztcDgYiiQ0oGDwzHXVLC8WZ/NRxifJAYjz/Yws5OaIk/y5m649YrCL\n lvJA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776702971; x=1777307771;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=rg76lOxP+GG8Fy5/znfBXqhxRJJ32H4CX3GdFulytlA=;\n b=Rb38DNb6rqdTZ4T2EQT2ngeQ4bDYrvtm8SegB6EjFwsn2SxDIM46CfcQJlZbTgnhDg\n kmI13boHlhIdZMe/KdwbA9P2RAf1/64rj5oDFLbebQixcXueyUTdAItsXwIVyce1jqQA\n BENi964rO7JtRID32xnaFiZqiRNxE7s9J186t3NlI48oBO0B2P75lxqgyN++CrHkHOje\n ZOpXiA8sA8i4y6uQjFmtcP6VldU6ymT3EPKFu3vDQIT+IsVkaESNNCZBdp6WVbn5fV8N\n g/xeXeSZyXob/Dow26v/hoartPqVf3m3tu8ZF/J/I0X2OXdNyI9B4I9otgXQoasIYwvF\n 4egA==","X-Gm-Message-State":"AOJu0YxgZILuvUk1EU0AhAv8LwXy5bycdUR+k0Yp/75AGT1Ny3wRMY61\n +SaTRrBLl5oNVnl87I1X1p1nbatTe8Tp4h8QDuKejsp7EA5XHQksn3MYKJxe0K+D","X-Gm-Gg":"AeBDietP9PLcgkeeGfGdru2ZwXHEDwZScDVVL2NYIkqw09RFGtL9ugnftSsaqVeLblW\n oEkA3xvR0+N6JLj5vMpUjxICMon7AfPdfnGLlzzcXMMzbN8GpB/dTo6eAdIBDGRQdjTc4VGzGFE\n H7zxxwOS3GZl76Zw+u5KMAbM2E7jVNhQ2AfzYieJ6yi8AUt8A00dI44CasgHdLtPN02VWITlE6h\n PBELSrmFkcGB/6Bj8fv0gVHwxRhpY07P67V4TI+vDIM/csqbgBLJKXx1H5ILekMutTQKyO9IfeO\n +Y6lUVAgorhObJVxByWuFOJLGDMPfm8P/yvNcQZLnyTPPR3ua/uL+u5/nEKbIHsAoweFhyyMxB2\n 4pL8ChEVHoIchNXS6bEK1ZWeWLragkN41lNPra7xZ6cDwhSN6kOYVqNFouNwQKf+UI+v49Y+3Uu\n x+nhHBddIS4/W56eumFBgOT5OooXMu/4L5/38FHnMrXXY7kSxGw3OxLcHLrxBpoCVQhkXzekHD3\n TBm/jKwNwWakPLelYedkhyKNA==","X-Received":"by 2002:a05:600c:8883:b0:488:def6:bb17 with SMTP id\n 5b1f17b1804b1-488fb73a9admr159671265e9.4.1776702970644;\n Mon, 20 Apr 2026 09:36:10 -0700 (PDT)","From":"Michael Zimmermann ","To":"u-boot@lists.denx.de","Cc":"Michael Zimmermann ,\n Andrew Goodbody ,\n Eric Kilmer ,\n Heinrich Schuchardt ,\n Joao Marcos Costa ,\n Miquel Raynal ,\n Quentin Schulz ,\n Richard Genoud ,\n Simon Glass ,\n Thomas Petazzoni , =?utf-8?q?Timo_tp_Prei?=\n\t=?utf-8?q?=C3=9Fl?= , Tom Rini ","Subject":"[PATCH] fs/squashfs: Set ret to 0 on successful read","Date":"Mon, 20 Apr 2026 18:35:31 +0200","Message-ID":"<20260420163551.515651-1-sigmaepsilon92@gmail.com>","X-Mailer":"git-send-email 2.53.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Mailman-Approved-At":"Mon, 20 Apr 2026 22:33:40 +0200","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"It might still be a positive number due to the call to sqfs_disk_read.\nThis only happens when reading a file from an uncompressed squashfs.\n\nI found this by trying to boot using the extlinux bootmethod, where\npositive values are treated as errors.\n\nSigned-off-by: Michael Zimmermann \n---\n\n fs/squashfs/sqfs.c | 2 ++\n 1 file changed, 2 insertions(+)","diff":"diff --git a/fs/squashfs/sqfs.c b/fs/squashfs/sqfs.c\nindex 543db8c7e9e..0768fc4a7b2 100644\n--- a/fs/squashfs/sqfs.c\n+++ b/fs/squashfs/sqfs.c\n@@ -1636,6 +1636,8 @@ static int sqfs_read_nest(const char *filename, void *buf, loff_t offset,\n \t\t*actread = finfo.size;\n \t}\n \n+\tret = 0;\n+\n out:\n \tfree(fragment);\n \tfree(datablock);\n","prefixes":[]}