{"id":2225229,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2225229/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20260420164725.359539-1-heinrich.schuchardt@canonical.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.1/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260420164725.359539-1-heinrich.schuchardt@canonical.com>","date":"2026-04-20T16:47:25","name":"[1/1] acpi: fix initial RSDT and XSDT size","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"f4a082fbae95a926ef8f96271dbea20f8435b8ce","submitter":{"id":82181,"url":"http://patchwork.ozlabs.org/api/1.1/people/82181/?format=json","name":"Heinrich Schuchardt","email":"heinrich.schuchardt@canonical.com"},"delegate":{"id":3184,"url":"http://patchwork.ozlabs.org/api/1.1/users/3184/?format=json","username":"sjg","first_name":"Simon","last_name":"Glass","email":"sjg@chromium.org"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20260420164725.359539-1-heinrich.schuchardt@canonical.com/mbox/","series":[{"id":500639,"url":"http://patchwork.ozlabs.org/api/1.1/series/500639/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=500639","date":"2026-04-20T16:47:25","name":"[1/1] acpi: fix initial RSDT and XSDT size","version":1,"mbox":"http://patchwork.ozlabs.org/series/500639/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2225229/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2225229/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (4096-bit key;\n unprotected) header.d=canonical.com header.i=@canonical.com\n header.a=rsa-sha256 header.s=20251003 header.b=McM4g9jX;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=canonical.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (4096-bit key;\n unprotected) header.d=canonical.com header.i=@canonical.com\n header.b=\"McM4g9jX\";\n\tdkim-atps=neutral","phobos.denx.de; dmarc=pass (p=reject dis=none)\n header.from=canonical.com","phobos.denx.de; spf=pass\n smtp.mailfrom=heinrich.schuchardt@canonical.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzry66W5rz1yCv\n\tfor ; Tue, 21 Apr 2026 02:47:42 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id CF260842A4;\n\tMon, 20 Apr 2026 18:47:35 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 9AF71842E1; Mon, 20 Apr 2026 18:47:34 +0200 (CEST)","from smtp-relay-internal-1.canonical.com\n (smtp-relay-internal-1.canonical.com [185.125.188.123])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 92ABB84258\n for ; Mon, 20 Apr 2026 18:47:32 +0200 (CEST)","from mail-wm1-f69.google.com (mail-wm1-f69.google.com\n [209.85.128.69])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 3079E3F617\n for ; Mon, 20 Apr 2026 16:47:32 +0000 (UTC)","by mail-wm1-f69.google.com with SMTP id\n 5b1f17b1804b1-488d9e1e61aso27885125e9.0\n for ; Mon, 20 Apr 2026 09:47:32 -0700 (PDT)","from workstation5.fritz.box\n (ip-176-199-115-125.um44.pools.vodafone-ip.de. [176.199.115.125])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488fc177dafsm368177525e9.4.2026.04.20.09.47.29\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 20 Apr 2026 09:47:30 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com;\n s=20251003; t=1776703652;\n bh=BxUjOYscHpwTA5f0txuEEqhlLOW8gCE0axz+dJyAeME=;\n h=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=McM4g9jXFrGFgxDYlgIqOWgyxMeEndstJjORv5zAUMB2EGtXu/fHgHZjEsDsMqwgE\n j5tyQZ2i8gvFHBPaxLpCBfqWh3FvtX7irFIgmmL13/ZhQz8nRS1H4bU2YoY+CmKJBT\n YfaT3b6Gjfk4mAPusEZ9RH3kf5EzrLYPtGB7i716HgwdohdEWPIaEd4v8oa6+mWAwG\n QQBPwQWKTxcmCP3LIwJUDfbXtrOudIV/UxFcntqyJ8k72+kHAPf6Sjp5VyQGz+6aVE\n jUY2TQBIdVJinlghlOHuzJpSUYFNOZ4HRgLWkgN1yB68yAGp6V2LR2JB/5tyyRsho9\n 5wxvyIn6LV9XxAzTKf4H4tSMlEdiLxXL/Tg8l+sif0Qx0SqJ3ErhM4q81M6DBPmqKd\n M2EqDqWhNSNuNAffEGlpBMn6E/YwFS2N77Ry7q2DwlZlBdPZYZ3atzY4fIsM/I4uSM\n WZmQVSMqXjq4BKkNNgD2fF8M49Mzo7CME7G3mzT69u9+TqAhkyRtCA1O4dvvY17SQc\n OL8frcPkX+MQ9ZFwiPum5+/TEhXzy7iHKlW5g+7pSh3ASdAz1JwxyoBdC8bL8nwuuH\n mxeBP++3D4kdrMVoMcjU7M6OcH/qVbdumQEJ2nBD6oTpJj3z0SV2dcMdIGPD4iNJzd\n QP3VOEAHgYhVeH7EcGBn/b64=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776703651; x=1777308451;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=BxUjOYscHpwTA5f0txuEEqhlLOW8gCE0axz+dJyAeME=;\n b=ih9cYA717CeRckjTSSv2cFnnx53bb+EjZBOOImFEOmhLQgAUQo3p6peOfA+u8+GFsr\n HciDDzQSZdM0dGp/KUVK+KBGr0cwrlWa6+IFJbuwlgYxxgus0UPzo53xmWupI8OBwrGu\n J2tQ9alDcaKWaqwPKiWzEL3yGUvBufz5l8XbNAyeguazKKLr7Q5wMhHpHG/AfGGM4c2C\n oEbnnFIICABrOZByRL8Rliw2ej1PK/XVpW4kHLOeAWP7e0IN5X1CVkF5RPkhw16fzohX\n PYs+bcoQ1neTpkQKoLO1fueSdJf99pYMD9upIdV0swV/vZx4CIJt5KUlJSFv3p8TN4Ev\n nZUQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/pwmJHr+l1dzWfzZF+v6OsrkUYZbPf10Wvx6zabkac5K8kyLj3mY+mEGe2XsMgTyfd1rHDQ1U=@lists.denx.de","X-Gm-Message-State":"AOJu0Yy8CLzADkaq/OROFyHcy5dQy5iCAMnseHrUTw2d95v/pJjLEUhn\n +zc9jcwlh+3zyDALr4400xuGoxl+sOcHUnimPclrgaeBJFbLmUQ9TQxlxvRphAWHMPAa5NUbfrC\n HhOomDaqPNs4B/JrX+IMIg07Jdr9zxj842F/tX/cW2wo8hx1MhkXrb+uW4qYloupAf5q83LQ=","X-Gm-Gg":"AeBDieuV1GcwJyBftI3VniU+t1VvJoc8Fhrvxj22pLOET9TaBtjelXuhJmODCVpnpLq\n paIsz44I9/ZuWxs2eg9ayDb5WurqFkUcd6MAHP8AwoiEw2k1bKhGuft11OfKbhZQibML1KYN1/6\n koMnOTI+ao51ZTM1q5hRRQDGkhy7N2bSLcXPhlTZNC1RmyyLW+BTXCkPGXWurmGwwTSit0eZ8n4\n Iyx721dpqsDAVxMChkAoZKfTWYQckJkQY2IrSER+IV0XRdiEiw9A/RaLzb7oO99WBYRiKCh82iN\n DlteRCkyeVl4yUW/VoB0YCeW/AaZXcDuSz/rAzVKVGp7Y2x6mgw+0+e/Oc/y9SXLaj/MrTGcK4P\n +v5nB5VbC7nd/dXLqHDc09urV0VSxUFZ7n4kbseyI7GVB6mTEaJp9xVbqVXc4pn3oxMBN0YTkqv\n +nlr7M5aWD6lSZ+NM+gskX2QVbJwlK5lOhZXH0iRyDImiVofz4xt6ZgwcSEEkiKn18wJ8BCWsc+\n g==","X-Received":["by 2002:a05:600c:a416:b0:488:af48:af11 with SMTP id\n 5b1f17b1804b1-488fb73a9b8mr166422705e9.1.1776703651206;\n Mon, 20 Apr 2026 09:47:31 -0700 (PDT)","by 2002:a05:600c:a416:b0:488:af48:af11 with SMTP id\n 5b1f17b1804b1-488fb73a9b8mr166422375e9.1.1776703650775;\n Mon, 20 Apr 2026 09:47:30 -0700 (PDT)"],"From":"Heinrich Schuchardt ","To":"Simon Glass ","Cc":"Tom Rini , Bin Meng ,\n Stefan Roese , Saket Sinha ,\n u-boot@lists.denx.de,\n Heinrich Schuchardt ","Subject":"[PATCH 1/1] acpi: fix initial RSDT and XSDT size","Date":"Mon, 20 Apr 2026 18:47:25 +0200","Message-ID":"<20260420164725.359539-1-heinrich.schuchardt@canonical.com>","X-Mailer":"git-send-email 2.53.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"When creating the RSDT and the XSDT table they contain no entries.\nThe table size therefore must equal the header size.\n\nWithout this change a NULL deference has been observed in\nacpi_find_table() when running `ut dm` on sandbox64_defconfig\nexecuted via `sudo ./u-boot -D`.\n\nFixes: 94ba15a3f13f (\"x86: Move base tables to a writer function\")\nFixes: 7e586f69070d (\"acpi: Put table-setup code in its own function\")\nFixes: ab5efd576c4e (\"x86: acpi: Adjust order in acpi_table.c\")\nFixes: 867bcb63e79f (\"x86: Generate a valid ACPI table\")\nSigned-off-by: Heinrich Schuchardt \n---\n lib/acpi/base.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/lib/acpi/base.c b/lib/acpi/base.c\nindex 5c755b14c16..01ebad8994a 100644\n--- a/lib/acpi/base.c\n+++ b/lib/acpi/base.c\n@@ -44,7 +44,7 @@ static void acpi_write_rsdt(struct acpi_rsdt *rsdt)\n \n \t/* Fill out header fields */\n \tacpi_fill_header(header, \"RSDT\");\n-\theader->length = sizeof(struct acpi_rsdt);\n+\theader->length = sizeof(struct acpi_table_header);\n \theader->revision = 1;\n \n \t/* Entries are filled in later, we come with an empty set */\n@@ -59,7 +59,7 @@ static void acpi_write_xsdt(struct acpi_xsdt *xsdt)\n \n \t/* Fill out header fields */\n \tacpi_fill_header(header, \"XSDT\");\n-\theader->length = sizeof(struct acpi_xsdt);\n+\theader->length = sizeof(struct acpi_table_header);\n \theader->revision = 1;\n \n \t/* Entries are filled in later, we come with an empty set */\n","prefixes":["1/1"]}