{"id":2225215,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2225215/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260420162114.308519-1-osama.abdelkader@gmail.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260420162114.308519-1-osama.abdelkader@gmail.com>","date":"2026-04-20T16:21:14","name":"hw/arm/raspi4b: NOP all DTB nodes when removing unimplemented devices","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"1de1128f7e3ceca3aa560861394aaf0d451eddd0","submitter":{"id":91532,"url":"http://patchwork.ozlabs.org/api/1.1/people/91532/?format=json","name":"Osama Abdelkader","email":"osama.abdelkader@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260420162114.308519-1-osama.abdelkader@gmail.com/mbox/","series":[{"id":500628,"url":"http://patchwork.ozlabs.org/api/1.1/series/500628/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500628","date":"2026-04-20T16:21:14","name":"hw/arm/raspi4b: NOP all DTB nodes when removing unimplemented devices","version":1,"mbox":"http://patchwork.ozlabs.org/series/500628/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2225215/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2225215/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=FXbhD+TX;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzrNn25d8z1yD4\n\tfor ; Tue, 21 Apr 2026 02:22:17 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wErNt-00081O-Ro; Mon, 20 Apr 2026 12:22:05 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wErNZ-0007hq-Lu\n for qemu-devel@nongnu.org; Mon, 20 Apr 2026 12:21:49 -0400","from mail-wr1-x435.google.com ([2a00:1450:4864:20::435])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wErNV-0003Yu-KN\n for qemu-devel@nongnu.org; Mon, 20 Apr 2026 12:21:43 -0400","by mail-wr1-x435.google.com with SMTP id\n ffacd0b85a97d-43d7605ec91so2983480f8f.3\n for ; Mon, 20 Apr 2026 09:21:39 -0700 (PDT)","from osama.. ([2a02:908:1b6:8980:1552:6880:e516:62d2])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43fe4e3a18csm34340249f8f.20.2026.04.20.09.21.36\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 20 Apr 2026 09:21:37 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776702098; x=1777306898; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=jlbR+uwzdp2+lvyziz0wCYmj2F91tqT21v73CNtF/qY=;\n b=FXbhD+TXIWTj90MhJVIaurs7A4UVazzNHz8q7WVA9z5aO+pdGFDVWMvgDGdpXa4zYf\n FwheJHquMtwooQD1knFVMh9Tn+PMeGLm8boy9GnTaPhMjqddWYwtKNoIt2rJYLi7yM0U\n 3hdbUVyuMvP+0K4XVcWqTDpFysHfaAqYJfl3fZPEDKP87UFrQKkJbnjzKUYJADVN7vTT\n mT0KuiVCsbnTt2J7/10UOYfI9k9Ubh3hMug8hhKpTZBzt4Kx2JuiCrdGkt0V1GhFyVyo\n e8seMvVaJUVv5NpPyBrXcsNDjgmkgz9+V+rSTmBB0ESBemKafMmlxNm1qgoEaMmRCma8\n gtLw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776702098; x=1777306898;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=jlbR+uwzdp2+lvyziz0wCYmj2F91tqT21v73CNtF/qY=;\n b=ElJXrlH4Jt8LhSlkY+F6j5K1UnPWapV0cogPgXw2ayHaOovu9huk35vy0lH8qoJFAz\n NRNETx/St1g8UKqqDidSWFSf7NlXwymN+jr7BR6e6wfvUqm6eFXAc8IdstjQi3YUdOdN\n AMM70r2Z28R6j+rrKy4COfz+qrHTtgaUdBzdG2aW/CsQxQCyJDNfARD7jpQ971mFiRXm\n eltzKaEunINkloo6KwXdRutPV6HOX+Z66DsFy3DDJJXLfsIEIJWjuHJdFRy8ZcaEgYQF\n rcZpnQb7ArVahSiufL+pp9heWpYHs1tNsszKt67GGFg4X5+WZjXp6an0A+UsE1dg5SFg\n 7sgw==","X-Gm-Message-State":"AOJu0YyEzpdHsPUt01RgDmacZ5KxN6qUYIjiiKLjfS7krPlxtFDar+U6\n 2LUxWRtysN90tMi6QvqcXlYsUAFCwT8U5zVSlImrpGpR8wWGJ1BY+Uaz25Cyn3ZU","X-Gm-Gg":"AeBDiev8ic+ht81Qx0h56qYgQq8e1qvFovYkHD6PCodUTqSOQ7gSm6+2q6Uu9xEK4S9\n MN66AQua2KjoY2UG/7Dsge9Vq8rQfmrFPhyUjjWEfh45l4PZ5SIWH6ShitLzYvbRjUnWfeCzBCN\n bmHc6JZnaHyWagVP7gbhmGZIFDi6JIFJS41Mc4wxNTBoZaq0PoDlyWaQgSl9NSgzjbJg9Yv57Aw\n rkvpIMD8q5rW6vXbUKW5C5kGe+i7/siqWGqjbkt6YBrwyJ74iuk4JSaTpnFyyLYG+kKpZapS6xV\n goGS7L7SfScolsJmt30THqJbSj+IkzFJLR9dER0yStNpLhcfmD0wI1Ys5qmBwpE4VsdfJd07NNY\n ostfhPpP6RihbejGU2+ExPojKynPk82PcKsgNgej7lJReQuXsYh5t/72ZV49pqSK+uFnbZuUjsN\n AkVM1sTVlwuEt7i6i0qbBjTf0C5XzlaT25L0TXTlGKeLpyWp4zEyI7MLLGrHfyATtBqm+SqsQ=","X-Received":"by 2002:a05:6000:610:b0:43d:1c21:ead5 with SMTP id\n ffacd0b85a97d-43fe3e0b4d8mr22737692f8f.22.1776702097900;\n Mon, 20 Apr 2026 09:21:37 -0700 (PDT)","From":"Osama Abdelkader ","To":"qemu-devel@nongnu.org","Cc":"Osama Abdelkader ,\n Peter Maydell ,\n qemu-arm@nongnu.org (open list:ARM TCG CPUs)","Subject":"[PATCH] hw/arm/raspi4b: NOP all DTB nodes when removing unimplemented\n devices","Date":"Mon, 20 Apr 2026 18:21:14 +0200","Message-ID":"<20260420162114.308519-1-osama.abdelkader@gmail.com>","X-Mailer":"git-send-email 2.43.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::435;\n envelope-from=osama.abdelkader@gmail.com; helo=mail-wr1-x435.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"fdt_node_offset_by_compatible(fdt, -1, compat) only finds the first match.\nIf the blob has more than one node with the same compatible string, extra\nnodes will remain active. using the same loop as imx8mp-evk.c\n\nSigned-off-by: Osama Abdelkader \n---\n hw/arm/raspi4b.c | 10 ++++++----\n 1 file changed, 6 insertions(+), 4 deletions(-)","diff":"diff --git a/hw/arm/raspi4b.c b/hw/arm/raspi4b.c\nindex 3eeb8f447e..06aeb8db01 100644\n--- a/hw/arm/raspi4b.c\n+++ b/hw/arm/raspi4b.c\n@@ -72,12 +72,14 @@ static void raspi4_modify_dtb(const struct arm_boot_info *info, void *fdt)\n \n for (int i = 0; i < ARRAY_SIZE(nodes_to_remove); i++) {\n const char *dev_str = nodes_to_remove[i];\n+ int offset;\n \n- int offset = fdt_node_offset_by_compatible(fdt, -1, dev_str);\n- if (offset >= 0) {\n- if (!fdt_nop_node(fdt, offset)) {\n- warn_report(\"bcm2711 dtc: %s has been disabled!\", dev_str);\n+ offset = fdt_node_offset_by_compatible(fdt, -1, dev_str);\n+ while (offset >= 0) {\n+ if (fdt_nop_node(fdt, offset) == 0) {\n+ warn_report(\"bcm2711 dtb: %s has been disabled!\", dev_str);\n }\n+ offset = fdt_node_offset_by_compatible(fdt, offset, dev_str);\n }\n }\n \n","prefixes":[]}