{"id":2225210,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2225210/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260420161958.584407-3-vsementsov@yandex-team.ru/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260420161958.584407-3-vsementsov@yandex-team.ru>","date":"2026-04-20T16:19:52","name":"[v14,2/8] net/tap: move vhost initialization to tap_setup_vhost()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"3473f4c25583a0addcd4b8846f4d7efe667501e7","submitter":{"id":84116,"url":"http://patchwork.ozlabs.org/api/1.1/people/84116/?format=json","name":"Vladimir Sementsov-Ogievskiy","email":"vsementsov@yandex-team.ru"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260420161958.584407-3-vsementsov@yandex-team.ru/mbox/","series":[{"id":500626,"url":"http://patchwork.ozlabs.org/api/1.1/series/500626/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500626","date":"2026-04-20T16:19:57","name":"virtio-net: live-TAP local migration","version":14,"mbox":"http://patchwork.ozlabs.org/series/500626/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2225210/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2225210/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=yandex-team.ru header.i=@yandex-team.ru\n header.a=rsa-sha256 header.s=default header.b=PaZDTRD3;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","mail-nwsmtp-smtp-corp-main-68.klg.yp-c.yandex.net;\n dkim=pass header.i=@yandex-team.ru"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzrMh4p1rz1yD4\n\tfor ; Tue, 21 Apr 2026 02:21:20 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wErM6-0005VQ-Ny; Mon, 20 Apr 2026 12:20:14 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wErM4-0005TY-It\n for qemu-devel@nongnu.org; Mon, 20 Apr 2026 12:20:12 -0400","from forwardcorp1d.mail.yandex.net\n ([2a02:6b8:c41:1300:1:45:d181:df01])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wErM1-0003FT-Bd\n for qemu-devel@nongnu.org; Mon, 20 Apr 2026 12:20:12 -0400","from mail-nwsmtp-smtp-corp-main-68.klg.yp-c.yandex.net\n (mail-nwsmtp-smtp-corp-main-68.klg.yp-c.yandex.net\n [IPv6:2a02:6b8:c42:94a9:0:640:a3fa:0])\n by forwardcorp1d.mail.yandex.net (Yandex) with ESMTPS id 9D0B38073F;\n Mon, 20 Apr 2026 19:20:07 +0300 (MSK)","from vsementsov-lin (unknown [2a02:6bf:8080:54b::1:34])\n by mail-nwsmtp-smtp-corp-main-68.klg.yp-c.yandex.net (smtpcorp) with ESMTPSA\n id 0KUTY10KuKo0-ex6B2VCb; Mon, 20 Apr 2026 19:20:06 +0300"],"Precedence":"bulk","X-Yandex-Fwd":"1","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru;\n s=default; t=1776702007;\n bh=uM4ZSd5P6FlqCb5Aknd1WBF30LZiWvbe5vaL6RixKhA=;\n h=Message-ID:Date:In-Reply-To:Cc:Subject:References:To:From;\n b=PaZDTRD3c7koE9VIpRjVm+XRS+JhaDsz863u3E7lO8L2GqiskVYV7vs1biIqyHNgC\n 4wMh3UFBDq5Pnb3e6YhwUw7t95RVr0h+TfQkwlGevEya3JUnRdx2F+89kyAgkKoIMj\n tIcuh6QPOQPloS4Moy8VuRuZDVQ0wVhZHI6N83Mc=","From":"Vladimir Sementsov-Ogievskiy ","To":"jasowang@redhat.com,\n\tmst@redhat.com","Cc":"armbru@redhat.com, peterx@redhat.com, farosas@suse.de,\n raphael.s.norwitz@gmail.com, bchaney@akamai.com, vsementsov@yandex-team.ru,\n qemu-devel@nongnu.org, berrange@redhat.com, pbonzini@redhat.com,\n yc-core@yandex-team.ru","Subject":"[PATCH v14 2/8] net/tap: move vhost initialization to\n tap_setup_vhost()","Date":"Mon, 20 Apr 2026 19:19:52 +0300","Message-ID":"<20260420161958.584407-3-vsementsov@yandex-team.ru>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260420161958.584407-1-vsementsov@yandex-team.ru>","References":"<20260420161958.584407-1-vsementsov@yandex-team.ru>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a02:6b8:c41:1300:1:45:d181:df01;\n envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1d.mail.yandex.net","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Make a new helper function in a way it can be reused later for\nTAP fd-migration feature: we'll need to initialize vhost in a later\npoint when we doesn't have access to QAPI parameters.\n\nSigned-off-by: Vladimir Sementsov-Ogievskiy \n---\n net/tap.c | 62 ++++++++++++++++++++++++++++++++++---------------------\n 1 file changed, 38 insertions(+), 24 deletions(-)","diff":"diff --git a/net/tap.c b/net/tap.c\nindex d941c67895e..9d6213fc3e5 100644\n--- a/net/tap.c\n+++ b/net/tap.c\n@@ -71,6 +71,8 @@ static const int kernel_feature_bits[] = {\n typedef struct TAPState {\n NetClientState nc;\n int fd;\n+ int vhostfd;\n+ uint32_t vhost_busyloop_timeout;\n char down_script[1024];\n char down_script_arg[128];\n uint8_t buf[NET_BUFSIZE];\n@@ -702,6 +704,38 @@ static int net_tap_init(const NetdevTapOptions *tap, int *vnet_hdr,\n return fd;\n }\n \n+static bool tap_setup_vhost(TAPState *s, Error **errp)\n+{\n+ VhostNetOptions options;\n+\n+ if (s->vhostfd == -1) {\n+ return true;\n+ }\n+\n+ options.backend_type = VHOST_BACKEND_TYPE_KERNEL;\n+ options.net_backend = &s->nc;\n+ options.busyloop_timeout = s->vhost_busyloop_timeout;\n+ options.opaque = (void *)(uintptr_t)s->vhostfd;\n+ options.nvqs = 2;\n+ options.feature_bits = kernel_feature_bits;\n+ options.get_acked_features = NULL;\n+ options.save_acked_features = NULL;\n+ options.max_tx_queue_size = 0;\n+ options.is_vhost_user = false;\n+\n+ s->vhost_net = vhost_net_init(&options);\n+ if (!s->vhost_net) {\n+ error_setg(errp,\n+ \"vhost-net requested but could not be initialized\");\n+ return false;\n+ }\n+\n+ /* vhostfd ownership is passed to s->vhost_net */\n+ s->vhostfd = -1;\n+\n+ return true;\n+}\n+\n static bool net_init_tap_one(const NetdevTapOptions *tap, NetClientState *peer,\n const char *name,\n const char *ifname, const char *script,\n@@ -736,30 +770,10 @@ static bool net_init_tap_one(const NetdevTapOptions *tap, NetClientState *peer,\n }\n }\n \n- if (vhostfd != -1) {\n- VhostNetOptions options;\n-\n- options.backend_type = VHOST_BACKEND_TYPE_KERNEL;\n- options.net_backend = &s->nc;\n- if (tap->has_poll_us) {\n- options.busyloop_timeout = tap->poll_us;\n- } else {\n- options.busyloop_timeout = 0;\n- }\n- options.opaque = (void *)(uintptr_t)vhostfd;\n- options.nvqs = 2;\n- options.feature_bits = kernel_feature_bits;\n- options.get_acked_features = NULL;\n- options.save_acked_features = NULL;\n- options.max_tx_queue_size = 0;\n- options.is_vhost_user = false;\n-\n- s->vhost_net = vhost_net_init(&options);\n- if (!s->vhost_net) {\n- error_setg(errp,\n- \"vhost-net requested but could not be initialized\");\n- goto failed;\n- }\n+ s->vhostfd = vhostfd;\n+ s->vhost_busyloop_timeout = tap->has_poll_us ? tap->poll_us : 0;\n+ if (!tap_setup_vhost(s, errp)) {\n+ return false;\n }\n \n return true;\n","prefixes":["v14","2/8"]}