{"id":2225173,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2225173/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260420140552.104369-8-eric.auger@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260420140552.104369-8-eric.auger@redhat.com>","date":"2026-04-20T14:03:57","name":"[v10,7/7] Revert \"target/arm: Reinstate bogus AArch32 DBGDTRTX register for migration compat\"","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"7eb134918a2dc21eedd6759b8e598dce459425e9","submitter":{"id":69187,"url":"http://patchwork.ozlabs.org/api/1.1/people/69187/?format=json","name":"Eric Auger","email":"eric.auger@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260420140552.104369-8-eric.auger@redhat.com/mbox/","series":[{"id":500612,"url":"http://patchwork.ozlabs.org/api/1.1/series/500612/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500612","date":"2026-04-20T14:03:52","name":"[v10,1/7] target/arm/cpu: Introduce the infrastructure for cpreg migration tolerances","version":10,"mbox":"http://patchwork.ozlabs.org/series/500612/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2225173/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2225173/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=M8wYECN4;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fznPw3jbFz1yGs\n\tfor ; Tue, 21 Apr 2026 00:08:04 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wEpHE-000378-Ej; Mon, 20 Apr 2026 10:07:06 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wEpGu-00033U-Du\n for qemu-devel@nongnu.org; Mon, 20 Apr 2026 10:06:44 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wEpGr-0001TQ-Lh\n for qemu-devel@nongnu.org; Mon, 20 Apr 2026 10:06:44 -0400","from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-113-fjcJ40SdON-6rFO84lnt4Q-1; Mon,\n 20 Apr 2026 10:06:33 -0400","from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 904A31800348; Mon, 20 Apr 2026 14:06:31 +0000 (UTC)","from laptop.redhat.com (unknown [10.44.32.74])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id D858C180047F; Mon, 20 Apr 2026 14:06:27 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776693998;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=HtGVpbU9D9A5ZHk/Is/GCfoppgSwhjM/X5KsFFKMQBQ=;\n b=M8wYECN4DLt5N1jIRx+zh1n5PEpvAgqjzVMc/JvMYevYL9C1S7u7Yz2xcokEPzqe+O8QDx\n W1BNVwAAjYOnH1RorVoIVH1oRwx10WL+XGxYy0cMCsiDcEBybY+HMY0ssxl1yEBXGLs6R9\n n87+9PRcSgHvJXDjQjjBRT8TqbCpVv0=","X-MC-Unique":"fjcJ40SdON-6rFO84lnt4Q-1","X-Mimecast-MFC-AGG-ID":"fjcJ40SdON-6rFO84lnt4Q_1776693991","From":"Eric Auger ","To":"eric.auger.pro@gmail.com, eric.auger@redhat.com, qemu-devel@nongnu.org,\n qemu-arm@nongnu.org, peter.maydell@linaro.org, cohuck@redhat.com,\n sebott@redhat.com, peterx@redhat.com, philmd@linaro.org,\n alex.bennee@linaro.org","Subject":"[PATCH v10 7/7] Revert \"target/arm: Reinstate bogus AArch32 DBGDTRTX\n register for migration compat\"","Date":"Mon, 20 Apr 2026 16:03:57 +0200","Message-ID":"<20260420140552.104369-8-eric.auger@redhat.com>","In-Reply-To":"<20260420140552.104369-1-eric.auger@redhat.com>","References":"<20260420140552.104369-1-eric.auger@redhat.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.93","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=eric.auger@redhat.com; helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"This reverts commit 4f2b82f60431 (\"target/arm: Reinstate bogus AArch32\nDBGDTRTX register for migration compat). We don't need that commit\nanymore as the AArch32 DBGDTRTX register is declared to\nbe safe to ignore in the incoming migration stream.\n\nSigned-off-by: Eric Auger \nReviewed-by: Sebastian Ott \nReviewed-by: Peter Maydell \n---\n target/arm/debug_helper.c | 29 -----------------------------\n 1 file changed, 29 deletions(-)","diff":"diff --git a/target/arm/debug_helper.c b/target/arm/debug_helper.c\nindex 352c8e5c8e7..8477ca5def6 100644\n--- a/target/arm/debug_helper.c\n+++ b/target/arm/debug_helper.c\n@@ -171,13 +171,6 @@ static void dbgclaimclr_write(CPUARMState *env, const ARMCPRegInfo *ri,\n env->cp15.dbgclaim &= ~(value & 0xFF);\n }\n \n-static CPAccessResult access_bogus(CPUARMState *env, const ARMCPRegInfo *ri,\n- bool isread)\n-{\n- /* Always UNDEF, as if this cpreg didn't exist */\n- return CP_ACCESS_UNDEFINED;\n-}\n-\n static const ARMCPRegInfo debug_cp_reginfo[] = {\n /*\n * DBGDRAR, DBGDSAR: always RAZ since we don't implement memory mapped\n@@ -240,28 +233,6 @@ static const ARMCPRegInfo debug_cp_reginfo[] = {\n .opc0 = 2, .opc1 = 3, .crn = 0, .crm = 4, .opc2 = 0,\n .access = PL0_RW, .accessfn = access_tdcc,\n .type = ARM_CP_CONST, .resetvalue = 0 },\n- /*\n- * This is not a real AArch32 register. We used to incorrectly expose\n- * this due to a QEMU bug; to avoid breaking migration compatibility we\n- * need to continue to provide it so that we don't fail the inbound\n- * migration when it tells us about a sysreg that we don't have.\n- * We set an always-fails .accessfn, which means that the guest doesn't\n- * actually see this register (it will always UNDEF, identically to if\n- * there were no cpreg definition for it other than that we won't print\n- * a LOG_UNIMP message about it), and we set the ARM_CP_NO_GDB flag so the\n- * gdbstub won't see it either.\n- * (We can't just set .access = 0, because add_cpreg_to_hashtable()\n- * helpfully ignores cpregs which aren't accessible to the highest\n- * implemented EL.)\n- *\n- * TODO: implement a system for being able to describe \"this register\n- * can be ignored if it appears in the inbound stream\"; then we can\n- * remove this temporary hack.\n- */\n- { .name = \"BOGUS_DBGDTR_EL0\", .state = ARM_CP_STATE_AA32,\n- .cp = 14, .opc1 = 3, .crn = 0, .crm = 5, .opc2 = 0,\n- .access = PL0_RW, .accessfn = access_bogus,\n- .type = ARM_CP_CONST | ARM_CP_NO_GDB, .resetvalue = 0 },\n /*\n * OSECCR_EL1 provides a mechanism for an operating system\n * to access the contents of EDECCR. EDECCR is not implemented though,\n","prefixes":["v10","7/7"]}