{"id":2225166,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2225166/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20260420120335.10120-1-maximilian.brune@9elements.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.1/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260420120335.10120-1-maximilian.brune@9elements.com>","date":"2026-04-20T12:03:35","name":"[v2] pci: correct PCI device enumeration to include all functions on device 0","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"238bd776ae51242ded291fa4067d54151ab419f4","submitter":{"id":93175,"url":"http://patchwork.ozlabs.org/api/1.1/people/93175/?format=json","name":"Maximilian Brune","email":"maximilian.brune@9elements.com"},"delegate":{"id":3651,"url":"http://patchwork.ozlabs.org/api/1.1/users/3651/?format=json","username":"trini","first_name":"Tom","last_name":"Rini","email":"trini@ti.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20260420120335.10120-1-maximilian.brune@9elements.com/mbox/","series":[{"id":500607,"url":"http://patchwork.ozlabs.org/api/1.1/series/500607/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=500607","date":"2026-04-20T12:03:35","name":"[v2] pci: correct PCI device enumeration to include all functions on device 0","version":2,"mbox":"http://patchwork.ozlabs.org/series/500607/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2225166/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2225166/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=9elements.com header.i=@9elements.com header.a=rsa-sha256\n header.s=google header.b=H2vdJzL6;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=9elements.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n secure) header.d=9elements.com header.i=@9elements.com header.b=\"H2vdJzL6\";\n\tdkim-atps=neutral","phobos.denx.de; dmarc=pass (p=quarantine dis=none)\n header.from=9elements.com","phobos.denx.de;\n spf=pass smtp.mailfrom=maximilian.brune@9elements.com"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzlpv4JByz1yD4\n\tfor ; Mon, 20 Apr 2026 22:56:07 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id C0FE5843D8;\n\tMon, 20 Apr 2026 14:54:41 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id A082C84312; Mon, 20 Apr 2026 14:07:09 +0200 (CEST)","from mail-wm1-x331.google.com (mail-wm1-x331.google.com\n [IPv6:2a00:1450:4864:20::331])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 930AB842F4\n for ; Mon, 20 Apr 2026 14:07:07 +0200 (CEST)","by mail-wm1-x331.google.com with SMTP id\n 5b1f17b1804b1-488a9033b2cso33452605e9.2\n for ; Mon, 20 Apr 2026 05:07:07 -0700 (PDT)","from mmax ([185.254.75.51]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48a525a0b1asm10879945e9.2.2026.04.20.05.07.06\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 20 Apr 2026 05:07:06 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=9elements.com; s=google; t=1776686827; x=1777291627; darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=Dyqi9+oOSZuy/ktekZfmEqGmAt/YUBvgDAuAXsiJpvs=;\n b=H2vdJzL6NmfvuWXCqq4e6MHxPwFqhF0YRUNelk2H2meoX13lmCEOeb3F2B2UBGD6On\n lDJ+aXtZvjqclwbPrjxZHrkhYecPf6TtRqyXwwetk0nWDsymkrFzWXNDh1cupF3/iN3c\n jGmiWplRgv3KizEVNbAhxbd8wKJNe8SRRs+o2VXbbZmdIA2RQpDab3mf2iW8br0MlBG2\n p9xTiA326M/LPI72VIrMcLSKBqnKUSFSiIMFW/rN8HA0oj5+jZMlNyiNi1AuxRnFaXKL\n 9vHljOebjHd81rk4+IMi0sk/3UfGBqori5IX8kAWt+Rwi+uVjLGauy40JhchL3XuBgcE\n iUYQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776686827; x=1777291627;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=Dyqi9+oOSZuy/ktekZfmEqGmAt/YUBvgDAuAXsiJpvs=;\n b=ibEf3Wze8CicTXIkYNp9bIpKKyyl27Jq9rKKh5V0OLVJMozIySTb0FFOFEd/hWv+im\n fAVzsIChKW6kTJn7nIATX0nU5RASn2k8poHBEv9m5HZzCynFS7gzJ6Duk9vUlLXnIgag\n JYEOrlOOToGu9by2Lat4LByrpIw8RTES3U0y1MInLt4BJWEd62PNpytDzrzMy+kpXPZd\n jj+Qj7qpOOabxKsCTaYnjnbNfc+5YPTDPz88FkGuT7djpFJnrPv8mR1zPABL3HVZ6GtN\n cWEf71QMYBuIALCJsZUMZ55897tE+i8Jgq799eqtv+Y22/o2RNdeVYNQSHmaRZfreZCm\n bpvg==","X-Gm-Message-State":"AOJu0Yw6nDPONsotm22hPI1q2h+TqLOKqqlDUZ2OpuOEbiBq52puDqiF\n 88xwYNo7dN92jEzldDg6x0Apu8QqTGGNnCQfVRXqnXiFSIyQxOzb2trrcP1Z01eCuJuW3jGv+G0\n Afvn90F4=","X-Gm-Gg":"AeBDievUGmiFkahdSMNlJMGC7XZLxX1e7fR6VphL19g/NeLOD9Lfrsx7hI7qFi1pIQf\n Jey6+O5iFu9XVeaIOj0B5PDKQqNaT4TPodOBw3Jfex0b9h3rHF0OVnirsPhMxSOZeWYCBrjw3Ti\n gE1rWQYLus4QYOistx5bAFnvErwAUcSz2u+Zp5ChzF9S+TVBv1hXXn0RfNWGYQdD0UUabG6bmHm\n 3FZAKZD5x7RwIthvF+hi9bpZeB3OePQwLY/slnmyWJdnjIjrwzh0NFhPpZvL2OvCAI99KXlpbEI\n F76zOYmakeUeyFP1gO43o0TZrKxuxOuzH2ogAUOBKXCM8HsljdhtAjiSfMp6YJD9DB0r8mImGos\n j7Sd5jqJy7juUnBfmQkOivMRBGny1Y6IXyr3k2Cl8cJE7vUMVsQ+d+KJSOKv64FrES+sCTHLs/4\n pnYvJ6Mi6tJViuyhpmf4V8nC0bZItFOIhDDqCmMA==","X-Received":"by 2002:a05:600c:888b:b0:485:4bd1:4c64 with SMTP id\n 5b1f17b1804b1-488fb796f95mr153969965e9.31.1776686826844;\n Mon, 20 Apr 2026 05:07:06 -0700 (PDT)","From":"Maximilian Brune ","To":"u-boot@lists.denx.de","Cc":"trini@konsulko.com, andrew.goodbody@linaro.org,\n george.mccollister@konsulko.com,\n Maximilian Brune ,\n Simon Glass ","Subject":"[PATCH v2] pci: correct PCI device enumeration to include all\n functions on device 0","Date":"Mon, 20 Apr 2026 14:03:35 +0200","Message-ID":"<20260420120335.10120-1-maximilian.brune@9elements.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260416161305.24118-1-maximilian.brune@9elements.com>","References":"<20260416161305.24118-1-maximilian.brune@9elements.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Mailman-Approved-At":"Mon, 20 Apr 2026 14:54:39 +0200","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"Currently the implementation does not just skip all devices beside\ndevice 0, it also skips all functions (besides 0) on device 0. This\nbroke basically all AMD platforms, since they have a lot of internal SOC\ndevices behind these functions.\n\nThis was detected, because the XHCI controller and therefore the USB\ndevices were not found by u-boot on AMD/crater platform.\n\nPCI_MASK_BUS() returns both device and function bits, so it skipps any\nbdf where either device > 0 or function > 0. Using PCI_DEV() extracts\nonly the device number, matching the intent in only_one_child().\nIt therefore now checks all functions on device 0 (Linux does the same).\n\nI build tested u-boot as coreboot payload and run it on a recent x86 AMD\nplatform. Devices like the XHCI controller are now found again.\n\nFixes: fbde868ba4aa (\"pci: skip unnecessary PCIe scanning\")\nSigned-off-by: Maximilian Brune \nCC: Tom Rini \nCC: Andrew Goodbody \nCC: George McCollister \nCC: Simon Glass \n---\n drivers/pci/pci-uclass.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/drivers/pci/pci-uclass.c b/drivers/pci/pci-uclass.c\nindex 83b76d01f24..f58d542ef75 100644\n--- a/drivers/pci/pci-uclass.c\n+++ b/drivers/pci/pci-uclass.c\n@@ -927,7 +927,7 @@ int pci_bind_bus_devices(struct udevice *bus)\n \t\tif (PCI_FUNC(bdf) && !found_multi)\n \t\t\tcontinue;\n \n-\t\tif (only_one_child(bus) && (PCI_MASK_BUS(bdf) > 0))\n+\t\tif (only_one_child(bus) && (PCI_DEV(bdf) > 0))\n \t\t\tcontinue;\n \n \t\t/* Check only the first access, we don't expect problems */\n","prefixes":["v2"]}