{"id":2225143,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2225143/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260420201317.30199-4-junjie.cao@intel.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260420201317.30199-4-junjie.cao@intel.com>","date":"2026-04-20T20:13:17","name":"[3/3] migration/qemu-file: drop incorrect const from qemu_get_buffer_at buf","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"58e37159a67fa4e43565796eefdb249f794f6204","submitter":{"id":91537,"url":"http://patchwork.ozlabs.org/api/1.1/people/91537/?format=json","name":"Junjie Cao","email":"junjie.cao@intel.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260420201317.30199-4-junjie.cao@intel.com/mbox/","series":[{"id":500601,"url":"http://patchwork.ozlabs.org/api/1.1/series/500601/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500601","date":"2026-04-20T20:13:15","name":"migration: switch remaining positioned I/O to _all helpers","version":1,"mbox":"http://patchwork.ozlabs.org/series/500601/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2225143/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2225143/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=J6WC+/9Q;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzkqQ5nzbz1yGs\n\tfor ; Mon, 20 Apr 2026 22:11:30 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wEnTF-0006be-Iv; Mon, 20 Apr 2026 08:11:22 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wEnSW-0006HV-UW\n for qemu-devel@nongnu.org; Mon, 20 Apr 2026 08:10:41 -0400","from mgamail.intel.com ([198.175.65.13])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wEnSV-0004Rl-5h\n for qemu-devel@nongnu.org; Mon, 20 Apr 2026 08:10:36 -0400","from orviesa003.jf.intel.com ([10.64.159.143])\n by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 20 Apr 2026 05:10:35 -0700","from junjie-optiplex-micro-plus-7010.bj.intel.com ([10.238.152.98])\n by ORVIESA003-auth.jf.intel.com with\n ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2026 05:10:33 -0700"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1776687036; x=1808223036;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=FRDFZTXk/wsz+JehMsAdHWcXLCvo0ta2YnqKF+zvKDE=;\n b=J6WC+/9QXdkFBTxlopngrVaIb+3Pn2A7b8Fd4T+N31RY8zpZ7Y9ZWNGt\n y2q/hWk1NWxioZe+G7KFc5ugHLkaEw1xM9bwbVoabdCvz9P9fC4joDK1d\n ongSJ29csNFcthZwTZHWE4Gi/BnXZ6tSab4E+0sFZVhr+04EF69ykVFCF\n iXYUs+X/NSHUwuX/R5dFnbwC07Fim5IrSoTxbARn59ZGgSAvcq92a+Tqb\n 1buNECtE5lVQO9NVKmwmuT7R3JcUe+HB0TIdMTeqDhPO65CmA00PdQOjT\n yFuEo2cAttVeEKwDNtDt5sZVnjn48w2x7GSc3kmH5edjrXQUeSYlOX3+u g==;","X-CSE-ConnectionGUID":["Mlu0mJGSQI+qcD8g5BblLA==","p0+IrDa3SFCWxpDZ3XGolA=="],"X-CSE-MsgGUID":["qN3uVjSBSQeF/4UeCyCVzg==","gfrZWsBTTf+5knFCofey6Q=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11762\"; a=\"88674256\"","E=Sophos;i=\"6.23,189,1770624000\"; d=\"scan'208\";a=\"88674256\"","E=Sophos;i=\"6.23,189,1770624000\"; d=\"scan'208\";a=\"235708280\""],"X-ExtLoop1":"1","From":"Junjie Cao ","To":"qemu-devel@nongnu.org","Cc":"peterx@redhat.com,\n\tfarosas@suse.de,\n\tjunjie.cao@intel.com","Subject":"[PATCH 3/3] migration/qemu-file: drop incorrect const from\n qemu_get_buffer_at buf","Date":"Tue, 21 Apr 2026 04:13:17 +0800","Message-ID":"<20260420201317.30199-4-junjie.cao@intel.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260420201317.30199-1-junjie.cao@intel.com>","References":"<20260420201317.30199-1-junjie.cao@intel.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=198.175.65.13;\n envelope-from=junjie.cao@intel.com;\n helo=mgamail.intel.com","X-Spam_score_int":"-24","X-Spam_score":"-2.5","X-Spam_bar":"--","X-Spam_report":"(-2.5 / 5.0 requ) BAYES_00=-1.9, DATE_IN_FUTURE_06_12=1.947,\n DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\n DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"qemu_get_buffer_at() reads data *into* buf -- it should not be const.\nDrop the qualifier and remove the now-unnecessary cast.\n\nSigned-off-by: Junjie Cao \n---\n migration/qemu-file.c | 4 ++--\n migration/qemu-file.h | 2 +-\n 2 files changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/migration/qemu-file.c b/migration/qemu-file.c\nindex 9dfb202203..d5a48115bd 100644\n--- a/migration/qemu-file.c\n+++ b/migration/qemu-file.c\n@@ -550,7 +550,7 @@ void qemu_put_buffer_at(QEMUFile *f, const uint8_t *buf, size_t buflen,\n }\n \n \n-size_t qemu_get_buffer_at(QEMUFile *f, const uint8_t *buf, size_t buflen,\n+size_t qemu_get_buffer_at(QEMUFile *f, uint8_t *buf, size_t buflen,\n off_t pos)\n {\n Error *err = NULL;\n@@ -559,7 +559,7 @@ size_t qemu_get_buffer_at(QEMUFile *f, const uint8_t *buf, size_t buflen,\n return 0;\n }\n \n- if (qio_channel_pread_all(f->ioc, (char *)buf, buflen, pos, &err) < 0) {\n+ if (qio_channel_pread_all(f->ioc, buf, buflen, pos, &err) < 0) {\n qemu_file_set_error_obj(f, -EIO, err);\n return 0;\n }\ndiff --git a/migration/qemu-file.h b/migration/qemu-file.h\nindex a390554208..8f824c124d 100644\n--- a/migration/qemu-file.h\n+++ b/migration/qemu-file.h\n@@ -76,7 +76,7 @@ void qemu_set_offset(QEMUFile *f, off_t off, int whence);\n off_t qemu_get_offset(QEMUFile *f);\n void qemu_put_buffer_at(QEMUFile *f, const uint8_t *buf, size_t buflen,\n off_t pos);\n-size_t qemu_get_buffer_at(QEMUFile *f, const uint8_t *buf, size_t buflen,\n+size_t qemu_get_buffer_at(QEMUFile *f, uint8_t *buf, size_t buflen,\n off_t pos);\n \n QIOChannel *qemu_file_get_ioc(QEMUFile *file);\n","prefixes":["3/3"]}