{"id":2225111,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2225111/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260420105816.72168-2-mahe.tardy@gmail.com/","project":{"id":26,"url":"http://patchwork.ozlabs.org/api/1.1/projects/26/?format=json","name":"Netfilter Development","link_name":"netfilter-devel","list_id":"netfilter-devel.vger.kernel.org","list_email":"netfilter-devel@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260420105816.72168-2-mahe.tardy@gmail.com>","date":"2026-04-20T10:58:11","name":"[bpf-next,v4,1/6] net: move netfilter nf_reject_fill_skb_dst to core ipv4","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"2fc349b290b0d89b99aa5da5d788757a327e11ec","submitter":{"id":91349,"url":"http://patchwork.ozlabs.org/api/1.1/people/91349/?format=json","name":"Mahe Tardy","email":"mahe.tardy@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260420105816.72168-2-mahe.tardy@gmail.com/mbox/","series":[{"id":500597,"url":"http://patchwork.ozlabs.org/api/1.1/series/500597/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=500597","date":"2026-04-20T10:58:10","name":"bpf: add icmp_send_unreach kfunc","version":4,"mbox":"http://patchwork.ozlabs.org/series/500597/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2225111/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2225111/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=jJJVPpqu;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-12040-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"jJJVPpqu\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.128.50","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzjCq5WPYz1yGs\n\tfor ; Mon, 20 Apr 2026 20:59:03 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 713213031B0A\n\tfor ; Mon, 20 Apr 2026 10:58:41 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id DCF2139C629;\n\tMon, 20 Apr 2026 10:58:34 +0000 (UTC)","from mail-wm1-f50.google.com (mail-wm1-f50.google.com\n [209.85.128.50])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 71B77389104\n\tfor ; Mon, 20 Apr 2026 10:58:32 +0000 (UTC)","by mail-wm1-f50.google.com with SMTP id\n 5b1f17b1804b1-488b0046078so27584455e9.1\n for ;\n Mon, 20 Apr 2026 03:58:32 -0700 (PDT)","from mtardy-friendly-lvh-runner.local ([2600:1900:4010:1a8::])\n by smtp.googlemail.com with ESMTPSA id\n 5b1f17b1804b1-488fc1cfbf2sm290929495e9.15.2026.04.20.03.58.30\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 20 Apr 2026 03:58:30 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776682714; cv=none;\n b=CIiCo5jzk+IGRsgdKbVHnvuKZm7xSXN68xYxebvMvs6xqs+thMXf/KfpljZaH+LpUJYHncWoLeS/uBAqSCUvnob8ZTEX28/pgNk50NeT+CuIdBTbqCVv8XZ+SF7joLMig9X2MvHi0mL2S4wzO2q8EPMg8xVN+U6S9N8d6QGLgL4=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776682714; c=relaxed/simple;\n\tbh=Z/RqQZ5y6bft4hMqHDaUqfOlQhmbzjC0l1HNhO7nBss=;\n\th=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:\n\t MIME-Version;\n b=fkZeews/aDJsSDNokhaco43uwXCqYg2h8n+RtHofYOzs5T57+pwEkp3twWnhzeZ9H4lJf1pyLIzU3OvGBRb8ZqKrkyZa4FQ2OADKu9TeIriZVtQGu4mWBb96U7VjTiEGjhcOGNHx1IZNTLaMZmnM78CGhuPa4f7CRah4ReUsffQ=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=jJJVPpqu; arc=none smtp.client-ip=209.85.128.50","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776682711; x=1777287511;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=vQOWKei7Kltdv3X+USCnxklQ74uXe3yFxWu8Qz5lwVU=;\n b=jJJVPpqucET7sdp+zik/1K0WCBhkX0wEZkUdBUuIhuqyC5EMcg0CDVmcl25VK7gDaZ\n ekaE/8XtEQ7PtvT6fNB1YhcLyopAE2DIaoDakL2TBpwagHQU0IoZ42GBFlIy2SvX5Tj0\n LSa6jEKVo0Qp7j8tuiVkWRM3mEtPziw0bfqSewkE/6BSklBnRVy1EqEs6Th0g7mK/U5R\n geyzL1CpPkSl3WjSSN+8sl2Ru/YNCpzNvlwvZSie9q7+ZX/vUykDOOOktNAn+/Y2ZxXW\n +SI7WZMitSlWlYpEB0yRz2c5t9YjyvJBAgJ9JLn+AB3x+q27Z7oj+Y8OONR9np3Of2YY\n IxPQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776682711; x=1777287511;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=vQOWKei7Kltdv3X+USCnxklQ74uXe3yFxWu8Qz5lwVU=;\n b=sgW6ze7rm71yYcJbgAqeJU6uHqUklpbJSs5f2iKhOScespa2pzjmL8aIhpk4JnOM2k\n bE8nojNkSMzz4FM5JJgcQ2nxZpY2Bg16elVtpc32wHPSMtQl5eLxBNfh4dkfVUoFEI4n\n z9nS7a98baKLwskCn34hggi7eEh1SlVbTYolOu/PjfGVi2yrnADgKaulShllKqTgEJYp\n k4Q7yLZ3wXXajsY1XjTX8HkyBEvULCM5LBdBFZy8cmiK/ZcgfWPZggvwFlT+qI+a4xx4\n iCePsYO3sY+xrJoAjh0uQkObd7AeT+S9J5CLasQR28x0YkxOPDxoLzR6mqfenLpjS4X4\n wsVw==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8mr7p/S8xO0K2+AqiZfqCuLqoDlRllXfrH92H9MTfc/E6qJ7f0YTK05lx6bg2HPATXc2fZzr1Ptw7otMycHY8=@vger.kernel.org","X-Gm-Message-State":"AOJu0Ywf1HB5mjkCO3EKzbZrmHLf8uP3bzLhwiU/qIdcjTpHmEw+7hMF\n\t2sjCmAl+h8NfzA2POQoslEoW7c+FjkTnhTcGxbW3+pQgxYXWfv93b6hR","X-Gm-Gg":"AeBDievOBVcyIgplUSUPPt++X8tELKupGQPVB7WV9/M7iJRTkuRNea0IOYdw+VRCGRL\n\tWdSk7Ck3vFkBlJgPNXPbxaEA2H0CNLCNT1yvJBWmf+3Lzg2LOTO99BCkB+p1S/SPUwVQ2ES4KLJ\n\tqDXlBJYS1lvkTPK/ef0k4uxrLgil9RGfL24VfIuIFg4+sMPj08XfZNN0lzDOHjutIdNPuUYxLN2\n\tjkGCQsNAeeAB0pvlFU0retsiB5AnYagEbVXRp0rHXetiqgtsAbHE7FPTH05nJ3bYqSxRmGkNGT/\n\tECJav8syXpvTTa86Cf8NeSV8BsTn0Lcte0R5uxNhtEMoQSTbISJAA7ikMjjES1dNIn8Mndu8K+S\n\tNBsLpMLvtwsQySUlr6af0FvwuEVyLUX0FVBNpUiAV++TEa4IPkSTLO2Y6t47MBFbKskjn1Jr6X4\n\ts7LgKFK0OxwK60dXYIBAPh0UzGFguYXEUqF6ggVA==","X-Received":"by 2002:a05:600c:12d4:b0:489:1f04:96c3 with SMTP id\n 5b1f17b1804b1-4891f049763mr20239635e9.2.1776682710673;\n Mon, 20 Apr 2026 03:58:30 -0700 (PDT)","From":"Mahe Tardy ","To":"mahe.tardy@gmail.com","Cc":"alexei.starovoitov@gmail.com,\n\tandrii@kernel.org,\n\tast@kernel.org,\n\tbpf@vger.kernel.org,\n\tcoreteam@netfilter.org,\n\tdaniel@iogearbox.net,\n\tfw@strlen.de,\n\tjohn.fastabend@gmail.com,\n\tlkp@intel.com,\n\tmartin.lau@linux.dev,\n\tnetdev@vger.kernel.org,\n\tnetfilter-devel@vger.kernel.org,\n\toe-kbuild-all@lists.linux.dev,\n\tpablo@netfilter.org","Subject":"[PATCH bpf-next v4 1/6] net: move netfilter nf_reject_fill_skb_dst to\n core ipv4","Date":"Mon, 20 Apr 2026 10:58:11 +0000","Message-Id":"<20260420105816.72168-2-mahe.tardy@gmail.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20260420105816.72168-1-mahe.tardy@gmail.com>","References":"\n <20260420105816.72168-1-mahe.tardy@gmail.com>","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"Move and rename nf_reject_fill_skb_dst from\nipv4/netfilter/nf_reject_ipv4 to ip_route_reply_fetch_dst in\nipv4/route.c so that it can be reused in the following patches by BPF\nkfuncs.\n\nNetfilter uses nf_ip_route that is almost a transparent wrapper around\nip_route_output_key so this patch inlines it.\n\nSigned-off-by: Mahe Tardy \n---\n include/net/route.h | 1 +\n net/ipv4/netfilter/nf_reject_ipv4.c | 19 ++-----------------\n net/ipv4/route.c | 15 +++++++++++++++\n 3 files changed, 18 insertions(+), 17 deletions(-)\n\n--\n2.34.1","diff":"diff --git a/include/net/route.h b/include/net/route.h\nindex f90106f383c5..ec2466fd0bec 100644\n--- a/include/net/route.h\n+++ b/include/net/route.h\n@@ -173,6 +173,7 @@ struct rtable *ip_route_output_flow(struct net *, struct flowi4 *flp,\n \t\t\t\t const struct sock *sk);\n struct dst_entry *ipv4_blackhole_route(struct net *net,\n \t\t\t\t struct dst_entry *dst_orig);\n+int ip_route_reply_fetch_dst(struct sk_buff *skb);\n\n static inline struct rtable *ip_route_output_key(struct net *net, struct flowi4 *flp)\n {\ndiff --git a/net/ipv4/netfilter/nf_reject_ipv4.c b/net/ipv4/netfilter/nf_reject_ipv4.c\nindex fecf6621f679..2290451ed122 100644\n--- a/net/ipv4/netfilter/nf_reject_ipv4.c\n+++ b/net/ipv4/netfilter/nf_reject_ipv4.c\n@@ -252,21 +252,6 @@ static void nf_reject_ip_tcphdr_put(struct sk_buff *nskb, const struct sk_buff *\n \tnskb->csum_offset = offsetof(struct tcphdr, check);\n }\n\n-static int nf_reject_fill_skb_dst(struct sk_buff *skb_in)\n-{\n-\tstruct dst_entry *dst = NULL;\n-\tstruct flowi fl;\n-\n-\tmemset(&fl, 0, sizeof(struct flowi));\n-\tfl.u.ip4.daddr = ip_hdr(skb_in)->saddr;\n-\tnf_ip_route(dev_net(skb_in->dev), &dst, &fl, false);\n-\tif (!dst)\n-\t\treturn -1;\n-\n-\tskb_dst_set(skb_in, dst);\n-\treturn 0;\n-}\n-\n /* Send RST reply */\n void nf_send_reset(struct net *net, struct sock *sk, struct sk_buff *oldskb,\n \t\t int hook)\n@@ -279,7 +264,7 @@ void nf_send_reset(struct net *net, struct sock *sk, struct sk_buff *oldskb,\n \tif (!oth)\n \t\treturn;\n\n-\tif (!skb_dst(oldskb) && nf_reject_fill_skb_dst(oldskb) < 0)\n+\tif (!skb_dst(oldskb) && ip_route_reply_fetch_dst(oldskb) < 0)\n \t\treturn;\n\n \tif (skb_rtable(oldskb)->rt_flags & (RTCF_BROADCAST | RTCF_MULTICAST))\n@@ -352,7 +337,7 @@ void nf_send_unreach(struct sk_buff *skb_in, int code, int hook)\n \tif (iph->frag_off & htons(IP_OFFSET))\n \t\treturn;\n\n-\tif (!skb_dst(skb_in) && nf_reject_fill_skb_dst(skb_in) < 0)\n+\tif (!skb_dst(skb_in) && ip_route_reply_fetch_dst(skb_in) < 0)\n \t\treturn;\n\n \tif (skb_csum_unnecessary(skb_in) ||\ndiff --git a/net/ipv4/route.c b/net/ipv4/route.c\nindex bc1296f0ea69..7091ef936073 100644\n--- a/net/ipv4/route.c\n+++ b/net/ipv4/route.c\n@@ -2945,6 +2945,21 @@ struct rtable *ip_route_output_flow(struct net *net, struct flowi4 *flp4,\n }\n EXPORT_SYMBOL_GPL(ip_route_output_flow);\n\n+int ip_route_reply_fetch_dst(struct sk_buff *skb)\n+{\n+\tstruct rtable *rt;\n+\tstruct flowi4 fl4 = {\n+\t\t.daddr = ip_hdr(skb)->saddr\n+\t};\n+\n+\trt = ip_route_output_key(dev_net(skb->dev), &fl4);\n+\tif (IS_ERR(rt))\n+\t\treturn PTR_ERR(rt);\n+\tskb_dst_set(skb, &rt->dst);\n+\treturn 0;\n+}\n+EXPORT_SYMBOL_GPL(ip_route_reply_fetch_dst);\n+\n /* called with rcu_read_lock held */\n static int rt_fill_info(struct net *net, __be32 dst, __be32 src,\n \t\t\tstruct rtable *rt, u32 table_id, dscp_t dscp,\n","prefixes":["bpf-next","v4","1/6"]}