{"id":2225108,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2225108/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20260420-pinconf-v1-1-82f8276d8aec@gmail.com/","project":{"id":42,"url":"http://patchwork.ozlabs.org/api/1.1/projects/42/?format=json","name":"Linux GPIO development","link_name":"linux-gpio","list_id":"linux-gpio.vger.kernel.org","list_email":"linux-gpio@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260420-pinconf-v1-1-82f8276d8aec@gmail.com>","date":"2026-04-20T10:55:55","name":"pinctrl: pinconf-generic: fix properties bitmap leak in parse_fw_cfg()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"5432eddbf985c6c10dc812dfeb1153d859faf6d4","submitter":{"id":92491,"url":"http://patchwork.ozlabs.org/api/1.1/people/92491/?format=json","name":"Felix Gu","email":"ustc.gu@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20260420-pinconf-v1-1-82f8276d8aec@gmail.com/mbox/","series":[{"id":500596,"url":"http://patchwork.ozlabs.org/api/1.1/series/500596/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/list/?series=500596","date":"2026-04-20T10:55:55","name":"pinctrl: pinconf-generic: fix properties bitmap leak in parse_fw_cfg()","version":1,"mbox":"http://patchwork.ozlabs.org/series/500596/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2225108/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2225108/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=C2GApaAd;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-gpio+bounces-35256-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"C2GApaAd\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.210.177","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzjBy4r5tz1yGs\n\tfor ; Mon, 20 Apr 2026 20:58:18 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 395AD305D142\n\tfor ; Mon, 20 Apr 2026 10:56:02 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id A4CEA39A7F8;\n\tMon, 20 Apr 2026 10:56:01 +0000 (UTC)","from mail-pf1-f177.google.com (mail-pf1-f177.google.com\n [209.85.210.177])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 4463439A809\n\tfor ; Mon, 20 Apr 2026 10:56:00 +0000 (UTC)","by mail-pf1-f177.google.com with SMTP id\n d2e1a72fcca58-82f946efa38so1262364b3a.0\n for ;\n Mon, 20 Apr 2026 03:56:00 -0700 (PDT)","from junjungu-PC.localdomain ([223.167.147.125])\n by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-82f8ec06cbfsm12227889b3a.58.2026.04.20.03.55.57\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 20 Apr 2026 03:55:58 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776682561; cv=none;\n b=MJXbAwBGanAB2SbivmfqHS0fwFCbuOrtbI31FMmxA7JFuGfnBdOsd/aRQw6RXWyJsgSLB2igwCP09P/v9GglYM3oTagU2XcIO8Jkyakeu0mFzRd8eQWYSWiRah5tHm3y+i68VEESEN/P+/I6NyvfUmwTOoST+meZqfs4qnsOG1c=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776682561; c=relaxed/simple;\n\tbh=A1WSNvZBH7Gl27blE0SBf08sIf2c8iIjtoiwnzlc7uU=;\n\th=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc;\n b=fgHCqcbD6cEkpa8vBKwM+JzEZxOPCM2FwzA2wam5MQKgjUbo+rGB4Ibdn4GIPMYFYPEaLM/4IPshNCi9pqm19JwmgAgQKWV6nyCdNCsb9fv65PZjBxz0xWEX/PI6AEa08K7uacSfQyFlJ6fI41MLO8TUeEW/OtNQZJQ05FRzqmQ=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=C2GApaAd; arc=none smtp.client-ip=209.85.210.177","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776682559; x=1777287359;\n darn=vger.kernel.org;\n h=cc:to:message-id:content-transfer-encoding:mime-version:subject\n :date:from:from:to:cc:subject:date:message-id:reply-to;\n bh=86QtRyfODNt78/15/vwrG7dKY8dGMsIZ3LKVUkBa3Dc=;\n b=C2GApaAdsHE7hO+QI7QaLC/4rKSN2OBn/3C3cmOQ/fffZy0NdG0dDnyHdIkuYyHGox\n v7PSppjq7MuPiB1sWepxOamDkZosu+uhls4qDhCx10bEYXzjxNXqfIOnjr+iLRUi4OfL\n JAd4BrAP3bt3jhwHi8dP0o/DqfkmQr+CflM9PZ5Vq8DODxfmjdNc6nf+U78UEkkDNNgm\n 2QeCoku0INurif9YOJbzXzHN7yUywsJz2RcK4hty66vfso6haffGsbZpEGG1ZE422PQb\n exrRwC/v6L2uErWsB5C4GRivZdfhumqbVCThkUIq16mLQsmPhj2UA1Q54VO8LRp0GaI0\n /S2A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776682559; x=1777287359;\n h=cc:to:message-id:content-transfer-encoding:mime-version:subject\n :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=86QtRyfODNt78/15/vwrG7dKY8dGMsIZ3LKVUkBa3Dc=;\n b=ewTCb35TMGQxsyTi4I2sQpFvxFShVfjuiYw7aG8xMKubVfZYS1gX+ldN5WOKeAVLnX\n WXvjo6689CGmn0+Eft99zItRTbxWcP63DHuu3B8J2fm4ZqmWsQidsKxdyr8A/6dbZRux\n EpnFOZNWbEiD1RbpaSFy5mZVInDdKuGLJg1RehgDHqVG8RExh1Xr+4tNcNBb2GIbIhbY\n n4P9GtKPo8YhHiZO5mNpS1nfzdbpHux1Yi5afIja1osfks4tMYKtMqGEWVk5W5ZAQOxU\n nkapz4vdb9NRmZgF211sYujFOk9u+42GJmfY0WeCXqmTA++lu591sFJJfONOvYiNOY7r\n q2IQ==","X-Gm-Message-State":"AOJu0Yx8VAl/zXqMUpMiYIsnERfQyW5x2GkOE06xsQW4n4Fgie4uGSwC\n\tsdJNeiddqtRFlKAoW2Dos1r64O/Fx/6XwS9kibaGKCl+KXqdhVCzI+2WbzeoYRDt","X-Gm-Gg":"AeBDietfU3vFG7LFwp1yTboxwiGDXMOS5ODuu35ps1rmWDYWyGFbKhrah1ywp8VZvxd\n\taOgHMPkypu3V8kBhG8UGf++A9/atMva0oateVzlhM+pI2Sm8hYy1Rh+tnnTWxK4G8vZ5wBSPLZo\n\tlmbRiktziDWd3smvOBsS4EIQki38TvRm6YPxtsdmEE8lBZdalBZ62MGmOz7KaH5I1iKxGC3GdWb\n\tn1ch+8+909hJu9WFvY+k9VQLluKUlOrKXnrv1ca7UsIbMCTGxavpYOL6BmtIZj69A5GpZSs1n7R\n\tzvrxAGSibY/QSOnHhpt+9SWB3Bpi1ftFl+/VAGuj1NMJhupp5zk623sbClIwKveRfpuQWeuSDQn\n\t08QKx/jzh+2tpVa3eRAALFi+NnheX0e3U5M321e3wffE6ohzrUc78q2cGilHAE20W4eDS1uSKVv\n\tk9zCA9wmocCCcV07+xO8jN991p5ilB5ElOCqMzqdE4UCU9melFLajzDGl0SvD7oWNstqS6ubdzP\n\tJWDrzGweJXf0JbpLdjWwt3/ZeMajB8=","X-Received":"by 2002:a05:6a00:181b:b0:824:b304:2d1e with SMTP id\n d2e1a72fcca58-82f8b389d04mr12288256b3a.8.1776682559260;\n Mon, 20 Apr 2026 03:55:59 -0700 (PDT)","From":"Felix Gu ","Date":"Mon, 20 Apr 2026 18:55:55 +0800","Subject":"[PATCH] pinctrl: pinconf-generic: fix properties bitmap leak in\n parse_fw_cfg()","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260420-pinconf-v1-1-82f8276d8aec@gmail.com>","X-B4-Tracking":"v=1; b=H4sIADoG5mkC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE\n vPSU3UzU4B8JSMDIzMDEyMD3YLMvOT8vDTdtFRDC0uTxGQDo8RkJaDqgqLUtMwKsEnRsbW1AOW\n jILdZAAAA","X-Change-ID":"20260420-pinconf-fe1894ac02ac","To":"Linus Walleij ,\n Conor Dooley ","Cc":"linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,\n Felix Gu ","X-Mailer":"b4 0.14.3","X-Developer-Signature":"v=1; a=ed25519-sha256; t=1776682557; l=1640;\n i=ustc.gu@gmail.com; h=from:subject:message-id;\n bh=A1WSNvZBH7Gl27blE0SBf08sIf2c8iIjtoiwnzlc7uU=;\n b=4KG3p0Phbq/joYNJzNNSAXc7vV/V3sEXN3+vnu2zRTfQmR2eDxVA4yNT4p/ETdVhM12Xwlmww\n PhEA3EdTXZ8AvyBc47tS9XL/nhySJYHqz7zo+yMuXlKamMJK2eGgLgF","X-Developer-Key":"i=ustc.gu@gmail.com; a=ed25519;\n pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw="},"content":"In parse_fw_cfg(), if fwnode_property_match_property_string() fails with\n-ENOENT, the code returns directly and leaks the bitmap.\n\nUse __free(bitmap) for automatic cleanup to fix the leak.\n\nFixes: 9c105255108b (\"pinctrl: pinconf-generic: perform basic checks on pincfg properties\")\nSigned-off-by: Felix Gu \n---\n drivers/pinctrl/pinconf-generic.c | 5 +----\n 1 file changed, 1 insertion(+), 4 deletions(-)\n\n\n---\nbase-commit: c7275b05bc428c7373d97aa2da02d3a7fa6b9f66\nchange-id: 20260420-pinconf-fe1894ac02ac\n\nBest regards,","diff":"diff --git a/drivers/pinctrl/pinconf-generic.c b/drivers/pinctrl/pinconf-generic.c\nindex 64ed28309788..077149121628 100644\n--- a/drivers/pinctrl/pinconf-generic.c\n+++ b/drivers/pinctrl/pinconf-generic.c\n@@ -225,10 +225,9 @@ static int parse_fw_cfg(struct fwnode_handle *fwnode,\n \t\t\tunsigned int count, unsigned long *cfg,\n \t\t\tunsigned int *ncfg)\n {\n-\tunsigned long *properties;\n \tint i, test;\n \n-\tproperties = bitmap_zalloc(count, GFP_KERNEL);\n+\tunsigned long *properties __free(bitmap) = bitmap_zalloc(count, GFP_KERNEL);\n \n \tfor (i = 0; i < count; i++) {\n \t\tu32 val;\n@@ -263,7 +262,6 @@ static int parse_fw_cfg(struct fwnode_handle *fwnode,\n \t\t\tif (ret) {\n \t\t\t\tpr_err(\"%pfw: conflicting setting detected for %s\\n\",\n \t\t\t\t fwnode, par->property);\n-\t\t\t\tbitmap_free(properties);\n \t\t\t\treturn -EINVAL;\n \t\t\t}\n \t\t}\n@@ -295,7 +293,6 @@ static int parse_fw_cfg(struct fwnode_handle *fwnode,\n \t\tpr_err(\"%pfw: cannot have multiple drive configurations\\n\",\n \t\t fwnode);\n \n-\tbitmap_free(properties);\n \treturn 0;\n }\n \n","prefixes":[]}