{"id":2225013,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2225013/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260420083705.1009074-12-dhowells@redhat.com/","project":{"id":12,"url":"http://patchwork.ozlabs.org/api/1.1/projects/12/?format=json","name":"Linux CIFS Client","link_name":"linux-cifs-client","list_id":"linux-cifs.vger.kernel.org","list_email":"linux-cifs@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260420083705.1009074-12-dhowells@redhat.com>","date":"2026-04-20T08:37:02","name":"[11/11] netfs: Fix netfs_read_folio() to wait on writeback","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"e9afe122dccf225caab21ae0a1e056b8b8fa770b","submitter":{"id":59,"url":"http://patchwork.ozlabs.org/api/1.1/people/59/?format=json","name":"David Howells","email":"dhowells@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260420083705.1009074-12-dhowells@redhat.com/mbox/","series":[{"id":500568,"url":"http://patchwork.ozlabs.org/api/1.1/series/500568/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=500568","date":"2026-04-20T08:36:52","name":"netfs: Further miscellaneous fixes","version":1,"mbox":"http://patchwork.ozlabs.org/series/500568/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2225013/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2225013/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Bd+fxYHS;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-cifs+bounces-10934-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=\"Bd+fxYHS\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=170.10.133.124","smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=redhat.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=redhat.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzfGx5hzXz1yGs\n\tfor ; Mon, 20 Apr 2026 18:46:33 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id BC2F230D3CB3\n\tfor ; Mon, 20 Apr 2026 08:39:05 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id EA18B38BF62;\n\tMon, 20 Apr 2026 08:38:13 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AF5C393DC1\n\tfor ; Mon, 20 Apr 2026 08:38:12 +0000 (UTC)","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-68-V5spEUY1NImn6v35llKtVg-1; Mon,\n 20 Apr 2026 04:38:10 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id BB68D19560B1;\n\tMon, 20 Apr 2026 08:38:08 +0000 (UTC)","from warthog.procyon.org.com (unknown [10.44.48.17])\n\tby mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id BCB953000C15;\n\tMon, 20 Apr 2026 08:38:05 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776674293; cv=none;\n b=MDHqyqYbjPJYQ8D9KzhVISgEoslsHgNwWPz9sA37nDNnMoFgN3Mj3QEaGjSkjDMXRm0TZuyHXIiuxyN98xuKGakzZbs+80vJaVc4hneTMLqZDWOVzBBY+xypJzB4iNm1V2ptibHF567JSqVvYdmrEzgc1bE483+EZi9LRsvQ/XI=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776674293; c=relaxed/simple;\n\tbh=UEd2DPy5Oydn8gPnoSJEViWZQyJhuKPr8I6vUBK9yqU=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=dgs3G7CiZOYCS7OrItJUhC7EEbLyb40bTM3Rwld+ffCye/QocDysfKV0ru8eTX0pIVUtwcl5pafLXwzocWmukthVBVmdnh7hHqPbtuppo4FPFKuXLay+UG3eX1r4G2IddR1KQ8RErF/wj/a+K+ViBGr8A6U2N0Cmkji53luTIzw=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=redhat.com;\n spf=pass smtp.mailfrom=redhat.com;\n dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=Bd+fxYHS; arc=none smtp.client-ip=170.10.133.124","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1776674291;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\t to:to:cc:cc:mime-version:mime-version:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=i/iqAtL+28tWt3sinE2J51vlI+HAUHWznAcDahw6A20=;\n\tb=Bd+fxYHSfNZ/B0dCk9eDzxroJEFioUn0e+fEWzpJ3t1HNXX1q0rnGWbfzSAvynZLEuZNjP\n\tUPcb9pv5bqT7MScKEVzIgfpjRgsGXYH9ggYIvcU5MIQyVVTEw8W9hvJynsIzj1KVdJZsHD\n\tJlvZqHpEcTJYEU3aEVvuJrEbQ6VfFOg=","X-MC-Unique":"V5spEUY1NImn6v35llKtVg-1","X-Mimecast-MFC-AGG-ID":"V5spEUY1NImn6v35llKtVg_1776674288","From":"David Howells ","To":"Christian Brauner ","Cc":"David Howells ,\n\tPaulo Alcantara ,\n\tnetfs@lists.linux.dev,\n\tlinux-afs@lists.infradead.org,\n\tlinux-cifs@vger.kernel.org,\n\tceph-devel@vger.kernel.org,\n\tlinux-fsdevel@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tMatthew Wilcox ","Subject":"[PATCH 11/11] netfs: Fix netfs_read_folio() to wait on writeback","Date":"Mon, 20 Apr 2026 09:37:02 +0100","Message-ID":"<20260420083705.1009074-12-dhowells@redhat.com>","In-Reply-To":"<20260420083705.1009074-1-dhowells@redhat.com>","References":"<20260420083705.1009074-1-dhowells@redhat.com>","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4"},"content":"Fix netfs_read_folio() to wait for an ongoing writeback to complete so that\nit can trust the dirty flag and whatever is attached to folio->private\n(folio->private may get cleaned up by the collector before it clears the\nwriteback flag).\n\nFixes: ee4cdf7ba857 (\"netfs: Speed up buffered reading\")\nCloses: https://sashiko.dev/#/patchset/20260414082004.3756080-1-dhowells%40redhat.com\nSigned-off-by: David Howells \ncc: Paulo Alcantara \ncc: Matthew Wilcox \ncc: netfs@lists.linux.dev\ncc: linux-fsdevel@vger.kernel.org\n---\n fs/netfs/buffered_read.c | 2 ++\n 1 file changed, 2 insertions(+)","diff":"diff --git a/fs/netfs/buffered_read.c b/fs/netfs/buffered_read.c\nindex 4d6dfcffba78..dcfe51eec266 100644\n--- a/fs/netfs/buffered_read.c\n+++ b/fs/netfs/buffered_read.c\n@@ -506,6 +506,8 @@ int netfs_read_folio(struct file *file, struct folio *folio)\n \tstruct netfs_inode *ctx = netfs_inode(mapping->host);\n \tint ret;\n \n+\tfolio_wait_writeback(folio);\n+\n \tif (folio_test_dirty(folio))\n \t\treturn netfs_read_gaps(file, folio);\n \n","prefixes":["11/11"]}