{"id":2225012,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2225012/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260420083705.1009074-11-dhowells@redhat.com/","project":{"id":12,"url":"http://patchwork.ozlabs.org/api/1.1/projects/12/?format=json","name":"Linux CIFS Client","link_name":"linux-cifs-client","list_id":"linux-cifs.vger.kernel.org","list_email":"linux-cifs@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260420083705.1009074-11-dhowells@redhat.com>","date":"2026-04-20T08:37:01","name":"[10/11] netfs: Fix comment about write-streaming avoidance","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"3e47493aa9d591e5775ffd02cdfb75a8659e9374","submitter":{"id":59,"url":"http://patchwork.ozlabs.org/api/1.1/people/59/?format=json","name":"David Howells","email":"dhowells@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260420083705.1009074-11-dhowells@redhat.com/mbox/","series":[{"id":500568,"url":"http://patchwork.ozlabs.org/api/1.1/series/500568/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=500568","date":"2026-04-20T08:36:52","name":"netfs: Further miscellaneous fixes","version":1,"mbox":"http://patchwork.ozlabs.org/series/500568/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2225012/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2225012/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=U08+HEfh;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-cifs+bounces-10933-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=\"U08+HEfh\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=170.10.129.124","smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=redhat.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=redhat.com"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzfF23hFKz1yGs\n\tfor ; Mon, 20 Apr 2026 18:44:54 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 3A9BB304624D\n\tfor ; Mon, 20 Apr 2026 08:39:05 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id D355638B7DD;\n\tMon, 20 Apr 2026 08:38:13 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B0CB393DC7\n\tfor ; Mon, 20 Apr 2026 08:38:12 +0000 (UTC)","from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-279-rfE_8BV6PwedqQ7uh3JVAw-1; Mon,\n 20 Apr 2026 04:38:05 -0400","from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 115EA195609F;\n\tMon, 20 Apr 2026 08:38:04 +0000 (UTC)","from warthog.procyon.org.com (unknown [10.44.48.17])\n\tby mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 1BDB8195608E;\n\tMon, 20 Apr 2026 08:38:00 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776674293; cv=none;\n b=SUj9B/QHv5YecygBZB220FfASC43eLMYKMa9ErjKDDYwtTybvHwdAQjw0iBipw0pj72aZA5rC09Cx4cHw6/nt6qoQVojs3FBiykAPZsqhaW0krczMmj6KVz37CNtGSds8mwl0wigC/ME6xAQd++KcyS2OGGy2a9kWEf7Ex98OVE=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776674293; c=relaxed/simple;\n\tbh=iWEKgr0fPS2LBwyZw/FU46u4D7VN/HA2cp40fXv2VUw=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=jnnAfciJhEri2Cq3alRPtWXoB/6GyTJ14MGDb3VecNCsAcctTQGsmQkU0hUcOM2q6BSHL5kMlocFUWVZ82RAZSa7zVxPSRY5vC2UU269z8wFePlc3C20Jo38lYQfpGJdhWE/mgyDMDCH5wrYaYCInZHN1sBi/fBfqDNUoAckBgE=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=redhat.com;\n spf=pass smtp.mailfrom=redhat.com;\n dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=U08+HEfh; arc=none smtp.client-ip=170.10.129.124","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1776674291;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\t to:to:cc:cc:mime-version:mime-version:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=73kY/18lwrFclzGx58kIFewTdVs+3oxIn+HO6KCOAHs=;\n\tb=U08+HEfh76Yv2Bd8g01n94verZExIuSeHAaZmMSfNxigam4LHQ1osi7MAlgZucn7ruSzVW\n\tb6YkvhkXmmkqjW2SCq3vka3ccMabloAYxEZ7GWZjBYxPSKIHjQQ1ERuc7l2sh0qZoDUcQd\n\t+O6YVoNU69PZTQYUM+xDYHTeuUpw6cY=","X-MC-Unique":"rfE_8BV6PwedqQ7uh3JVAw-1","X-Mimecast-MFC-AGG-ID":"rfE_8BV6PwedqQ7uh3JVAw_1776674284","From":"David Howells ","To":"Christian Brauner ","Cc":"David Howells ,\n\tPaulo Alcantara ,\n\tnetfs@lists.linux.dev,\n\tlinux-afs@lists.infradead.org,\n\tlinux-cifs@vger.kernel.org,\n\tceph-devel@vger.kernel.org,\n\tlinux-fsdevel@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tMatthew Wilcox ","Subject":"[PATCH 10/11] netfs: Fix comment about write-streaming avoidance","Date":"Mon, 20 Apr 2026 09:37:01 +0100","Message-ID":"<20260420083705.1009074-11-dhowells@redhat.com>","In-Reply-To":"<20260420083705.1009074-1-dhowells@redhat.com>","References":"<20260420083705.1009074-1-dhowells@redhat.com>","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.17"},"content":"In netfs_perform_write(), there used to be a section in which\nwrite-streaming was avoided if either the fd is open O_RDWR or fscaching is\nenabled, but the former was removed as netfs_read_folio() can now fill in\nthe gaps rather then flushing, but the comment was not updated.\n\nFix the comment to match.\n\nFixes: eac38f8a2b85 (\"netfs: Fix write streaming disablement if fd open O_RDWR\")\nCloses: https://sashiko.dev/#/patchset/20260414082004.3756080-1-dhowells%40redhat.com\nSigned-off-by: David Howells \ncc: Paulo Alcantara \ncc: Matthew Wilcox \ncc: netfs@lists.linux.dev\ncc: linux-fsdevel@vger.kernel.org\n---\n fs/netfs/buffered_write.c | 4 +---\n 1 file changed, 1 insertion(+), 3 deletions(-)","diff":"diff --git a/fs/netfs/buffered_write.c b/fs/netfs/buffered_write.c\nindex c840f5448178..2abf451c38f6 100644\n--- a/fs/netfs/buffered_write.c\n+++ b/fs/netfs/buffered_write.c\n@@ -278,9 +278,7 @@ ssize_t netfs_perform_write(struct kiocb *iocb, struct iov_iter *iter,\n \n \t\t/* We don't want to do a streaming write on a file that loses\n \t\t * caching service temporarily because the backing store got\n-\t\t * culled and we don't really want to get a streaming write on\n-\t\t * a file that's open for reading as ->read_folio() then has to\n-\t\t * be able to flush it.\n+\t\t * culled.\n \t\t */\n \t\tif (netfs_is_cache_enabled(ctx)) {\n \t\t\tif (finfo) {\n","prefixes":["10/11"]}