{"id":2224974,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2224974/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260420-virtio-fixups-v3-2-07aef1eff9d2@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260420-virtio-fixups-v3-2-07aef1eff9d2@linaro.org>","date":"2026-04-20T05:07:06","name":"[v3,2/2] virtio-snd: check for overflow before g_malloc0","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"91f3c69510feaae3ed24576e7477a25249acf46a","submitter":{"id":86526,"url":"http://patchwork.ozlabs.org/api/1.1/people/86526/?format=json","name":"Manos Pitsidianakis","email":"manos.pitsidianakis@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260420-virtio-fixups-v3-2-07aef1eff9d2@linaro.org/mbox/","series":[{"id":500552,"url":"http://patchwork.ozlabs.org/api/1.1/series/500552/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500552","date":"2026-04-20T05:07:04","name":"More virtio-snd fortifications/coverity fixes","version":3,"mbox":"http://patchwork.ozlabs.org/series/500552/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2224974/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2224974/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=GcH/W/zA;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzYRL3D48z1yJN\n\tfor ; Mon, 20 Apr 2026 15:08:30 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wEgqx-0004sC-Vf; Mon, 20 Apr 2026 01:07:24 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wEgqu-0004qY-BA\n for qemu-devel@nongnu.org; Mon, 20 Apr 2026 01:07:20 -0400","from mail-wm1-x332.google.com ([2a00:1450:4864:20::332])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wEgqr-0002az-E9\n for qemu-devel@nongnu.org; Mon, 20 Apr 2026 01:07:20 -0400","by mail-wm1-x332.google.com with SMTP id\n 5b1f17b1804b1-4891b0786beso5315555e9.1\n for ; Sun, 19 Apr 2026 22:07:13 -0700 (PDT)","from [127.0.1.1] (athedsl-4440559.home.otenet.gr. [79.129.177.223])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43fe4e3a341sm28886954f8f.24.2026.04.19.22.07.11\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 19 Apr 2026 22:07:11 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776661632; x=1777266432; darn=nongnu.org;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:from:to:cc:subject:date:message-id\n :reply-to; bh=BwyGpcxIm+U3udOJ+6cB8zSHqyzc689Y7MjRe26X6L4=;\n b=GcH/W/zAeLQow3QxMQbYzyn/3kS3G4TTxXtWSpHlpw0n1GDDYwSyjlP+Qb89ZbPnpi\n kY3hDWW7x2pJkUdDiRuoVxyP+wrF2c1iISdtp5R5wmU/8kt4gbedCfbYwA2cIHc0iP40\n CCA0HhgRWy0F1YZUV9M/PnTDkoZa3ciUwQy0PNaoToxOvRNc+0V6VoteOFbQ5TP3r6Ve\n Z6/qeeGMthd0O/e6EgioECkf4hi/7wB4hm+Gqt4oeLDEpmqQrwO4q+GyXIdy5RboNnDu\n 436rWmkmvijJU3UDvmCSiV4KaTtWBssG4vVXuqILMjt+INdO02PSJSYxZVPwUuzoB/m8\n mBkQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776661632; x=1777266432;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=BwyGpcxIm+U3udOJ+6cB8zSHqyzc689Y7MjRe26X6L4=;\n b=bDXcwLI91sh+xcv2jo1CZLCxTxnb8D7hKegCVVYXFaGmA0FGK/qqoPf+wrh2DFsCqV\n i0wX5lPQwwdNwhdEK452yrEdjwrdJ4kG3fdoxDmGttjJ2JuMkRMX6nCEKk9EVoeMiAo8\n b6oL8FeNT254FmeYMOr1QLqmljZVxC+VxBOa5JQnBh3YGQc/GK8MoK6yiMKWFB478NEi\n ImwKxtjKD5mVKPAt31H3BdkCOm+gfKTC1cO2/azwCGMLXSw3peSBs9nbVzbepsYbec+M\n lYxHmp/PCgJGAWBpqSK091RPuzpQV6q4VahCMwWUjcvN8tB4NFY/vYH2nVmzcTCgFH00\n Oz1Q==","X-Gm-Message-State":"AOJu0Yz43QU/scTIogfiDaMc15Ec27dX726m3LkdmWKfkbQraMPSbfWi\n N0PimOCOlHCQLrxBBx1wVLek0YeaKpCN7H+IQdlz4zaYq+u8oy1f7iMHmFVz68KgkQBUgyLYMiU\n J2k5s7i8=","X-Gm-Gg":"AeBDieuYUyMYBOv3vMrBMQzK4XoKJOfDU5hIi0J8SRmKXVHdvHpJL7+8Px35cXx5pnA\n PwanH6bpYHE02Jm289IlwPBKZqLFqgA8P5/QnrpIVaxCJmQoU3PURK9JDc6WeK/urKKvWchE6gx\n PWQ/Cr1JXB77kggdbL30yJEhaKTu5DXoxJ6Ib117oZzBIpM/o9Exp7yr8WvTkxDWJOKLsq4q98H\n SR1AphJ5MISF7lXDYNsorpIZoqtGOAp3O/PWNILnF7GLFoPl9VCIfwyWWJCt1jhRJDlTO0GY53s\n X+kunBlNZbRRMQo00ccxwV4r1ZqyQpoH8uC74PZyg2jQ4zYd5VQP7rj50oO5WZv6nyjshOuI8EH\n LyTgQNODkz0bdWepNoVYo40j5juVnsAqKchzRkm7nvgVwsOGs4l2g0UnDQIS9KNBFP/QvzqLD2w\n dEnEBKLxHs2FWaGUZ3znFYDZZOrbd9+NojlMHA2yla5y3H/ymg7x2UmDlir/glzk14kOCQFetgn\n Yi45ZxDCBbx/qhtoRo1W1SV3NRiy2kdiwwDB7IJ0osb7m9Nx20=","X-Received":"by 2002:a05:600c:3110:b0:488:8c89:cfaa with SMTP id\n 5b1f17b1804b1-488fb73841dmr178046755e9.3.1776661631947;\n Sun, 19 Apr 2026 22:07:11 -0700 (PDT)","From":"Manos Pitsidianakis ","Date":"Mon, 20 Apr 2026 08:07:06 +0300","Subject":"[PATCH v3 2/2] virtio-snd: check for overflow before g_malloc0","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260420-virtio-fixups-v3-2-07aef1eff9d2@linaro.org>","References":"<20260420-virtio-fixups-v3-0-07aef1eff9d2@linaro.org>","In-Reply-To":"<20260420-virtio-fixups-v3-0-07aef1eff9d2@linaro.org>","To":"qemu-devel@nongnu.org","Cc":"Gerd Hoffmann , \"Michael S. Tsirkin\" ,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , =?utf-8?q?Alex?=\n\t=?utf-8?q?_Benn=C3=A9e?= ,\n Richard Henderson , qemu-stable@nongnu.org,\n Manos Pitsidianakis ","X-Mailer":"b4 0.14.2","X-Developer-Signature":"v=1; a=openpgp-sha256; l=2786;\n i=manos.pitsidianakis@linaro.org; h=from:subject:message-id;\n bh=+9Dhd+SEfK8bKKIwFEcKs73DtTFYq0bCyKTuZMmWZ7Q=;\n b=LS0tLS1CRUdJTiBQR1AgTUVTU0FHRS0tLS0tCgpvd0VCYlFLUy9aQU5Bd0FLQVhjcHgzQi9mZ\n 25RQWNzbVlnQnA1YlI4NnVkVmgzd01BeGxRZ2dVZEVhV3d1ZTUwCjRiMkxXZGFsbG5zd3ZOcWhj\n TnFKQWpNRUFBRUtBQjBXSVFUTVhCdE9SS0JXODRkd0hSQjNLY2R3ZjM0SjBBVUMKYWVXMGZBQUt\n DUkIzS2Nkd2YzNEowQjFCRC85dHBlMVNiclVEOHJ4cmJuVGlvVXFGdmJvNGNldjVZRVNTaTU1VQ\n p5c1o4UHpBcjU2cDFwdkJ6R0o5NEhYNFVCeWVRMVBTS2M0cXljNGYxUVNMQWJqbVkyZVhmTFp2V\n U56ckxnWG05ClpEZmM0dWdnbHBSWE1Ha2t6UFN2TUFybWMxcjQ1UVNXZkFtT2pGdGkyTngvb1R6\n ZVREcm43L2ZqWC8zZ24rOVQKZzJYKy9HazRuR2pJQmFMOEcrTWhTQklIZVdhMkQ5RWxFaSsyWUc\n rbUJkUEhySVpBRXJJVzdTSFRNeTJ0TUs1Rwp4SVQ0alN5TThxYVNJaUNVRXk1SHhQK0dkOFFmVz\n NRUnp1UzA2R2hNbmxVNmo0NmUzR3F3QnA2ak00eU8vbE0wCkJDQXY0V3VQYlF0c0Q1Z3dmQlhEa\n XYyV3FONURicVRqRjNyQkk2MUVIdHZEOSs3OW5tUzE2TnpMWml6VGd5cTMKQzVqTXBxZGZRUUR1\n Q2NuTCtCb011REw1UGE2MTNieUtVdjdzd3pyVnZja2kvMnNmYy9UMU5PcDZ5S0trZkJkZwovOEV\n vN1dxNXd4S09na0t1ODFYYjgzU0xpcDJpc1lvb1gzOXNZd0xjZ3l3S3F6b2JCUDJvUE1CaERTNS\n t5Mk1ECkN5M0t2ZEgySnprUHlCb3p2azlZdVh6RmFLUTRDNEJyYXhHVFpSRlJMRzUza1JpZytOO\n C9ESTVmcjdTdnNrSlcKSk10VWJQZWtraUF0K1hvTzJVZzdPdWVLVHNEZ3pFOTIxZnVVUk15aVM5\n QnErWUQwMGlUaHo4T1h3Q1lsT2JMMQo3RHVjY0J4cW15VXNmbEdxYXYzLzMzWGtsajNSSHF0YlV\n 1R3NRZG1tQWZHS0FpY3RCNFUwRGYrckNpdlF4dWV6CkkvOC9ndz09Cj1qUDJVCi0tLS0tRU5EIF\n BHUCBNRVNTQUdFLS0tLS0K","X-Developer-Key":"i=manos.pitsidianakis@linaro.org; a=openpgp;\n fpr=7C721DF9DB3CC7182311C0BF68BC211D47B421E1","Received-SPF":"pass client-ip=2a00:1450:4864:20::332;\n envelope-from=manos.pitsidianakis@linaro.org; helo=mail-wm1-x332.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Coverity points out one g_malloc0 overflow, but it seems to be a false\npositive. Add a check to it regardless to fortify the code, and also add\nchecks for every other g_malloc0 use.\n\nResolves: Coverity CID 1547527\nSigned-off-by: Manos Pitsidianakis \n---\n hw/audio/virtio-snd.c | 16 ++++++++++++----\n 1 file changed, 12 insertions(+), 4 deletions(-)","diff":"diff --git a/hw/audio/virtio-snd.c b/hw/audio/virtio-snd.c\nindex 93fbcfb43f7fdcfd5c164b496015da743822f5eb..694bcebb60f6c866346470672cc798b3271ae34f 100644\n--- a/hw/audio/virtio-snd.c\n+++ b/hw/audio/virtio-snd.c\n@@ -850,7 +850,7 @@ static void virtio_snd_handle_tx_xfer(VirtIODevice *vdev, VirtQueue *vq)\n VirtIOSound *vsnd = VIRTIO_SND(vdev);\n VirtIOSoundPCMBuffer *buffer;\n VirtQueueElement *elem;\n- size_t msg_sz, size;\n+ size_t msg_sz, size, tmp;\n virtio_snd_pcm_xfer hdr;\n uint32_t stream_id;\n /*\n@@ -880,6 +880,8 @@ static void virtio_snd_handle_tx_xfer(VirtIODevice *vdev, VirtQueue *vq)\n if (msg_sz != sizeof(virtio_snd_pcm_xfer)) {\n goto tx_err;\n }\n+ assert(iov_size(elem->out_sg, elem->out_num) >= msg_sz);\n+ size = iov_size(elem->out_sg, elem->out_num) - msg_sz;\n stream_id = le32_to_cpu(hdr.stream_id);\n \n if (stream_id >= vsnd->snd_conf.streams\n@@ -892,9 +894,11 @@ static void virtio_snd_handle_tx_xfer(VirtIODevice *vdev, VirtQueue *vq)\n goto tx_err;\n }\n \n+ /* Check for g_malloc0 overflow. */\n+ if (!g_size_checked_add(&tmp, sizeof(VirtIOSoundPCMBuffer), size)) {\n+ goto tx_err;\n+ }\n WITH_QEMU_LOCK_GUARD(&stream->queue_mutex) {\n- size = iov_size(elem->out_sg, elem->out_num) - msg_sz;\n-\n buffer = g_malloc0(sizeof(VirtIOSoundPCMBuffer) + size);\n buffer->elem = elem;\n buffer->populated = false;\n@@ -932,7 +936,7 @@ static void virtio_snd_handle_rx_xfer(VirtIODevice *vdev, VirtQueue *vq)\n VirtIOSound *vsnd = VIRTIO_SND(vdev);\n VirtIOSoundPCMBuffer *buffer;\n VirtQueueElement *elem;\n- size_t msg_sz, size;\n+ size_t msg_sz, size, tmp;\n virtio_snd_pcm_xfer hdr;\n uint32_t stream_id;\n /*\n@@ -977,6 +981,10 @@ static void virtio_snd_handle_rx_xfer(VirtIODevice *vdev, VirtQueue *vq)\n goto rx_err;\n }\n size -= sizeof(virtio_snd_pcm_status);\n+ /* Check for g_malloc0 overflow. */\n+ if (!g_size_checked_add(&tmp, sizeof(VirtIOSoundPCMBuffer), size)) {\n+ goto rx_err;\n+ }\n WITH_QEMU_LOCK_GUARD(&stream->queue_mutex) {\n buffer = g_malloc0(sizeof(VirtIOSoundPCMBuffer) + size);\n buffer->elem = elem;\n","prefixes":["v3","2/2"]}