{"id":2224900,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2224900/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260419130139.15554-6-alexander@mihalicyn.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260419130139.15554-6-alexander@mihalicyn.com>","date":"2026-04-19T13:01:36","name":"[v6,5/8] hw/nvme: unmap req->sg earlier in nvme_enqueue_req_completion","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"7ea320aeb58fb4461afbb6c7f58fd6c4d5814240","submitter":{"id":81630,"url":"http://patchwork.ozlabs.org/api/1.1/people/81630/?format=json","name":"Alexander Mikhalitsyn","email":"alexander@mihalicyn.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260419130139.15554-6-alexander@mihalicyn.com/mbox/","series":[{"id":500500,"url":"http://patchwork.ozlabs.org/api/1.1/series/500500/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500500","date":"2026-04-19T13:01:32","name":"hw/nvme: add basic live migration support","version":6,"mbox":"http://patchwork.ozlabs.org/series/500500/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2224900/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2224900/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n secure) header.d=mihalicyn.com header.i=@mihalicyn.com header.a=rsa-sha256\n header.s=mihalicyn header.b=idPypAc9;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fz82P0HdWz1yD4\n\tfor ; Sun, 19 Apr 2026 23:03:56 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wERnD-00013w-MW; Sun, 19 Apr 2026 09:02:32 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wERmk-0000u8-He\n for qemu-devel@nongnu.org; Sun, 19 Apr 2026 09:02:05 -0400","from mail-wr1-x429.google.com ([2a00:1450:4864:20::429])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wERmc-0008Jr-Cn\n for qemu-devel@nongnu.org; Sun, 19 Apr 2026 09:01:59 -0400","by mail-wr1-x429.google.com with SMTP id\n ffacd0b85a97d-43d64313c39so1680202f8f.3\n for ; Sun, 19 Apr 2026 06:01:48 -0700 (PDT)","from alex-laptop.lan\n (p200300cf57228c00995e4e0d3496e07b.dip0.t-ipconnect.de.\n [2003:cf:5722:8c00:995e:4e0d:3496:e07b])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43fe4cc2cacsm20734304f8f.13.2026.04.19.06.01.46\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 19 Apr 2026 06:01:47 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=mihalicyn.com; s=mihalicyn; t=1776603708; x=1777208508; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=HQw+kuVjtbO6TkwAkF7eczBsBb+4xiQrsikCv0Jap6c=;\n b=idPypAc9pa6wpOoAO+u1Ftp5iX0eqYyNLBzIzCCDYsMqIIwz7891i116pX+4bPmZPs\n ynRbyMsKUorTt8En7GpI8m7tuCn6lXBHdhK9ZPZdeR6omr2eB2Rbq7NFYoMIgV8tw9CE\n 1BBC7NWGVWf838tAPJzd7V0pddXz+1Z7aNjXo=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776603708; x=1777208508;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=HQw+kuVjtbO6TkwAkF7eczBsBb+4xiQrsikCv0Jap6c=;\n b=fp/CJ0PSquclpZ2oEsYqoQhCqEhlWoTn+g+0jMlyIVsddVzBS5N59hU5X3ed6vk0OB\n ai/i8JjKcrSZ6JJundeUgteg/nI7NrK5HgIr7WEnfowIkVmCkJvGT9Xh1Vch/mbtlcB4\n 2grMhGSsED11LHHSwQZlVnFEOma/OQEXpESfUNDiSw/hd3DEUJ0HbGfuuRNIL0M5Rduv\n U3OL/FO25R6QpXakwxs/0LPLNB16BjGbTJkrTM1bxFC64HnLrtwMhglvWy8IYhFzThqh\n T4SUfLm5ivpB5P0QszZvqwCgg7zrVdg6BFubq79fXWIhXMIPB+4ffRMGDFOZmh0AJ1dl\n soQQ==","X-Gm-Message-State":"AOJu0YxWo72yA7479kVgQ2EyaosciAsqSdJiPnqN8fixsBIR2CHtOe52\n MX4Izyj+cFuw6J8UpIsQv4u4GN6VJjrjcPJ1LPuwuawK6EYvy7O83wYvLrqu2CFtBXP10aMT4bl\n c0P7YbU0=","X-Gm-Gg":"AeBDiev8FVd6fNeDLtnRuT8JrFHMYdLm9shE7RrxD3L/Coih6Mv9Wy6gzrpgnnCVJWv\n 7EC5kRAWDXEDV77GyI+kRmN/nK/PcauQ/f4/DmGyzyhq7rPMzvBjdWa7V07nVUAoQmtv46Pl4A8\n 1zokkYWRUFVqgCZeGbcEPd3VXrVUZMlmhSCxY/iFbCeXDBTR5J1YMt6iXUMAKkWsjOe6HQyHJaP\n NOasl9c7udezMZySPiihsiPEJsz63Q2g+OazsZMjqeaYVmIF/rnCZgKTqz6kguXCBM8klrWznje\n n2xiuhERWKZMbnw+m4gWlVigtn2d6kFPMXVPiahM18oOaeD5aEoGYDmyP7DYSr/wAMxlcImLMmD\n 1Vemy0tZ0C0VuplEedVL+1RPwfp3Slz8w1eNNNh4FSiKeUVVK5igxdNSbZ55UrrCW8ALHELntQc\n GoPZmb3i4SSVtXEsbL7ISv9SUnOLTi3yweddldEGeWlBv629ci8cY0J0Yy91R3zDhJBMHWgNr0w\n AiaSTTv2EMc1pFhy46hCSCvjg+y6LT95Q==","X-Received":"by 2002:a05:6000:25c4:b0:43b:8f56:1e1d with SMTP id\n ffacd0b85a97d-43fe3dc10demr14095668f8f.13.1776603707596;\n Sun, 19 Apr 2026 06:01:47 -0700 (PDT)","From":"Alexander Mikhalitsyn ","To":"qemu-devel@nongnu.org","Cc":"Alexander Mikhalitsyn ,\n Kevin Wolf , qemu-block@nongnu.org,\n Fam Zheng ,\n =?utf-8?q?St=C3=A9phane_Graber?= , =?utf-8?q?Philipp?=\n\t=?utf-8?q?e_Mathieu-Daud=C3=A9?= ,\n Paolo Bonzini , Stefan Hajnoczi ,\n Laurent Vivier , Jesper Devantier ,\n Klaus Jensen , Fabiano Rosas ,\n Zhao Liu , Keith Busch ,\n Peter Xu , Hanna Reitz ,\n Alexander Mikhalitsyn ","Subject":"[PATCH v6 5/8] hw/nvme: unmap req->sg earlier in\n nvme_enqueue_req_completion","Date":"Sun, 19 Apr 2026 15:01:36 +0200","Message-ID":"<20260419130139.15554-6-alexander@mihalicyn.com>","X-Mailer":"git-send-email 2.47.3","In-Reply-To":"<20260419130139.15554-1-alexander@mihalicyn.com>","References":"<20260419130139.15554-1-alexander@mihalicyn.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::429;\n envelope-from=alexander@mihalicyn.com; helo=mail-wr1-x429.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Alexander Mikhalitsyn \n\nInstead of unmapping req->sg in nvme_post_cqes(), we can do it earlier in\nnvme_enqueue_req_completion(). When req completion is enqueued we don't\nneed to access req->sg anymore. We only care about req->sq, req->cqe and\nreq->status.\n\nSigned-off-by: Alexander Mikhalitsyn \n---\n hw/nvme/ctrl.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c\nindex d9bf32bff2c..1ff91493b60 100644\n--- a/hw/nvme/ctrl.c\n+++ b/hw/nvme/ctrl.c\n@@ -1534,7 +1534,6 @@ static void nvme_post_cqes(void *opaque)\n QTAILQ_REMOVE(&cq->req_list, req, entry);\n \n nvme_inc_cq_tail(cq);\n- nvme_sg_unmap(&req->sg);\n \n if (QTAILQ_EMPTY(&sq->req_list) && !nvme_sq_empty(sq)) {\n qemu_bh_schedule(sq->bh);\n@@ -1564,6 +1563,8 @@ static void nvme_enqueue_req_completion(NvmeCQueue *cq, NvmeRequest *req)\n req->status, req->cmd.opcode);\n }\n \n+ nvme_sg_unmap(&req->sg);\n+\n QTAILQ_REMOVE(&req->sq->out_req_list, req, entry);\n QTAILQ_INSERT_TAIL(&cq->req_list, req, entry);\n \n","prefixes":["v6","5/8"]}