{"id":2224894,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2224894/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260419130139.15554-2-alexander@mihalicyn.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260419130139.15554-2-alexander@mihalicyn.com>","date":"2026-04-19T13:01:32","name":"[v6,1/8] tests/functional/migration: add VM launch/configure hooks","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"cdf88bd00349f866a412707c602f907ed3af1d3a","submitter":{"id":81630,"url":"http://patchwork.ozlabs.org/api/1.1/people/81630/?format=json","name":"Alexander Mikhalitsyn","email":"alexander@mihalicyn.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260419130139.15554-2-alexander@mihalicyn.com/mbox/","series":[{"id":500500,"url":"http://patchwork.ozlabs.org/api/1.1/series/500500/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500500","date":"2026-04-19T13:01:32","name":"hw/nvme: add basic live migration support","version":6,"mbox":"http://patchwork.ozlabs.org/series/500500/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2224894/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2224894/checks/","tags":{},"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n secure) header.d=mihalicyn.com header.i=@mihalicyn.com header.a=rsa-sha256\n header.s=mihalicyn header.b=Wz5mhKN5;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fz81K2qS1z1yD4\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 19 Apr 2026 23:02:59 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wERmz-0000xD-8z; Sun, 19 Apr 2026 09:02:19 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <alexander@mihalicyn.com>)\n id 1wERme-0000tm-Uc\n for qemu-devel@nongnu.org; Sun, 19 Apr 2026 09:02:00 -0400","from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <alexander@mihalicyn.com>)\n id 1wERmX-0008IU-RU\n for qemu-devel@nongnu.org; Sun, 19 Apr 2026 09:01:54 -0400","by mail-wr1-x42e.google.com with SMTP id\n ffacd0b85a97d-43d734223e4so1419024f8f.0\n for <qemu-devel@nongnu.org>; Sun, 19 Apr 2026 06:01:44 -0700 (PDT)","from alex-laptop.lan\n (p200300cf57228c00995e4e0d3496e07b.dip0.t-ipconnect.de.\n [2003:cf:5722:8c00:995e:4e0d:3496:e07b])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43fe4cc2cacsm20734304f8f.13.2026.04.19.06.01.41\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 19 Apr 2026 06:01:42 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=mihalicyn.com; s=mihalicyn; t=1776603703; x=1777208503; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=9OztW63tvsDLU5EHuMGMvPzYUtmXl7GocMNqQvsnffQ=;\n b=Wz5mhKN5kiETJuPc4AHKD8m/D1YkXPnp3OBO1+96VTJ5Kc0zHNSFuZUDMHe6mIKl3T\n fkKd5Dqq0CT4KOWrNzIATEfSinAJNTlaojLcQd0bPkDnM272Y01EemNam0HsIMbA9X5l\n 40bacxg5Yt4H9KmfYAsLdA7gc1nY3BAYQ0/+Y=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776603703; x=1777208503;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=9OztW63tvsDLU5EHuMGMvPzYUtmXl7GocMNqQvsnffQ=;\n b=Em7/hcpNh13wFXn4ElSfSqCTvwSuDP7CLacsqXhbYIaTieoxVAeyKKy9yv6/UeBbw0\n 6zog2N1Ak51do4uaadV7hL62fSjJ3kPzCOX3Ik9B0WbFTKXzbXf3gAAyh6ew1iN6Etq5\n bh4RAMeLwsBtZNG7xHpkWXyP1KRgM6PCnM+CoMDHpUv4CY5LGO1B72dl+3m6VX4uZUIv\n 6SOr2Zx23i5j9LvMLEqLjq00XoA21xe2FjXpD0ueMm9gVn2+YWEBrKWIKvsF0z2R1swF\n dgrBWQ550jg0pmlijcMQhQN/GMYt3Qub6L5Krp4ILAgSTlJr9W/2pSvhiICo9abSWeZZ\n 8CZQ==","X-Gm-Message-State":"AOJu0YyaqU7GbGuobZbCEhw8/uITdeObJqMrjF6Z7UNiQtqFOA8C8lsY\n Fc3O2VF4O5CHAoJbO21uSMYYs7J5gxQW9y0dh6SvW85iZUcI41u6+CyRdBA/TICCKJBdiV4cuAU\n DKgsL2Os=","X-Gm-Gg":"AeBDieuP61Bx1wRJv4E/cxi+BBOuBZVkb+2X84FThCTGupxGzjxppHzHzrxq0oTQgIt\n kK3CtwxBOq1XnItqGZliCXonhrL6WJsZxxdvLVD0QNI46D9c+iVgi/Pr6k3vrgr06J9XzViYUom\n bB2rJs68xvUACajWe1FYGxAGDEfFYRHEFdYV/O1t0yXEs0DFTUHydK43Mk7OK8BZKH+K10ExREt\n 6HXS/OhcXK5eOEqz7Pm8B/4KpCulpK9DYpUun35KrRBhuxXMID9+lob1hwmUtiadbs1J6guNun7\n QaGDi+tifYbjBKhlGbYqME8zfkC0IPK8AnumdWH7dhqDUs/h7g/ycW8kqBOCmzky0yHVd/7cXFe\n Jy26st/jz3+mv3d5KQRl/X6TZv2hCE9vpRfjS3hTLLxoeDZjPuPtY3DAFfUzyTIKVmL0kCZ9M6m\n YsMMxmIg3V5Ru6h65m1MQ/K/hjClZpTNPxQUiYM3h6Mtzf0A3SlDFsDtLkMOILsnI533KFvrdM6\n bJuhHQ5SOuDvMPSw51UA2/x952X4FYTSA==","X-Received":"by 2002:a5d:64e5:0:b0:43d:7606:5a47 with SMTP id\n ffacd0b85a97d-43fe3f358a5mr14523615f8f.2.1776603703174;\n Sun, 19 Apr 2026 06:01:43 -0700 (PDT)","From":"Alexander Mikhalitsyn <alexander@mihalicyn.com>","To":"qemu-devel@nongnu.org","Cc":"Alexander Mikhalitsyn <alexander@mihalicyn.com>,\n Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org,\n Fam Zheng <fam@euphon.net>,\n =?utf-8?q?St=C3=A9phane_Graber?= <stgraber@stgraber.org>, =?utf-8?q?Philipp?=\n\t=?utf-8?q?e_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n Paolo Bonzini <pbonzini@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>,\n Laurent Vivier <lvivier@redhat.com>, Jesper Devantier <foss@defmacro.it>,\n Klaus Jensen <its@irrelevant.dk>, Fabiano Rosas <farosas@suse.de>,\n Zhao Liu <zhao1.liu@intel.com>, Keith Busch <kbusch@kernel.org>,\n Peter Xu <peterx@redhat.com>, Hanna Reitz <hreitz@redhat.com>,\n Alexander Mikhalitsyn <aleksandr.mikhalitsyn@futurfusion.io>","Subject":"[PATCH v6 1/8] tests/functional/migration: add VM launch/configure\n hooks","Date":"Sun, 19 Apr 2026 15:01:32 +0200","Message-ID":"<20260419130139.15554-2-alexander@mihalicyn.com>","X-Mailer":"git-send-email 2.47.3","In-Reply-To":"<20260419130139.15554-1-alexander@mihalicyn.com>","References":"<20260419130139.15554-1-alexander@mihalicyn.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::42e;\n envelope-from=alexander@mihalicyn.com; helo=mail-wr1-x42e.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@futurfusion.io>\n\nIntroduce configure_machine, launch_source_vm and assert_dest_vm\nmethods to allow child classes to override some pieces of\nsource/dest VMs creation, start and check logic.\n\nSigned-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@futurfusion.io>\n---\n tests/functional/migration.py | 22 +++++++++++++++++++---\n 1 file changed, 19 insertions(+), 3 deletions(-)","diff":"diff --git a/tests/functional/migration.py b/tests/functional/migration.py\nindex 2395119d6c6..9b5b31efe3e 100644\n--- a/tests/functional/migration.py\n+++ b/tests/functional/migration.py\n@@ -40,19 +40,35 @@ def assert_migration(self, src_vm, dst_vm):\n         self.assertEqual(dst_vm.cmd('query-status')['status'], 'running')\n         self.assertEqual(src_vm.cmd('query-status')['status'],'postmigrate')\n \n+    # Can be overridden by subclasses to configure both source/dest VMs.\n+    def configure_machine(self, vm):\n+        vm.add_args('-nodefaults')\n+\n+    # Can be overridden by subclasses to prepare the source VM before migration,\n+    # e.g. by running some workload inside the source VM to see if it continues\n+    # to run properly after migration.\n+    def launch_source_vm(self, vm):\n+        vm.launch()\n+\n+    # Can be overridden by subclasses to check the destination VM after migration,\n+    # e.g. by checking if the workload is still running after migration.\n+    def assert_dest_vm(self, vm):\n+        pass\n+\n     def migrate_vms(self, dst_uri, src_uri, dst_vm, src_vm):\n         dst_vm.qmp('migrate-incoming', uri=dst_uri)\n         src_vm.qmp('migrate', uri=src_uri)\n         self.assert_migration(src_vm, dst_vm)\n+        self.assert_dest_vm(dst_vm)\n \n     def migrate(self, dst_uri, src_uri=None):\n         dst_vm = self.get_vm('-incoming', 'defer', name=\"dst-qemu\")\n-        dst_vm.add_args('-nodefaults')\n+        self.configure_machine(dst_vm)\n         dst_vm.launch()\n \n         src_vm = self.get_vm(name=\"src-qemu\")\n-        src_vm.add_args('-nodefaults')\n-        src_vm.launch()\n+        self.configure_machine(src_vm)\n+        self.launch_source_vm(src_vm)\n \n         if src_uri is None:\n             src_uri = dst_uri\n","prefixes":["v6","1/8"]}