{"id":2224888,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2224888/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260419110255.2477785-3-charsyam@gmail.com/","project":{"id":12,"url":"http://patchwork.ozlabs.org/api/1.1/projects/12/?format=json","name":"Linux CIFS Client","link_name":"linux-cifs-client","list_id":"linux-cifs.vger.kernel.org","list_email":"linux-cifs@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260419110255.2477785-3-charsyam@gmail.com>","date":"2026-04-19T11:02:55","name":"[2/2] ksmbd: destroy async_ida in ksmbd_conn_free()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"4991552fd4b201bff870762a80a381cba2fb1d0f","submitter":{"id":93166,"url":"http://patchwork.ozlabs.org/api/1.1/people/93166/?format=json","name":"DaeMyung Kang","email":"charsyam@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260419110255.2477785-3-charsyam@gmail.com/mbox/","series":[{"id":500494,"url":"http://patchwork.ozlabs.org/api/1.1/series/500494/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=500494","date":"2026-04-19T11:02:53","name":"ksmbd: pair ida_init() with ida_destroy() in cleanup paths","version":1,"mbox":"http://patchwork.ozlabs.org/series/500494/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2224888/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2224888/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=JpLeJ91x;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-cifs+bounces-10915-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"JpLeJ91x\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.216.49","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fz5Mt6gsJz1yGs\n\tfor ; Sun, 19 Apr 2026 21:03:54 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 13AC3301C931\n\tfor ; Sun, 19 Apr 2026 11:03:15 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 65A6D3254B8;\n\tSun, 19 Apr 2026 11:03:08 +0000 (UTC)","from mail-pj1-f49.google.com (mail-pj1-f49.google.com\n [209.85.216.49])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 33A8C33D4EC\n\tfor ; Sun, 19 Apr 2026 11:03:07 +0000 (UTC)","by mail-pj1-f49.google.com with SMTP id\n 98e67ed59e1d1-358dff8447cso375132a91.0\n for ;\n Sun, 19 Apr 2026 04:03:07 -0700 (PDT)","from ser8.. ([221.156.231.192])\n by smtp.gmail.com with ESMTPSA id\n 41be03b00d2f7-c797703059fsm5527972a12.24.2026.04.19.04.03.04\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 19 Apr 2026 04:03:06 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776596588; cv=none;\n b=eFien8Sv5AvwkKUOgoFJEt/XbI7Gtf1Hx72zrZr6pU+cZCaIrG3acHhrBpbRHaEYiAviCHmpboPeNQH/MphQNrrT69hHA/DVMS/M2MzsO0/a1Pm4EOl83ITGr+er1Ftw6beFcaDCduZ5QSOXlHhdXaO/IBnzq7tE2SKzfbiCJ/4=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776596588; c=relaxed/simple;\n\tbh=VyK4kxf1xc0HknGrvHpp7IfOxieIEAAxS73/8cca4bQ=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=BVDg/r1K+BkXPSEx2Jz+wRZgUH3Ap208tLr8BT3PI6/k/PrRWA6S+L8mQAi1H0i38JESoi0eqxsIPeqaf/qy1F2QlFs0nQS/Ek/Ic0US6+1FDaNxNFlVNRl2++O/wongsrgprnKndPCznOdg1X9XbdsVo+4HnoHkz7KbZDI/+4w=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=JpLeJ91x; arc=none smtp.client-ip=209.85.216.49","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776596586; x=1777201386;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=9DyStktkJgiHhlYyQA1PqDFemYtpoFBPyefLrK+uytk=;\n b=JpLeJ91xQvRPNzdxliKy0sKpi6YBzMjAUzWtL8AtBlA1ck/npt444vhx3Y/Fmp3VpO\n 2J0fQiSVXGQART1V02JV6S5jZF/3eDuFW0N3jMEGLjTijq28zmpHe0efuA9I/NdTg1yv\n p0ldn2KfR53nWmWLKNx3ZI+BzTkl8rYyAe300qou7UsEtzDAC25Swj1xuuMinES72IYs\n 61T2KJXXzV6KWv30o1+KFShjoYtG2nAEmBfOMv8ze5yM1c4ixwl3MtXDItAEbQkir1GQ\n 65QfXPVazFYloKYotjgov4OiCDVgU3x4ZQG8Y8ZvLMy27Us52ps0TBlFrqt90Besuc6/\n Wslw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776596586; x=1777201386;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=9DyStktkJgiHhlYyQA1PqDFemYtpoFBPyefLrK+uytk=;\n b=BMK/1kZUGQ4Bm8R+ZVFKPIlx4e0A2VJuR5gnSS/zRxsmTfBOxzuxG/anyAclhxhnAC\n W3EINKjskAbjO7tTnPMXy+vNXaHWvEc211K8kP7R7Rb/M1gFgsNpfb7wZTzGeMFg+GxI\n UOOPBuS12cYBo+KBaCZ5chMq9dwIVYIsepPQretS/xboCDLD9JiPIaxJdnIjxXzKSZ62\n pBm4oinQyZCQoNcqK6Y0Xi5ZfbRfpq4d0EE6BtoKk/TmAirL8MY28LjX3glUoWJndKi+\n wwNUWCie4mzHtOAvC21qwpxHMY+ameHGBvs/82vF7dQkgxCcZvMj6caFqAYZ4qXGdLE3\n 0X5Q==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+eeEYQ4/PNREszqsPnUbPkLkqS0Iuy86OvnlXv4F+ViHTVsPEJjd4aq/PkmKDAHZrRRs+A1HHZ1Omz@vger.kernel.org","X-Gm-Message-State":"AOJu0YwKptISjZ1+bwaQkT5g2mEZW426UbIy12BYKlBkPQ8Yz6PYZxiQ\n\tE0ciW9fybIJ9dUl+vJZBteIs3Tpwb6IB0PZnWGU6CnjTahoDw6JMI91L","X-Gm-Gg":"AeBDiesF/tvZIXQi4kS3HmWWOthK9L9VIdcg4Rw/kskNxquITjqO0XksVjOzC7Z+9mB\n\tB5O5QRigMazxhicjtpGSQLtqfUnd4XZSO9CQKG+HLcwIfeVWYYWhVyCHNl0Hy1tR/TTsPaSeWpy\n\tcCFcX9TCH2tK40ft7+KpoUypoLaZgeRlqGTR2/OwiyLVcgJCmLA+eCAdGi9IB9dGwwesTeBuqpK\n\tqROILIzRvj9Xy+cb9v38IYczyA4znRdiKMQSxZexMYz00z4MnovSE7fpEgkq7/B8jLBMTz65j/Z\n\tCbdv4JzqhUSH1vfDyqb6z+e3DQhzq7zb8ZxYWdPDsEpcOGPxS7JU32M8GX2rszHwj1V+nkL17kG\n\tt3yFakU9CNB7z6P6T3KhvriRAh4X3gNN+Vi9/qD3Pdeem1webcpfk48d3PS/uKm7hxWnxbSIXZR\n\tCCB63RTTpHFZS/v74nnlN4IeoEhzM=","X-Received":"by 2002:a17:90b:4ccf:b0:35f:bd83:38c2 with SMTP id\n 98e67ed59e1d1-361403a686cmr5421740a91.1.1776596586452;\n Sun, 19 Apr 2026 04:03:06 -0700 (PDT)","From":"DaeMyung Kang ","To":"Namjae Jeon ","Cc":"Steve French ,\n\tSergey Senozhatsky ,\n\tTom Talpey ,\n\tlinux-cifs@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tDaeMyung Kang ","Subject":"[PATCH 2/2] ksmbd: destroy async_ida in ksmbd_conn_free()","Date":"Sun, 19 Apr 2026 20:02:55 +0900","Message-ID":"<20260419110255.2477785-3-charsyam@gmail.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260419110255.2477785-1-charsyam@gmail.com>","References":"<20260419110255.2477785-1-charsyam@gmail.com>","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"When per-connection async_ida was converted from a dynamically\nallocated ksmbd_ida to an embedded struct ida, ksmbd_ida_free() was\nremoved from the connection teardown path but no matching\nida_destroy() was added. The connection is therefore freed with the\nIDA's backing xarray still intact.\n\nThe kernel IDA API expects ida_init() and ida_destroy() to be paired\nover an object's lifetime, so add the missing cleanup before the\nconnection is freed.\n\nNo leak has been observed in testing; this is a pairing fix to match\nthe IDA lifetime rules, not a response to a reproduced regression.\n\nFixes: d40012a83f87 (\"cifsd: declare ida statically\")\nSigned-off-by: DaeMyung Kang \n---\n fs/smb/server/connection.c | 9 +++++++++\n 1 file changed, 9 insertions(+)","diff":"diff --git a/fs/smb/server/connection.c b/fs/smb/server/connection.c\nindex a4110c6cce37..8bbfe27387e3 100644\n--- a/fs/smb/server/connection.c\n+++ b/fs/smb/server/connection.c\n@@ -98,6 +98,15 @@ void ksmbd_conn_free(struct ksmbd_conn *conn)\n \tkfree(conn->preauth_info);\n \tkfree(conn->mechToken);\n \tif (atomic_dec_and_test(&conn->refcnt)) {\n+\t\t/*\n+\t\t * async_ida is embedded in struct ksmbd_conn, so pair\n+\t\t * ida_destroy() with the final kfree() rather than with\n+\t\t * the unconditional field teardown above. This keeps\n+\t\t * the IDA valid for the entire lifetime of the struct,\n+\t\t * even while other refcount holders (oplock / vfs\n+\t\t * durable handles) still reference the connection.\n+\t\t */\n+\t\tida_destroy(&conn->async_ida);\n \t\tconn->transport->ops->free_transport(conn->transport);\n \t\tkfree(conn);\n \t}\n","prefixes":["2/2"]}