{"id":2224696,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2224696/?format=json","web_url":"http://patchwork.ozlabs.org/project/rtc-linux/patch/20260417183849.88144-1-briansune@gmail.com/","project":{"id":9,"url":"http://patchwork.ozlabs.org/api/1.1/projects/9/?format=json","name":"Linux RTC development","link_name":"rtc-linux","list_id":"linux-rtc.vger.kernel.org","list_email":"linux-rtc@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260417183849.88144-1-briansune@gmail.com>","date":"2026-04-17T18:38:49","name":"[v1] Fix missing RTC charge ctrl","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"e30f770f87eaeac2759abd55f6028e768dca8de5","submitter":{"id":91590,"url":"http://patchwork.ozlabs.org/api/1.1/people/91590/?format=json","name":"Brian Sune","email":"briansune@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/rtc-linux/patch/20260417183849.88144-1-briansune@gmail.com/mbox/","series":[{"id":500388,"url":"http://patchwork.ozlabs.org/api/1.1/series/500388/?format=json","web_url":"http://patchwork.ozlabs.org/project/rtc-linux/list/?series=500388","date":"2026-04-17T18:38:49","name":"[v1] Fix missing RTC charge ctrl","version":1,"mbox":"http://patchwork.ozlabs.org/series/500388/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2224696/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2224696/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-rtc@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=I7LexiBh;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-rtc+bounces-6371-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"I7LexiBh\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.214.174","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fy3cD5dl8z1yDF\n\tfor ; Sat, 18 Apr 2026 04:41:00 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 3920D3020D65\n\tfor ; Fri, 17 Apr 2026 18:39:07 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id B942A363095;\n\tFri, 17 Apr 2026 18:39:06 +0000 (UTC)","from mail-pl1-f174.google.com (mail-pl1-f174.google.com\n [209.85.214.174])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 903C5354AF8\n\tfor ; Fri, 17 Apr 2026 18:39:05 +0000 (UTC)","by mail-pl1-f174.google.com with SMTP id\n d9443c01a7336-2aae4816912so6670985ad.2\n for ; Fri, 17 Apr 2026 11:39:05 -0700 (PDT)","from intel-VirtualBox.. ([185.213.82.129])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b5fab3a929sm25583465ad.72.2026.04.17.11.39.03\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 17 Apr 2026 11:39:04 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776451146; cv=none;\n b=TmylEnvUYyR+rN+wqo4CLCdhqQAHnXvYUhtH+lxxZsbVycvWTLPnX58PkmlwiU3jSMXmYr53EUjP9MbGV/qDVWjc1ob6dFZXIyOFrTMGXiYRnXxfM+2oLHLi/VU5aKZe+3K/Hc8cRnJbi1SN+OKFjBJjpc0r7o41jhK/o5pChFg=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776451146; c=relaxed/simple;\n\tbh=eruQFKRUgPkE3r+A43zpiXBrcwIJH4olNTJgaLccCvU=;\n\th=From:To:Cc:Subject:Date:Message-Id:MIME-Version;\n b=UdrPwxg4Li/Gf7yFJF2ztOLh1HfiMkqXuINioH21AO3DSIpcLZi/vAYYvdJpSAVnFysEm7zl0/PxebucSX7McR2y8PGjfJDZ4cBISz3zgb4EnHLHsy7JvvtMSoHk3ccnUf0JE93XuGUQ6AAZfSGKD5RltiUYTkBMWXJCD4QEqM8=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=I7LexiBh; arc=none smtp.client-ip=209.85.214.174","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776451145; x=1777055945;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=ae4XyvpGcdln6f15kE7xb97ONw8HzTbOYKK48/K7Tqw=;\n b=I7LexiBhDZ18mR7sSDS88KKCUN0ldw8qRw0AJkQt9VQcwYAATV7l4B+qU1YEW715dM\n zpK/uq4ksMjmpzv2kSLBSRkpuoETSIs+iy8USfjlockqDhY+kEYgP361w5A6IVIMqhLG\n wmSUOPinxR2mkOh/yxprY5JRQ0Hn3DAIfMKV+zrfYNwvi2Pu6Pr/Bc9RztEpXWdxq4tU\n KOauxwL/+WXuhDO8jMZ2A/i+I+uFb35/mmV/KmYVptKwhevhefPmOu/H9FQJZfBOIYUD\n IK26jywjkXbvWE73qxUeVoc3wF5fvt70Rn08MftdQjsl1l97E/RgQ3ORv0oITaMyg/jN\n iO7A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776451145; x=1777055945;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=ae4XyvpGcdln6f15kE7xb97ONw8HzTbOYKK48/K7Tqw=;\n b=Lll00hHZQZWoUDO6BN5gjPmMLyDZP1VPDdRWNN8CYMCGjY5JWhexeKG0nmamDitUIT\n pQFhcr9YOm1lLNo2tS+BoOew+2SSX5yGVwOO3zJfCYk11hgLTdIa/czE66JxQSnFF4jp\n w51Jh/8OBxCMOf53lVlqTmw1VS7iwSsfC8D2pa5RaJur4aiJfWQgmbTTdMV0gFByWfGo\n REudfVDOcIacFAAT1v82Y2pgu2yREWZeCMYhDoZaoU6MUEG8QxHXsjgZaKDaJ+9dR/iP\n R4ANUm0Tpse/I4SiyX8R2m00+LXujMFPxq0i063qx6WPvp+5c7J5isyIpw68HkJU6Knu\n aLSw==","X-Gm-Message-State":"AOJu0Yy44+9LkHU0VIbos9B2ugfOkATgLGuk/7suwIhPgDIHFjpw0ubn\n\tLKA0KgMmJcnthzxamtkDhze+xJ1IV6c0T/M050hpbMXB9WCHdm4EcYVW","X-Gm-Gg":"AeBDietRh4kkd94dYjtsKV7rIJY+lqISNdfXrUK1SPWDCg/VmM366JQfcLXT4rfabc/\n\tItwRZQn9mzViiyTSPyuJmF3+FagcRGkCNapG81LXlWh1rDQ8fL1+Eum7AEDpHy9pucCIVrIJFmf\n\tjIy3OfWFaGZ0hBAEYRaWnRPZnk6xbUQ70YHTiyeGTLgl6qQnTxy2VckZF9ZZ402rdcVsaIk9reX\n\tJn7SjrUkkdkJdRM0vuxw0Z7zitDs9NdUhVcvYbN/bVixg99kcuXAp6H4m4EfF9ZL4YAtfUbNM9g\n\tRIVx82Okc+/LG4stoEbramaswkCBfrkgHsguiw9saykAlZJPUqBPtsQiWUnjYuDCneSPje3R+ms\n\tPW/cHKzyFrHaFfTxfRCm8I5UQ9B/Ha94CUnqQukwrAWXa57KXCfVhNW9TuJcbBt8CZXsSRlLPPT\n\trjzYJBBVmjPAdisuPzuRj291yoeBzLwrBa3HKFeYaGdQ3VW+RTEFZNEYvR2qX7mT3XjAA=","X-Received":"by 2002:a17:902:690a:b0:2b2:50bd:83b3 with SMTP id\n d9443c01a7336-2b5f9e8196fmr29987735ad.10.1776451144652;\n Fri, 17 Apr 2026 11:39:04 -0700 (PDT)","From":"Brian Sune ","To":"alexandre.belloni@bootlin.com","Cc":"linux-rtc@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tBrian Sune ","Subject":"[PATCH v1] Fix missing RTC charge ctrl","Date":"Sat, 18 Apr 2026 02:38:49 +0800","Message-Id":"<20260417183849.88144-1-briansune@gmail.com>","X-Mailer":"git-send-email 2.34.1","Precedence":"bulk","X-Mailing-List":"linux-rtc@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"Default driver did not consider battery supported\nuse cases, which DTS and probe did not control\nthe charge switch and strength. As such battery\ncould be dried out and possible dmanage.\n\nSigned-off-by: Brian Sune \n---\n drivers/rtc/rtc-sd3078.c | 47 +++++++++++++++++++++++++++++++++++++++-\n 1 file changed, 46 insertions(+), 1 deletion(-)","diff":"diff --git a/drivers/rtc/rtc-sd3078.c b/drivers/rtc/rtc-sd3078.c\nindex 10cc1dcfc774..871e6d9acd86 100644\n--- a/drivers/rtc/rtc-sd3078.c\n+++ b/drivers/rtc/rtc-sd3078.c\n@@ -22,11 +22,17 @@\n #define SD3078_REG_CTRL1\t\t0x0f\n #define SD3078_REG_CTRL2\t\t0x10\n #define SD3078_REG_CTRL3\t\t0x11\n+#define SD3078_REG_AGTC\t\t\t0x17\n+#define SD3078_REG_CHARGE\t\t0x18\n \n #define KEY_WRITE1\t\t0x80\n #define KEY_WRITE2\t\t0x04\n #define KEY_WRITE3\t\t0x80\n \n+#define CLK_F32K\t\t0x40\n+\n+#define BAT_IIC\t\t\t0x80\n+\n #define NUM_TIME_REGS (SD3078_REG_YR - SD3078_REG_SC + 1)\n \n /*\n@@ -36,6 +42,13 @@\n */\n #define WRITE_PROTECT_EN\t0\n \n+static const char * const sd3078_charge_names[] = {\n+\t\"10k\", /* 0x00 */\n+\t\"5k\", /* 0x01 */\n+\t\"2k\", /* 0x02 */\n+\t\"inf\", /* 0x03 */\n+};\n+\n /*\n * In order to prevent arbitrary modification of the time register,\n * when modification of the register,\n@@ -148,13 +161,15 @@ static const struct rtc_class_ops sd3078_rtc_ops = {\n static const struct regmap_config regmap_config = {\n \t.reg_bits = 8,\n \t.val_bits = 8,\n-\t.max_register = 0x11,\n+\t.max_register = 0x18,\n };\n \n static int sd3078_probe(struct i2c_client *client)\n {\n \tint ret;\n+\tunsigned int val;\n \tstruct regmap *regmap;\n+\tbool f32k_out, bat_iic;\n \tstruct rtc_device *rtc;\n \n \tif (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C))\n@@ -182,6 +197,36 @@ static int sd3078_probe(struct i2c_client *client)\n \n \tsd3078_enable_reg_write(regmap);\n \n+\tf32k_out = device_property_read_bool(&client->dev, \"CLOCK_F32K\");\n+\tregmap_update_bits(regmap, SD3078_REG_CTRL3,\n+\t\t\t CLK_F32K, !f32k_out);\n+\n+\tbat_iic = device_property_read_bool(&client->dev, \"IIC_ON_BAT\");\n+\tregmap_update_bits(regmap, SD3078_REG_AGTC,\n+\t\t\t BAT_IIC, bat_iic);\n+\n+\tret = regmap_read(regmap, SD3078_REG_CHARGE, &val);\n+\tif (!ret) {\n+\t\tdev_info(&client->dev, \"RTC BAT Charge: %s\",\n+\t\t\t (val & 0x80) ? \"ON\" : \"OFF\");\n+\t}\n+\n+\tret = device_property_read_u32(&client->dev, \"BAT_CHARGE\", &val);\n+\tif (!ret) {\n+\t\t// 0: 10k, 1: 5k, 2: 2k, 3: inf\n+\t\tdev_info(&client->dev, \"Enable Battery Charge.\\n\");\n+\t\tregmap_write(regmap, SD3078_REG_CHARGE,\n+\t\t\t (val < 3) ? (u8)(val|0x80) : 0x03);\n+\t}\n+\n+\tret = regmap_read(regmap, SD3078_REG_CHARGE, &val);\n+\tif (!ret) {\n+\t\tdev_info(&client->dev, \"RTC BAT charge: %s\",\n+\t\t\t (val & 0x80) ? \"ON\" : \"OFF\");\n+\t\tdev_info(&client->dev, \"RTC BAT Charge Strength: %s\",\n+\t\t\t sd3078_charge_names[val & 0x03]);\n+\t}\n+\n \treturn 0;\n }\n \n","prefixes":["v1"]}