{"id":2223807,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2223807/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20260416-enable_fua-v3-1-84508de2bfd9@oss.qualcomm.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.1/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260416-enable_fua-v3-1-84508de2bfd9@oss.qualcomm.com>","date":"2026-04-16T09:10:46","name":"[v3,1/2] Revert \"scsi: sync cache on write\"","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"a6242e591e12ca2536b0dcfc144b2b4456f2085f","submitter":{"id":90810,"url":"http://patchwork.ozlabs.org/api/1.1/people/90810/?format=json","name":"Balaji Selvanathan","email":"balaji.selvanathan@oss.qualcomm.com"},"delegate":{"id":3651,"url":"http://patchwork.ozlabs.org/api/1.1/users/3651/?format=json","username":"trini","first_name":"Tom","last_name":"Rini","email":"trini@ti.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20260416-enable_fua-v3-1-84508de2bfd9@oss.qualcomm.com/mbox/","series":[{"id":500116,"url":"http://patchwork.ozlabs.org/api/1.1/series/500116/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=500116","date":"2026-04-16T09:10:45","name":"scsi: Replace SYNC_CACHE with FUA for scsi write","version":3,"mbox":"http://patchwork.ozlabs.org/series/500116/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2223807/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2223807/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=n6JnIuNT;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=V1zogV2t;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=oss.qualcomm.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com\n header.b=\"n6JnIuNT\";\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.b=\"V1zogV2t\";\n\tdkim-atps=neutral","phobos.denx.de; dmarc=none (p=none dis=none)\n header.from=oss.qualcomm.com","phobos.denx.de; spf=pass\n smtp.mailfrom=balaji.selvanathan@oss.qualcomm.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxC1K6vC0z1yCv\n\tfor ; Thu, 16 Apr 2026 19:11:17 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 862F18423F;\n\tThu, 16 Apr 2026 11:11:14 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 4431B83FC0; Thu, 16 Apr 2026 11:11:07 +0200 (CEST)","from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com\n [205.220.168.131])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id DCEA58423D\n for ; Thu, 16 Apr 2026 11:10:58 +0200 (CEST)","from pps.filterd (m0279865.ppops.net [127.0.0.1])\n by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63G90YmA2979251\n for ; Thu, 16 Apr 2026 09:10:57 GMT","from mail-pl1-f199.google.com (mail-pl1-f199.google.com\n [209.85.214.199])\n by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4djvru81jg-1\n (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n for ; Thu, 16 Apr 2026 09:10:56 +0000 (GMT)","by mail-pl1-f199.google.com with SMTP id\n d9443c01a7336-2b2eba42b8dso42839105ad.0\n for ; Thu, 16 Apr 2026 02:10:56 -0700 (PDT)","from hu-bselvana-blr.qualcomm.com\n (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b47810b898sm46211895ad.25.2026.04.16.02.10.52\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 16 Apr 2026 02:10:55 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n cc:content-transfer-encoding:content-type:date:from:in-reply-to\n :message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n psUcOxmKqahpoc0p2mWl7enoVqWY+qAczqDSLmlikxk=; b=n6JnIuNTAFs/QREO\n SWMfA72mFMpByNpL70xmqmN4DjTRYmAtryxxMZfDpvpfTe2WXi//MLGwzpNrkVAA\n oycSYiOCQuFcePY6AzhKFFZD9cd5QFEQRr1IYV9PjZKIici8BAnlLhGiuN2skJ4m\n qByNm8mRPs9myDEgtwOmvKlzSfqJ/Y3G23sJidhzpjzR19yZzYm+5TyOyBQyyDMM\n KrGpK8nL7GXELJ2wNcaFwFi1cdX+STkQsHCg/tCnF6wX7HG2+RWvKO/rNXh79Xfz\n ORFqhkIJ4yilg1tJQzybqZuuE1FZZG5ts9tNwvgaOirHX1FwYHupQs0nNsLd7Gq9\n iJPaGg==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1776330656; x=1776935456; darn=lists.denx.de;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:from:to:cc:subject:date:message-id\n :reply-to; bh=psUcOxmKqahpoc0p2mWl7enoVqWY+qAczqDSLmlikxk=;\n b=V1zogV2tDzFfFVOCnS9n6wYfvksb8kIKhqHz9XeCaX8Wgc+88X3fvr+Bbmcoq9d1AP\n JClNaS5Rx90XKSb2CAqPvFNAaygwib9BfuGOnnP/fM7bFV0EKoaPDzwV5etng53M9RNd\n HktFO+aS+AzXVljikpPt5rOhI7XAiBnVN8jZQoKKvHERj5R5yoCyh+7pQvwpFjsioVzR\n 9q3qGhV1tNGqB5Vke+/nM3sKJkBttpSUfOa6Vu9F0a/z+Ysp0wE0Ae/hBrcHaMH7wGVS\n +ZXxlMZsBfwmDS7G5vcgb7rZ+6lvRhZTTFlzU+xTR0thF3Oe0qPvPnQs6r5sqCSZ9jfv\n N/jA=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776330656; x=1776935456;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=psUcOxmKqahpoc0p2mWl7enoVqWY+qAczqDSLmlikxk=;\n b=Le0xxtl5YrzW2DV4xesQCT1rcTP8la3wm9Yy2VmI+r0H+eFEMMc9QLDf1RNWFq786P\n emZlpnvD/reRuvTBo//ox8D1/P4pXvK5qsnsCFu9vBUK5eFSIjNG9gFsx07yukbBQfNg\n +nTcyx98otvTM9qdCd578Bvq+txphxRbW4M0FgWc6btzgctwiw0IjhXYUwgaMj0I0mNU\n x4lraqHLgG/IxJC5sOxV0PUvVH3MSpgiTRHgfWeY/aKcWPwG+PXp1zfma4xZFD8k7j/e\n 5BrEIyhg2OXgHL7SlhaBfNBVDT4CdYYKY/9k+9Y26HQOLMswgwY1mHRiafb0ppogTnbN\n +nzw==","X-Gm-Message-State":"AOJu0YwV2S7tgbh0ZjrCaNH9gv7sxi4c1r9CMhUkgMGXzxYvsLEcVjKS\n jJNK8BCZX3YrodYNRtjhLA5wcNoH7aooak7o/V6ibEOwthKlosHvapTH0IKH93ZmMymW1S4fzsG\n Qy1+5+SOcxmW5QluYMWWkhcQbu3NO9xtH9/GEncesrs4h27lJlDqp/bun","X-Gm-Gg":"AeBDiesMS9g1Cj0/8r+6BagwRWcgvz85qZbxqSq5AHwqZfvL1vZm78ugryJNHOjfMV5\n feH27gqS1dw7TRh6cF/bB6LGJCmtjE0a3QEmP/RpFSwlJGvfAp1ueQ9K8tfOVEkS04bpIpAr+DZ\n 2foz40mkYnL3iTVypQu39ynV9m2c4u8M1naqup8Kl6OKUNOyFB7nzK43F+k/xjK1GpD9ZlszmFQ\n zbUL3TgVegSLL8XIBDP/prXoWyEUZ0ddNFsOdJWfjTG7YsLcSmsz5vAbGA3i8w9/FgaKCbTYmKh\n +HNsqizNuIuQD0bC65zn1p/4v0eScX6JaEqcxpytXTsmySYUh3o8ADoctsGAiDDIJtFq/EdcrvZ\n Il6dAEVOqR1DtB0qUPuCokZFcY/WZdxjURUfAkrXGH/kX2rwsLnu06EMlEwCA8CWqAZBtkIg4S3\n uqQ0Z87rlw1Ck3NH4A1EXkUKr0kbSa2lFbYAzqpsMHpw6rhUjziA==","X-Received":["by 2002:a17:903:2c10:b0:2b2:e6e8:3c09 with SMTP id\n d9443c01a7336-2b2e6e83e45mr177241405ad.40.1776330656216;\n Thu, 16 Apr 2026 02:10:56 -0700 (PDT)","by 2002:a17:903:2c10:b0:2b2:e6e8:3c09 with SMTP id\n d9443c01a7336-2b2e6e83e45mr177241075ad.40.1776330655756;\n Thu, 16 Apr 2026 02:10:55 -0700 (PDT)"],"From":"Balaji Selvanathan ","Date":"Thu, 16 Apr 2026 14:40:46 +0530","Subject":"[PATCH v3 1/2] Revert \"scsi: sync cache on write\"","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260416-enable_fua-v3-1-84508de2bfd9@oss.qualcomm.com>","References":"<20260416-enable_fua-v3-0-84508de2bfd9@oss.qualcomm.com>","In-Reply-To":"<20260416-enable_fua-v3-0-84508de2bfd9@oss.qualcomm.com>","To":"u-boot@lists.denx.de","Cc":"Tom Rini ,\n Varadarajan Narayanan ,\n Aswin Murugan ,\n Macpaul Lin ,\n Marek Vasut ,\n Andrew Goodbody ,\n Bin Meng ,\n Balaji Selvanathan ","X-Mailer":"b4 0.14.3","X-Developer-Signature":"v=1; a=ed25519-sha256; t=1776330648; l=2029;\n i=balaji.selvanathan@oss.qualcomm.com; s=20260213; h=from:subject:message-id;\n bh=o8PwxZfXcVL44M49MTd/tAXHJrEfHBvmrSSCiqJGpuA=;\n b=z2Y2aoqfLkE455vOT5pOs/Tqe8Zfuxv/9pyD4XkUKe9B198OwX/wqZPg4dNV8ip+LtiB/GBZu\n kP/6T3SgEGqA4nZn3V8zS52eXpTJK6uASGTq8Z+IrcRGW5SgzQq/lJU","X-Developer-Key":"i=balaji.selvanathan@oss.qualcomm.com; a=ed25519;\n pk=CDpYiUU3SH7KGEtsBvY2tBGPiWfMxqWJF0p2LftOfnc=","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDE2MDA4NiBTYWx0ZWRfX5H6G0lgb/yyO\n ukyi3iyiuKQ2zEVHGAj1Jct4h4O5MHDebkNJvMWY39TQWOqX/BxnZTN9/L9/uvGzGdi8ajZoBMB\n voFnPPkaQUTI7Gp+9S+ET7xb0tnOrmTj1VS7E3RJZDyyYkiSs4A6rXPtuieNqh+AGvmcNcDjfk5\n xunpUNOqHRBd5k4e+6NREGfJJ+w18oR6/7LDi2NTnUYxD+I+5njdEXuv2LgvE/jGp6OL8ILm+o+\n F+4kKH8jYG6pOq77Ixm8nD6/BVxQ26GkGzGfsuO9WegrRoL5OEiqciSXB2Q0UI2+YD9wTyv9qZj\n H2l6z3VJwU24kzpLs5SK0ctRVs4+x7igNeUNeOCqKeiDSz5XHnpule8akTAP+a67fsgvRVJXTIj\n H+LDgrkxBau+NQzuEjUXaENOjS+KjNdTHq7IsXqqJ/GsFWwFUyC09GkmqH9xTj+IKpD79DZEJKw\n +wMYl0S9XISZ+O1uAdw==","X-Proofpoint-GUID":"DQHD7Itkifj8t2e0BTF3E8cb2oNgDrU9","X-Proofpoint-ORIG-GUID":"DQHD7Itkifj8t2e0BTF3E8cb2oNgDrU9","X-Authority-Analysis":"v=2.4 cv=GcInWwXL c=1 sm=1 tr=0 ts=69e0a7a0 cx=c_pps\n a=JL+w9abYAAE89/QcEU+0QA==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17\n a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10\n a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22\n a=EUspDBNiAAAA:8 a=OPt5pyjpXDMeivyPd00A:9 a=QEXdDO2ut3YA:10 a=O8hF6Hzn-FEA:10\n a=324X-CrmTo6CU4MGRt3R:22","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-16_02,2026-04-13_04,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n lowpriorityscore=0 adultscore=0 priorityscore=1501 malwarescore=0\n impostorscore=0 phishscore=0 suspectscore=0 bulkscore=0 spamscore=0\n clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc=\n route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000\n definitions=main-2604160086","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"While the SYNC_CACHE approach prevents data loss during board resets,\nit causes system hangs during large sparse image flashing operations.\nThis will be replaced with a FUA (Force Unit Access) approach in future\ncommit, which achieves the same data integrity goal more efficiently.\n\nThis reverts commit ffe4e6ab42d2534302be825e49a2d085acf80f30.\n\nSigned-off-by: Balaji Selvanathan \n---\nChanges in v3:\n- Changed commit description's structure.\n---\n drivers/scsi/scsi.c | 22 ----------------------\n 1 file changed, 22 deletions(-)","diff":"diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c\nindex 116b696b08d..9a417795851 100644\n--- a/drivers/scsi/scsi.c\n+++ b/drivers/scsi/scsi.c\n@@ -82,23 +82,6 @@ static void scsi_setup_inquiry(struct scsi_cmd *pccb)\n \tpccb->msgout[0] = SCSI_IDENTIFY; /* NOT USED */\n }\n \n-static void scsi_setup_sync_cache(struct scsi_cmd *pccb, lbaint_t start,\n-\t\t\t\t lbaint_t blocks)\n-{\n-\tpccb->cmd[0] = SCSI_SYNC_CACHE;\n-\tpccb->cmd[1] = 0;\n-\tpccb->cmd[2] = (unsigned char)(start >> 24) & 0xff;\n-\tpccb->cmd[3] = (unsigned char)(start >> 16) & 0xff;\n-\tpccb->cmd[4] = (unsigned char)(start >> 8) & 0xff;\n-\tpccb->cmd[5] = (unsigned char)start & 0xff;\n-\tpccb->cmd[6] = 0;\n-\tpccb->cmd[7] = (unsigned char)(blocks >> 8) & 0xff;\n-\tpccb->cmd[8] = (unsigned char)blocks & 0xff;\n-\tpccb->cmd[9] = 0;\n-\tpccb->cmdlen = 10;\n-\tpccb->msgout[0] = SCSI_IDENTIFY; /* NOT USED */\n-}\n-\n static void scsi_setup_read_ext(struct scsi_cmd *pccb, lbaint_t start,\n \t\t\t\tlbaint_t blocks)\n {\n@@ -301,11 +284,6 @@ static ulong scsi_write(struct udevice *dev, lbaint_t blknr, lbaint_t blkcnt,\n \t\tbuf_addr += pccb->datalen;\n \t} while (blks != 0);\n \n-\t/* Flush the SCSI cache so we don't lose data on board reset. */\n-\tscsi_setup_sync_cache(pccb, 0, 0);\n-\tif (scsi_exec(bdev, pccb))\n-\t\tscsi_print_error(pccb);\n-\n \tdebug(\"%s: end startblk \" LBAF \", blccnt \" LBAF \" buffer %lX\\n\",\n \t __func__, start, blocks, buf_addr);\n \treturn blkcnt;\n","prefixes":["v3","1/2"]}