{"id":2223732,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2223732/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-ext4/patch/20260416030642.26744-1-changfengnan@bytedance.com/","project":{"id":8,"url":"http://patchwork.ozlabs.org/api/1.1/projects/8/?format=json","name":"Linux ext4 filesystem development","link_name":"linux-ext4","list_id":"linux-ext4.vger.kernel.org","list_email":"linux-ext4@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260416030642.26744-1-changfengnan@bytedance.com>","date":"2026-04-16T03:06:42","name":"iomap: avoid memset iomap when iter is done","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"f2a37e6fba637aa2e79907575c20340ec6981bf5","submitter":{"id":80323,"url":"http://patchwork.ozlabs.org/api/1.1/people/80323/?format=json","name":"Fengnan Chang","email":"fengnanchang@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-ext4/patch/20260416030642.26744-1-changfengnan@bytedance.com/mbox/","series":[{"id":500072,"url":"http://patchwork.ozlabs.org/api/1.1/series/500072/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-ext4/list/?series=500072","date":"2026-04-16T03:06:42","name":"iomap: avoid memset iomap when iter is done","version":1,"mbox":"http://patchwork.ozlabs.org/series/500072/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2223732/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2223732/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ext4@vger.kernel.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","patchwork-incoming@ozlabs.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=c5xOjVjk;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=2404:9400:2221:ea00::3; helo=mail.ozlabs.org;\n envelope-from=srs0=3rnv=cp=vger.kernel.org=linux-ext4+bounces-15855-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)","gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=\"2600:3c15:e001:75::12fc:5321\"\n arc.chain=subspace.kernel.org","gandalf.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","gandalf.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=c5xOjVjk;\n\tdkim-atps=neutral","gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15855-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"c5xOjVjk\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.210.169","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fx2x22kksz1yDF\n\tfor ; Thu, 16 Apr 2026 13:07:02 +1000 (AEST)","from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4fx2x22Qfpz4wJR\n\tfor ; Thu, 16 Apr 2026 13:07:02 +1000 (AEST)","by gandalf.ozlabs.org (Postfix)\n\tid 4fx2x22Jbtz4wTk; Thu, 16 Apr 2026 13:07:02 +1000 (AEST)","from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4fx2wy5Pxrz4wJR\n\tfor ; Thu, 16 Apr 2026 13:06:58 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 24508300A5B7\n\tfor ; Thu, 16 Apr 2026 03:06:56 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id AE84E2765D7;\n\tThu, 16 Apr 2026 03:06:52 +0000 (UTC)","from mail-pf1-f169.google.com (mail-pf1-f169.google.com\n [209.85.210.169])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 550E645038\n\tfor ; Thu, 16 Apr 2026 03:06:51 +0000 (UTC)","by mail-pf1-f169.google.com with SMTP id\n d2e1a72fcca58-82d0b68837aso4093574b3a.2\n for ;\n Wed, 15 Apr 2026 20:06:51 -0700 (PDT)","from localhost.localdomain ([240e:694:e20:401::4])\n by smtp.googlemail.com with ESMTPSA id\n d2e1a72fcca58-82f67418a47sm3490993b3a.48.2026.04.15.20.06.48\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Wed, 15 Apr 2026 20:06:50 -0700 (PDT)"],"ARC-Seal":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1776308822; cv=pass;\n\tb=V4J4Bh5V7KnN6C3KrD18NuVnt0fwk2oCA5DojEnRP2kOKUXMebeYfBYcYzSqlwla5yWQzukFoff3MmfXvvY8UTZwQcK34iq4thyxG6Lk1gAb/sivWzvLXB8d2nfDKwIp7Wm5OGbefBORNMZdz9sTguFw+ZQsnOefGIUZQtJf51HdH/GwToj2adA5B9WyzWFRP53MZO4k6Kl5Sof4MvcteDQ3qep+driEsIcSR+AJkEnu9VgTc/CKH+vLoA4fBWVJKc82JvJNENWYcEmH3MHXbvRhUlG48SkQ3aGf+5lkK2pc7xrO5snjCF6G8lxVKOwhTzM3mYqIH4+XdlJeoIMeGw==","i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776308812; cv=none;\n b=gniWgoqTU9z+BxCErifZuikrNCMrsei3AynvydE0exfvv9wMwmpWyxc0kNGFEudtw5aV4iPsl3S/3WWKhX19yK3fgPaWBGU3nulkq6Uqepe/nX994R/Y3MqV5GOZ/wUSYHvCpvsZnNfYJa5JfWsO4RDA9p4l2q4x2E9fFO+z7cQ="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1776308822; c=relaxed/relaxed;\n\tbh=ZLwFWID41PK+d9iSUqQXYtWXn+ddFgZMpYD1ReTw9mk=;\n\th=From:To:Cc:Subject:Date:Message-Id:MIME-Version;\n b=WIueAj6vxwtrNw7r1mB+pxIeGLrw9iORVzgPXazV0kI+4tex24gFk8yyuWfLFBxET+5q1PLNLVzG/0FIQP+VMfnEZzigdpi+t91G2fgEkAmKl+ViNAImnb6SRYQPu/dVSNdPjRy4YFqlHTC45cI8D5d+I13aIGoEMD8Y3DydKKUisCJMGP4oZreVIIjghcQKjSXDmnNLWZ47IbU58sb2z3/+f7OMy2fajpXDlDRCIiZcVgrRy5zfzki9a0l8G06Os8HRgOhiUNIQbmhTituoeDNajfKxf8XDy8uk6SIez33V1GYqW8+ttAgrlD25+WAy2k/B0jTcCevo3GfH1pWnSQ==","i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776308812; c=relaxed/simple;\n\tbh=2I63PklS8RTMy4ZBeNJKH5O9yBN3sFjLFkFF7J32HPQ=;\n\th=From:To:Cc:Subject:Date:Message-Id:MIME-Version;\n b=GBCHd9r2QkIysBLl/E48RYlmfRQ3xNJEBHyqyerBKE9mV4iacgBQX04o53nXWUuhLhZuWHtiHvlt52yG0CnEGihkI2F4YA2FZdEsvx0a4wg/yuEsW9YWG48eaGNohlR7s6QBbtqwGWyHIBkwKzZr5T75uclz3VufUzd6yoAfb5c="],"ARC-Authentication-Results":["i=2; gandalf.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com; dkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=c5xOjVjk; dkim-atps=neutral;\n spf=pass (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15855-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org","i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=c5xOjVjk; arc=none smtp.client-ip=209.85.210.169"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776308811; x=1776913611;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=ZLwFWID41PK+d9iSUqQXYtWXn+ddFgZMpYD1ReTw9mk=;\n b=c5xOjVjk7TuFm5MB6lwedJy1MqdOq2qCUgT2W0wTYlqXXGBxr6j4FK/7mfwTMGmO0g\n x1/W5/Fe5UpM55ONkUq4dz71yU9OMqkYvgwZOtkyXanOx0n53220JWW4Iu8xIh/4nP6y\n TiTdUe+Xr8vRs5H5/aUISLCKVV/fK9oY4ZFskeFvcGb3wRDhq3UE8s8tTSOiWBYbqM2f\n CEsKSABToJaTlls2XbSAlbihfI9g+xYsxwaVH3vEfFs6NgvXKOnf05Wf7zGkew5FR/ut\n kc2d08KaKgeFtZ4TbmSDlm92m3/XOm5yNFZeb+994Z69QBpto33gAF6Xi5TnsJBkczvg\n NBsg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776308811; x=1776913611;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=ZLwFWID41PK+d9iSUqQXYtWXn+ddFgZMpYD1ReTw9mk=;\n b=Ei96t8XK6Uj4CgPToHFFoIkwXxNb3wt7Cwm66F9duSv947IjWQAkUVc6kmQ26p8VNz\n xtQHKcTe94ymgrEJeR54cWAf50JRgZVLjQma+75wTZLgIajij/mkcERV+2xyqpCwBmRc\n hizI4C7axknh8xSxRQmP8RpOHwXpw1lmImURdZAibxP0f8VcHXQ0A3NDrDyhhrp0J9c6\n xVYKPZvCPs9mTpdi/Iy3nvhhGPWBnxUSGud0rTDxZCFsM4DE59AjlfN6KUKobO7Dw/T4\n zi0w34I+p6XXlDnKDXIEFR+jD0SchliFn6YVAcrhtk3BbUPf3BCUl/xa/hb+jflV8c3f\n 2afg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/Xr04zytqIbQ01vAgpHQZzOzEfy4WWYSILrnM5RHiCSAwTlXuvQM7P62b+YUqSz63xhV03Gz+Wa48z@vger.kernel.org","X-Gm-Message-State":"AOJu0Ywf+vcEfH3/w2LHOLgD5Spp0ifQ3ImZOrZiuLUbEj/k1QpQR77n\n\t5qSZKY19W1nfLBB6rdo2WSVdySUPdXjZbframsm7TCKtY0bxmVi1wWhI","X-Gm-Gg":"AeBDiesa+sQf7Q15HSX6a7nMkajeyKtEnWBNqdBvbTo8PVkxYzZ6qmNi75qunlHEdSB\n\tp364Nq/aoMuvgucTYMvexdVBqo7Wotk+F4Ac0E4jZOpOBqOyJqlwAwehH2/f0no/hjbdueujm3F\n\ttR7RM+M4Vl6+809Pdt72Ck9/R+WVq9uK0K1xvgUx0H7Ag0MBO79pmUqp6t8LX0gOUY4MOcr7ovG\n\tlSd5fY/3nkWwXvqIdxsV0lokxXRODulUqkmJ/LfujAaRkStlhn+LMysR/LW7ZOXClhSOl6gT19F\n\tiSB36HViRqZXE7ka2n+wahPQAb7lrQQ2CwodINqz8mHoMXhIHXhE6mHJkcB+r1DuI3G33MAGewp\n\tagUXQRdmSi1Bwk3xFs2vaMC6hNmH44IO5JK35IV44e4chWijTqtPXic8N2B9Yj1N/HzOydSeXym\n\teB6rdSDH/uw7778DTE8l3OXKCeI3tyeik52PX7DGj7DjkPfMTGBEqzpHs=","X-Received":"by 2002:a05:6a00:b80c:b0:82f:111:7e60 with SMTP id\n d2e1a72fcca58-82f0c323e1bmr25358052b3a.37.1776308810616;\n Wed, 15 Apr 2026 20:06:50 -0700 (PDT)","From":"Fengnan Chang ","X-Google-Original-From":"Fengnan Chang ","To":"brauner@kernel.org,\n\tdjwong@kernel.org,\n\thch@infradead.org,\n\tlinux-xfs@vger.kernel.org,\n\tlinux-fsdevel@vger.kernel.org,\n\tlinux-ext4@vger.kernel.org","Cc":"lidiangang@bytedance.com,\n\tFengnan Chang ","Subject":"[PATCH] iomap: avoid memset iomap when iter is done","Date":"Thu, 16 Apr 2026 11:06:42 +0800","Message-Id":"<20260416030642.26744-1-changfengnan@bytedance.com>","X-Mailer":"git-send-email 2.39.5 (Apple Git-154)","Precedence":"bulk","X-Mailing-List":"linux-ext4@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Spam-Status":"No, score=-1.2 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DMARC_PASS,\n\tFREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,\n\tMAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=disabled\n\tversion=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org"},"content":"When iomap_iter() finishes its iteration (returns <= 0), it is no longer\nnecessary to memset the entire iomap and srcmap structures.\n\nIn high-IOPS scenarios (like 4k randread NVMe polling with io_uring),\nwhere the majority of I/Os complete in a single extent map, this wasted\nmemory write bandwidth, as the caller will just discard the iterator.\n\nUse this command to test:\ntaskset -c 30 ./t/io_uring -p1 -d512 -b4096 -s32 -c32 -F1 -B1 -R1 -X1\n-n1 -P1 /mnt/testfile\nIOPS improve about 5% on ext4 and XFS.\n\nHowever, we MUST still call iomap_iter_reset_iomap() to release the\nfolio_batch if IOMAP_F_FOLIO_BATCH is set, otherwise we leak page\nreferences. Therefore, split the cleanup logic: always release the\nfolio_batch, but skip the memset() when ret <= 0.\n\nSigned-off-by: Fengnan Chang \n---\n fs/iomap/iter.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)","diff":"diff --git a/fs/iomap/iter.c b/fs/iomap/iter.c\nindex c04796f6e57f..91eb5e6165ff 100644\n--- a/fs/iomap/iter.c\n+++ b/fs/iomap/iter.c\n@@ -15,8 +15,6 @@ static inline void iomap_iter_reset_iomap(struct iomap_iter *iter)\n \t}\n \n \titer->status = 0;\n-\tmemset(&iter->iomap, 0, sizeof(iter->iomap));\n-\tmemset(&iter->srcmap, 0, sizeof(iter->srcmap));\n }\n \n /* Advance the current iterator position and decrement the remaining length */\n@@ -106,6 +104,9 @@ int iomap_iter(struct iomap_iter *iter, const struct iomap_ops *ops)\n \tif (ret <= 0)\n \t\treturn ret;\n \n+\tmemset(&iter->iomap, 0, sizeof(iter->iomap));\n+\tmemset(&iter->srcmap, 0, sizeof(iter->srcmap));\n+\n begin:\n \tret = ops->iomap_begin(iter->inode, iter->pos, iter->len, iter->flags,\n \t\t\t &iter->iomap, &iter->srcmap);\n","prefixes":[]}