{"id":2223727,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2223727/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260416015520.6090-3-khai.wen.tan@linux.intel.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/1.1/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260416015520.6090-3-khai.wen.tan@linux.intel.com>","date":"2026-04-16T01:55:19","name":"[iwl-next,v2,2/3] igc: move autoneg-enabled settings into igc_handle_autoneg_enabled()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"10a503c5d095eb43e663dc3639dcf4fbb3843682","submitter":{"id":93102,"url":"http://patchwork.ozlabs.org/api/1.1/people/93102/?format=json","name":"KhaiWenTan","email":"khai.wen.tan@linux.intel.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260416015520.6090-3-khai.wen.tan@linux.intel.com/mbox/","series":[{"id":500068,"url":"http://patchwork.ozlabs.org/api/1.1/series/500068/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=500068","date":"2026-04-16T01:55:17","name":"igc: add support for forcing link speed without autonegotiation","version":2,"mbox":"http://patchwork.ozlabs.org/series/500068/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2223727/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2223727/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=xx5WT3PC;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fx1sL587Rz1yG9\n\tfor ; Thu, 16 Apr 2026 12:18:46 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 969E580B4B;\n\tThu, 16 Apr 2026 02:18:42 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id DoV90t6ZASul; Thu, 16 Apr 2026 02:18:41 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id D61D180B49;\n\tThu, 16 Apr 2026 02:18:41 +0000 (UTC)","from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n by lists1.osuosl.org (Postfix) with ESMTP id 0FE23127\n for ; Thu, 16 Apr 2026 02:18:40 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id 6747980B19\n for ; Thu, 16 Apr 2026 02:18:38 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id Pr6IAV-6bu6N for ;\n Thu, 16 Apr 2026 02:18:37 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [198.175.65.14])\n by smtp1.osuosl.org (Postfix) with ESMTPS id 3F58E80B39\n for ; Thu, 16 Apr 2026 02:18:37 +0000 (UTC)","from fmviesa007.fm.intel.com ([10.60.135.147])\n by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 15 Apr 2026 19:18:36 -0700","from unknown (HELO localhost.png.intel.com) ([10.107.255.61])\n by fmviesa007.fm.intel.com with ESMTP; 15 Apr 2026 19:18:33 -0700"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org D61D180B49","OpenDKIM Filter v2.11.0 smtp1.osuosl.org 3F58E80B39"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776305921;\n\tbh=PcMVa54i0dkFXQygNG8g3dRKgOhOk68GamMPEm2mRkw=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=xx5WT3PC2/Vw9ya5FS6gvFYCsFkaL0lqbl0rX0VTbCXTuh6TzkbyyBGoONFZfIsDY\n\t Xh1tqlC82yIehqL55T3n+HEDbuZjI5gnPlqD6yEphBCcatgdMysOkqGB3zFk3znORm\n\t RmcL9mrovk4AhXDMQ2wDdz1i2Viyp8lDhIKqos2Pojk5F6eSKJ5zTcOSv91+jqJHi2\n\t FBHW8LN65fGZj8UIVJno5kccCPm6MtyuoViv77WdL8AcxN01PZ0GEFa/Q3fUGK3mkm\n\t iyfkg879FmpH9alFSsOSVldsLPT0XSp6p4ibxp80ABQdIXQove6HqS0Z8NOpl7HxWg\n\t XVFhx9KBN04BA==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.14;\n helo=mgamail.intel.com; envelope-from=khai.wen.tan@linux.intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp1.osuosl.org 3F58E80B39","X-CSE-ConnectionGUID":["oEZU6Qb8R7+ClctAw3RVUQ==","CvtgE75lStGQS2UNjJ1dAQ=="],"X-CSE-MsgGUID":["ecTx5+RVTza3eENik1RA8A==","xjIpfms5R4ulvO2oqIEPQw=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11760\"; a=\"81168802\"","E=Sophos;i=\"6.23,181,1770624000\"; d=\"scan'208\";a=\"81168802\"","E=Sophos;i=\"6.23,181,1770624000\"; d=\"scan'208\";a=\"227442200\""],"X-ExtLoop1":"1","From":"KhaiWenTan ","To":"anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com,\n andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,\n kuba@kernel.org, pabeni@redhat.com","Cc":"intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,\n linux-kernel@vger.kernel.org, faizal.abdul.rahim@intel.com,\n hong.aun.looi@intel.com, khai.wen.tan@intel.com,\n Faizal Rahim , Looi,\n KhaiWenTan ","Date":"Thu, 16 Apr 2026 09:55:19 +0800","Message-ID":"<20260416015520.6090-3-khai.wen.tan@linux.intel.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260416015520.6090-1-khai.wen.tan@linux.intel.com>","References":"<20260416015520.6090-1-khai.wen.tan@linux.intel.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1776305916; x=1807841916;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=gLZdUWehz2CnGY9z/fhytGrTHfZiwQXVAh5sMsRRzkE=;\n b=YUQGTePEIxqZU9CienjUdPgVIgGKr2JD/eSEvcn9ehDhSeSQ/2qSIQOm\n K1jlsIztgW1OLdssFyz9+RZxoe7oHAmel+GV2UgLq/wQ5Pkqh+wDoFmy3\n fmlgxGm7phO5OQ/wzY4N8woB0vwF92RPPxlYI77QqJPBS2kP7fSqfz2pv\n Zo+m3a5srDt/OL2nsdljzUeFVANgMkwt7d4RHhznMoafO2AR3UN0KgIUV\n dcu9pi/khY5TQvEkRnGInEGSciwKDL7tuNxtxp1Y9acK+jXN/ea+a3g/c\n tqHr7UHRfcDOo9ZpVLoRSG11bC14Qva/h6cJmdRdlQ2rhgkuXcubEpALm\n A==;","X-Mailman-Original-Authentication-Results":["smtp1.osuosl.org;\n dmarc=none (p=none dis=none)\n header.from=linux.intel.com","smtp1.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=YUQGTePE"],"Subject":"[Intel-wired-lan] [PATCH iwl-next v2 2/3] igc: move autoneg-enabled\n settings into igc_handle_autoneg_enabled()","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"From: Faizal Rahim \n\nMove the advertised link modes and flow control configuration from\nigc_ethtool_set_link_ksettings() into igc_handle_autoneg_enabled().\n\nNo functional change.\n\nReviewed-by: Looi, Hong Aun \nSigned-off-by: Faizal Rahim \nSigned-off-by: KhaiWenTan \n---\n drivers/net/ethernet/intel/igc/igc_ethtool.c | 72 ++++++++++++--------\n 1 file changed, 44 insertions(+), 28 deletions(-)\n\n--\n2.43.0","diff":"diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c\nindex 0122009bedd0..cfcbf2fdad6e 100644\n--- a/drivers/net/ethernet/intel/igc/igc_ethtool.c\n+++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c\n@@ -2000,6 +2000,49 @@ static int igc_ethtool_get_link_ksettings(struct net_device *netdev,\n \treturn 0;\n }\n\n+/**\n+ * igc_handle_autoneg_enabled - Configure autonegotiation advertisement\n+ * @adapter: private driver structure\n+ * @cmd: ethtool link ksettings from user\n+ *\n+ * Records advertised speeds and flow control settings when autoneg\n+ * is enabled.\n+ */\n+static void igc_handle_autoneg_enabled(struct igc_adapter *adapter,\n+\t\t\t\t const struct ethtool_link_ksettings *cmd)\n+{\n+\tstruct igc_hw *hw = &adapter->hw;\n+\tu16 advertised = 0;\n+\n+\tif (ethtool_link_ksettings_test_link_mode(cmd, advertising,\n+\t\t\t\t\t\t 2500baseT_Full))\n+\t\tadvertised |= ADVERTISE_2500_FULL;\n+\n+\tif (ethtool_link_ksettings_test_link_mode(cmd, advertising,\n+\t\t\t\t\t\t 1000baseT_Full))\n+\t\tadvertised |= ADVERTISE_1000_FULL;\n+\n+\tif (ethtool_link_ksettings_test_link_mode(cmd, advertising,\n+\t\t\t\t\t\t 100baseT_Full))\n+\t\tadvertised |= ADVERTISE_100_FULL;\n+\n+\tif (ethtool_link_ksettings_test_link_mode(cmd, advertising,\n+\t\t\t\t\t\t 100baseT_Half))\n+\t\tadvertised |= ADVERTISE_100_HALF;\n+\n+\tif (ethtool_link_ksettings_test_link_mode(cmd, advertising,\n+\t\t\t\t\t\t 10baseT_Full))\n+\t\tadvertised |= ADVERTISE_10_FULL;\n+\n+\tif (ethtool_link_ksettings_test_link_mode(cmd, advertising,\n+\t\t\t\t\t\t 10baseT_Half))\n+\t\tadvertised |= ADVERTISE_10_HALF;\n+\n+\thw->phy.autoneg_advertised = advertised;\n+\tif (adapter->fc_autoneg)\n+\t\thw->fc.requested_mode = igc_fc_default;\n+}\n+\n static int\n igc_ethtool_set_link_ksettings(struct net_device *netdev,\n \t\t\t const struct ethtool_link_ksettings *cmd)\n@@ -2007,7 +2050,6 @@ igc_ethtool_set_link_ksettings(struct net_device *netdev,\n \tstruct igc_adapter *adapter = netdev_priv(netdev);\n \tstruct net_device *dev = adapter->netdev;\n \tstruct igc_hw *hw = &adapter->hw;\n-\tu16 advertised = 0;\n\n \t/* When adapter in resetting mode, autoneg/speed/duplex\n \t * cannot be changed\n@@ -2032,34 +2074,8 @@ igc_ethtool_set_link_ksettings(struct net_device *netdev,\n \twhile (test_and_set_bit(__IGC_RESETTING, &adapter->state))\n \t\tusleep_range(1000, 2000);\n\n-\tif (ethtool_link_ksettings_test_link_mode(cmd, advertising,\n-\t\t\t\t\t\t 2500baseT_Full))\n-\t\tadvertised |= ADVERTISE_2500_FULL;\n-\n-\tif (ethtool_link_ksettings_test_link_mode(cmd, advertising,\n-\t\t\t\t\t\t 1000baseT_Full))\n-\t\tadvertised |= ADVERTISE_1000_FULL;\n-\n-\tif (ethtool_link_ksettings_test_link_mode(cmd, advertising,\n-\t\t\t\t\t\t 100baseT_Full))\n-\t\tadvertised |= ADVERTISE_100_FULL;\n-\n-\tif (ethtool_link_ksettings_test_link_mode(cmd, advertising,\n-\t\t\t\t\t\t 100baseT_Half))\n-\t\tadvertised |= ADVERTISE_100_HALF;\n-\n-\tif (ethtool_link_ksettings_test_link_mode(cmd, advertising,\n-\t\t\t\t\t\t 10baseT_Full))\n-\t\tadvertised |= ADVERTISE_10_FULL;\n-\n-\tif (ethtool_link_ksettings_test_link_mode(cmd, advertising,\n-\t\t\t\t\t\t 10baseT_Half))\n-\t\tadvertised |= ADVERTISE_10_HALF;\n-\n \tif (cmd->base.autoneg == AUTONEG_ENABLE) {\n-\t\thw->phy.autoneg_advertised = advertised;\n-\t\tif (adapter->fc_autoneg)\n-\t\t\thw->fc.requested_mode = igc_fc_default;\n+\t\tigc_handle_autoneg_enabled(adapter, cmd);\n \t} else {\n \t\tnetdev_info(dev, \"Force mode currently not supported\\n\");\n \t}\n","prefixes":["iwl-next","v2","2/3"]}