{"id":2223712,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2223712/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260416014928.1279360-9-jamin_lin@aspeedtech.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260416014928.1279360-9-jamin_lin@aspeedtech.com>","date":"2026-04-16T01:49:45","name":"[v3,08/17] hw/usb/hcd-ehci: Reject CTRLDSSEGMENT writes without 64-bit capability","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"51430a696438c922fcf5c341b976770c1f9f0456","submitter":{"id":81768,"url":"http://patchwork.ozlabs.org/api/1.1/people/81768/?format=json","name":"Jamin Lin","email":"jamin_lin@aspeedtech.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260416014928.1279360-9-jamin_lin@aspeedtech.com/mbox/","series":[{"id":500066,"url":"http://patchwork.ozlabs.org/api/1.1/series/500066/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500066","date":"2026-04-16T01:49:32","name":"hw/usb/ehci: Add 64-bit descriptor addressing support","version":3,"mbox":"http://patchwork.ozlabs.org/series/500066/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2223712/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2223712/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=aspeedtech.com header.i=@aspeedtech.com\n header.a=rsa-sha256 header.s=selector1 header.b=BVh2K0Wz;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=aspeedtech.com;"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fx1GG3VN3z1yHV\n\tfor ; Thu, 16 Apr 2026 11:51:50 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wDBsL-0008Gq-5S; Wed, 15 Apr 2026 21:50:37 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wDBro-0007sb-N0; Wed, 15 Apr 2026 21:50:11 -0400","from mail-japaneastazlp170120005.outbound.protection.outlook.com\n ([2a01:111:f403:c405::5] helo=TYPPR03CU001.outbound.protection.outlook.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wDBrm-0007Ut-SC; Wed, 15 Apr 2026 21:50:04 -0400","from TYPPR06MB8206.apcprd06.prod.outlook.com (2603:1096:405:383::19)\n by SEYPR06MB6202.apcprd06.prod.outlook.com (2603:1096:101:c7::12)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.48; Thu, 16 Apr\n 2026 01:49:45 +0000","from TYPPR06MB8206.apcprd06.prod.outlook.com\n ([fe80::e659:1ead:77cb:f6d3]) by TYPPR06MB8206.apcprd06.prod.outlook.com\n ([fe80::e659:1ead:77cb:f6d3%3]) with mapi id 15.20.9818.017; Thu, 16 Apr 2026\n 01:49:45 +0000"],"ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=mb1u1C/WH5XJ0V6eSkO9q5wl6IGw1FJ0pV3xJPSxykvGP4yHeNDCx4bnnXEIMwkpbmzq/VOx4gvFFjutLwE7fo4QvOYyTrheCD7iV1ShZPg7ecmdghlePVk6AbtKXW0p8v+CAocXT7mALGYmQzWikcQLD3T+AKfBSTk5WUbFiZZfCtLq9K/Iq5CbrxqjEg4X4VaY/1w7V0/gKuJQvH5xwd3vVRMhFPa6CPEiNSiJT7Hp4Vhe4qkP3dI15sudjoW+bwJhWOdr6WFEofRIdJP1BFO4u1zrHmpllpvNGG2rBjndZKO3V2k2RVkCg6v8kBYRVWsW9x0ZGzj/mJocb7nTiA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=Q+mmQwIDcXjYZQ7eiIgMS2IKUaumd4IMqBC+8JCwHS4=;\n b=PiFtip0vFwczYrJMfmb0HD/YAcOIQFFmECyqm2V3WehUsjfU8lLTdXFtdhMXdjPlw/cS9gvrrtuwvzGSmdgXH59JGbySITJhi2ZpjWFRWyn//XcW5rH97m9xFRKl+209q2cFZecS8qqAyIo7rejUn9RLnAffRez/l6T39lWhgclBFztXoaI32vaOyWiLXTGres5Vt4XHqW5R/gDy7vl9HJ1UY8+yLFZ1NjtWJWO6r8rIaOJ73apFakW1EgHdp7398xeib6YhH0z0tfMw230orRwALhWWkQkmseyTOIU4C1T3+XlZ8S+3PoXGdKjs+P1weYosyPAym7oL9Vz/ltWzdg==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=aspeedtech.com; dmarc=pass action=none\n header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=Q+mmQwIDcXjYZQ7eiIgMS2IKUaumd4IMqBC+8JCwHS4=;\n b=BVh2K0Wz00dcMNkfTIPiI5IUrn2x4AxDMZeVAVane4EomfrhAGqiLdFuzcgmh5N+LFpl+FkqlxXnrePfePB4aTIG/GllxTj6JooNkIx8M4/PzeRtjYk/J/5A3zlsycyzIkwe+BC46gQ94KHCUio9zAPeIOxP3lza2OZ3J/RiSNA+nyHKWimCIhv7jgZHuoGqnJEKC7caJdIHGQdbyA1Rnp1ejdVS45PsLbyCrsMIzjiBR8Ol7Jj81X5YSx51H8WyYebDa4+TpvhACyFLFDbWwCXU8ctv9X2sOLOPDOdf3f4EtxMNd3t+zh5Tw4GWs7yzpdruKeo2TraS72zQBL/tiQ==","From":"Jamin Lin ","To":"\"philmd@linaro.org\" , =?iso-8859-1?q?C=E9dric_Le_Goat?=\n\t=?iso-8859-1?q?er?= , Peter Maydell ,\n Steven Lee , Troy Lee ,\n Kane Chen ,\n Andrew Jeffery , Joel Stanley ,\n \"open list:ASPEED BMCs\" ,\n \"open list:All patches CC here\" ","CC":"Jamin Lin , Troy Lee ,\n \"flwu@google.com\" , \"nabihestefan@google.com\"\n ","Subject":"[PATCH v3 08/17] hw/usb/hcd-ehci: Reject CTRLDSSEGMENT writes without\n 64-bit capability","Thread-Topic":"[PATCH v3 08/17] hw/usb/hcd-ehci: Reject CTRLDSSEGMENT writes\n without 64-bit capability","Thread-Index":"AQHczUNMTNflNW37RU+bzbw6mVnqig==","Date":"Thu, 16 Apr 2026 01:49:45 +0000","Message-ID":"<20260416014928.1279360-9-jamin_lin@aspeedtech.com>","References":"<20260416014928.1279360-1-jamin_lin@aspeedtech.com>","In-Reply-To":"<20260416014928.1279360-1-jamin_lin@aspeedtech.com>","Accept-Language":"zh-TW, en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","authentication-results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=aspeedtech.com header.i=@aspeedtech.com\n header.a=rsa-sha256 header.s=selector1 header.b=BVh2K0Wz;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=aspeedtech.com;"],"x-ms-publictraffictype":"Email","x-ms-traffictypediagnostic":"TYPPR06MB8206:EE_|SEYPR06MB6202:EE_","x-ms-office365-filtering-correlation-id":"d38592a4-ce9a-4c1c-56f8-08de9b5a6f69","x-ms-exchange-senderadcheck":"1","x-ms-exchange-antispam-relay":"0","x-microsoft-antispam":"BCL:0;\n ARA:13230040|376014|7416014|1800799024|366016|38070700021|921020|18002099003|22082099003|56012099003;","x-microsoft-antispam-message-info":"\n 7p4ksrtEbdBIEIFuTHUrUCipAe01/17kXSddnC++TJHGgySxiQEoos8uIJ6qNlFpm0NkccOxAXw9lkKyG1TYQOUTRkDA58p/nAeNNsqTuty96pgFuRRVVDeytyf3N3/ZIedS5xsO/FGXLjlcfP2HVjSJwMNTxOKUSJVWXVhpmv/V5rmAOKRsX8NATl/GYNiPu0qK9eCJbieZpsZIL+pKlSeFjeBsmB6G35YNM0aTmlGdUMyDFd6xarp1RAFQizMiDvMrqt3BeGmDTfPjbqoWNleU/otUTr2ClW4WRj/P+gDJHvv4puAGVjxUYgqoTUUqH51evx4FoE9vF49iW2UYQ7kMOgbXcQuKDv2PAEklxy6oBKNr9ry21xpT6pi4BNLSirOoV7mepXSC00DsuGJrW5uzVHfiffUMJVnD66WwFrEh6gNZXVB2wImVgAwyPhqi6i2eD7GY1S95duDihKmh2yg1spQXafFydxnB8E4Rlvct0hJ8fHx9xLNXzhnwxe2/EwduFJDhQcPvIN7u0a5P3tkeIng/jSCIt5KyrgaVRsQw/0l0ziP8Y2QHFaPYyEFBJfq4uCPKhis2X4xDBO776IPzw7QWgBX/6gKJV7+KvOuFgLpS0rH7e4ELA5FvSSKzIMC6LnwcVux2AGj5RL3tpp7VC9vPvmfoDXo5bvDlIULYMf08BDQeCENfgZhwoCU73U7jg5bZRaUfm3+yLC8oOuueqEEpnCeduz+Mq6IQk46myiVFZEMoetWVAF3uE7CuLad+Q5R+ZhAaH5P8VSiBAJKe0jDqAJzYwsLmkZ+yUQQJ4KxgQmq34+AhU8bjeyVJ","x-forefront-antispam-report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:TYPPR06MB8206.apcprd06.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(376014)(7416014)(1800799024)(366016)(38070700021)(921020)(18002099003)(22082099003)(56012099003);\n DIR:OUT; SFP:1102;","x-ms-exchange-antispam-messagedata-chunkcount":"1","x-ms-exchange-antispam-messagedata-0":"=?iso-8859-1?q?icqSRBBtUOROsLPWBDZ8d9w?=\n\t=?iso-8859-1?q?rzWemSZAXi/9Ki9fk5zNxWpuHt+6KGIV+J+hJl3dCNOTLhktczL/gAREjg/w?=\n\t=?iso-8859-1?q?G6Fd8LczMocURM6D8ROTS6kWynet65J5nu6jenZaJnoxjSw74lkclGk+yttb?=\n\t=?iso-8859-1?q?L12bHhX0Pr7spx//dLtt+bXGnsbvi6C0OP0GAsKhf86phZPUjS5CwzWRtO1i?=\n\t=?iso-8859-1?q?abpC4dqDBvgw8PtHUlVwFjab+E5fSlsYjQelPP2hTgHXPUcGbneHumZ9re2D?=\n\t=?iso-8859-1?q?hDWzy+6gGzerzilu4TK+a0rKGRX34JY5xiZM7ll2aIryT0OPOFf39MhFaicT?=\n\t=?iso-8859-1?q?FHT/K5mm1DGSXWiFP2g8tXqC+at7FejtnXFGeZH3QV4lxNwBFuuKAtLKWV3x?=\n\t=?iso-8859-1?q?mB35SltxnhpYE+4qau9KxhY37Oyh0v6H3Rm6cEHU/alL/KZ+YpHwC/5PJVNA?=\n\t=?iso-8859-1?q?OckC38tUIwjDYL2KwF1POYpXcqMuHPBsquWzuqKqoUzwyqbLcmTrnLme9ZVT?=\n\t=?iso-8859-1?q?pxLDJur2jj5cxCxoV5yb0RNDVDNZkoIJCKLhHvsX5HQEM/pGtnXRNRFuL4TT?=\n\t=?iso-8859-1?q?tkzzGXX4ugkOJJB1F/PazEXoyejRPux7tMIzKx75Vpgs610LBD4VRZmjWkWt?=\n\t=?iso-8859-1?q?VgULHUMoTkxKT+POIDZwaXNQHA8uv9qjDuHUn7XtFTrg5oNRsPymrXqPTOh2?=\n\t=?iso-8859-1?q?GKqNKT6WYgTorSQrrz4IhkFWsOFNnhkQQt9C35QMipDRC1eZFYJjZpj/NKli?=\n\t=?iso-8859-1?q?pemSuT0yVlxk0KgVXKTCb2Jzw24HwB7ELN2TR0L3T1NFqvKcbi2Qfx0gqWKo?=\n\t=?iso-8859-1?q?ApP+bJtA7n5qXSzqWhZnMIVLzCkKvCVLC71ckJwsW8o1FSMZ/HqzxUXSPk07?=\n\t=?iso-8859-1?q?tyo+N3YiGa+qr+2OLwBfh0i42VAG5ibVmwvfpX1IZujLeW4oGKe+jt07QTa6?=\n\t=?iso-8859-1?q?jXKTX6UFfzywx/5iZcordyyeokN2qBTzJ9/x+K5YRMuWK33OAQewyAY1bLfW?=\n\t=?iso-8859-1?q?Dlf3SAokWzG26NGc1uuwFl/ii8f7gqVwL8jIAoLiW6QokMvP9sHwqHVTXUHF?=\n\t=?iso-8859-1?q?1muU9h4RyeamJwMklLF72X7m2Eg8yY8hLJ0ecTSKQtZPU4P0hbaRPe4C7uYx?=\n\t=?iso-8859-1?q?0bV55mHbO7F15Yun/HsHJiG1Rn4+y5tVpiK8JlRGB+ZvljdMhHWPDkV9NSrp?=\n\t=?iso-8859-1?q?3umLuPVOlCtRLL9473xqakYfdjyZ6uJf2M+xl9br4Obj2O0rP7euQqZvKyZq?=\n\t=?iso-8859-1?q?E4RBaNNmonJm7VXlwXQv1kVrFtY8WAVDipsfUSWcnJdkj9xIaRysYdg8atJ5?=\n\t=?iso-8859-1?q?tVnbf0HXY8B/o2C37x87128pwFTSF6NCAvB9u4UV47f95a0BOhesbMtXINIm?=\n\t=?iso-8859-1?q?hSsEEWvy9YRRM0Sxtz0gJJr9OiVM4zqnCyusZMLd7+TS7FdhLkmosgPJA99E?=\n\t=?iso-8859-1?q?Fl5CdkU1OdeSEd//L7KVyA50Udv0yCfyMIDsDc168zxZ+2hpmK/qhC0/FZhO?=\n\t=?iso-8859-1?q?HIeoYkc081ZVMPJhpx9vnlms50EQhoChyaIKAwgfChSNV9R19yTsVJUcZ7hy?=\n\t=?iso-8859-1?q?yPKFAqfLXU+10XnhH902Fihb/WDnFnMqvz5gfgWvRkMNHGgASzorjQoGaLbx?=\n\t=?iso-8859-1?q?0sYDkfxjZj2uUXyiVJ1q5hST+mZqMpmHLXezPaY3+zSPDSqQM9ZvKmmMsYWG?=\n\t=?iso-8859-1?q?bOQxR0ODp5rCFxKzwfRK22JvrP0+fr7RFMHKO23TV8SeB+7iGTJ4UhnxA/Df?=\n\t=?iso-8859-1?q?wsC5S6g2K7UWWVGgbRaPzuAhQSqztFpiZI8f44lCZebQzEQ=3D=3D?=","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","X-Exchange-RoutingPolicyChecked":"\n pEa+2KERKAwhwbp0xteyfGDXnEtEQnu9VFYWGlkqe/o55ABgtEDJEBFqGjHS8WYQFgnxMk4HW4rmqXipewOuAg+gZItf6rlUqMRLerzAmnBpMyfrT1L1RcgRei8C3rC+T0B7kUtk+yrvyv84ek8O+8Y9Jlr2cgem/mVjInMgh82X96GKnyUVpL6/C/rEIc3ySLLCUyxTCcr42ZGb7xc7IGG1ieN4Z36/9AXpeIP8IygKNp+9NELO+OVkgfvAex1bSqRyXQnW27NytaY+TqgJhwTvhMFgYnPPhtn4rjI+kw6MLAm9N/9nFRv2JKtTTfywySGG0tT29pG1tmcNJVVEUQ==","X-OriginatorOrg":"aspeedtech.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-AuthSource":"TYPPR06MB8206.apcprd06.prod.outlook.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n d38592a4-ce9a-4c1c-56f8-08de9b5a6f69","X-MS-Exchange-CrossTenant-originalarrivaltime":"16 Apr 2026 01:49:45.1386 (UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"43d4aa98-e35b-4575-8939-080e90d5a249","X-MS-Exchange-CrossTenant-mailboxtype":"HOSTED","X-MS-Exchange-CrossTenant-userprincipalname":"\n V5QMx2sBXbTR4e+OkvaTOSPQWQqrfdU1iIY8VDQcWdMlzcxvwwla8qyjCKY3Iw5Uk1WQjfEkndEts2gVO+ntGRAUt6dtSEVagV7BB19fKXY=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"SEYPR06MB6202","Received-SPF":"pass client-ip=2a01:111:f403:c405::5;\n envelope-from=jamin_lin@aspeedtech.com;\n helo=TYPPR03CU001.outbound.protection.outlook.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The EHCI CTRLDSSEGMENT register provides the upper 32 bits [63:32] used to\nform 64-bit addresses for EHCI control data structures. Per EHCI 1.0\nspec section 2.3.5, when the HCCPARAMS 64-bit Addressing Capability bit\nis zero, CTRLDSSEGMENT is not used: software cannot write it and reads\nmust return zero.\n\nAdd a capability check in the operational register write handler and\nreject guest writes to CTRLDSSEGMENT when 64-bit addressing is\nnot enabled.\n\nSigned-off-by: Jamin Lin \n---\n hw/usb/hcd-ehci.c | 9 ++++++++-\n 1 file changed, 8 insertions(+), 1 deletion(-)","diff":"diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c\nindex 6409457186..b9e4251d62 100644\n--- a/hw/usb/hcd-ehci.c\n+++ b/hw/usb/hcd-ehci.c\n@@ -1108,7 +1108,14 @@ static void ehci_opreg_write(void *ptr, hwaddr addr,\n \" is enabled and HC is enabled\\n\");\n }\n break;\n-\n+ case CTRLDSSEGMENT:\n+ if (!s->caps_64bit_addr) {\n+ qemu_log_mask(LOG_GUEST_ERROR,\n+ \"ehci: write to CTRLDSSEGMENT while \"\n+ \" 64-bit addressing capability is disabled\\n\");\n+ return;\n+ }\n+ break;\n case ASYNCLISTADDR:\n if (ehci_async_enabled(s)) {\n qemu_log_mask(LOG_GUEST_ERROR,\n","prefixes":["v3","08/17"]}