{"id":2223663,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2223663/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260415232906.212349-2-stefanha@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260415232906.212349-2-stefanha@redhat.com>","date":"2026-04-15T23:29:05","name":"[1/2] scsi: change buf_size to unsigned int in scsi_SG_IO()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"3cae09e46dfeb1afa50fa7868041f66036ea95ab","submitter":{"id":17227,"url":"http://patchwork.ozlabs.org/api/1.1/people/17227/?format=json","name":"Stefan Hajnoczi","email":"stefanha@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260415232906.212349-2-stefanha@redhat.com/mbox/","series":[{"id":500051,"url":"http://patchwork.ozlabs.org/api/1.1/series/500051/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500051","date":"2026-04-15T23:29:04","name":"scsi: handle reservation changes across migration","version":1,"mbox":"http://patchwork.ozlabs.org/series/500051/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2223663/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2223663/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=iiMWxF4i;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwy6g2rxMz1yCv\n\tfor ; Thu, 16 Apr 2026 09:30:03 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wD9fe-00013R-M1; Wed, 15 Apr 2026 19:29:22 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wD9fc-00012p-RY\n for qemu-devel@nongnu.org; Wed, 15 Apr 2026 19:29:20 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wD9fa-00010Z-FL\n for qemu-devel@nongnu.org; Wed, 15 Apr 2026 19:29:20 -0400","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-631-wdUZKjSDPhmsB7Q4wpw8MA-1; Wed,\n 15 Apr 2026 19:29:16 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 546931956095; Wed, 15 Apr 2026 23:29:15 +0000 (UTC)","from localhost (unknown [10.44.34.70])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id F147430001A4; Wed, 15 Apr 2026 23:29:13 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776295757;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=/ykdNZSAaW0/nvkmQYjbcWRVUA1nOc186/+rW2QcWnQ=;\n b=iiMWxF4i5/YwNmWNxzHRNTd217Io9KLXRraAMWAy3gdHWcH/z4OWOoniGmJkp69FmdTsbp\n YfvAfS/ZmAqcd7fl19IapgTm2EYhXx2IslE4Cu2YQ9i7+rhRwPT0bt/HueMf+XvDOs9CcC\n 0k7wS2fGeLmEs39cUXSirGYFZ1qiY5A=","X-MC-Unique":"wdUZKjSDPhmsB7Q4wpw8MA-1","X-Mimecast-MFC-AGG-ID":"wdUZKjSDPhmsB7Q4wpw8MA_1776295755","From":"Stefan Hajnoczi ","To":"qemu-devel@nongnu.org","Cc":"Fam Zheng , Paolo Bonzini ,\n , Stefan Hajnoczi ","Subject":"[PATCH 1/2] scsi: change buf_size to unsigned int in scsi_SG_IO()","Date":"Wed, 15 Apr 2026 19:29:05 -0400","Message-ID":"<20260415232906.212349-2-stefanha@redhat.com>","In-Reply-To":"<20260415232906.212349-1-stefanha@redhat.com>","References":"<20260415232906.212349-1-stefanha@redhat.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=stefanha@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"7","X-Spam_score":"0.7","X-Spam_bar":"/","X-Spam_report":"(0.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_SBL_CSS=3.335, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"SG_IO supports an unsigned int dxfer_len value. Existing callers use\nless than 256 bytes, so scsi_SG_IO()'s uint8_t buf_size type was\nsufficient. The next patch will use a larger value, so update the type.\n\nSigned-off-by: Stefan Hajnoczi \n---\n include/hw/scsi/scsi.h | 3 ++-\n hw/scsi/scsi-generic.c | 2 +-\n 2 files changed, 3 insertions(+), 2 deletions(-)","diff":"diff --git a/include/hw/scsi/scsi.h b/include/hw/scsi/scsi.h\nindex a3e246dbd9..5f83e58d1d 100644\n--- a/include/hw/scsi/scsi.h\n+++ b/include/hw/scsi/scsi.h\n@@ -247,7 +247,8 @@ void scsi_device_unit_attention_reported(SCSIDevice *dev);\n void scsi_generic_read_device_inquiry(SCSIDevice *dev);\n int scsi_device_get_sense(SCSIDevice *dev, uint8_t *buf, int len, bool fixed);\n int scsi_SG_IO(BlockBackend *blk, int direction, uint8_t *cmd, uint8_t cmd_size,\n- uint8_t *buf, uint8_t buf_size, uint32_t timeout, Error **errp);\n+ uint8_t *buf, unsigned int buf_size, uint32_t timeout,\n+ Error **errp);\n SCSIDevice *scsi_device_find(SCSIBus *bus, int channel, int target, int lun);\n SCSIDevice *scsi_device_get(SCSIBus *bus, int channel, int target, int lun);\n \ndiff --git a/hw/scsi/scsi-generic.c b/hw/scsi/scsi-generic.c\nindex 5182f9236d..29bc952af5 100644\n--- a/hw/scsi/scsi-generic.c\n+++ b/hw/scsi/scsi-generic.c\n@@ -794,7 +794,7 @@ static int read_naa_id(const uint8_t *p, uint64_t *p_wwn)\n }\n \n int scsi_SG_IO(BlockBackend *blk, int direction, uint8_t *cmd,\n- uint8_t cmd_size, uint8_t *buf, uint8_t buf_size,\n+ uint8_t cmd_size, uint8_t *buf, unsigned int buf_size,\n uint32_t timeout, Error **errp)\n {\n sg_io_hdr_t io_header;\n","prefixes":["1/2"]}