{"id":2223651,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2223651/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260415215539.92629-5-philmd@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260415215539.92629-5-philmd@linaro.org>","date":"2026-04-15T21:55:35","name":"[4/8] cocci: Do not initialize variable used by QTAILQ_FOREACH macro","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"9ea106e7a3a1ef223c603e2be597b381c825d2ab","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.1/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260415215539.92629-5-philmd@linaro.org/mbox/","series":[{"id":500043,"url":"http://patchwork.ozlabs.org/api/1.1/series/500043/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500043","date":"2026-04-15T21:55:33","name":"cocci: Do not initialize variable used by *FOREACH*() macro","version":1,"mbox":"http://patchwork.ozlabs.org/series/500043/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2223651/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2223651/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=izI+MYoJ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fww4h711xz1yCv\n\tfor ; Thu, 16 Apr 2026 07:58:12 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wD8Df-0002O6-Ds; Wed, 15 Apr 2026 17:56:23 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wD8DW-0002LM-Mv\n for qemu-devel@nongnu.org; Wed, 15 Apr 2026 17:56:15 -0400","from mail-wm1-x335.google.com ([2a00:1450:4864:20::335])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wD8DT-0002lJ-KH\n for qemu-devel@nongnu.org; Wed, 15 Apr 2026 17:56:14 -0400","by mail-wm1-x335.google.com with SMTP id\n 5b1f17b1804b1-488a88aeec9so96977495e9.2\n for ; Wed, 15 Apr 2026 14:56:10 -0700 (PDT)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488f584e243sm261015e9.10.2026.04.15.14.56.07\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Wed, 15 Apr 2026 14:56:08 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776290169; x=1776894969; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=SbzRYXXryYZ+mwGu76PWqGXVlNyCIhPPUDzA8n+lP6I=;\n b=izI+MYoJthDgTj44brPRhQa+liqJvitMw8GBXLbPFV8PQ+nFHWFIQSL46YFnDHnZIj\n VKpXUI7zEU/N+10hQPdO/bP01SbgofIbhxVAQMtg1fsPd0A9YCjqgbhnxtmbgvB8jqBT\n gUWCXOy8aOTCimwRMuZeo4yoXKcWTLjMCIu7vBdv1kc3kxS2xmzj9mfLNnkpBKFb/jyc\n fdjlyiyfz78Yv+vf0nz7T6a+l7pkv7I+69P3pIfW1dZf2J3yH5RWL9kXlSSvfzYjaLRO\n Ium8NgZdoYD3r4qjEhXzx1fuwdAf2/pmnEk+zgyReUdE1xmfQ78WsHt0Jl2Kts0TVvwT\n CWoQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776290169; x=1776894969;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=SbzRYXXryYZ+mwGu76PWqGXVlNyCIhPPUDzA8n+lP6I=;\n b=fge3HXQgGziO7CFFrTawtBv5z9LyCN/lOUyW6e93Ste2h2N1HD4OgASONOjU90I7g4\n ZlV04wRFK/EjtBbTbS70xHlfA/BecLKRrLuhIw+jGHRxmyeuGz7sudOmR7cHn3fD2Gss\n 9Btyv0CtCxO7bRq+pHwAXTBdUdaTPRpQ4NgfIylfH2QtcKLVImZWIAOOKw5NbqtoPaGU\n 4BEmXSZG+t+Cz+mwPPOU6d1TjuLmNvnY2xjanLCvD0BPHkkfe0fillYyRsjAdBO0JKfB\n feJERBvjaCKx1GW5z+jPQ2vhau5iDqSOQsmNUVBbLRit3Zz1G/FkKJukfQX29PDIRtTI\n 7zbQ==","X-Gm-Message-State":"AOJu0YwAqylBevh5kxIJe0bVvYCumHmoH6agBlrdti+PEYIqegOlY8ti\n 46CJKqPU+UsAWsNCkxLE21yI+H163k9ls+uHfOG3b4BuOC22F+xodlI02RC9tu947Uq51e34Jd3\n RvRggnOY=","X-Gm-Gg":"AeBDietiZp6c/2KFtGb6v+piVhXIahsvXS+LNV+8SpCk+p/F5ygaJ13V99R/O/kjIrQ\n HWvQHivyU/wj3xn/T95PGMrGTy79cHcZeM6uo9JeueXINK5gQ3/g2q4aoa6/vBW6GiocvnjqEVL\n s/U/XM0EBMlCBd04wEhK3vOQe5kjNiFp/nIcLutge5nn9MBazEZXKOVk+YO0tA0FwSkC2Q3HKMm\n NDWNDAzUi5/zmL/ZIWwKIwUIetoK9oTzgUqF6R6FIEsRZCpTyKKwpU2/htzF/LFi+0qutVtaPPG\n 2R66Jcqsh+D81ucPi87nKYOnLWnqatVr2ANlIEBhIpdShLfjXBilsnq7//rQRMfoGxtWORY5Ztd\n yu7NZS+Etv5+6YOvbEpi2urrxLSWKxSUyWOc7pgz5BEzXj8hO0ktK5SGtFw/2ChJgh89hLYX9cP\n Wfetlv/Zju0WP+BIPBj4D+LHXo8+ZDLhzt6+SDYuaqdPZbj51uFnN7W6HCmGf4TK9MmkuLs7xf","X-Received":"by 2002:a05:600c:348d:b0:486:ff92:63e5 with SMTP id\n 5b1f17b1804b1-488d67df5aamr346175875e9.6.1776290168733;\n Wed, 15 Apr 2026 14:56:08 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"qemu-arm@nongnu.org, qemu-s390x@nongnu.org, qemu-riscv@nongnu.org,\n qemu-block@nongnu.org","Subject":"[PATCH 4/8] cocci: Do not initialize variable used by QTAILQ_FOREACH\n macro","Date":"Wed, 15 Apr 2026 23:55:35 +0200","Message-ID":"<20260415215539.92629-5-philmd@linaro.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260415215539.92629-1-philmd@linaro.org>","References":"<20260415215539.92629-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::335;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x335.google.com","X-Spam_score_int":"4","X-Spam_score":"0.4","X-Spam_bar":"/","X-Spam_report":"(0.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1,\n DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001,\n SUSPICIOUS_RECIPS=2.51 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The QTAILQ_FOREACH() macro, defined in \"qemu/queue.h\",\nalways assigns its iterator variable when entering the\nloop. Remove the pointless and possibly misleading\nassignment.\n\nMechanical patch using the following coccinelle spatch:\n\n @@\n type T;\n identifier e;\n iterator FOREACH_MACRO =~ \".*_FOREACH.*\";\n statement S;\n @@\n - T *e = ...;\n + T *e;\n ... when != e\n FOREACH_MACRO(e, ...) S\n\nSigned-off-by: Philippe Mathieu-Daudé \n---\n hw/ppc/spapr.c | 2 +-\n hw/ppc/spapr_events.c | 4 ++--\n net/colo-compare.c | 4 ++--\n net/net.c | 2 +-\n target/s390x/kvm/stsi-topology.c | 2 +-\n 5 files changed, 7 insertions(+), 7 deletions(-)","diff":"diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c\nindex 0ab39dfea6b..bc7232e774a 100644\n--- a/hw/ppc/spapr.c\n+++ b/hw/ppc/spapr.c\n@@ -3685,7 +3685,7 @@ struct SpaprDimmState {\n static SpaprDimmState *spapr_pending_dimm_unplugs_find(SpaprMachineState *s,\n PCDIMMDevice *dimm)\n {\n- SpaprDimmState *dimm_state = NULL;\n+ SpaprDimmState *dimm_state;\n \n QTAILQ_FOREACH(dimm_state, &s->pending_dimm_unplugs, next) {\n if (dimm_state->dimm == dimm) {\ndiff --git a/hw/ppc/spapr_events.c b/hw/ppc/spapr_events.c\nindex 1a21ac7bbf8..ab23e3f477b 100644\n--- a/hw/ppc/spapr_events.c\n+++ b/hw/ppc/spapr_events.c\n@@ -460,7 +460,7 @@ static void rtas_event_log_queue(SpaprMachineState *spapr,\n static SpaprEventLogEntry *rtas_event_log_dequeue(SpaprMachineState *spapr,\n uint32_t event_mask)\n {\n- SpaprEventLogEntry *entry = NULL;\n+ SpaprEventLogEntry *entry;\n \n QTAILQ_FOREACH(entry, &spapr->pending_events, next) {\n const SpaprEventSource *source =\n@@ -482,7 +482,7 @@ static SpaprEventLogEntry *rtas_event_log_dequeue(SpaprMachineState *spapr,\n \n static bool rtas_event_log_contains(SpaprMachineState *spapr, uint32_t event_mask)\n {\n- SpaprEventLogEntry *entry = NULL;\n+ SpaprEventLogEntry *entry;\n \n QTAILQ_FOREACH(entry, &spapr->pending_events, next) {\n const SpaprEventSource *source =\ndiff --git a/net/colo-compare.c b/net/colo-compare.c\nindex c356419d6a8..abc1326b704 100644\n--- a/net/colo-compare.c\n+++ b/net/colo-compare.c\n@@ -1396,7 +1396,7 @@ static void colo_compare_init(Object *obj)\n \n void colo_compare_cleanup(void)\n {\n- CompareState *tmp = NULL;\n+ CompareState *tmp;\n CompareState *n = NULL;\n \n QTAILQ_FOREACH_SAFE(tmp, &net_compares, next, n) {\n@@ -1407,7 +1407,7 @@ void colo_compare_cleanup(void)\n static void colo_compare_finalize(Object *obj)\n {\n CompareState *s = COLO_COMPARE(obj);\n- CompareState *tmp = NULL;\n+ CompareState *tmp;\n \n qemu_mutex_lock(&colo_compare_mutex);\n QTAILQ_FOREACH(tmp, &net_compares, next) {\ndiff --git a/net/net.c b/net/net.c\nindex a176936f9bc..2892f1730d1 100644\n--- a/net/net.c\n+++ b/net/net.c\n@@ -653,7 +653,7 @@ static ssize_t filter_receive_iov(NetClientState *nc,\n NetPacketSent *sent_cb)\n {\n ssize_t ret = 0;\n- NetFilterState *nf = NULL;\n+ NetFilterState *nf;\n \n if (direction == NET_FILTER_DIRECTION_TX) {\n QTAILQ_FOREACH(nf, &nc->filters, next) {\ndiff --git a/target/s390x/kvm/stsi-topology.c b/target/s390x/kvm/stsi-topology.c\nindex c8d6389cd87..301d41b68d2 100644\n--- a/target/s390x/kvm/stsi-topology.c\n+++ b/target/s390x/kvm/stsi-topology.c\n@@ -285,7 +285,7 @@ static void s390_topology_fill_list_sorted(S390TopologyList *topology_list)\n */\n static void s390_topology_empty_list(S390TopologyList *topology_list)\n {\n- S390TopologyEntry *entry = NULL;\n+ S390TopologyEntry *entry;\n S390TopologyEntry *tmp = NULL;\n \n QTAILQ_FOREACH_SAFE(entry, topology_list, next, tmp) {\n","prefixes":["4/8"]}