{"id":2223650,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2223650/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260415215539.92629-9-philmd@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260415215539.92629-9-philmd@linaro.org>","date":"2026-04-15T21:55:39","name":"[8/8] target/riscv: Iterate vCPUs using CPU_FOREACH() macro","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"fa8d0d29609efbfe47b5d789bafec422ed45a957","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.1/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260415215539.92629-9-philmd@linaro.org/mbox/","series":[{"id":500043,"url":"http://patchwork.ozlabs.org/api/1.1/series/500043/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500043","date":"2026-04-15T21:55:33","name":"cocci: Do not initialize variable used by *FOREACH*() macro","version":1,"mbox":"http://patchwork.ozlabs.org/series/500043/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2223650/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2223650/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=RBKDgv7x;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fww4d5nDVz1yCv\n\tfor ; Thu, 16 Apr 2026 07:58:09 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wD8E5-0002kp-24; Wed, 15 Apr 2026 17:56:49 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wD8Dw-0002bC-Rc\n for qemu-devel@nongnu.org; Wed, 15 Apr 2026 17:56:40 -0400","from mail-wr1-x435.google.com ([2a00:1450:4864:20::435])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wD8Du-0002sm-Ju\n for qemu-devel@nongnu.org; Wed, 15 Apr 2026 17:56:40 -0400","by mail-wr1-x435.google.com with SMTP id\n ffacd0b85a97d-43cfd832155so5059383f8f.1\n for ; Wed, 15 Apr 2026 14:56:38 -0700 (PDT)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43ead3dfff3sm7480881f8f.26.2026.04.15.14.56.35\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Wed, 15 Apr 2026 14:56:35 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776290197; x=1776894997; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=vuIqjkDFYw/UkV0TZBDvRk6uXE3wlZHhGyuhp0aPUMA=;\n b=RBKDgv7ximPB2GInQa14ECT1DEJGv4A/AdgyP+RbMjl8kGjtMnOc5X1JkqwqoQnmc6\n +KomiWK1hPZ2CfXcxesobPv0clIQ1niG0i8cXGcPg2FhSZw9z9/1oeRzTQkNmVA/akW9\n x8jvlEQEJYXX+V050irB8IiMOUEjQvxyQKLBwahmcTyKC7HKZI9mvDYPK2sgm98LPtz9\n znWuMexzUxjTzqL1W266+8PzjcBdn52vfOlU2kHH/O9Ao29LAIu42p9CS/rTcQZlNKT6\n 8JNz/b/tr5op9VB5E6yOGcxe0rI22BtU+hlDAHpZtpA4GeJyhcCfXmzB45rAhcaWDSYA\n ni1g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776290197; x=1776894997;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=vuIqjkDFYw/UkV0TZBDvRk6uXE3wlZHhGyuhp0aPUMA=;\n b=N267g47wUdFpMVOfBFeNN1VFvKr8MNwl0oFnEHFrtUNM7T9dXzijaLzXDmMUBzecs5\n BzUyOQkkHYe3pFPRgKarF1gruBvxJELvf4+5HobRs5/IeUvUPbCepOe/3N9UBI25Wxsn\n cz4hutZHhFzjkq4R0+h++xAoWRjRBbbKiDuxcRuiK46zocCDU6sbS/O+AhKOPRdtunXU\n aTkj47HM11rylwVhuu2RUiSTAuV+jHMwJ/DpT1jeEXfjJARHNyczM0KxIAD9qSHhTmxW\n 8jm77fMCAnjpzVf8x0FPBVvChKFsDuTFQ89F3mG2c5OjhLkEtpdWJn/YOtqokPDJm0CZ\n Vi/Q==","X-Gm-Message-State":"AOJu0YyLmj7oyjUUl+kryNAXs7ULL24j8NlSlkNeYbM2WNHRBFDbh279\n fLhTbMBc7nb8t9dTi50hSuGlXQWrBS+FtBxf+2O5V4EUYOpvWmXyJOYO6WaVw4TAB81Yc/lXXBY\n DH/8yQ9c=","X-Gm-Gg":"AeBDiesk/if4hqemWtTBFT5twtWI8x+0DKM//cf0OGF+p7+oVllvRWA/ZtMbiMQhbtv\n OHcTBa2mO3R4cMDqGe0QiIW1glZz1P5MDQ+wVY7D3tNg3eXSDXRxjJBdnPddkpZr7vxSEjf0CuO\n B/4loDuamKEnDJzoWkhUaq9paLNWxAEpL/vthhaR2grAhly+BEyMLUGZUjht2t6lR61jkEObUpy\n +dhl5K/sj7rcbtr+niYeZE5+dMWWrHzvDqbH9l6xGDkTzS+LrCI8m9EkFQDtry7kZOat2uwwiEE\n +MP7MQB6aAQos3DiJikiKZy3cIl6/Tn+RY4QkWzmnLO3PkQDq0aYweuyrlFtGp2ZDWCz7+/BX7p\n zP/fb/1cweO//bFFbifo1YFk7skpS9XHVM2J/xVneAuVaeBAWIA2nLDvPkd0xdrIdnZRx2u0WLG\n 5fOq5weiJY9OB1Fwj3+0yJoHuJmxqdihyokAv4aNO3xz7jYki0GyIoyzMH3hZtSABFOv/CLcJo","X-Received":"by 2002:a5d:5f92:0:b0:43b:60f7:2283 with SMTP id\n ffacd0b85a97d-43d64289753mr35084545f8f.22.1776290196656;\n Wed, 15 Apr 2026 14:56:36 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"qemu-arm@nongnu.org, qemu-s390x@nongnu.org, qemu-riscv@nongnu.org,\n qemu-block@nongnu.org","Subject":"[PATCH 8/8] target/riscv: Iterate vCPUs using CPU_FOREACH() macro","Date":"Wed, 15 Apr 2026 23:55:39 +0200","Message-ID":"<20260415215539.92629-9-philmd@linaro.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260415215539.92629-1-philmd@linaro.org>","References":"<20260415215539.92629-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::435;\n envelope-from=philmd@linaro.org; helo=mail-wr1-x435.google.com","X-Spam_score_int":"4","X-Spam_score":"0.4","X-Spam_bar":"/","X-Spam_report":"(0.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1,\n DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001,\n SUSPICIOUS_RECIPS=2.51 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Most code iterates over vCPUs using the CPU_FOREACH()\nmacro. Prefer cpu_env(cpu) over &cpu->env.\n\nSigned-off-by: Philippe Mathieu-Daudé \n---\n hw/riscv/boot.c | 9 +++++----\n 1 file changed, 5 insertions(+), 4 deletions(-)","diff":"diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c\nindex e5490beda00..61e21678cd1 100644\n--- a/hw/riscv/boot.c\n+++ b/hw/riscv/boot.c\n@@ -490,10 +490,11 @@ void riscv_setup_direct_kernel(hwaddr kernel_addr, hwaddr fdt_addr)\n {\n CPUState *cs;\n \n- for (cs = first_cpu; cs; cs = CPU_NEXT(cs)) {\n- RISCVCPU *riscv_cpu = RISCV_CPU(cs);\n- riscv_cpu->env.kernel_addr = kernel_addr;\n- riscv_cpu->env.fdt_addr = fdt_addr;\n+ CPU_FOREACH(cs) {\n+ CPURISCVState *env = cpu_env(cs);\n+\n+ env->kernel_addr = kernel_addr;\n+ env->fdt_addr = fdt_addr;\n }\n }\n \n","prefixes":["8/8"]}