{"id":2223649,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2223649/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260415215539.92629-4-philmd@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260415215539.92629-4-philmd@linaro.org>","date":"2026-04-15T21:55:34","name":"[3/8] cocci: Do not initialize variable used by QSIMPLEQ_FOREACH macro","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"aff84fd60f6dbf78cb08f0f5423f20a8cea9b4ff","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.1/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260415215539.92629-4-philmd@linaro.org/mbox/","series":[{"id":500043,"url":"http://patchwork.ozlabs.org/api/1.1/series/500043/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500043","date":"2026-04-15T21:55:33","name":"cocci: Do not initialize variable used by *FOREACH*() macro","version":1,"mbox":"http://patchwork.ozlabs.org/series/500043/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2223649/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2223649/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=ULCXDeA4;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fww4N4MJTz1yCv\n\tfor ; Thu, 16 Apr 2026 07:57:56 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wD8DV-0002K2-DR; Wed, 15 Apr 2026 17:56:13 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wD8DO-0002HG-QJ\n for qemu-devel@nongnu.org; Wed, 15 Apr 2026 17:56:07 -0400","from mail-wm1-x329.google.com ([2a00:1450:4864:20::329])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wD8DL-0002jL-LH\n for qemu-devel@nongnu.org; Wed, 15 Apr 2026 17:56:06 -0400","by mail-wm1-x329.google.com with SMTP id\n 5b1f17b1804b1-482f454be5bso311205e9.0\n for ; Wed, 15 Apr 2026 14:56:03 -0700 (PDT)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488f5818e51sm1034545e9.5.2026.04.15.14.56.00\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Wed, 15 Apr 2026 14:56:01 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776290162; x=1776894962; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=3YcATVaIISTbgVGscn8e0nT489EMZwoo2OUk1DH7jcY=;\n b=ULCXDeA47qpjtuY9x+BL6qRbuLadcmM9f+Im7pKFIfCq4bTwqwiJE1+rGCOwQWHNDM\n oyp1KZC88kNC/74O/IUSJoeYIxwCtwjV/JN+s/PcS9mlF4yWbTlxN3ReesObdMbHSZiE\n W7/sDzIUBpJJdsi9vZFlMTMiL9YoFJQBo6kQtYf+7Wq/SQTymMZ8i9/yAmUvS9cCjbE5\n HZGNCYTpWSW9TBRGvj4CCkQeRZfjiP2AcVXlS01smhb/3h5f2KoHUvXOy0ZLtQ6A7ods\n Z8tfhayFxQjpBdPZOGV71R4KqEODdPi/1LR2nbx2LEqZhoKBAjm89H/VvqlOitcImVev\n bXJg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776290162; x=1776894962;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=3YcATVaIISTbgVGscn8e0nT489EMZwoo2OUk1DH7jcY=;\n b=IzZW3Zclxzud57qoOTTtE9o059YiDxgsOQ1mOTfdZ+53JwbndRkZmtkuat2Z/XwAMx\n NSlmZrcyFnNARmi+RLJVCTLHW9c2vpSFCNjzHsiIwRMmZ4Kf6txEjncf6LARK3gC6Taj\n ZSnBezi5dAtauLR4oqkC7crV4sxBkXo++bMApg2HOJpbP6RLw6ORGGMolRu2g0s2t96y\n vegaQhdpV5MMne+fptJwCBfI5lex4qs1iw+XXDklxyCRQ83yIfJ6j3GMTt9XLerm9XFh\n +4rDLT2djtOJ3JCJQ7BmW/Jbp7AJLcu7IRsEjBYN9GRe/C+lo/+VRvuALcEeR8H/mMAs\n 7jSQ==","X-Gm-Message-State":"AOJu0Yy/L5re16L6D+iqrPkf5YJGSCugGMXVEReoSzJ9PyRjNm0Uf/Wy\n REbN3fY3LF6qTeM+A66u771Ry9P1EsdksB160b/OubURkrxd7DkhsOKV11Lg8VGLk0Ha+BLC0Lg\n Dh83wYGE=","X-Gm-Gg":"AeBDiest23wh+0B7Vp++tR8Kc+XImC6drW7SIg+rP5QIARZ9qlrYUK9rOhXcfnFzeNy\n CDzWyl8enOQpuaX+wsZ3TkVh/60aWWD/VLbK1Orxm/Xho3Wztffv5IyojUYLgV1ZaJ/Znw/iabU\n W6q9b13kQ4n/2kW+r+69dCL5eedE8k74JU2Zbxr5H+IPZiTqn3fiMPaGxBMruq1xvWXAGiAl9nY\n mYJlo8H3vSrBeSOePAbBmTfIu0wDZuJcnGJF9O78G2zEVnIPSz3U3NKySUS6UaPf1jDhMkVxK/B\n cVG82oYANpo3W1L1S3ckRV866MTKuG/HioWcp9mVcwHABfFYlBH+hNHEauLTRKGoH6FtYJ0MtJO\n H74gH/Ue0ZrT3FmrEGFVdajIc8OTocMNUjkNj3dEiL/YQrNpOBz2Zk8kgIMBd9j0p/RMuRh+cu3\n 3Qxztn+KXWjq+CoYw1vVKtInPSzkSMJvD7TsRBMLH4v8QWVlw1g9ONTdP+9PnS4EOpEnzHvOSA","X-Received":"by 2002:a05:600c:c090:b0:485:fbd2:f72 with SMTP id\n 5b1f17b1804b1-488f45cc70amr10941795e9.1.1776290161823;\n Wed, 15 Apr 2026 14:56:01 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"qemu-arm@nongnu.org, qemu-s390x@nongnu.org, qemu-riscv@nongnu.org,\n qemu-block@nongnu.org","Subject":"[PATCH 3/8] cocci: Do not initialize variable used by\n QSIMPLEQ_FOREACH macro","Date":"Wed, 15 Apr 2026 23:55:34 +0200","Message-ID":"<20260415215539.92629-4-philmd@linaro.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260415215539.92629-1-philmd@linaro.org>","References":"<20260415215539.92629-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::329;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x329.google.com","X-Spam_score_int":"4","X-Spam_score":"0.4","X-Spam_bar":"/","X-Spam_report":"(0.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1,\n DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001,\n SUSPICIOUS_RECIPS=2.51 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The QSIMPLEQ_FOREACH() macro, defined in \"qemu/queue.h\",\nalways assigns its iterator variable when entering the\nloop. Remove the pointless and possibly misleading\nassignment.\n\nMechanical patch using the following coccinelle spatch:\n\n @@\n type T;\n identifier e;\n iterator FOREACH_MACRO =~ \".*_FOREACH.*\";\n statement S;\n @@\n - T *e = ...;\n + T *e;\n ... when != e\n FOREACH_MACRO(e, ...) S\n\nSigned-off-by: Philippe Mathieu-Daudé \n---\n block/blkdebug.c | 2 +-\n migration/block-dirty-bitmap.c | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/block/blkdebug.c b/block/blkdebug.c\nindex 8a4a8cb85ea..fdc96d1f45d 100644\n--- a/block/blkdebug.c\n+++ b/block/blkdebug.c\n@@ -591,7 +591,7 @@ static int coroutine_fn rule_check(BlockDriverState *bs, uint64_t offset,\n uint64_t bytes, BlkdebugIOType iotype)\n {\n BDRVBlkdebugState *s = bs->opaque;\n- BlkdebugRule *rule = NULL;\n+ BlkdebugRule *rule;\n int error;\n bool immediately;\n \ndiff --git a/migration/block-dirty-bitmap.c b/migration/block-dirty-bitmap.c\nindex a061aad8177..87009c45182 100644\n--- a/migration/block-dirty-bitmap.c\n+++ b/migration/block-dirty-bitmap.c\n@@ -1216,7 +1216,7 @@ fail:\n static int dirty_bitmap_save_setup(QEMUFile *f, void *opaque, Error **errp)\n {\n DBMSaveState *s = &((DBMState *)opaque)->save;\n- SaveBitmapState *dbms = NULL;\n+ SaveBitmapState *dbms;\n \n if (init_dirty_bitmap_migration(s, errp) < 0) {\n return -1;\n","prefixes":["3/8"]}