{"id":2223647,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2223647/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260415215539.92629-6-philmd@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260415215539.92629-6-philmd@linaro.org>","date":"2026-04-15T21:55:36","name":"[5/8] cocci: Do not initialize variable used by RAMBLOCK_FOREACH* macro","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"edf121c26c6a3b00fdac10cb57f6d93ad0e3377e","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.1/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260415215539.92629-6-philmd@linaro.org/mbox/","series":[{"id":500043,"url":"http://patchwork.ozlabs.org/api/1.1/series/500043/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500043","date":"2026-04-15T21:55:33","name":"cocci: Do not initialize variable used by *FOREACH*() macro","version":1,"mbox":"http://patchwork.ozlabs.org/series/500043/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2223647/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2223647/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=kpInVKQG;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fww3w3sK6z1yCv\n\tfor ; Thu, 16 Apr 2026 07:57:32 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wD8Di-0002S2-5a; Wed, 15 Apr 2026 17:56:26 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wD8Dd-0002OS-Tm\n for qemu-devel@nongnu.org; Wed, 15 Apr 2026 17:56:23 -0400","from mail-wm1-x329.google.com ([2a00:1450:4864:20::329])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wD8Db-0002me-7n\n for qemu-devel@nongnu.org; Wed, 15 Apr 2026 17:56:21 -0400","by mail-wm1-x329.google.com with SMTP id\n 5b1f17b1804b1-48374014a77so96838505e9.3\n for ; Wed, 15 Apr 2026 14:56:17 -0700 (PDT)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488f5818da1sm651695e9.6.2026.04.15.14.56.14\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Wed, 15 Apr 2026 14:56:14 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776290176; x=1776894976; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=J61p27Quk4EZorcOVqxk0jX5dP0dgc/X3RVLAwpYOiA=;\n b=kpInVKQGAMeTNalefhpPzZAscPAh/ks+gblWUXCFG1YP97XLsf2INUBFOVR5sgEXCA\n c+HxmMNDNasWdtHAC7eK92y23t5H7UHjQeRaJYGczoxL8qvnHNcXS1CSuJ0LB/4l2txO\n zcYG0X30Q4v6mUXvlK+bsR5CJ6nc4YI28fvgcsuosgaxV7hC8Kwpg8uZD96WpG1/w2P7\n 01P/6Jql6Zil/MurgeQYn7g9nvkqbzzJQD6d6Gt1oOh6Bowqoi+eP5q3UmkAdwFOxfBR\n ekscZO70tDNooZi9fhbCyjZwSPKwawIJ9TSYSms8HOJImT5i55vhr3zxblEnV8AKHTEq\n r98g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776290176; x=1776894976;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=J61p27Quk4EZorcOVqxk0jX5dP0dgc/X3RVLAwpYOiA=;\n b=f1nIyzEDARbqIYdB0lsnDhzi0ACbQbogHCZVu1+mCgITjJTdWqtXDgrTGFBMYUS7G2\n LfZaOXMfHAhL2r+lTDJoJO1y+zrRMza/iPGfBbTnHSIaeh1z2dV+nH2toDHFSNGz7EFi\n ex/Sr1+7AOnY9j0Kflx+q55VLN3gDCxDqfi6U0zo6cJJr/Mq9Sxls5qcWUClel+Ry0hx\n e+glyBPSZxssrRVtyVzCSryhDBeVOtoSnOatjbooA8bKjIQWCn23drfEfSy7cOUEJ1AX\n 5nkMy3z1BNthfn1Hxw9ETUnMYzgtHmAlXLxm++xY39Zzt555Q6137HN61fbwCtACMK20\n s5vQ==","X-Gm-Message-State":"AOJu0Yw+BZ289YPDjcFS8f4la1q7ijBm/5jNxnmKAUiSR+1DgxPApJF/\n tsfVBC74IclgmW7V16aNChZZCwH7uaHkyYMZYe/S0nJcLmMkFZVJyHnjnjdsphxqmprHHFFrZgo\n Me6PPCeU=","X-Gm-Gg":"AeBDieuPn4AlqFFhmDBv075p5rbH5byGFgpGTI3SVj1HwpYdz/AgJ487KRjruCVFFbF\n u3wDvBiY44ctgayr/9/1bbq0K1v8xjiXd5SuTdo8ZJaZyzmllhdKa+dHoVuLJjpVeGSam9hsjEH\n 2uSiL3CNYQeowC/iNI88+iIcDYxG1wFXsj42N6GkZJ4O91uFKZH7Y9HJgXWln+qsUdvuiM41ux+\n B7/WULLl/PVawnQIS9AGPp1n2WlriALKTMrF5Cs1ZEThcRGwlvYXP3jwyvwvxaHz2EMVIDcvGAw\n R1LS5aaK1N0HnMm/K7fl/GUBRVfiFbDb/iQZ0XJJCRHGEt3kVASIClATlMOF7FcXb6jGqvhWzgJ\n Zcb4ShQCHQdKHR+xF40+L807vuU4iMMIVsWov7C/ZBm/MmYLS1qmgNpE14Z+W3yW8DkzhbHQmao\n JP7KR7ih7FX1RrXGZRFEA5aIDj02brqXay5gdNzbaZsrl5WWNS8xZEJuc37UmNOD1L97KcnLMO","X-Received":"by 2002:a05:600c:a105:b0:486:d76c:fa57 with SMTP id\n 5b1f17b1804b1-488d685b75emr226950265e9.17.1776290175874;\n Wed, 15 Apr 2026 14:56:15 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"qemu-arm@nongnu.org, qemu-s390x@nongnu.org, qemu-riscv@nongnu.org,\n qemu-block@nongnu.org","Subject":"[PATCH 5/8] cocci: Do not initialize variable used by\n RAMBLOCK_FOREACH* macro","Date":"Wed, 15 Apr 2026 23:55:36 +0200","Message-ID":"<20260415215539.92629-6-philmd@linaro.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260415215539.92629-1-philmd@linaro.org>","References":"<20260415215539.92629-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::329;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x329.google.com","X-Spam_score_int":"4","X-Spam_score":"0.4","X-Spam_bar":"/","X-Spam_report":"(0.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1,\n DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001,\n SUSPICIOUS_RECIPS=2.51 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The RAMBLOCK_FOREACH_MIGRATABLE() macro, defined in\nmigration/ram.h, ends up calling QLIST_FOREACH_RCU()\nwhich always assigns its iterator variable when entering\nthe loop. Remove the pointless and possibly misleading\nassignment.\n\nMechanical patch using the following coccinelle spatch:\n\n @@\n type T;\n identifier e;\n iterator FOREACH_MACRO =~ \".*_FOREACH.*\";\n statement S;\n @@\n - T *e = ...;\n + T *e;\n ... when != e\n FOREACH_MACRO(e, ...) S\n\nSigned-off-by: Philippe Mathieu-Daudé \n---\n migration/dirtyrate.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c\nindex 58f04670629..b360f49efea 100644\n--- a/migration/dirtyrate.c\n+++ b/migration/dirtyrate.c\n@@ -485,7 +485,7 @@ static bool record_ramblock_hash_info(struct RamblockDirtyInfo **block_dinfo,\n {\n struct RamblockDirtyInfo *info = NULL;\n struct RamblockDirtyInfo *dinfo = NULL;\n- RAMBlock *block = NULL;\n+ RAMBlock *block;\n int total_count = 0;\n int index = 0;\n bool ret = false;\n@@ -568,7 +568,7 @@ static bool compare_page_hash_info(struct RamblockDirtyInfo *info,\n int block_count)\n {\n struct RamblockDirtyInfo *block_dinfo = NULL;\n- RAMBlock *block = NULL;\n+ RAMBlock *block;\n \n RAMBLOCK_FOREACH_MIGRATABLE(block) {\n if (skip_sample_ramblock(block)) {\n","prefixes":["5/8"]}