{"id":2223644,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2223644/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260415215539.92629-3-philmd@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260415215539.92629-3-philmd@linaro.org>","date":"2026-04-15T21:55:33","name":"[2/8] cocci: Do not initialize variable used by QSLIST_FOREACH macro","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"b659ac9e11f83e61036e050f8d9795c737f27d94","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.1/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260415215539.92629-3-philmd@linaro.org/mbox/","series":[{"id":500043,"url":"http://patchwork.ozlabs.org/api/1.1/series/500043/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500043","date":"2026-04-15T21:55:33","name":"cocci: Do not initialize variable used by *FOREACH*() macro","version":1,"mbox":"http://patchwork.ozlabs.org/series/500043/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2223644/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2223644/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=eq0xDjgj;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fww3G1BCBz1yHY\n\tfor ; Thu, 16 Apr 2026 07:56:56 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wD8DR-0002IT-Se; Wed, 15 Apr 2026 17:56:09 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wD8DI-0002Fx-Et\n for qemu-devel@nongnu.org; Wed, 15 Apr 2026 17:56:01 -0400","from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wD8DF-0002h1-05\n for qemu-devel@nongnu.org; Wed, 15 Apr 2026 17:55:59 -0400","by mail-wm1-x32e.google.com with SMTP id\n 5b1f17b1804b1-488ad135063so71634205e9.0\n for ; Wed, 15 Apr 2026 14:55:56 -0700 (PDT)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488f57da2aesm2566985e9.0.2026.04.15.14.55.53\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Wed, 15 Apr 2026 14:55:54 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776290155; x=1776894955; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=jHqQq9mgfz0/IbHwfpAA/ZimJYVnAn25wtx09Q5wcT0=;\n b=eq0xDjgjWtN1ErEI6QXip1IE3qJrJ5spiDesBpP/e59VghsVMAZDbc3TiWwefmwFjz\n ci3RRIftPxU+ZQimrmHk04duDHRgRv+hFsYiWeqPQJm5d15o+fiLAPZEzXsm2P96TaHA\n 79HPAyDiQGZe0lIkWGRlV1Fnk9KHmiOWnwST1gVBTN0Ea8fd0nxCI3K9zg3zsC05k1YZ\n CRRnVO8rRIHuY2yhX8pB8ThyiggqdZkN2bRmeemxloM9qSPCKmxfp9jQezAnQxfpcS+S\n UwBkLmrAXPxmV3XQsA3s9D9iMKW/OOrExruD9933w79jNZFzHJooAMULoV4qWacLG/WX\n NS9A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776290155; x=1776894955;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=jHqQq9mgfz0/IbHwfpAA/ZimJYVnAn25wtx09Q5wcT0=;\n b=nWpmHFMXYOyHVuJpAAeuE7AJVKoSJa75chdeidG8Erm8NKPoZAce+2b1FTZz7rLQ8I\n q2T5eREhqNUZNbhwInJ/FhQKLqG1hEaDUm3I1pUeybu/OMWGQNxsro+Dl9ycxRIZ+njx\n dYzcG6pu4KX9G/NOTqnCOFjvkq/ODMqwNhNVdy8iLu1z0o8r8VDurRU8vhAAmxOuLoB4\n Rlxn8AFjIYF8leGSejITM/SfLx6Mux0LttpDzq0Uv/8SlUulKhL3gldOY8aCK1nWfPrM\n 2ZXfWYfhrQMYHZiFYlyqXTrXyMyOk6l0p3Bk/wXuPsbeVPgAziVrsagCf/DFfQMS3ie4\n EJHg==","X-Gm-Message-State":"AOJu0YyJAnHbNA1JNS3XPvli2z8INxAMi2AoeJiM319B99r5jnvAOl+J\n hkbNp6L0A/W5DVxFNEeCYNfdfm8PcX+Nx6w4zbKp0+8Hgh64cm1t5gxtg/FHfXEobfeCz/avl+1\n B0ENnobQ=","X-Gm-Gg":"AeBDieufqcDIxDNgPf3lxhSXhQbNzi+dE4gxu/neHAzZHj+Qpn6JkZGeWC2FCH2paYX\n TZsacHLyC4veBIEjCE+NU80Wfs3GmqHh19IT6Z+BHmPUdW+eAOMIedUCPI6HqEt0wYusGV/SC2k\n TNeKUkUAYbrEP1RgAGOalfikMddQ/cg+cCjP4A8pFS6wGX+LRlzlQnNpe+L/P7mA9CvOuI7d1Qz\n 5LjtuMiCSHFUr/5gJGHSzz+gal1ke5TE9H7QAZbX0XqztNq7XOba7pDZyFGeGXvI22qPbJKAhZ/\n 2Q7HXnl2Yd5tyEbHSdnC/nSbdAVsXhU0uWADhLHe+MBowKC07POY1jJ585/cNJY85Ba4FP69CoL\n RF86cWDQe9BeHI7UiN8nAEUyR7vfVZ+Gt2NdKVG7SjY7cR+MC9YD0MJdqbf0MH0T3FtkgCUE2gz\n 5YVH8wQ9ixLfyWRBb3LUJ6UjBdf7CSyBOMIyWtbQs3GVlSh4tpXggGImUCLtby0ElUaRGJ4FzvG\n RQbcelGt5k=","X-Received":"by 2002:a05:600c:8595:b0:485:3b00:f93b with SMTP id\n 5b1f17b1804b1-488d6ab8082mr238560215e9.31.1776290155006;\n Wed, 15 Apr 2026 14:55:55 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"qemu-arm@nongnu.org, qemu-s390x@nongnu.org, qemu-riscv@nongnu.org,\n qemu-block@nongnu.org","Subject":"[PATCH 2/8] cocci: Do not initialize variable used by QSLIST_FOREACH\n macro","Date":"Wed, 15 Apr 2026 23:55:33 +0200","Message-ID":"<20260415215539.92629-3-philmd@linaro.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260415215539.92629-1-philmd@linaro.org>","References":"<20260415215539.92629-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32e;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32e.google.com","X-Spam_score_int":"4","X-Spam_score":"0.4","X-Spam_bar":"/","X-Spam_report":"(0.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1,\n DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001,\n SUSPICIOUS_RECIPS=2.51 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The QSLIST_FOREACH() macro, defined in \"qemu/queue.h\",\nalways assigns its iterator variable when entering the\nloop. Remove the pointless and possibly misleading\nassignment.\n\nMechanical patch using the following coccinelle spatch:\n\n @@\n type T;\n identifier e;\n iterator FOREACH_MACRO =~ \".*_FOREACH.*\";\n statement S;\n @@\n - T *e = ...;\n + T *e;\n ... when != e\n FOREACH_MACRO(e, ...) S\n\nSigned-off-by: Philippe Mathieu-Daudé \n---\n ebpf/ebpf.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/ebpf/ebpf.c b/ebpf/ebpf.c\nindex 2d73beb4796..a8d441b02c1 100644\n--- a/ebpf/ebpf.c\n+++ b/ebpf/ebpf.c\n@@ -40,7 +40,7 @@ void ebpf_register_binary_data(int id, const void *data, size_t datalen)\n \n const void *ebpf_find_binary_by_id(int id, size_t *sz, Error **errp)\n {\n- struct ElfBinaryDataEntry *it = NULL;\n+ struct ElfBinaryDataEntry *it;\n QSLIST_FOREACH(it, &ebpf_elf_obj_list, node) {\n if (id == it->id) {\n *sz = it->datalen;\n","prefixes":["2/8"]}