{"id":2223638,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2223638/?format=json","web_url":"http://patchwork.ozlabs.org/project/glibc/patch/20260415205905.1257892-3-samuel.thibault@ens-lyon.org/","project":{"id":41,"url":"http://patchwork.ozlabs.org/api/1.1/projects/41/?format=json","name":"GNU C Library","link_name":"glibc","list_id":"libc-alpha.sourceware.org","list_email":"libc-alpha@sourceware.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260415205905.1257892-3-samuel.thibault@ens-lyon.org>","date":"2026-04-15T20:59:04","name":"[hurd,commited,2/3] hurd: __adjtime(): struct timeval and time_value_t are not identical.","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"94e44070b76099a02285efe2840aeef374d4a8bd","submitter":{"id":418,"url":"http://patchwork.ozlabs.org/api/1.1/people/418/?format=json","name":"Samuel Thibault","email":"samuel.thibault@ens-lyon.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/glibc/patch/20260415205905.1257892-3-samuel.thibault@ens-lyon.org/mbox/","series":[{"id":500039,"url":"http://patchwork.ozlabs.org/api/1.1/series/500039/?format=json","web_url":"http://patchwork.ozlabs.org/project/glibc/list/?series=500039","date":"2026-04-15T20:59:02","name":"hurd: Support for adjtime(NULL, &olddelta)","version":1,"mbox":"http://patchwork.ozlabs.org/series/500039/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2223638/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2223638/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","libc-alpha@sourceware.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","libc-alpha@sourceware.org"],"Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n dmarc=none (p=none dis=none) header.from=ens-lyon.org","sourceware.org;\n spf=pass smtp.mailfrom=bounce.ens-lyon.org","server2.sourceware.org;\n arc=none smtp.remote-ip=140.77.166.138"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwtn0476cz1yHV\n\tfor ; Thu, 16 Apr 2026 06:59:32 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 44FDC4BA23D4\n\tfor ; Wed, 15 Apr 2026 20:59:30 +0000 (GMT)","from sonata.ens-lyon.org (sonata.ens-lyon.org [140.77.166.138])\n by sourceware.org (Postfix) with ESMTPS id 49D6F4BA543C\n for ; Wed, 15 Apr 2026 20:59:09 +0000 (GMT)","from localhost (localhost [127.0.0.1])\n by sonata.ens-lyon.org (Postfix) with ESMTP id 4A84FA0230;\n Wed, 15 Apr 2026 22:59:07 +0200 (CEST)","from sonata.ens-lyon.org ([127.0.0.1])\n by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id SSyGCPf8AT11; Wed, 15 Apr 2026 22:59:07 +0200 (CEST)","from end (aamiens-653-1-40-48.w83-192.abo.wanadoo.fr\n [83.192.199.48])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest\n SHA256) (No client certificate requested)\n by sonata.ens-lyon.org (Postfix) with ESMTPSA id 93AB3A022F;\n Wed, 15 Apr 2026 22:59:06 +0200 (CEST)","from samy by end with local (Exim 4.99.1)\n (envelope-from )\n id 1wD7KE-00000005HEx-0awS; Wed, 15 Apr 2026 22:59:06 +0200"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 44FDC4BA23D4","OpenDKIM Filter v2.11.0 sourceware.org 49D6F4BA543C"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 49D6F4BA543C","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 49D6F4BA543C","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776286749; cv=none;\n b=AXBWuFPpS8ehlOeE/B+5KlP1jyLE1jKaZF25J60PehT0uIm0omCk4rFK38qVuYKHLkODxgQI5TRuy5jKSLhASOLTsQNq0D77GUetP4IhwgzkVYvX0CxRoNgdMfWKrvpfx4SDUwKXalpZ8H8ZU47OA4jDnj6v8G52lQUVPUHhiyY=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776286749; c=relaxed/simple;\n bh=hM/1qyYVkg+Sxci98ZqZZJHoCrZ+Mxs4a649KqDTGP4=;\n h=From:To:Subject:Date:Message-ID:MIME-Version;\n b=oX4SfNWsJD6nWrMTTv5skYLVx3xlMmIK3S5dmHRHf4Fh4X54v98a0KklVt97kThy6kn2VxRQqJecWKEFFtvG6PWzkEFRCyE+cGGzqIePHF7Rmvl6kZXM0gvJvvY849IyiEB7Z26A8WW1iWKOsicrIztrAAGXUU1sY8l+vm+FV7E=","ARC-Authentication-Results":"i=1; server2.sourceware.org","From":"Samuel Thibault ","To":"libc-alpha@sourceware.org","Cc":"Michael Kelly ,\n\tcommit-hurd@gnu.org","Subject":"[hurd,\n commited 2/3] hurd: __adjtime(): struct timeval and time_value_t are\n not identical.","Date":"Wed, 15 Apr 2026 22:59:04 +0200","Message-ID":"<20260415205905.1257892-3-samuel.thibault@ens-lyon.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260415205905.1257892-1-samuel.thibault@ens-lyon.org>","References":"<20260415205905.1257892-1-samuel.thibault@ens-lyon.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libc-alpha@sourceware.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Libc-alpha mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org"},"content":"From: Michael Kelly \n\n'struct timeval' and 'struct time_value' have different types for the\nmicroseconds component: int and long int. Casting one to the other\nleads to negative numbers not being preserved properly within the\ncalled code.\nMessage-ID: <20260415180318.109742-3-mike@weatherwax.co.uk>\n---\n sysdeps/mach/hurd/adjtime.c | 23 ++++++++++++++---------\n 1 file changed, 14 insertions(+), 9 deletions(-)","diff":"diff --git a/sysdeps/mach/hurd/adjtime.c b/sysdeps/mach/hurd/adjtime.c\nindex 915b86da13..9d01533b23 100644\n--- a/sysdeps/mach/hurd/adjtime.c\n+++ b/sysdeps/mach/hurd/adjtime.c\n@@ -28,31 +28,36 @@ __adjtime (const struct timeval *delta, struct timeval *olddelta)\n {\n error_t err;\n mach_port_t hostpriv;\n- struct timeval dummy;\n+ time_value_t rpc_delta, rpc_olddelta;\n \n err = __get_privileged_ports (&hostpriv, NULL);\n if (err)\n return __hurd_fail (EPERM);\n \n- if (olddelta == NULL)\n- olddelta = &dummy;\n-\n if (delta != NULL)\n {\n if (delta->tv_usec >= TIME_MICROS_MAX ||\n delta->tv_usec <= -TIME_MICROS_MAX)\n return EINVAL;\n+\n+ rpc_delta.seconds = delta->tv_sec;\n+ rpc_delta.microseconds = delta->tv_usec;\n }\n+ else\n+ return EINVAL;\n \n- err = __host_adjust_time (hostpriv,\n-\t\t\t /* `time_value_t' and `struct timeval' are in\n- fact identical with the names changed. */\n-\t\t\t *(time_value_t *) delta,\n-\t\t\t (time_value_t *) olddelta);\n+ err = __host_adjust_time (hostpriv, rpc_delta, &rpc_olddelta);\n __mach_port_deallocate (__mach_task_self (), hostpriv);\n \n if (err)\n return __hurd_fail (err);\n+\n+ if (olddelta != NULL)\n+ {\n+ olddelta->tv_sec = rpc_olddelta.seconds;\n+ olddelta->tv_usec = rpc_olddelta.microseconds;\n+ }\n+\n return 0;\n }\n \n","prefixes":["hurd","commited","2/3"]}