{"id":2223636,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2223636/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-i2c/patch/20260415205021.1174764-1-zlatistiv@gmail.com/","project":{"id":35,"url":"http://patchwork.ozlabs.org/api/1.1/projects/35/?format=json","name":"Linux I2C development","link_name":"linux-i2c","list_id":"linux-i2c.vger.kernel.org","list_email":"linux-i2c@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260415205021.1174764-1-zlatistiv@gmail.com>","date":"2026-04-15T20:50:21","name":"i2c: Compare the return value of gpiod_get_direction against GPIO_LINE_DIRECTION_OUT","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"1aa2b1e53740dcabfa1295a5cc60ba524a2c677b","submitter":{"id":93163,"url":"http://patchwork.ozlabs.org/api/1.1/people/93163/?format=json","name":"Nikola Z. Ivanov","email":"zlatistiv@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-i2c/patch/20260415205021.1174764-1-zlatistiv@gmail.com/mbox/","series":[{"id":500038,"url":"http://patchwork.ozlabs.org/api/1.1/series/500038/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-i2c/list/?series=500038","date":"2026-04-15T20:50:21","name":"i2c: Compare the return value of gpiod_get_direction against GPIO_LINE_DIRECTION_OUT","version":1,"mbox":"http://patchwork.ozlabs.org/series/500038/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2223636/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2223636/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-i2c@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=PqlwaBma;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=linux-i2c+bounces-17074-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"PqlwaBma\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.128.48","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwtZn12g8z1yHP\n\tfor ; Thu, 16 Apr 2026 06:50:41 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 985043031029\n\tfor ; Wed, 15 Apr 2026 20:50:38 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id BD1C438BF6E;\n\tWed, 15 Apr 2026 20:50:37 +0000 (UTC)","from mail-wm1-f48.google.com (mail-wm1-f48.google.com\n [209.85.128.48])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B0CC387569\n\tfor ; Wed, 15 Apr 2026 20:50:36 +0000 (UTC)","by mail-wm1-f48.google.com with SMTP id\n 5b1f17b1804b1-488b150559bso57152985e9.1\n for ; Wed, 15 Apr 2026 13:50:35 -0700 (PDT)","from fedora-dev ([46.10.223.24])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488f0e9c668sm43399925e9.4.2026.04.15.13.50.32\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 15 Apr 2026 13:50:33 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776286237; cv=none;\n b=CYdQHuj5QHV3J2MDSSx7Tv8NWA+CEHyOidtUNddm5JREF5W8BSo3FjbNjxO5NQCPqho283/akVOnpS+ZqVUPL91XQs9nMpQg9iNhCoY2VjIBytbVWbTn9QERWTHHYj6cueyV+EVUNefc6g2Yb0Ugdy/Wp09AX5cFDBpQ8/FXqLE=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776286237; c=relaxed/simple;\n\tbh=xUvGExRn1JIMhaMrVeZ8FlE5z2gqEEdKQ9vRaXSYa/8=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=jzDwdyzGlxrudJJI4tlY4A31FpAHmC/lrrx+xU/RCpu64WgXAUhbBNAqQUuwZLVLmUrbXI6ar/3/x4gqBTYysW9PZdNi8LID/VvFCMIrcDnrY8mHl3FIxlGKxd/lO1tufrcbxStOvckL7xFpXyHKbXVwikF6njVzo2RI1QdF6tY=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=PqlwaBma; arc=none smtp.client-ip=209.85.128.48","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776286234; x=1776891034;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=X5UjgvnDtHGKM9cTBMyUbG1NygpM0dsNdRiJlKXvD/0=;\n b=PqlwaBmamoBcMvYTKR/0JijP1Na64KaSm+TpsQjWZTIG1EfLv5e09ej/IocvvqdVCp\n fZBUclCJsNHTGGmlnT+7N3zsxxWhnzdaVzH3+Y08haMpKROwY+gpLc9I9ahEMQpEDkq+\n zVekzLVxHfnct92mSzaAf2EqQaVs1h8MUFxLOMfx9HOt7PLfcDvQwz+Xs2hoVQOg3AoH\n 9oVNCSuJBDxaZUvOVi9WXB+UaUDMoDD26ib2bRYtWBDppHMoSHX2hdc3sqyiCYfvao/o\n UQW20fKh6BEaw2OW75M+axgNofkH40YS67/DvCOd1O+qtygE1mNtW4Aehw0M+fRUvxXQ\n 0TXw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776286234; x=1776891034;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=X5UjgvnDtHGKM9cTBMyUbG1NygpM0dsNdRiJlKXvD/0=;\n b=ZA0LW6vyYGe1C2OOQXAnheWNHSAx3+oLMn8iKngYOONx7BubnjF22YLzeeJHfUf/Y/\n HC3j3hZSAw6ZajASxhBTkBP1dhLIOGY/D2/jG9MuTZZJd4dmbNvt6dfJ2qKiViv21tqF\n H/nS8uvkjtyRAfJFnnGCJU1FJNA6+FZILLsPIJyMz8V+Ee758Sh03wJJL1b85YpKGjig\n 4y/HAuQsMe/6ZCF/qbRscXI0L0QMfF0dh3LujuMLmbKkZ4l3jMten3D/9tqW0RaK+t8L\n YA/vTRonPiJwrosQyjCn/EB5oBBLC20GdWp2mRDu1iF8gfdfywezY0k3VUgktxw4HBb9\n oRZQ==","X-Gm-Message-State":"AOJu0YymUsnl7SdwP7rpN5kHAUscLF3no7JnddWJb+AoO50VxxLVBjxL\n\twEArbmDuCu6rRYLYnyr9ogX3c6Dp+KwqANiJL/qlpFAqU+o1qGjH/+Ub","X-Gm-Gg":"AeBDiev3vzjDJ/EBgrdOeNK3DRoIAWS/oNC13RnaAmMQQaOF3Vp8yptT+gbEYImFh1k\n\trgW8dWKu60FFPLv5sZRLajeytbiidaIjfq4Auax7LBPgfxrRViy/vWx/4CsBVv1urAbMH2YWzbF\n\tjB/Pt2JbR6Nn4uig3XtUxDDX/amI9AJHK/oQQHl6Ca37AEx8cRjuTQNjdl8T/8nKE/GWXxhjZox\n\tdlBTG1yLeaGIPzCUDaUEJvYuJoBlLhaWc2A8RKmHY6ThSxrCPG8dfubtXr2L3PVnSymi6u0AIAo\n\tkkR+UOKvoGRm5mdo1Akp+740Yn66506I1I5yPPCDnNorRdXZPGbiyHVteQlC2m8lTmckdjvWyP4\n\tJ78LJVfnM1hSmlDK6qKMpavZTuqkwgmLRRxTA8LX4J+qMIZhVQypzgKQuoQGwhMowuTWn0oBVtu\n\tMFobqHdub8ijGwOk7MXOOxCUM+/X4yyA==","X-Received":"by 2002:a05:600c:c0da:b0:488:b187:d898 with SMTP id\n 5b1f17b1804b1-488d685b6e8mr280744715e9.14.1776286234407;\n Wed, 15 Apr 2026 13:50:34 -0700 (PDT)","From":"\"Nikola Z. Ivanov\" ","To":"wsa+renesas@sang-engineering.com","Cc":"linux-i2c@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\t\"Nikola Z. Ivanov\" ","Subject":"[PATCH] i2c: Compare the return value of gpiod_get_direction against\n GPIO_LINE_DIRECTION_OUT","Date":"Wed, 15 Apr 2026 23:50:21 +0300","Message-ID":"<20260415205021.1174764-1-zlatistiv@gmail.com>","X-Mailer":"git-send-email 2.53.0","Precedence":"bulk","X-Mailing-List":"linux-i2c@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"The GPIO_LINE_DIRECTION_* definitions have just recently been exposed to\ngpio consumers.h by breaking them out in a separate defs.h file.\n\nUse this to validate the gpio direction instead of the hard-coded literal.\n\nSigned-off-by: Nikola Z. Ivanov \n---\n drivers/i2c/i2c-core-base.c | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)","diff":"diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c\nindex 9c46147e3506..a2132d70fb36 100644\n--- a/drivers/i2c/i2c-core-base.c\n+++ b/drivers/i2c/i2c-core-base.c\n@@ -445,8 +445,7 @@ static int i2c_init_recovery(struct i2c_adapter *adap)\n \t\tbri->set_scl = set_scl_gpio_value;\n \t\tif (bri->sda_gpiod) {\n \t\t\tbri->get_sda = get_sda_gpio_value;\n-\t\t\t/* FIXME: add proper flag instead of '0' once available */\n-\t\t\tif (gpiod_get_direction(bri->sda_gpiod) == 0)\n+\t\t\tif (gpiod_get_direction(bri->sda_gpiod) == GPIO_LINE_DIRECTION_OUT)\n \t\t\t\tbri->set_sda = set_sda_gpio_value;\n \t\t}\n \t} else if (bri->recover_bus == i2c_generic_scl_recovery) {\n","prefixes":[]}