{"id":2223615,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2223615/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20260415183250.3031030-7-dario.binacchi@amarulasolutions.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.1/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260415183250.3031030-7-dario.binacchi@amarulasolutions.com>","date":"2026-04-15T18:31:33","name":"[v3,6/7] fwu: add helper to get image GUID by type and bank index","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":true,"hash":"6ed968b63b0ec6f5bfc44d455267bd63a777899d","submitter":{"id":83038,"url":"http://patchwork.ozlabs.org/api/1.1/people/83038/?format=json","name":"Dario Binacchi","email":"dario.binacchi@amarulasolutions.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20260415183250.3031030-7-dario.binacchi@amarulasolutions.com/mbox/","series":[{"id":500027,"url":"http://patchwork.ozlabs.org/api/1.1/series/500027/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=500027","date":"2026-04-15T18:31:27","name":"Support metadata-driven A/B boot for STM32MP25","version":3,"mbox":"http://patchwork.ozlabs.org/series/500027/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2223615/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2223615/checks/","tags":{},"headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com\n header.a=rsa-sha256 header.s=google header.b=XDSxH6Cz;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=amarulasolutions.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com\n header.b=\"XDSxH6Cz\";\n\tdkim-atps=neutral","phobos.denx.de; dmarc=pass (p=none dis=none)\n header.from=amarulasolutions.com","phobos.denx.de; spf=pass\n smtp.mailfrom=dario.binacchi@amarulasolutions.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwqY54CMbz1yHM\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 16 Apr 2026 04:34:01 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 39890841F2;\n\tWed, 15 Apr 2026 20:33:16 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id B2DAD8422D; Wed, 15 Apr 2026 20:33:15 +0200 (CEST)","from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com\n [IPv6:2a00:1450:4864:20::32c])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id C1746841D7\n for <u-boot@lists.denx.de>; Wed, 15 Apr 2026 20:33:13 +0200 (CEST)","by mail-wm1-x32c.google.com with SMTP id\n 5b1f17b1804b1-48896199cbaso74889555e9.1\n for <u-boot@lists.denx.de>; Wed, 15 Apr 2026 11:33:13 -0700 (PDT)","from dario-ThinkPad-P14s-Gen-5.amarulasolutions.com ([2.196.40.93])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488f0e72980sm34953115e9.5.2026.04.15.11.33.11\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 15 Apr 2026 11:33:12 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=amarulasolutions.com; s=google; t=1776277993; x=1776882793;\n darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=uCAR4bHfuzLtCYDWhI3svjkqvfHud+Ornn0vBeRVnY0=;\n b=XDSxH6Cz3sGEb64oypSUTU0+cnljuQDFUuBSZ2LNVYLpf4YMFakfDHUxRCOgNvjiQD\n WkrqhwF4itobV0P1ZWBShdM7NTsq8hrlYw9XE6hXAKGDzjPoMpZ41J5kBvBY7c0iEd5I\n CEHh9MWhRFMEjwW38FF6+nOKOrO4CRx4rsmMw=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776277993; x=1776882793;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=uCAR4bHfuzLtCYDWhI3svjkqvfHud+Ornn0vBeRVnY0=;\n b=LSmNJ8fx0BVX4WRoi0e37YxsfM5pvCR0YyOGwkfTvi/expzTc4H3uc4iWBKObe0YH8\n PPXVh7Sxd5c+7Y7MgFnzxsECRbxb2ol1nCXsJ30mCk7iqjPCiVaYjHR0AOTUpTaJffGm\n zHCxPjgc21cn3U1HovJ0vVAeAainblqHkP0UFHUMJtWR48Nbs/LYy9y66nhlyChoVx5z\n bzE05wOxx9nRe8AR3ciAcnBJtSZ1YkK++OjQvrYQ6OZ5aXw8D+A7T07OI1RiSzJBgLie\n hqQ4zDv5nmdOu1uW2DduYgNEpZ6uZEjsromDiOfSbifh/p5eV0XjjsaEechinAtOygNf\n LlEQ==","X-Gm-Message-State":"AOJu0YycoMGvkvdugOFvU5DdfdpDnZV1LtX7Jrw3eEKCm1S+ZyHfCB3g\n NEGUyGUilMb6Jq0cSzv2PYR0QSJMqiPJGGyo6k+dRV8khX0vj4lSA+DzfyN+wpHf5YUAwxTjUfW\n GeV9O","X-Gm-Gg":"AeBDiesHXVOJkKbE5AqVL7ZGATQRBJT8xx0U5SLmF0OQUwBi2o8qQmre6JKed3MPWR9\n jDkzKaJfn2/pNfSun0R2O+1gi/IZByMZ8/yg1mys0URkvcdPkEsQmWLyNPeWPLpyw37syxPVGm6\n 69dRLQKKXt+OJMXPFZWwHs86xOgq68omB37/cN6euFv0qBoF9y8uiZpzWjjxqelxfvejoEdQ95A\n 11R9LktSbU6WKYCr65LXP3sKLQVUYyN1RVxoBF0p/UIr9eGqeS59LNYjXdpdX7FG1/Cmjw68hhw\n oYR/sgS1+jkK2VhwBdL2N8xBxAys14qfP/1Y4pwF5Ky8Gr0049nbeOKXB5aKUBgcoxr33FNGft1\n SDWl+e4FQPYVBlGGv9gpTY9rZuGuo1rgKqE0PTRVVuj93nvkgbIbKHB9nfg8fYWs6zWsh3Vxnxk\n qrkF1+Q7P9PIOuaIv9kKeZPpm5rhioPPmutoQHrwRQRFp71mPJTBp7F/tbGj3lWdg0vlyhImsD+\n kUELBHJzsrkG6DBlXuNKmM8S+uaMsW9TE8pk0h7e7JlnGeAQd4EHEa5Yg==","X-Received":"by 2002:a05:600c:8b2f:b0:485:3423:727d with SMTP id\n 5b1f17b1804b1-488d688d46cmr293152095e9.26.1776277993020;\n Wed, 15 Apr 2026 11:33:13 -0700 (PDT)","From":"Dario Binacchi <dario.binacchi@amarulasolutions.com>","To":"u-boot@lists.denx.de","Cc":"linux-amarula@amarulasolutions.com,\n Dario Binacchi <dario.binacchi@amarulasolutions.com>,\n Ilias Apalodimas <ilias.apalodimas@linaro.org>,\n Kory Maincent <kory.maincent@bootlin.com>,\n Michal Simek <michal.simek@amd.com>,\n Padmarao Begari <padmarao.begari@amd.com>,\n Sughosh Ganu <sughosh.ganu@arm.com>, Tom Rini <trini@konsulko.com>","Subject":"[PATCH v3 6/7] fwu: add helper to get image GUID by type and bank\n index","Date":"Wed, 15 Apr 2026 20:31:33 +0200","Message-ID":"<20260415183250.3031030-7-dario.binacchi@amarulasolutions.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260415183250.3031030-1-dario.binacchi@amarulasolutions.com>","References":"<20260415183250.3031030-1-dario.binacchi@amarulasolutions.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"Introduce fwu_mdata_get_image_guid() to retrieve a specific image GUID\nfrom the FWU metadata based on the bank index and image type GUID.\n\nThis allows identifying the correct partition in multi-bank (A/B)\nscenarios, ensuring the correct image is targeted depending on the\ncurrent bank.\n\nSigned-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>\n\n---\n\nChanges in v3:\n- Add kerneldoc comment for fwu_mdata_get_image_guid() above its\n  declaration in fwu.h.\n\nChanges in v2:\n- Add kerneldoc comment for fwu_mdata_get_image_guid().\n- Pass efi_guid_t by pointer for consistency.\n\n include/fwu.h         | 11 +++++++++++\n lib/fwu_updates/fwu.c | 33 +++++++++++++++++++++++++++++++++\n 2 files changed, 44 insertions(+)","diff":"diff --git a/include/fwu.h b/include/fwu.h\nindex 9cee8fb085cb..68a51fb4296b 100644\n--- a/include/fwu.h\n+++ b/include/fwu.h\n@@ -396,6 +396,17 @@ void fwu_populate_mdata_image_info(struct fwu_data *data);\n  */\n int fwu_get_mdata_size(uint32_t *mdata_size);\n \n+/**\n+ * fwu_mdata_get_image_guid() - Get image GUID for a type and bank\n+ * @image_guid: Pointer to be filled with the found image GUID\n+ * @image_type_guid: Pointer to the image type GUID to search for\n+ * @bank_index: Index of the bank\n+ *\n+ * Return: 0 if OK, -ve on error\n+ */\n+int fwu_mdata_get_image_guid(efi_guid_t *image_guid,\n+\t\t\t     const efi_guid_t *image_type_guid, u32 bank_index);\n+\n /**\n  * fwu_state_machine_updates() - Update FWU state of the platform\n  * @state: FWU bank state\ndiff --git a/lib/fwu_updates/fwu.c b/lib/fwu_updates/fwu.c\nindex 37c613014d18..e5e4907a2d43 100644\n--- a/lib/fwu_updates/fwu.c\n+++ b/lib/fwu_updates/fwu.c\n@@ -243,6 +243,39 @@ int fwu_sync_mdata(struct fwu_mdata *mdata, int part)\n \treturn 0;\n }\n \n+/**\n+ * fwu_mdata_get_image_guid() - Get image GUID for a type and bank\n+ * @image_guid: Pointer to be filled with the found image GUID\n+ * @image_type_guid: Pointer to the image type GUID to search for\n+ * @bank_index: Index of the bank\n+ *\n+ * Return: 0 if OK, -ve on error\n+ */\n+int fwu_mdata_get_image_guid(efi_guid_t *image_guid,\n+\t\t\t     const efi_guid_t *image_type_guid, u32 bank_index)\n+{\n+\tstruct fwu_data *data = &g_fwu_data;\n+\tstruct fwu_image_entry *image;\n+\tint i;\n+\n+\tif (bank_index >= data->num_banks)\n+\t\treturn -EINVAL;\n+\n+\tfor (i = 0; i < data->num_images; i++) {\n+\t\timage = &data->fwu_images[i];\n+\n+\t\tif (!guidcmp(image_type_guid, &image->image_type_guid)) {\n+\t\t\tstruct fwu_image_bank_info *bank;\n+\n+\t\t\tbank = &image->img_bank_info[bank_index];\n+\t\t\tguidcpy(image_guid, &bank->image_guid);\n+\t\t\treturn 0;\n+\t\t}\n+\t}\n+\n+\treturn -ENOENT;\n+}\n+\n /**\n  * fwu_mdata_copies_allocate() - Allocate memory for metadata\n  * @mdata_size: Size of the metadata structure\n","prefixes":["v3","6/7"]}