{"id":2223612,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2223612/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20260415183250.3031030-4-dario.binacchi@amarulasolutions.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.1/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260415183250.3031030-4-dario.binacchi@amarulasolutions.com>","date":"2026-04-15T18:31:30","name":"[v3,3/7] test: cmd: add unit tests for part command","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":true,"hash":"f17062ef334abbf271b417b3c0112667222f722d","submitter":{"id":83038,"url":"http://patchwork.ozlabs.org/api/1.1/people/83038/?format=json","name":"Dario Binacchi","email":"dario.binacchi@amarulasolutions.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20260415183250.3031030-4-dario.binacchi@amarulasolutions.com/mbox/","series":[{"id":500027,"url":"http://patchwork.ozlabs.org/api/1.1/series/500027/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=500027","date":"2026-04-15T18:31:27","name":"Support metadata-driven A/B boot for STM32MP25","version":3,"mbox":"http://patchwork.ozlabs.org/series/500027/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2223612/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2223612/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com\n header.a=rsa-sha256 header.s=google header.b=ZxpoQs4X;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=amarulasolutions.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com\n header.b=\"ZxpoQs4X\";\n\tdkim-atps=neutral","phobos.denx.de; dmarc=pass (p=none dis=none)\n header.from=amarulasolutions.com","phobos.denx.de; spf=pass\n smtp.mailfrom=dario.binacchi@amarulasolutions.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwqXY6wYJz1yHM\n\tfor ; Thu, 16 Apr 2026 04:33:33 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 7055B84206;\n\tWed, 15 Apr 2026 20:33:12 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id BBF1884201; Wed, 15 Apr 2026 20:33:10 +0200 (CEST)","from mail-wm1-x331.google.com (mail-wm1-x331.google.com\n [IPv6:2a00:1450:4864:20::331])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id B9A97841CD\n for ; Wed, 15 Apr 2026 20:33:08 +0200 (CEST)","by mail-wm1-x331.google.com with SMTP id\n 5b1f17b1804b1-488ba6366a7so86721375e9.0\n for ; Wed, 15 Apr 2026 11:33:08 -0700 (PDT)","from dario-ThinkPad-P14s-Gen-5.amarulasolutions.com ([2.196.40.93])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488f0e72980sm34953115e9.5.2026.04.15.11.33.06\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 15 Apr 2026 11:33:07 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=amarulasolutions.com; s=google; t=1776277988; x=1776882788;\n darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=605kfiPAmyyhG0L5m4NA62wmfJrRDN9SrX8UGlTD18M=;\n b=ZxpoQs4X/UGp3/RX25uZpISeBdu1S6CfiJ0ijmjOEgDAYnwfbJXghkWDJYO/qwjOwD\n thxlhB5Hn6eKZJcHRrDn+5npv5PLB+0qYQjY8EO/VquQ2c0U4/tBpKDrzu5Q0tilXv7M\n PsP1FmjHzUAx04JHfr+G7KddUuk3hrrhbEWG0=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776277988; x=1776882788;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=605kfiPAmyyhG0L5m4NA62wmfJrRDN9SrX8UGlTD18M=;\n b=leiZBd0F3L/RBE/WZiDqv45nYI50srur/2lutX9yaZCAKA31lcO1hmR9n0xLGWiImP\n iw5I2CsNFnn1nw+GW3AqIjqw256V6Yy8FMVBDAdKdGuvDESQMXAGRsYMJbEgZKZ5ksBv\n tMIgwyfhcDSZK+P9r4fl+x1XgKKZ4oS3cw/kKcl9Ze3/QfXuiPH4TCseAHp0tf6vgzPW\n xQ32ShERv8Z37OMtjbc0Tv7b9wcFx3HUY6WYYMALQQJ1khl5tkyZkC9+3Z/+kiKsXoTA\n jGioKVVzB40c/EATKPXg9VFwTDhBC0C/P2dymn00jgsqYaI4DaNY0AkEdMzTDeRRbbz7\n /FrQ==","X-Gm-Message-State":"AOJu0YwhcURraim7u2p5SBhQ+T2V8j6NxT/cWEUd3P7uUJ+9zsFYy4Xl\n z0OyOgRW3yT6q0fzFomZg9IsaIhgkkvuVa1z62iUwB3tocRwWGCH1tvNxUGHINJyJSPyBWc/cdU\n ZkUdH","X-Gm-Gg":"AeBDiet98icB1FFbWmgm3fqVy+OTNU7Yrmk+4tCbIHslfDstX7S6krgHCgFJ4WH5dTl\n ZpdwBxN2nGXwVIX+MlzeYrZXDlDJ6pJzLqanzyiDzow7SPDyoLWZKsT92QkG1cK5bn7F7pPaTEw\n kIUWTQIWhcGCVc10/i51bx9nBhUFiPb3PbAcajPBWC2ZDC0spH8yi5XRAyguz1mIASote5Wh+ts\n 92ccJSPHSIz4celMnBTZ5ZqoXPHqkfIUSPFEAA0PeifnoSFtgqQlSP5GCeRfWPCK90XvMtgXJPW\n vLL851hVVfxJf3QsyNJ5MuJdl4YPBik2yhNgp+JcJ0VZmMou511wYVDuX5FnaGy2ICuD2evhlxQ\n Ad3qfghk3g0JXhteeoEM61qWlF2KsGvbJ9tkuABJ9rH0TwaZ8RP2M2tWm8czx3BAv1HRVP4PS+f\n PBr8C71cqdBlevThFq4G8E4wkXx73LHfk5qZrthHq8leLJFQtDCcrkwqaVj4hQ+axDquia2aLnl\n ph34JIzB7RvIDn7gDHaSXOf+H+ta5COdyNh+sLOcep6dNUgfc0X4OPi0g==","X-Received":"by 2002:a05:600c:4e45:b0:488:9439:881a with SMTP id\n 5b1f17b1804b1-488d67bf6f6mr336739085e9.2.1776277987902;\n Wed, 15 Apr 2026 11:33:07 -0700 (PDT)","From":"Dario Binacchi ","To":"u-boot@lists.denx.de","Cc":"linux-amarula@amarulasolutions.com,\n Dario Binacchi ,\n Dinesh Maniyam ,\n Heinrich Schuchardt ,\n Marek Vasut ,\n Simon Glass , Tom Rini ","Subject":"[PATCH v3 3/7] test: cmd: add unit tests for part command","Date":"Wed, 15 Apr 2026 20:31:30 +0200","Message-ID":"<20260415183250.3031030-4-dario.binacchi@amarulasolutions.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260415183250.3031030-1-dario.binacchi@amarulasolutions.com>","References":"<20260415183250.3031030-1-dario.binacchi@amarulasolutions.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"Add unit tests for the 'part' command, specifically for the 'number',\n'start', and 'size' subcommands.\n\nThese tests establish a baseline for the current partition lookup\nfunctionality by name. This foundation will be used by subsequent\npatches to extend the command, ensuring consistent behavior as new\nfeatures are introduced.\n\nSigned-off-by: Dario Binacchi \n\n---\n\nChanges in v3:\n- Wrap the lines exceeding 80 columns\n- Combine run_command() and ut_asserteq() -> ut_asserteq(1, run_command(\n\n test/cmd/Makefile | 1 +\n test/cmd/part.c | 161 ++++++++++++++++++++++++++++++++++++++++++++++\n 2 files changed, 162 insertions(+)\n create mode 100644 test/cmd/part.c","diff":"diff --git a/test/cmd/Makefile b/test/cmd/Makefile\nindex 8c9f112782d0..41fe21a4541e 100644\n--- a/test/cmd/Makefile\n+++ b/test/cmd/Makefile\n@@ -26,6 +26,7 @@ obj-$(CONFIG_CMD_LOADM) += loadm.o\n obj-$(CONFIG_CMD_MEMINFO) += meminfo.o\n obj-$(CONFIG_CMD_MEMORY) += mem_copy.o\n obj-$(CONFIG_CMD_MEM_SEARCH) += mem_search.o\n+obj-$(CONFIG_CMD_PART) += part.o\n ifdef CONFIG_CMD_PCI\n obj-$(CONFIG_CMD_PCI_MPS) += pci_mps.o\n endif\ndiff --git a/test/cmd/part.c b/test/cmd/part.c\nnew file mode 100644\nindex 000000000000..f808ddbc87eb\n--- /dev/null\n+++ b/test/cmd/part.c\n@@ -0,0 +1,161 @@\n+// SPDX-License-Identifier: GPL-2.0+\n+/*\n+ * Test for part command\n+ *\n+ * Copyright (C) 2026 Amarula Solutions\n+ * Written by Dario Binacchi \n+ */\n+\n+#include \n+#include \n+#include \n+#include \n+#include \n+\n+static struct disk_partition gpt_parts[] = {\n+\t{\n+\t\t.start = 48,\n+\t\t.size = 1,\n+\t\t.name = \"test1\",\n+\t\t.uuid = \"c5bce7a2-03f0-4d03-9048-01ff23b9d527\",\n+\t},\n+\t{\n+\t\t.start = 49,\n+\t\t.size = 2,\n+\t\t.name = \"test2\",\n+\t\t.uuid = \"9df346e8-2c53-4cd8-b9ac-3af83f9a9b74\",\n+\t},\n+};\n+\n+static char disk_guid[UUID_STR_LEN + 1] =\n+\t\"8d60b397-1bb6-4d33-80ee-b1587d24c2f8\";\n+\n+static int setup_gpt_partitions(struct unit_test_state *uts,\n+\t\t\t\tunsigned int mmc_dev_num)\n+{\n+\tstruct blk_desc *mmc_dev_desc;\n+\tchar dev_str[10];\n+\tint i;\n+\n+\tsnprintf(dev_str, sizeof(dev_str), \"%u\", mmc_dev_num);\n+\n+\tut_asserteq(mmc_dev_num, blk_get_device_by_str(\"mmc\", dev_str,\n+\t\t\t\t\t\t &mmc_dev_desc));\n+\n+\tif (CONFIG_IS_ENABLED(RANDOM_UUID)) {\n+\t\tfor (i = 0; i < ARRAY_SIZE(gpt_parts); i++)\n+\t\t\tgen_rand_uuid_str(gpt_parts[i].uuid,\n+\t\t\t\t\t UUID_STR_FORMAT_STD);\n+\n+\t\tgen_rand_uuid_str(disk_guid, UUID_STR_FORMAT_STD);\n+\t}\n+\n+\tut_assertok(gpt_restore(mmc_dev_desc, disk_guid, gpt_parts,\n+\t\t\t\tARRAY_SIZE(gpt_parts)));\n+\treturn 0;\n+}\n+\n+static int dm_test_cmd_part_number(struct unit_test_state *uts)\n+{\n+\tunsigned int mmc_dev_num = 2;\n+\tchar expected[10];\n+\tint i;\n+\n+\tut_assertok(setup_gpt_partitions(uts, mmc_dev_num));\n+\n+\tfor (i = 0; i < ARRAY_SIZE(gpt_parts); i++) {\n+\t\tenv_set(\"partnum\", NULL);\n+\t\tut_assertok(run_commandf(\"part number mmc %u %s partnum\",\n+\t\t\t\t\t mmc_dev_num, gpt_parts[i].name));\n+\t\tsnprintf(expected, sizeof(expected), \"0x%x\", i + 1);\n+\t\tut_asserteq_str(expected, env_get(\"partnum\"));\n+\t}\n+\n+\tenv_set(\"partnum\", NULL);\n+\tut_asserteq(1, run_commandf(\"part number mmc %u bogus partnum\",\n+\t\t\t\t mmc_dev_num));\n+\tut_assertnull(env_get(\"partnum\"));\n+\n+\treturn 0;\n+}\n+DM_TEST(dm_test_cmd_part_number, UTF_SCAN_PDATA | UTF_SCAN_FDT);\n+\n+static int dm_test_cmd_part_start(struct unit_test_state *uts)\n+{\n+\tunsigned int mmc_dev_num = 2;\n+\tchar expected[32];\n+\tint i;\n+\n+\tut_assertok(setup_gpt_partitions(uts, mmc_dev_num));\n+\n+\tfor (i = 0; i < ARRAY_SIZE(gpt_parts); i++) {\n+\t\tenv_set(\"partstart\", NULL);\n+\t\tut_assertok(run_commandf(\"part start mmc %u %d partstart\",\n+\t\t\t\t\t mmc_dev_num, i + 1));\n+\t\tsnprintf(expected, sizeof(expected), \"%lx\",\n+\t\t\t (unsigned long)gpt_parts[i].start);\n+\t\tut_asserteq_str(expected, env_get(\"partstart\"));\n+\t}\n+\n+\tenv_set(\"partstart\", NULL);\n+\tut_asserteq(1, run_commandf(\"part start mmc %u 3 partstart\",\n+\t\t\t\t mmc_dev_num));\n+\tut_assertnull(env_get(\"partstart\"));\n+\n+\tfor (i = 0; i < ARRAY_SIZE(gpt_parts); i++) {\n+\t\tenv_set(\"partstart\", NULL);\n+\t\tut_assertok(run_commandf(\"part start mmc %u %s partstart\",\n+\t\t\t\t\t mmc_dev_num, gpt_parts[i].name));\n+\t\tsnprintf(expected, sizeof(expected), \"%lx\",\n+\t\t\t (unsigned long)gpt_parts[i].start);\n+\t\tut_asserteq_str(expected, env_get(\"partstart\"));\n+\t}\n+\n+\tenv_set(\"partstart\", NULL);\n+\tut_asserteq(1, run_commandf(\"part start mmc %u bogus partstart\",\n+\t\t\t\t mmc_dev_num));\n+\tut_assertnull(env_get(\"partstart\"));\n+\n+\treturn 0;\n+}\n+DM_TEST(dm_test_cmd_part_start, UTF_SCAN_PDATA | UTF_SCAN_FDT);\n+\n+static int dm_test_cmd_part_size(struct unit_test_state *uts)\n+{\n+\tunsigned int mmc_dev_num = 2;\n+\tchar expected[32];\n+\tint i;\n+\n+\tut_assertok(setup_gpt_partitions(uts, mmc_dev_num));\n+\n+\tfor (i = 0; i < ARRAY_SIZE(gpt_parts); i++) {\n+\t\tenv_set(\"partsize\", NULL);\n+\t\tut_assertok(run_commandf(\"part size mmc %u %d partsize\",\n+\t\t\t\t\t mmc_dev_num, i + 1));\n+\t\tsnprintf(expected, sizeof(expected), \"%lx\",\n+\t\t\t (unsigned long)gpt_parts[i].size);\n+\t\tut_asserteq_str(expected, env_get(\"partsize\"));\n+\t}\n+\n+\tenv_set(\"partsize\", NULL);\n+\tut_asserteq(1, run_commandf(\"part size mmc %u 3 partsize\",\n+\t\t\t\t mmc_dev_num));\n+\tut_assertnull(env_get(\"partsize\"));\n+\n+\tfor (i = 0; i < ARRAY_SIZE(gpt_parts); i++) {\n+\t\tenv_set(\"partsize\", NULL);\n+\t\tut_assertok(run_commandf(\"part size mmc %u %s partsize\",\n+\t\t\t\t\t mmc_dev_num, gpt_parts[i].name));\n+\t\tsnprintf(expected, sizeof(expected), \"%lx\",\n+\t\t\t (unsigned long)gpt_parts[i].size);\n+\t\tut_asserteq_str(expected, env_get(\"partsize\"));\n+\t}\n+\n+\tenv_set(\"partsize\", NULL);\n+\tut_asserteq(1, run_commandf(\"part size mmc %u bogus partsize\",\n+\t\t\t\t mmc_dev_num));\n+\tut_assertnull(env_get(\"partsize\"));\n+\n+\treturn 0;\n+}\n+DM_TEST(dm_test_cmd_part_size, UTF_SCAN_PDATA | UTF_SCAN_FDT);\n","prefixes":["v3","3/7"]}