{"id":2223601,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2223601/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260415171038.41442-1-pablo@netfilter.org/","project":{"id":26,"url":"http://patchwork.ozlabs.org/api/1.1/projects/26/?format=json","name":"Netfilter Development","link_name":"netfilter-devel","list_id":"netfilter-devel.vger.kernel.org","list_email":"netfilter-devel@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260415171038.41442-1-pablo@netfilter.org>","date":"2026-04-15T17:10:37","name":"[nf,v2,2/3] netfilter: nf_tables: join hook list via splice_list_rcu() in commit phase","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"6e9e6b82bf3b8bb393bc45041bb87c8e62f2ac94","submitter":{"id":1315,"url":"http://patchwork.ozlabs.org/api/1.1/people/1315/?format=json","name":"Pablo Neira Ayuso","email":"pablo@netfilter.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260415171038.41442-1-pablo@netfilter.org/mbox/","series":[{"id":500019,"url":"http://patchwork.ozlabs.org/api/1.1/series/500019/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=500019","date":"2026-04-15T17:10:38","name":"[nf,v2,1/3] rculist: add list_splice_rcu() for private lists","version":2,"mbox":"http://patchwork.ozlabs.org/series/500019/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2223601/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2223601/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=netfilter.org header.i=@netfilter.org\n header.a=rsa-sha256 header.s=2025 header.b=mevvlUpg;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-11932-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=netfilter.org header.i=@netfilter.org\n header.b=\"mevvlUpg\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=217.70.190.124","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=netfilter.org","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=netfilter.org"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwp3w6m94z1yCv\n\tfor ; Thu, 16 Apr 2026 03:27:08 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 1E358319D2DB\n\tfor ; Wed, 15 Apr 2026 17:10:46 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 42C913E51C7;\n\tWed, 15 Apr 2026 17:10:45 +0000 (UTC)","from mail.netfilter.org (mail.netfilter.org [217.70.190.124])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id AE2DC3A75B7\n\tfor ; Wed, 15 Apr 2026 17:10:43 +0000 (UTC)","from localhost.localdomain (mail-agni [217.70.190.124])\n\tby mail.netfilter.org (Postfix) with ESMTPSA id E0347600B5;\n\tWed, 15 Apr 2026 19:10:41 +0200 (CEST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776273044; cv=none;\n b=ROgenMN6OBy5DjXyGVHRQyT28TyixX33EkWexSOGGwwn9jVH6Nf625lT/nE5H4I/rCGWMVYjHTCEUnh8R8mzKYj1SHssfAeaDx4AbdAfARNppcZogQuCF5FOXw2hOUOjoeIi5sSD62gs/iSHmhx0o1COtSIV9LYMbFIrQn5VeCw=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776273044; c=relaxed/simple;\n\tbh=lmmms9F9hKXxtQq5/IgvrDrITmDAEB1Ql3EbXZ/zR38=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=oz7WqJehFdHh4x+PzPej7BzED84GhdJd3LlEfC6G5kIQdHO0QJNEmeku8Jn03YJcbuYpdo0TyUWVnoyg0uSWC8K1tFviNB4DifupqlgcueOkEETfe5rSlJNx3eSqlsDLIygndMik9o0Rd9LiCqaup3RxiXQTBNNsCgn2o0DPAIA=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=netfilter.org;\n spf=pass smtp.mailfrom=netfilter.org;\n dkim=pass (2048-bit key) header.d=netfilter.org header.i=@netfilter.org\n header.b=mevvlUpg; arc=none smtp.client-ip=217.70.190.124","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=netfilter.org;\n\ts=2025; t=1776273042;\n\tbh=mmJ932xZG47Mi9yqqlqrKBNTWPzT/ghXoz8AY2TrW+Q=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=mevvlUpgxVeNBWVOA7ux3nZBCz46czTQETZy3Rfe5SU6owI++FoGazNlgVrsRXybT\n\t MPN9ZXqSMM3smALtKHeijlN6y9E+oH/4CxI7sW7oPJ8i7AWz7FYYs7qyCg1yD52aBh\n\t 6OK9I9ObK157ZRzJhbbfKcOEjR9HrELu0vI0MRyAX97kSXP9lttS3WccYXZH0e7NUP\n\t 4v9EdhWq7KdfSkP+gIsgo+8TokODmcQcCoq723r4E+KQwUHVI02ZcTESfwPNItXqfV\n\t m2jmPQbbRbn1ykP/qBE2ZZnbV/q9+OMcoq3hDNR/1QslkaKK/zgTlioIq2a0+Qvnhv\n\t e9ZoCuWg+FGMw==","From":"Pablo Neira Ayuso ","To":"netfilter-devel@vger.kernel.org","Cc":"fw@strlen.de","Subject":"[PATCH nf,v2 2/3] netfilter: nf_tables: join hook list via\n splice_list_rcu() in commit phase","Date":"Wed, 15 Apr 2026 19:10:37 +0200","Message-ID":"<20260415171038.41442-1-pablo@netfilter.org>","X-Mailer":"git-send-email 2.47.3","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"Publish new hooks in the list into the basechain/flowtable using\nsplice_list_rcu() to ensure netlink dump list traversal via rcu is safe\nwhile concurrent ruleset update is going on.\n\nFixes: 78d9f48f7f44 (\"netfilter: nf_tables: add devices to existing flowtable\")\nFixes: b9703ed44ffb (\"netfilter: nf_tables: support for adding new devices to an existing netdev chain\")\nSigned-off-by: Pablo Neira Ayuso \n---\nv2: no changes, requires list_splice_rcu() in v2\n\n net/netfilter/nf_tables_api.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c\nindex 8c42247a176c..4d7c2794c87d 100644\n--- a/net/netfilter/nf_tables_api.c\n+++ b/net/netfilter/nf_tables_api.c\n@@ -10912,8 +10912,8 @@ static int nf_tables_commit(struct net *net, struct sk_buff *skb)\n \t\t\t\tnft_chain_commit_update(nft_trans_container_chain(trans));\n \t\t\t\tnf_tables_chain_notify(&ctx, NFT_MSG_NEWCHAIN,\n \t\t\t\t\t\t &nft_trans_chain_hooks(trans));\n-\t\t\t\tlist_splice(&nft_trans_chain_hooks(trans),\n-\t\t\t\t\t &nft_trans_basechain(trans)->hook_list);\n+\t\t\t\tlist_splice_rcu(&nft_trans_chain_hooks(trans),\n+\t\t\t\t\t\t&nft_trans_basechain(trans)->hook_list);\n \t\t\t\t/* trans destroyed after rcu grace period */\n \t\t\t} else {\n \t\t\t\tnft_chain_commit_drop_policy(nft_trans_container_chain(trans));\n@@ -11042,8 +11042,8 @@ static int nf_tables_commit(struct net *net, struct sk_buff *skb)\n \t\t\t\t\t\t\t nft_trans_flowtable(trans),\n \t\t\t\t\t\t\t &nft_trans_flowtable_hooks(trans),\n \t\t\t\t\t\t\t NFT_MSG_NEWFLOWTABLE);\n-\t\t\t\tlist_splice(&nft_trans_flowtable_hooks(trans),\n-\t\t\t\t\t &nft_trans_flowtable(trans)->hook_list);\n+\t\t\t\tlist_splice_rcu(&nft_trans_flowtable_hooks(trans),\n+\t\t\t\t\t\t&nft_trans_flowtable(trans)->hook_list);\n \t\t\t} else {\n \t\t\t\tnft_clear(net, nft_trans_flowtable(trans));\n \t\t\t\tnf_tables_flowtable_notify(&ctx,\n","prefixes":["nf","v2","2/3"]}