{"id":2223582,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2223582/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/patch/20260415165715.413643-1-jwakely@redhat.com/","project":{"id":17,"url":"http://patchwork.ozlabs.org/api/1.1/projects/17/?format=json","name":"GNU Compiler Collection","link_name":"gcc","list_id":"gcc-patches.gcc.gnu.org","list_email":"gcc-patches@gcc.gnu.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260415165715.413643-1-jwakely@redhat.com>","date":"2026-04-15T16:57:00","name":"[committed] libstdc++: Fix philox2x64 case for 32-bit targets","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"a45a3331b4fe8a3bbcf441cf54c23b726d5cbd17","submitter":{"id":48004,"url":"http://patchwork.ozlabs.org/api/1.1/people/48004/?format=json","name":"Jonathan Wakely","email":"jwakely@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/gcc/patch/20260415165715.413643-1-jwakely@redhat.com/mbox/","series":[{"id":500015,"url":"http://patchwork.ozlabs.org/api/1.1/series/500015/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/list/?series=500015","date":"2026-04-15T16:57:00","name":"[committed] libstdc++: Fix philox2x64 case for 32-bit targets","version":1,"mbox":"http://patchwork.ozlabs.org/series/500015/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2223582/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2223582/checks/","tags":{},"headers":{"Return-Path":"<gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org>","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=X7d52sA7;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (1024-bit key,\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=X7d52sA7","sourceware.org; dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com","sourceware.org; spf=pass smtp.mailfrom=redhat.com","server2.sourceware.org;\n arc=none smtp.remote-ip=170.10.133.124"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwnQJ4TGHz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 16 Apr 2026 02:57:59 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 3B5C94BA2E33\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 15 Apr 2026 16:57:57 +0000 (GMT)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by sourceware.org (Postfix) with ESMTP id 4946C4BA2E33\n for <gcc-patches@gcc.gnu.org>; Wed, 15 Apr 2026 16:57:25 +0000 (GMT)","from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-646-NfIdmYaVN--PVnxSOsmqCg-1; Wed,\n 15 Apr 2026 12:57:21 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id E26271956089; Wed, 15 Apr 2026 16:57:19 +0000 (UTC)","from zen.kayari.org (unknown [10.44.34.88])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id EA0B330001B9; Wed, 15 Apr 2026 16:57:17 +0000 (UTC)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 3B5C94BA2E33","OpenDKIM Filter v2.11.0 sourceware.org 4946C4BA2E33"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 4946C4BA2E33","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 4946C4BA2E33","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776272245; cv=none;\n b=vYxLWBA0qm6Sf7TJA8DvfKJXn3tkUTdPm9K5DilFXlXCTEoYkwiH3NZqinubnE1sw0r8Fctyc+4eUzuajHPZj2VF7v+udJBugGqLNeobO5xpjRTf3e/aKro8bjEHR0Ln8D3eRJx0zmSRTxUGXhrM653PwWKoDk1PXVdCcMbeW2A=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776272245; c=relaxed/simple;\n bh=OTBSfUgeQTpauCTJlKKLKPLS0GwzWS1q5sfJkSWZAW8=;\n h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version;\n b=QpCFnttrlxjegB9bEU4ehMYvLBX1H2h7iybuOxT3REj6iOXFNPEkem4wEXY97/HcjZIAigkR9d2bp3qNoP3pcC8FsANVXbV3hEro71xYoOcIw59Ou59Kh12W3ab6X17XvrmuUTzqR+BWnHaRNAboneC9Y0iLPaFSQDoURJkNEq8=","ARC-Authentication-Results":"i=1; server2.sourceware.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776272244;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=uEMOlutGn0QUy3l77nmqbxXYACPqXe4MDoYxbt2lV6I=;\n b=X7d52sA7RLy/CPFa76sLvktY66nRaD0vVh0CjevvCqkH1KJhWbymDTQA7naIn17c19eSka\n xthG3zjNN0pOLky0p/uY4Fk9MI4/kydtRHxKRueqLkfDvoQBjMzXxgADJ0sQIm0q45y3q2\n gPKMC6WXMH6SFB8lghDdXjP73NHPBWQ=","X-MC-Unique":"NfIdmYaVN--PVnxSOsmqCg-1","X-Mimecast-MFC-AGG-ID":"NfIdmYaVN--PVnxSOsmqCg_1776272240","From":"Jonathan Wakely <jwakely@redhat.com>","To":"libstdc++@gcc.gnu.org,\n\tgcc-patches@gcc.gnu.org","Cc":"Elena Tyuleneva <elena.tyuleneva@intel.com>,\n Ruslan Arutyunyan <ruslan.arutyunyan@intel.com>,\n Pavel Dyakov <pavel.dyakov@intel.com>","Subject":"[committed] libstdc++: Fix philox2x64 case for 32-bit targets","Date":"Wed, 15 Apr 2026 17:57:00 +0100","Message-ID":"<20260415165715.413643-1-jwakely@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"9IJfQRAihrSDWkOan-t7o2q5CRo0MkLnwy9-VMHM_uQ_1776272240","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","Content-Transfer-Encoding":"8bit","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list <gcc-patches.gcc.gnu.org>","List-Unsubscribe":"<https://gcc.gnu.org/mailman/options/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>","List-Archive":"<https://gcc.gnu.org/pipermail/gcc-patches/>","List-Post":"<mailto:gcc-patches@gcc.gnu.org>","List-Help":"<mailto:gcc-patches-request@gcc.gnu.org?subject=help>","List-Subscribe":"<https://gcc.gnu.org/mailman/listinfo/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"},"content":"While testing a patch for std::philox_engine I noticed that\ninstantiating std::philox_engine with n=2 and w=64 fails on targets\nwithout __int128, because it relies on an implicit conversion from the\nintermediate counter type to the result type. When w=64 and the target\ndoesn't support __int128, we use the __rand_uint128 class type for the\nintermediate counter values, but that does not support implicit\nconversion to integral types.\n\nThis adds the necessary casts to make the conversions explicit.\n\nlibstdc++-v3/ChangeLog:\n\n\t* include/bits/random.tcc (philox_engine::_M_transition): Cast\n\tintermediate values to result_type for n=2 case.\n---\n\nTested x86_64-linux. Pushed to trunk.\n\n libstdc++-v3/include/bits/random.tcc | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/libstdc++-v3/include/bits/random.tcc b/libstdc++-v3/include/bits/random.tcc\nindex 7a63e868a895..bc3393d35a89 100644\n--- a/libstdc++-v3/include/bits/random.tcc\n+++ b/libstdc++-v3/include/bits/random.tcc\n@@ -966,8 +966,8 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION\n \t  __type __num =\n \t\t  (static_cast<__type>(_M_x[1]) << __w)\n \t\t  | (static_cast<__type>(_M_x[0]) + 1);\n-\t  _M_x[0] = __num & max();\n-\t  _M_x[1] = (__num >> __w) & max();\n+\t  _M_x[0] = static_cast<_UIntType>(__num & max());\n+\t  _M_x[1] = static_cast<_UIntType>((__num >> __w) & max());\n \t}\n       _M_i = 0;\n     }\n","prefixes":["committed"]}