{"id":2223545,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2223545/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260415144635.3318697-1-lgs201920130244@gmail.com/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/1.1/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/"},"msgid":"<20260415144635.3318697-1-lgs201920130244@gmail.com>","date":"2026-04-15T14:46:35","name":"macintosh: windfarm_core: fix reference leak on failed device registration","commit_ref":null,"pull_url":null,"state":"rejected","archived":false,"hash":"a1034c79b9f2362c524e58cdeb2c24eec8c52663","submitter":{"id":91722,"url":"http://patchwork.ozlabs.org/api/1.1/people/91722/?format=json","name":"Guangshuo Li","email":"lgs201920130244@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260415144635.3318697-1-lgs201920130244@gmail.com/mbox/","series":[{"id":500000,"url":"http://patchwork.ozlabs.org/api/1.1/series/500000/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=500000","date":"2026-04-15T14:46:35","name":"macintosh: windfarm_core: fix reference leak on failed device registration","version":1,"mbox":"http://patchwork.ozlabs.org/series/500000/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2223545/comments/","check":"success","checks":"http://patchwork.ozlabs.org/api/patches/2223545/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=coJGPwLc;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19777-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2607:f8b0:4864:20::1031\"","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=coJGPwLc;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com\n (client-ip=2607:f8b0:4864:20::1031; helo=mail-pj1-x1031.google.com;\n envelope-from=lgs201920130244@gmail.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwkW22YFgz1yHM\n\tfor ; Thu, 16 Apr 2026 00:46:54 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fwkW15Q73z2yvr;\n\tThu, 16 Apr 2026 00:46:53 +1000 (AEST)","from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com\n [IPv6:2607:f8b0:4864:20::1031])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fwkW04KKmz2yvY\n\tfor ; Thu, 16 Apr 2026 00:46:51 +1000 (AEST)","by mail-pj1-x1031.google.com with SMTP id\n 98e67ed59e1d1-35da8d037a5so3236360a91.0\n for ;\n Wed, 15 Apr 2026 07:46:51 -0700 (PDT)","from lgs.. ([112.224.67.108])\n by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-35fd308cf98sm2310617a91.7.2026.04.15.07.46.44\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 15 Apr 2026 07:46:47 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1776264413;\n\tcv=none;\n b=VKMqUFN8WIirHny/N11yTZFItEC6w6amAJ4iwhQQxpiluTiGrEqzwm0pBejfkiHasxof6JaefECIRgY1RMNJfYgXXKAYo84KqFs06Nrj+zZx42B1doJ6PTHAje9PhigoIWtgAsZI5vdP7I6tzlXcgMgcRJCG+TxsSQvDulMs2plt90h0lz+nro3mtX7CRbQg3j+lOKKSRP1Wu7HTNQjlQYLf0Ex0il3kiVNp7FtsJztQXt7qL/cNNZvjgD0LAQ+YRMnAaChvuEWv8bhrv+8Vmr8h0lavhHNx4L0Br0gIuUKvf+foct0qxgqCvkBREDXO3GDOAYZ+OW0kwyIcjWGNIw==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1776264413; c=relaxed/relaxed;\n\tbh=znxX/LCQa33kO599nbk2Q/Mw7o66DJJuY9IEDvMYWxM=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=aMFLvFlZq2J5+uea5J+UaQv4RXJ7u0GjHVjVcEyJrdhYU/KnqxqJLwgM4HqdAwn/RovXyqVJLVcAPDU/GudVVEZZcciWs2U1g6zjg/Aw9MrguY6CVKGfo4SncpljOLiSMPCn18ar7l3bzgS7wkeutk0fj2un9s79VJ701mwGBoK5bhnhADLsrFtpwzWRX7rGmoUwsdrH6Ra5LXhKh1IZRqWVrETrHvX45LxJPY2FMhSP6OavFys8SAZF0xYQ6sJ0LCXmJXE2x/QaqIl/CtFPwsUVvglkjZbMSQtLCmQvrDVYxUVGZInnqoNcyjPzgFCtXajtVWtvbvVkGmFZKW7eAg==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com; dkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=coJGPwLc; dkim-atps=neutral;\n spf=pass (client-ip=2607:f8b0:4864:20::1031; helo=mail-pj1-x1031.google.com;\n envelope-from=lgs201920130244@gmail.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=gmail.com","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776264409; x=1776869209;\n darn=lists.ozlabs.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=znxX/LCQa33kO599nbk2Q/Mw7o66DJJuY9IEDvMYWxM=;\n b=coJGPwLccmt5Bbrt6AGjM3IE7+gvBJeNk0rgQNvFpbfbM8kDXexTAv/+gMUq+n90aH\n fAiHE8aBrLzf2cDatJqBa8E/mdfEE0vz6/03hKJ9gUbaDELs3L+xluLBCDJ2LL1K/NTY\n Xw0H1ofxeiBWpDSOWzNt7OQHY3bP5ZJJl+tbPM2ZYnTyMZaXV3BPJvBscSwc+CdMu8zh\n xJHsghiZLxWo0pKZds7Zpx9uqb2aIMre1OljSn8V4ncyOSsR4y1+S6pQcwdlSYJTjsYC\n Lu60Ctdq/WB6Sb7Vw7q9KvK2eDFqEo6DQQIHelLqKNchwI4tQqILd1BmwamXEgYE0n09\n ZUeQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776264409; x=1776869209;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=znxX/LCQa33kO599nbk2Q/Mw7o66DJJuY9IEDvMYWxM=;\n b=D5R8++0CLswJ6VsoRM1XHb41MEt6ayyIlNP9sCdYUsnVq9dfw4ouMZseyXyEHNNIrJ\n THapsUDL79qXzymsKf+ZDG3CRLstZgqKMudnXp8yzbQSZl34WEnjcCnrVdR/ztmnKX1a\n D6t6v8rmxMvJ90TvGMQxlJ8rRVzudiwsiDZtZWGeLffp2MPpXzFqJ0xrOoNu0Dtyc0oE\n s/ZyI0sDu/EnaQJElLp5XkQQIZGHkFuSAIsV8JlOF/47THEn6xkMjBg/Jrar8I4vrwWt\n iIvVB09mQm1Q6efoJ/NhyT9DGGS/qI16ZuLXswPxcFv/wWIchchPs30fJsfloQYQ+5Vh\n PqJg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8Cbl3dstPx8c3Gc70dW9Z/kffVJYnblfTN8oEb8lAksH4Xl0cVWzr0p7JuxfiEqhNutLg6aSQkbPmyCzM=@lists.ozlabs.org","X-Gm-Message-State":"AOJu0YzMFQRX3fyx3ESfeT6X6C9Z6GVSlHGi5uF+TbtfxAukMoz6h6XN\n\t0jQZYnqFJWyESEijxXJM+1Xs5rPyn+s6gyvqMi0OxCNqCTNTfZ0wMO3Y","X-Gm-Gg":"AeBDieumryKFcXy4tMoRYIeDmN+wEg4s0bszpSP35GWJ9/uL/iKVi8PoS5oBjsUS2Q0\n\tITNkTQR4/RL+Aa5CDnweXuCbSUeJxaR30z4XUSGUbg/0jrZROhHklQ6yb6QpY3kbPdoJfgIUYHy\n\tZso7bytzh2/OHRR3y1/mlZc8uJPnEB49+MlJre7PeELuaOX5PIS8DFN+OXu3/c8EqHQGRdKftf4\n\tcGFLqrKVARtVdHMQ5wYbxR2LPESAav+lZc/J369krmXAQDWoFPTRHmrgvWJKvty+nxv4WETy7EA\n\tItZ4uOkX+/cDUUH728ZqkMz2vHqCSPAXHHxR9/B9nFcouAIKSrmoSyAnAuqv1cgB2zDRo+2WQoz\n\tjy1IzeDJRz52iE0rg191mzEk667pFkfPhbezMQQ+a/pLOtTwRqHPoiHHlWvjF+8JsrImFUPNXa5\n\tQiRQMBLqsevigsYqPQNvUrY/jJZNGecrxQ","X-Received":"by 2002:a17:90b:4a04:b0:35b:e550:e68a with SMTP id\n 98e67ed59e1d1-35e4254fb13mr21922246a91.3.1776264409084;\n Wed, 15 Apr 2026 07:46:49 -0700 (PDT)","From":"Guangshuo Li ","To":"Guangshuo Li ,\n\tPaul Mackerras ,\n\tBenjamin Herrenschmidt ,\n\tlinuxppc-dev@lists.ozlabs.org,\n\tlinux-kernel@vger.kernel.org","Cc":"stable@vger.kernel.org","Subject":"[PATCH] macintosh: windfarm_core: fix reference leak on failed device\n registration","Date":"Wed, 15 Apr 2026 22:46:35 +0800","Message-ID":"<20260415144635.3318697-1-lgs201920130244@gmail.com>","X-Mailer":"git-send-email 2.43.0","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Spam-Status":"No, score=0.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,\n\tFROM_LOCAL_DIGITS,FROM_LOCAL_HEX,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,\n\tSPF_PASS autolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"When platform_device_register() fails in windfarm_core_init(), the\nembedded struct device in wf_platform_device has already been\ninitialized by device_initialize(), but the failure path does not drop\nthe device reference for the current platform device:\n\n windfarm_core_init()\n platform_device_register(&wf_platform_device)\n device_initialize(&wf_platform_device.dev)\n setup_pdev_dma_masks(&wf_platform_device)\n return platform_device_add(&wf_platform_device)\n\nThis leads to a reference leak when platform_device_register() fails.\nFix this by checking the return value and calling platform_device_put().\n\nThe issue was identified by a static analysis tool I developed and\nconfirmed by manual review.\n\nFixes: 75722d3992f57 (\"[PATCH] ppc64: Thermal control for SMU based machines\")\nCc: stable@vger.kernel.org\nSigned-off-by: Guangshuo Li \n---\n drivers/macintosh/windfarm_core.c | 7 ++++++-\n 1 file changed, 6 insertions(+), 1 deletion(-)","diff":"diff --git a/drivers/macintosh/windfarm_core.c b/drivers/macintosh/windfarm_core.c\nindex 5307b1e34261..4003e72f3a57 100644\n--- a/drivers/macintosh/windfarm_core.c\n+++ b/drivers/macintosh/windfarm_core.c\n@@ -436,9 +436,14 @@ EXPORT_SYMBOL_GPL(wf_clear_overtemp);\n \n static int __init windfarm_core_init(void)\n {\n+\tint err;\n+\n \tDBG(\"wf: core loaded\\n\");\n \n-\tplatform_device_register(&wf_platform_device);\n+\terr = platform_device_register(&wf_platform_device);\n+\tif (err)\n+\t\tplatform_device_put(&wf_platform_device);\n+\n \treturn 0;\n }\n \n","prefixes":[]}