{"id":2223310,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2223310/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260415012336.964736-1-zhaoguohan@kylinos.cn/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260415012336.964736-1-zhaoguohan@kylinos.cn>","date":"2026-04-15T01:23:36","name":"ui/vnc-clipboard: validate decompressed text length","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"d07347617c5b302e7a73135f13cc99666af31615","submitter":{"id":92952,"url":"http://patchwork.ozlabs.org/api/1.1/people/92952/?format=json","name":"GuoHan Zhao","email":"zhaoguohan@kylinos.cn"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260415012336.964736-1-zhaoguohan@kylinos.cn/mbox/","series":[{"id":499903,"url":"http://patchwork.ozlabs.org/api/1.1/series/499903/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499903","date":"2026-04-15T01:23:36","name":"ui/vnc-clipboard: validate decompressed text length","version":1,"mbox":"http://patchwork.ozlabs.org/series/499903/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2223310/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2223310/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":"legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwNkF18sSz1yCv\n\tfor ; Wed, 15 Apr 2026 11:25:23 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wCozd-0003zg-BR; Tue, 14 Apr 2026 21:24:37 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wCozX-0003z4-Oi\n for qemu-devel@nongnu.org; Tue, 14 Apr 2026 21:24:32 -0400","from mailgw.kylinos.cn ([124.126.103.232])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wCozU-0007sT-TJ\n for qemu-devel@nongnu.org; Tue, 14 Apr 2026 21:24:31 -0400","from localhost.localdomain [(116.128.244.171)] by mailgw.kylinos.cn\n (envelope-from )\n (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256)\n with ESMTP id 1546656504; Wed, 15 Apr 2026 09:24:09 +0800"],"X-UUID":["cdaa65d8386911f1aa26b74ffac11d73-20260415","cdaa65d8386911f1aa26b74ffac11d73-20260415"],"X-CID-O-RULE":"Release_Ham","X-CID-RULE":"Release_Ham","X-CID-O-INFO":"VERSION:1.3.12, REQID:838ace5f-8f5c-4dc6-a8c8-f8f6d1ca7cc3,\n IP:15,\n URL:0,TC:0,Content:0,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTI\n ON:release,TS:0","X-CID-INFO":"VERSION:1.3.12, REQID:838ace5f-8f5c-4dc6-a8c8-f8f6d1ca7cc3, IP:15,\n UR\n L:0,TC:0,Content:0,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTION\n :release,TS:0","X-CID-META":"VersionHash:e7bac3a, CLOUDID:a73e5dc2a6387b21f940792dbf995a6c,\n BulkI\n D:260415092410WP6HJ0RW,BulkQuantity:0,Recheck:0,SF:10|66|78|101|102|123|12\n 7|850|898,TC:nil,Content:0|15|50,EDM:-3,IP:-2,URL:0,File:nil,RT:nil,Bulk:n\n il,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BR\n E:0,ARC:0","X-CID-BVR":"2,SSN|SDN","X-CID-BAS":"2,SSN|SDN,0,_","X-CID-FACTOR":"TF_CID_SPAM_SNR","X-CID-RHF":"D41D8CD98F00B204E9800998ECF8427E","X-User":"zhaoguohan@kylinos.cn","From":"zhaoguohan@kylinos.cn","To":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Cc":"qemu-devel@nongnu.org","Subject":"[PATCH] ui/vnc-clipboard: validate decompressed text length","Date":"Wed, 15 Apr 2026 09:23:36 +0800","Message-ID":"<20260415012336.964736-1-zhaoguohan@kylinos.cn>","X-Mailer":"git-send-email 2.43.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=124.126.103.232;\n envelope-from=zhaoguohan@kylinos.cn; helo=mailgw.kylinos.cn","X-Spam_score_int":"-18","X-Spam_score":"-1.9","X-Spam_bar":"-","X-Spam_report":"(-1.9 / 5.0 requ) BAYES_00=-1.9,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001,\n UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: GuoHan Zhao \n\nThe decompressed clipboard data starts with a 32-bit text length.\nCheck that the advertised length fits in the payload after that\nheader before passing it to qemu_clipboard_set_data().\n\nOtherwise a malformed VNC clipboard message can make QEMU read past\nthe end of the decompressed buffer.\n\nFixes: 0bf41cab93e5 (\"ui/vnc: clipboard support\")\nSigned-off-by: GuoHan Zhao \n---\n ui/vnc-clipboard.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/ui/vnc-clipboard.c b/ui/vnc-clipboard.c\nindex 124b6fbd9c23..85851a632dba 100644\n--- a/ui/vnc-clipboard.c\n+++ b/ui/vnc-clipboard.c\n@@ -281,8 +281,8 @@ void vnc_client_cut_text_ext(VncState *vs, int32_t len, uint32_t flags, uint8_t\n if ((flags & VNC_CLIPBOARD_TEXT) &&\n buf && size >= 4) {\n uint32_t tsize = read_u32(buf, 0);\n- uint8_t *tbuf = buf + 4;\n- if (tsize < size) {\n+ uint8_t *tbuf = buf + sizeof(tsize);\n+ if (tsize <= size - sizeof(tsize)) {\n qemu_clipboard_set_data(&vs->cbpeer, vs->cbinfo,\n QEMU_CLIPBOARD_TYPE_TEXT,\n tsize, tbuf, true);\n","prefixes":[]}