{"id":2223291,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2223291/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/patch/20260414231905.191063-23-arthur.cohen@embecosm.com/","project":{"id":17,"url":"http://patchwork.ozlabs.org/api/1.1/projects/17/?format=json","name":"GNU Compiler Collection","link_name":"gcc","list_id":"gcc-patches.gcc.gnu.org","list_email":"gcc-patches@gcc.gnu.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260414231905.191063-23-arthur.cohen@embecosm.com>","date":"2026-04-14T23:18:44","name":"[COMMITTED,23/43] gccrs: Visit builtin attributes within the expand visitor","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"47445577e601827cf1fcc5a57fa3ad25b68c2b64","submitter":{"id":83476,"url":"http://patchwork.ozlabs.org/api/1.1/people/83476/?format=json","name":"Arthur Cohen","email":"arthur.cohen@embecosm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/gcc/patch/20260414231905.191063-23-arthur.cohen@embecosm.com/mbox/","series":[{"id":499900,"url":"http://patchwork.ozlabs.org/api/1.1/series/499900/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/list/?series=499900","date":"2026-04-14T23:18:24","name":"[COMMITTED,01/43] gccrs: testsuite:Add a testcase for setup_associated_types","version":1,"mbox":"http://patchwork.ozlabs.org/series/499900/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2223291/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2223291/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=embecosm.com header.i=@embecosm.com header.a=rsa-sha256\n header.s=google header.b=a04D68aB;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=embecosm.com header.i=@embecosm.com header.a=rsa-sha256\n header.s=google header.b=a04D68aB","sourceware.org;\n dmarc=none (p=none dis=none) header.from=embecosm.com","sourceware.org; spf=pass smtp.mailfrom=embecosm.com","server2.sourceware.org;\n arc=none smtp.remote-ip=209.85.128.68"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwL3r2Djyz1yCv\n\tfor ; Wed, 15 Apr 2026 09:25:28 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 0C73B4BA23C4\n\tfor ; Tue, 14 Apr 2026 23:25:26 +0000 (GMT)","from mail-wm1-f68.google.com (mail-wm1-f68.google.com\n [209.85.128.68])\n by sourceware.org (Postfix) with ESMTPS id 3781F4BA2E06\n for ; Tue, 14 Apr 2026 23:14:43 +0000 (GMT)","by mail-wm1-f68.google.com with SMTP id\n 5b1f17b1804b1-482f454be5bso64817145e9.0\n for ; Tue, 14 Apr 2026 16:14:43 -0700 (PDT)","from platypus.localdomain (176-147-231-59.abo.bbox.fr.\n [176.147.231.59]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488f1dd8806sm3325945e9.3.2026.04.14.16.14.40\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 14 Apr 2026 16:14:40 -0700 (PDT)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 0C73B4BA23C4","OpenDKIM Filter v2.11.0 sourceware.org 3781F4BA2E06"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 3781F4BA2E06","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 3781F4BA2E06","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776208483; cv=none;\n b=OItRVdzuQ2wLiI6QzYxA8ikQ4HApOLpeRYUVuEaDVi/bVmvwYVQhcoDasD5GQ9teFlslNut5viWp4Dz6vdygKBK0JlwQ1PSnOp/8yHR0pCTVxn70zixQjvbvSyTwfIER6D1n2rFOFWnVuqTTF/MWXVCUrOTEbOPSpxQoyHdx3Zo=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776208483; c=relaxed/simple;\n bh=KHxI3xZ9X+nic7xXNAts2ZnMMzCI8kbWpfIpQrKJ5Vg=;\n h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version;\n b=c6B56pPmO34nGiFUv/gve/JcPjspTQysUIjhwH8+H3Tn7tUgFPanvz9vqGSwG6V2j7anFHwEhCGmWMpkqiTmBEZVlZ50bdvWIKDkaDVrKSLXZOnQVKLY36hVYR5qqI5xJClT9+1IhJ5m9tCa81r1+7NS6wt0J7/QPGtFZKZ8YXQ=","ARC-Authentication-Results":"i=1; server2.sourceware.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=embecosm.com; s=google; t=1776208482; x=1776813282; darn=gcc.gnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=qkRJVvU8QxPvFNQHCLuOxAU1FhKUbzNk6JNQ54wKFuE=;\n b=a04D68aBruX7y6YXsOd/GgumnD6rrf0DpN6yoi6xMzVvVkFyrg7SfLqSthGDj0n2IB\n uWmPxxr7jbFXsP/wQ0sAa+MVs7q0tB+ZA0opjklqg6WyaUrjwXXlXF9ike/zkkWUz1pT\n tcps5uyx8E/Mx8C79DnJ1FO5Hl3gAtvV/HF2HS4+CgAlJ4Fhp/yxEm4qnoK2fr+muyre\n i4hw1kx9PWxNcpls/sLIN5BYnznhQNwr8aX/CWrWSvUS+cosBwyNXYco1rU8yvhyFgUY\n CjfyJ20ogaH+5Mwn3NcZIJ3HnZ79AM9Yms35lFujTiySSWwfFsAUAfQk2n6YxT5yzPV+\n IxNQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776208482; x=1776813282;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=qkRJVvU8QxPvFNQHCLuOxAU1FhKUbzNk6JNQ54wKFuE=;\n b=Tx383XoZuT35GsPglG5sMU59bYVqn4KAY5wYaCJStmZSznf20A2t56MtKZuadF7ood\n GnCEQ9+r/12Sny30JJFxyjCbFUcPdiDSqPkF1kW/bnrPQt7cRBCST8HBol0DVr5GzZCN\n +2wEIYM/enghbV6npCBaQZtSMMvAiqXufZg743DahQ4Q0w0NWVw8Ud4HYZWKYsLckvJp\n Az5PZI4kebTLfbbkT5Div2hax4QxWlltHF5PfAHPc8C05kHmq9lUwVBIWQbLhGISj20D\n jVDWWlwvUN0IR1SJu28osEe2ut9PPOP0dMwktX1GiQaX0fGrUYpo1/x05fMQ7nmN1Snn\n FZKg==","X-Gm-Message-State":"AOJu0YwvQ33nrzfZ4tbbSygpAizX7QEP28zKgOlLSBRbAXXrssydvu1v\n Na+uATT9UJ/FLB4UqVb6SqfHtN7oGGDLLP+QnycNjfP8Zw+hCjFdBSo0t5AkIQ93l1f17Iyy5qO\n DQbOFQl3Z","X-Gm-Gg":"AeBDiesC/94OvVSOf9FSle3Z3nnxl6/fqRabo/ba0Hbliz/LwbdQdaiTdMHj/zbiX3B\n Snw+s7vjiQgP8d6lZWxoeRr8aDhyOAAtba/YtQMQGjLk4/RXorAUDMMr+YnZsAKntHH1A9fK9lk\n sA+e+1Kugf9J1YuB6gJLWaXfrblnO0wxIngmDQwq/FRM6cOeWWtEF64gj+H3jLhBz8yvlVlMs9R\n FdjzIJx3/2kdIvnvX0Bp3EEB10ZtgL95cTa3rU/BQ/YwycfEcEagMxJeK9hTUmM8eY5rin+n3z2\n Rk7R9U0z2MCj1mDcEoljlpsoJwPIhktMSWGUxsbao3T0T9oh+32WXPAsOUxcZYmbjCsUFdBvqa1\n g9vBQ3Jx58lVutHFi59ycJQh4Ue2yMJd5nBri6mCQzBlnkfWlpkhunkZ0i6e7CLBnFWLK5JGCC2\n 8l+crPQN4sU+xphRdWxx6dutnQlJZLLjjWi0tgi2COfqA5WUE8UBKR+s4hpYrRRrs+996bvFrLC\n tTRYg==","X-Received":"by 2002:a05:600c:4ecb:b0:485:3cef:d6ea with SMTP id\n 5b1f17b1804b1-488dc76d45amr231172855e9.13.1776208481857;\n Tue, 14 Apr 2026 16:14:41 -0700 (PDT)","From":"arthur.cohen@embecosm.com","To":"gcc-patches@gcc.gnu.org","Cc":"gcc-rust@gcc.gnu.org,\n Pierre-Emmanuel Patry ","Subject":"[COMMITTED 23/43] gccrs: Visit builtin attributes within the expand\n visitor","Date":"Wed, 15 Apr 2026 01:18:44 +0200","Message-ID":"<20260414231905.191063-23-arthur.cohen@embecosm.com>","X-Mailer":"git-send-email 2.50.1","In-Reply-To":"<20260414231905.191063-1-arthur.cohen@embecosm.com>","References":"<20260414231905.191063-1-arthur.cohen@embecosm.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"},"content":"From: Pierre-Emmanuel Patry \n\nThose attribute may contain macros within their input that must be\nexpanded, hence why we must visit them.\n\ngcc/rust/ChangeLog:\n\n\t* ast/rust-ast.h: Add helper to set a new attribute input.\n\t* expand/rust-expand-visitor.cc (ExpandVisitor::expand_inner_stmts):\n\tVisit builtin attributes.\n\t(ExpandVisitor::visit): Likewise.\n\t* resolve/rust-early-name-resolver-2.0.cc (Early::visit): Expand\n\tattribute input expr.\n\nSigned-off-by: Pierre-Emmanuel Patry \n---\n gcc/rust/ast/rust-ast.h | 5 +++++\n gcc/rust/expand/rust-expand-visitor.cc | 4 +++-\n gcc/rust/resolve/rust-early-name-resolver-2.0.cc | 2 ++\n 3 files changed, 10 insertions(+), 1 deletion(-)","diff":"diff --git a/gcc/rust/ast/rust-ast.h b/gcc/rust/ast/rust-ast.h\nindex 4a1974d4d9d..f6b704507f7 100644\n--- a/gcc/rust/ast/rust-ast.h\n+++ b/gcc/rust/ast/rust-ast.h\n@@ -632,6 +632,11 @@ public:\n \n AttrInput &get_attr_input () const { return *attr_input; }\n \n+ void set_attr_input (std::unique_ptr input)\n+ {\n+ attr_input = std::move (input);\n+ }\n+\n /* e.g.:\n #![crate_type = \"lib\"]\n #[test]\ndiff --git a/gcc/rust/expand/rust-expand-visitor.cc b/gcc/rust/expand/rust-expand-visitor.cc\nindex c124f9ab937..16786e32e15 100644\n--- a/gcc/rust/expand/rust-expand-visitor.cc\n+++ b/gcc/rust/expand/rust-expand-visitor.cc\n@@ -218,6 +218,7 @@ ExpandVisitor::expand_inner_items (\n \t\t{\n \t\t if (is_builtin (current))\n \t\t {\n+\t\t visit (*attr_it);\n \t\t attr_it++;\n \t\t }\n \t\t else\n@@ -303,6 +304,7 @@ ExpandVisitor::expand_inner_stmts (AST::BlockExpr &expr)\n \t\t{\n \t\t if (is_builtin (current))\n \t\t {\n+\t\t visit (*attr_it);\n \t\t attr_it++;\n \t\t }\n \t\t else\n@@ -586,7 +588,7 @@ ExpandVisitor::visit (AST::AttrInputLiteral &)\n void\n ExpandVisitor::visit (AST::AttrInputExpr &attr_input)\n {\n- reseat (attr_input.get_expr_ptr ());\n+ maybe_expand_expr (attr_input.get_expr_ptr ());\n }\n \n void\ndiff --git a/gcc/rust/resolve/rust-early-name-resolver-2.0.cc b/gcc/rust/resolve/rust-early-name-resolver-2.0.cc\nindex 91ad82c8966..058207f1f4a 100644\n--- a/gcc/rust/resolve/rust-early-name-resolver-2.0.cc\n+++ b/gcc/rust/resolve/rust-early-name-resolver-2.0.cc\n@@ -397,6 +397,8 @@ Early::visit (AST::Attribute &attr)\n {\n visit_non_builtin_attribute (attr, mappings, name);\n }\n+\n+ DefaultResolver::visit (attr);\n }\n \n void\n","prefixes":["COMMITTED","23/43"]}