{"id":2223279,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2223279/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/patch/20260414231905.191063-14-arthur.cohen@embecosm.com/","project":{"id":17,"url":"http://patchwork.ozlabs.org/api/1.1/projects/17/?format=json","name":"GNU Compiler Collection","link_name":"gcc","list_id":"gcc-patches.gcc.gnu.org","list_email":"gcc-patches@gcc.gnu.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260414231905.191063-14-arthur.cohen@embecosm.com>","date":"2026-04-14T23:18:35","name":"[COMMITTED,14/43] gccrs: Remove redundant expand visitor overloads","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"7061b2f230f93c7cc5c2350963ef61f5d93f90db","submitter":{"id":83476,"url":"http://patchwork.ozlabs.org/api/1.1/people/83476/?format=json","name":"Arthur Cohen","email":"arthur.cohen@embecosm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/gcc/patch/20260414231905.191063-14-arthur.cohen@embecosm.com/mbox/","series":[{"id":499900,"url":"http://patchwork.ozlabs.org/api/1.1/series/499900/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/list/?series=499900","date":"2026-04-14T23:18:24","name":"[COMMITTED,01/43] gccrs: testsuite:Add a testcase for setup_associated_types","version":1,"mbox":"http://patchwork.ozlabs.org/series/499900/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2223279/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2223279/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=embecosm.com header.i=@embecosm.com header.a=rsa-sha256\n header.s=google header.b=QsnFuQQV;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=embecosm.com header.i=@embecosm.com header.a=rsa-sha256\n header.s=google header.b=QsnFuQQV","sourceware.org;\n dmarc=none (p=none dis=none) header.from=embecosm.com","sourceware.org; spf=pass smtp.mailfrom=embecosm.com","server2.sourceware.org;\n arc=none smtp.remote-ip=209.85.128.41"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwKyF4KNrz1yHM\n\tfor ; Wed, 15 Apr 2026 09:20:37 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 466004BA23DE\n\tfor ; Tue, 14 Apr 2026 23:20:35 +0000 (GMT)","from mail-wm1-f41.google.com (mail-wm1-f41.google.com\n [209.85.128.41])\n by sourceware.org (Postfix) with ESMTPS id E97CB4BA23DA\n for ; Tue, 14 Apr 2026 23:14:29 +0000 (GMT)","by mail-wm1-f41.google.com with SMTP id\n 5b1f17b1804b1-48374014a77so83070195e9.3\n for ; Tue, 14 Apr 2026 16:14:29 -0700 (PDT)","from platypus.localdomain (176-147-231-59.abo.bbox.fr.\n [176.147.231.59]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488f1dd8806sm3325945e9.3.2026.04.14.16.14.27\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 14 Apr 2026 16:14:27 -0700 (PDT)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 466004BA23DE","OpenDKIM Filter v2.11.0 sourceware.org E97CB4BA23DA"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org E97CB4BA23DA","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org E97CB4BA23DA","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776208470; cv=none;\n b=uwfSszYlLJ572DWhNAERuYPhGAxFus87DYOPVvQRTml10tP5DPvqc+OoatohDT5p/UgutddZT43tY59rhPTwYkEzNUXTTSrq8ux18d2sJqyslFudILJcJo+jpTolbxmZ0eweSRrz9/9twjevxCm9h1kbHJHbEaJT+Kkx8qqAg1E=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776208470; c=relaxed/simple;\n bh=O0c7B+bM544DySt0A+ZwRn7RwtahuAgr8AJGqbCUIOE=;\n h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version;\n b=AtGGGfBR381DI3/HlYjSDRWLPK8jFY7WjwaJnSU8+lObiA/wXYANh7h4tGIUkQGQByPZX8YjiyuJYOt7Xn1p3Lxvoosk/hl84Ku/INp+bpGL8iDYvwL8IzENN3atqvs3preQbWqPv/+3YddyI/BgeR2v5EnceKmc5q8AIu2UGLg=","ARC-Authentication-Results":"i=1; server2.sourceware.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=embecosm.com; s=google; t=1776208468; x=1776813268; darn=gcc.gnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=YLhZbqqFuhOtz9CNL5m5cVgluY15tlgNVW8im5ApSHI=;\n b=QsnFuQQVTjtvMrx7kz9M23QqhRzicpxlFX4RTZJyW2Kpt1yuOlsY/Vas0OuuIJjr6t\n SzQt3OFNMqnj3EGpbqphtue99epampQv0vc9KauYBDpG9+9J1cgR9SsTTMqZ96NzYpQS\n XjguPaRpNSXVOTWQqEyJ64hfDf0P89429/yg/ZnVmDtdPnXfxUhBwJBll77r0oxPbL66\n 5AcC+QNXuRBD33kc5CbakrCsEpwzlLAUFkja1LU2wwWrAkoCcBkjEFrZSxlk49QnZRoH\n XmVMUAf7ILiYHm/qLSKb6BSlYtJi3IgOgvvETeEzXj1cu5GlYBxpJKYQqcWaYVDD8xHo\n bdTg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776208468; x=1776813268;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=YLhZbqqFuhOtz9CNL5m5cVgluY15tlgNVW8im5ApSHI=;\n b=XtdRtm7jsesP/Gvi3eIC0ZbPVi+QdrPTEp1rgBMDcdPbUJb5G6bP6GMRJ7thvSwBhy\n b8wfJXcVtozPMEZtUTp7PBH8WAik0zJ+eRMNClb8O3AwvnymswAtlympQQDhplhJQ6iK\n FiOKCY3FsCXOLh5zWVgtHZGFzcJYgwYc5ZSFpnXfQ1Q/4y5db8bXkZsi58W0AfwesP8H\n e30uqrqE+vFX6B0cEGywcq8rg68aEFnm7O9lRLgEcFCFc8rJrqyEraEQ6ZGvF7Vi42cL\n FedBzGIU4S5X5rDx4vXBInfgbwTQ+yNJwseLiwf0baEH3UBiZ0VkRvTv1sDh2fY8JF0/\n 2i2g==","X-Gm-Message-State":"AOJu0Yy8a/QpKOWNtnKrT6/4WdETTqwPpdsv+jWNKTCU+J/3vTU/UN6j\n s9nB8Z3IjfcR7/ruDMdNCf4Cly5rdorQfl2PP736M6nhC/7jCD2PapMm8b8sWs9sEKXadC/8i0r\n 1zzcjEw==","X-Gm-Gg":"AeBDieuZsfhayDHUqyELt3Rl4B5lZpvLYIL8ubGNTT+z7xQRNjEaLw1C0ky9HICe5v1\n agSJ3s05AdHBYvklr0DiuB5XWL1LmCOscFS8/045Q4BbAS+DZwAsEZl3Z1mR0JCRJXLWIyQ87IG\n BLmyD7IS9rn5kYvTkR6Jn7AlNW5pGhpX6YwZtsMfxs7o389cFKw+s7g7u+o7MRFyA4CXq+BD04B\n k/kOC70vLK94Hnd0XkL1PA+mIheSTzZCBxQrqWpW3X7+ZLZ7nQjttarULULiOeze81bMiqV57K5\n jJrPB3ryL2y/HpcQYy5mGbLuWaC4P4q6/XKKzBrA2orFSMtPs8H0AYw3IfemgnJ0RfRPkXoJRTP\n Lze+O/dCQhQ8kd7gnRRI39mcvhHRbyfT+cbRFH867EcG2FFOY9wOFXcdHJTFtlWq+aRIQZAaGrK\n o3VeukA4isqFh7MpwGOTvdFJ2z97h3i1WjjlpnM9ewc0hZF3Q26qHG1MDuZHAKDvRcxnyCAZhRX\n f5O9iuu8zBtyoAw","X-Received":"by 2002:a05:600c:a404:b0:488:bfc3:ef3 with SMTP id\n 5b1f17b1804b1-488d6671271mr242165905e9.0.1776208468591;\n Tue, 14 Apr 2026 16:14:28 -0700 (PDT)","From":"arthur.cohen@embecosm.com","To":"gcc-patches@gcc.gnu.org","Cc":"gcc-rust@gcc.gnu.org,\n\tOwen Avery ","Subject":"[COMMITTED 14/43] gccrs: Remove redundant expand visitor overloads","Date":"Wed, 15 Apr 2026 01:18:35 +0200","Message-ID":"<20260414231905.191063-14-arthur.cohen@embecosm.com>","X-Mailer":"git-send-email 2.50.1","In-Reply-To":"<20260414231905.191063-1-arthur.cohen@embecosm.com>","References":"<20260414231905.191063-1-arthur.cohen@embecosm.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"},"content":"From: Owen Avery \n\ngcc/rust/ChangeLog:\n\n\t* expand/rust-expand-visitor.cc (ExpandVisitor::visit): Remove\n\tsome redundant function overloads.\n\t* expand/rust-expand-visitor.h (ExpandVisitor::visit): Likewise.\n\nSigned-off-by: Owen Avery \n---\n gcc/rust/expand/rust-expand-visitor.cc | 166 -------------------------\n gcc/rust/expand/rust-expand-visitor.h | 23 ----\n 2 files changed, 189 deletions(-)","diff":"diff --git a/gcc/rust/expand/rust-expand-visitor.cc b/gcc/rust/expand/rust-expand-visitor.cc\nindex 5fed8b52f73..690c74bee28 100644\n--- a/gcc/rust/expand/rust-expand-visitor.cc\n+++ b/gcc/rust/expand/rust-expand-visitor.cc\n@@ -597,67 +597,10 @@ void\n ExpandVisitor::visit (AST::MetaItemPathExpr &)\n {}\n \n-void\n-ExpandVisitor::visit (AST::ArithmeticOrLogicalExpr &expr)\n-{\n- maybe_expand_expr (expr.get_left_expr_ptr ());\n- maybe_expand_expr (expr.get_right_expr_ptr ());\n-}\n-\n-void\n-ExpandVisitor::visit (AST::ComparisonExpr &expr)\n-{\n- maybe_expand_expr (expr.get_left_expr_ptr ());\n- maybe_expand_expr (expr.get_right_expr_ptr ());\n-}\n-\n-void\n-ExpandVisitor::visit (AST::LazyBooleanExpr &expr)\n-{\n- maybe_expand_expr (expr.get_left_expr_ptr ());\n- maybe_expand_expr (expr.get_right_expr_ptr ());\n-}\n-\n-void\n-ExpandVisitor::visit (AST::TypeCastExpr &expr)\n-{\n- maybe_expand_expr (expr.get_casted_expr_ptr ());\n- maybe_expand_type (expr.get_type_to_cast_to_ptr ());\n-}\n-\n-void\n-ExpandVisitor::visit (AST::AssignmentExpr &expr)\n-{\n- maybe_expand_expr (expr.get_left_expr_ptr ());\n- maybe_expand_expr (expr.get_right_expr_ptr ());\n-}\n-\n-void\n-ExpandVisitor::visit (AST::CompoundAssignmentExpr &expr)\n-{\n- maybe_expand_expr (expr.get_left_expr_ptr ());\n- maybe_expand_expr (expr.get_right_expr_ptr ());\n-}\n-\n-void\n-ExpandVisitor::visit (AST::GroupedExpr &expr)\n-{\n- maybe_expand_expr (expr.get_expr_in_parens_ptr ());\n-}\n-\n void\n ExpandVisitor::visit (AST::StructExprStruct &expr)\n {}\n \n-void\n-ExpandVisitor::visit (AST::CallExpr &expr)\n-{\n- visit (expr.get_function_expr ());\n-\n- for (auto ¶m : expr.get_params ())\n- maybe_expand_expr (param);\n-}\n-\n void\n ExpandVisitor::visit (AST::ClosureExprInner &expr)\n {\n@@ -686,10 +629,6 @@ ExpandVisitor::visit (AST::ClosureExprInnerTyped &expr)\n visit (expr.get_definition_expr ());\n }\n \n-void\n-ExpandVisitor::visit (AST::ContinueExpr &expr)\n-{}\n-\n void\n ExpandVisitor::visit (AST::IfExpr &expr)\n {\n@@ -724,13 +663,6 @@ ExpandVisitor::visit (AST::IfLetExprConseqElse &expr)\n visit (expr.get_else_block ());\n }\n \n-void\n-ExpandVisitor::visit (AST::TupleExpr &expr)\n-{\n- for (auto &sub : expr.get_tuple_elems ())\n- maybe_expand_expr (sub);\n-}\n-\n void\n ExpandVisitor::visit (AST::TypeParam ¶m)\n {\n@@ -856,23 +788,6 @@ ExpandVisitor::visit (AST::Union &union_item)\n expand_struct_fields (union_item.get_variants ());\n }\n \n-void\n-ExpandVisitor::visit (AST::ConstantItem &const_item)\n-{\n- maybe_expand_type (const_item.get_type_ptr ());\n-\n- if (const_item.has_expr ())\n- maybe_expand_expr (const_item.get_expr_ptr ());\n-}\n-\n-void\n-ExpandVisitor::visit (AST::StaticItem &static_item)\n-{\n- maybe_expand_type (static_item.get_type_ptr ());\n-\n- maybe_expand_expr (static_item.get_expr_ptr ());\n-}\n-\n void\n ExpandVisitor::visit (AST::Trait &trait)\n {\n@@ -994,87 +909,6 @@ void\n ExpandVisitor::visit (AST::StructPatternFieldIdent &field)\n {}\n \n-void\n-ExpandVisitor::visit (AST::GroupedPattern &pattern)\n-{\n- maybe_expand_pattern (pattern.get_pattern_in_parens_ptr ());\n-}\n-\n-void\n-ExpandVisitor::visit (AST::SlicePatternItemsNoRest &items)\n-{\n- for (auto &sub : items.get_patterns ())\n- maybe_expand_pattern (sub);\n-}\n-\n-void\n-ExpandVisitor::visit (AST::SlicePatternItemsHasRest &items)\n-{\n- for (auto &sub : items.get_lower_patterns ())\n- maybe_expand_pattern (sub);\n- for (auto &sub : items.get_upper_patterns ())\n- maybe_expand_pattern (sub);\n-}\n-\n-void\n-ExpandVisitor::visit (AST::AltPattern &pattern)\n-{\n- for (auto &alt : pattern.get_alts ())\n- maybe_expand_pattern (alt);\n-}\n-\n-void\n-ExpandVisitor::visit (AST::TupleStructItemsNoRest &tuple_items)\n-{\n- for (auto &sub : tuple_items.get_patterns ())\n- maybe_expand_pattern (sub);\n-}\n-\n-void\n-ExpandVisitor::visit (AST::TupleStructItemsHasRest &tuple_items)\n-{\n- for (auto &sub : tuple_items.get_lower_patterns ())\n- maybe_expand_pattern (sub);\n-\n- for (auto &sub : tuple_items.get_upper_patterns ())\n- maybe_expand_pattern (sub);\n-}\n-\n-void\n-ExpandVisitor::visit (AST::TuplePatternItemsNoRest &tuple_items)\n-{\n- for (auto &sub : tuple_items.get_patterns ())\n- maybe_expand_pattern (sub);\n-}\n-\n-void\n-ExpandVisitor::visit (AST::TuplePatternItemsHasRest &tuple_items)\n-{\n- for (auto &sub : tuple_items.get_lower_patterns ())\n- maybe_expand_pattern (sub);\n-\n- for (auto &sub : tuple_items.get_upper_patterns ())\n- maybe_expand_pattern (sub);\n-}\n-\n-void\n-ExpandVisitor::visit (AST::LetStmt &stmt)\n-{\n- maybe_expand_pattern (stmt.get_pattern_ptr ());\n-\n- if (stmt.has_type ())\n- maybe_expand_type (stmt.get_type_ptr ());\n-\n- if (stmt.has_init_expr ())\n- maybe_expand_expr (stmt.get_init_expr_ptr ());\n-}\n-\n-void\n-ExpandVisitor::visit (AST::ExprStmt &stmt)\n-{\n- maybe_expand_expr (stmt.get_expr_ptr ());\n-}\n-\n void\n ExpandVisitor::visit (AST::BareFunctionType &type)\n {\ndiff --git a/gcc/rust/expand/rust-expand-visitor.h b/gcc/rust/expand/rust-expand-visitor.h\nindex 08de64e02ed..2a3938afe73 100644\n--- a/gcc/rust/expand/rust-expand-visitor.h\n+++ b/gcc/rust/expand/rust-expand-visitor.h\n@@ -234,27 +234,17 @@ public:\n void visit (AST::AttrInputMacro &) override;\n void visit (AST::MetaItemLitExpr &) override;\n void visit (AST::MetaItemPathExpr &) override;\n- void visit (AST::ArithmeticOrLogicalExpr &expr) override;\n- void visit (AST::ComparisonExpr &expr) override;\n- void visit (AST::LazyBooleanExpr &expr) override;\n- void visit (AST::TypeCastExpr &expr) override;\n- void visit (AST::AssignmentExpr &expr) override;\n- void visit (AST::CompoundAssignmentExpr &expr) override;\n- void visit (AST::GroupedExpr &expr) override;\n void visit (AST::StructExprStruct &expr) override;\n \n- void visit (AST::CallExpr &expr) override;\n void visit (AST::ClosureExprInner &expr) override;\n \n void visit (AST::BlockExpr &expr) override;\n \n void visit (AST::ClosureExprInnerTyped &expr) override;\n- void visit (AST::ContinueExpr &expr) override;\n void visit (AST::IfExpr &expr) override;\n void visit (AST::IfExprConseqElse &expr) override;\n void visit (AST::IfLetExpr &expr) override;\n void visit (AST::IfLetExprConseqElse &expr) override;\n- void visit (AST::TupleExpr &expr) override;\n void visit (AST::TypeParam ¶m) override;\n void visit (AST::LifetimeWhereClauseItem &) override;\n void visit (AST::TypeBoundWhereClauseItem &item) override;\n@@ -272,8 +262,6 @@ public:\n void visit (AST::EnumItemStruct &item) override;\n void visit (AST::EnumItemDiscriminant &item) override;\n void visit (AST::Union &union_item) override;\n- void visit (AST::ConstantItem &const_item) override;\n- void visit (AST::StaticItem &static_item) override;\n void visit (AST::Trait &trait) override;\n void visit (AST::InherentImpl &impl) override;\n void visit (AST::TraitImpl &impl) override;\n@@ -290,17 +278,6 @@ public:\n void visit (AST::MetaListPaths &) override;\n void visit (AST::MetaListNameValueStr &) override;\n void visit (AST::StructPatternFieldIdent &field) override;\n- void visit (AST::GroupedPattern &pattern) override;\n- void visit (AST::SlicePatternItemsNoRest &items) override;\n- void visit (AST::SlicePatternItemsHasRest &items) override;\n- void visit (AST::AltPattern &pattern) override;\n- void visit (AST::TupleStructItemsNoRest &tuple_items) override;\n- void visit (AST::TupleStructItemsHasRest &tuple_items) override;\n- void visit (AST::TuplePatternItemsNoRest &tuple_items) override;\n- void visit (AST::TuplePatternItemsHasRest &tuple_items) override;\n-\n- void visit (AST::LetStmt &stmt) override;\n- void visit (AST::ExprStmt &stmt) override;\n \n void visit (AST::BareFunctionType &type) override;\n void visit (AST::FunctionParam ¶m) override;\n","prefixes":["COMMITTED","14/43"]}