{"id":2223270,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2223270/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/patch/20260414231905.191063-4-arthur.cohen@embecosm.com/","project":{"id":17,"url":"http://patchwork.ozlabs.org/api/1.1/projects/17/?format=json","name":"GNU Compiler Collection","link_name":"gcc","list_id":"gcc-patches.gcc.gnu.org","list_email":"gcc-patches@gcc.gnu.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260414231905.191063-4-arthur.cohen@embecosm.com>","date":"2026-04-14T23:18:25","name":"[COMMITTED,04/43] gccrs: Use pretty printer instead ofcall to open_memstream","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"9d3f70205b98a2593cce2c5c11f1b3c150b303de","submitter":{"id":83476,"url":"http://patchwork.ozlabs.org/api/1.1/people/83476/?format=json","name":"Arthur Cohen","email":"arthur.cohen@embecosm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/gcc/patch/20260414231905.191063-4-arthur.cohen@embecosm.com/mbox/","series":[{"id":499900,"url":"http://patchwork.ozlabs.org/api/1.1/series/499900/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/list/?series=499900","date":"2026-04-14T23:18:24","name":"[COMMITTED,01/43] gccrs: testsuite:Add a testcase for setup_associated_types","version":1,"mbox":"http://patchwork.ozlabs.org/series/499900/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2223270/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2223270/checks/","tags":{},"headers":{"Return-Path":"<gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org>","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=embecosm.com header.i=@embecosm.com header.a=rsa-sha256\n header.s=google header.b=dUYmTPLV;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=embecosm.com header.i=@embecosm.com header.a=rsa-sha256\n header.s=google header.b=dUYmTPLV","sourceware.org;\n dmarc=none (p=none dis=none) header.from=embecosm.com","sourceware.org; spf=pass smtp.mailfrom=embecosm.com","server2.sourceware.org;\n arc=none smtp.remote-ip=209.85.128.46"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwKsw5tmlz1yHc\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 15 Apr 2026 09:16:52 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id D66AA4BA23E1\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 14 Apr 2026 23:16:50 +0000 (GMT)","from mail-wm1-f46.google.com (mail-wm1-f46.google.com\n [209.85.128.46])\n by sourceware.org (Postfix) with ESMTPS id E68454BA2E23\n for <gcc-patches@gcc.gnu.org>; Tue, 14 Apr 2026 23:14:15 +0000 (GMT)","by mail-wm1-f46.google.com with SMTP id\n 5b1f17b1804b1-488a29e6110so66401775e9.3\n for <gcc-patches@gcc.gnu.org>; Tue, 14 Apr 2026 16:14:15 -0700 (PDT)","from platypus.localdomain (176-147-231-59.abo.bbox.fr.\n [176.147.231.59]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488f1dd8806sm3325945e9.3.2026.04.14.16.14.12\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 14 Apr 2026 16:14:12 -0700 (PDT)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org D66AA4BA23E1","OpenDKIM Filter v2.11.0 sourceware.org E68454BA2E23"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org E68454BA2E23","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org E68454BA2E23","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776208456; cv=none;\n b=JdtH+lL01pRXcS+Wr/wmkTGOfS/qwf8lXwzJqGqeJwJX6I1wAjNyUqn2bm+YBMqDdYdA/UrfFkoiRBvrJjBnYzCFfqmAaTjLhlWLfJuecp/b/70urMsq/O0EIqdeFSSbGonT5BATFElrUA7Vo9+UmJDc+vpVvw8rY5BtOaDkKuQ=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776208456; c=relaxed/simple;\n bh=nYMqJp6cwAHbEDNuRRLK2KdEi5iUscw+mFJU6yne9CQ=;\n h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version;\n b=CwHLss/WNZuekLfyDG0SICp2Cd/e8Fpcap2TbJsCGPk9c8sBwZoNMX4/E72zjydksTEbzvtlcEvnNKXjBGcUk9uQO2FbBrAGcxcD1sv/5YwmsLKeJ5qVzOqXyzCCx93vv2j5izYall6vBh/cLcjZMfap9Z5BQ6uB5hzuahjWPJA=","ARC-Authentication-Results":"i=1; server2.sourceware.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=embecosm.com; s=google; t=1776208454; x=1776813254; darn=gcc.gnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=VOPyfzgJQK5qGV6fbrTKeeLAceoQHZlT4uaDJaTmuEE=;\n b=dUYmTPLVbhxv+yKPyDwXoECgtg/BIOGmjBLZdVK806sUdw+PeeZitmoumdSjlff5kT\n k3aPeTtlFRnb5dJyYPi+h489PMa4wGfjeH2ms7r8ZBhdhyxHfB3qCHVaEKn1xtpYxRBM\n Z0IfFe3PE2UJZ4gRcveB7VHyBR4/FVAzZTf5Z7eKqZDxrYYg46AyBBtNMx+sFq6284iN\n X+vspaaneok8rhmyrHyDCbhrbhRlI97lJk4gCvoSnTvOzzcgRsDI7zJvdn2/w+1ClXna\n FH3Ol5khHE4qh6SAxR1NYqqTRNpSmbylhMQF3tY4XM2FlF56zeY3XjKNTAopuvvuqf9p\n y9QA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776208454; x=1776813254;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=VOPyfzgJQK5qGV6fbrTKeeLAceoQHZlT4uaDJaTmuEE=;\n b=mIn7dK3ayyTb8ZFvnMUN8IdBuzAMWE1dt5frr2tq0D623Lgrv7B1IEx7Qskmt/OWVq\n JO/0KIVgL5v1I4wu65eLUOm+AsCb2iwyvXlLNxcjEqb5POBqNmF6v/oZ5ncQRVtbpenT\n gNqUGRdtq1jWAEucCiZ+JwgO8ixzUhMnfpl8V5iJiws02C0Q//NVgqWxuETIYPgBWeVa\n M+BjhJFe91bRRTupw1EGsoQ+Fd2LxMgurMcoTt1o+/wwr018zxeCBffi1Z4oUfpOpTqc\n +DFuyOso4ovZlTVb+E8qMfakKN51gh2saJCtMhlo3reskczkz58rIXoWscZ20RR6hW/G\n bZ+g==","X-Gm-Message-State":"AOJu0YzcyTUZU8V0SkylbdZgrieNEPa6LBuEsJMzQhUNtgn/gOl85ebt\n 2ia/EZE5GLQA0rdFWec4nlOskX5DpXmnb5GwT3ekoHm/68C8wUTCX7HKTm0ljeh+/7oECNGVPoB\n lsZ/fjg==","X-Gm-Gg":"AeBDies+J+D4/wA18+SteHfw2fZL0jYoKvtlfBQn2UaBdtj/RbMZBBZ5JRqid6ug0xX\n N+PEDBv9XLztg20mEFGC33jAWbefZ8wG2h96DtR45xykj/r522d6l9kMz+VHY4Jpd3qITfOX/Oi\n +9OgtkURV0si2xWExII4iw3LK4j3EHH6tTmTXQfOFU7H5oIRVug5lfwARO1h8Hb30XJQ/filp8v\n 3GT2bn0Pbva+IxOdBeEakxridwVmPXbPlmhM69M0P6xaJtpfulIpMZyjIGmx1MibILJN+IbL9TT\n +KLz1guUAczFoiHkM8scWxnJWftQBNeAzrtZm4XSGPKjOwfxWt8SArSCTFQKqC/nEHWElwFD3yQ\n G5k/M683VFlkhHtaHlgvsJ882EwmKPuXIuk2pFLIzHGvdYXXZmJxT8KAlnq2ZgfHBXWpYS0+QC8\n ZZ2EDHfzHMFVcigPF/z5qEg6HyysR5vALbSgALZa7CQy8+PPrapNeUvuci4f9XKFmsi5bPL5G4e\n 9zkHA==","X-Received":"by 2002:a05:600c:8585:b0:488:ba19:da25 with SMTP id\n 5b1f17b1804b1-488d6822a0bmr190697195e9.12.1776208454214;\n Tue, 14 Apr 2026 16:14:14 -0700 (PDT)","From":"arthur.cohen@embecosm.com","To":"gcc-patches@gcc.gnu.org","Cc":"gcc-rust@gcc.gnu.org,\n\tAndrew Pinski <andrew.pinski@oss.qualcomm.com>","Subject":"[COMMITTED 04/43] gccrs: Use pretty printer instead ofcall to\n open_memstream","Date":"Wed, 15 Apr 2026 01:18:25 +0200","Message-ID":"<20260414231905.191063-4-arthur.cohen@embecosm.com>","X-Mailer":"git-send-email 2.50.1","In-Reply-To":"<20260414231905.191063-1-arthur.cohen@embecosm.com>","References":"<20260414231905.191063-1-arthur.cohen@embecosm.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list <gcc-patches.gcc.gnu.org>","List-Unsubscribe":"<https://gcc.gnu.org/mailman/options/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>","List-Archive":"<https://gcc.gnu.org/pipermail/gcc-patches/>","List-Post":"<mailto:gcc-patches@gcc.gnu.org>","List-Help":"<mailto:gcc-patches-request@gcc.gnu.org?subject=help>","List-Subscribe":"<https://gcc.gnu.org/mailman/listinfo/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"},"content":"From: Andrew Pinski <andrew.pinski@oss.qualcomm.com>\n\nopen_memstream is a POSIX call which is not available on mingw platform.\n\ngcc/rust/ChangeLog:\n\n\t* typecheck/rust-tyty.cc (generate_tree_str): Remove opem_memstream\n\tand print_generic_stmt call with call to dump_generic_node.\n\nSigned-off-by: Andrew Pinski <andrew.pinski@oss.qualcomm.com>\n---\n gcc/rust/typecheck/rust-tyty.cc | 15 +++------------\n 1 file changed, 3 insertions(+), 12 deletions(-)","diff":"diff --git a/gcc/rust/typecheck/rust-tyty.cc b/gcc/rust/typecheck/rust-tyty.cc\nindex 161c15e7896..e27577e311d 100644\n--- a/gcc/rust/typecheck/rust-tyty.cc\n+++ b/gcc/rust/typecheck/rust-tyty.cc\n@@ -3517,18 +3517,9 @@ ParamType::is_implicit_self_trait () const\n static std::string\n generate_tree_str (tree value)\n {\n-  char *buf = nullptr;\n-  size_t size = 0;\n-\n-  FILE *stream = open_memstream (&buf, &size);\n-  if (!stream)\n-    return \"<error>\";\n-\n-  print_generic_stmt (stream, value, TDF_NONE);\n-  fclose (stream);\n-\n-  std::string result = (buf ? std::string (buf, size) : \"<error>\");\n-  free (buf);\n+  pretty_printer pp;\n+  dump_generic_node (&pp, value, 0, TDF_NONE, true);\n+  std::string result = pp_formatted_text (&pp);\n \n   if (!result.empty () && result.back () == '\\n')\n     result.pop_back ();\n","prefixes":["COMMITTED","04/43"]}